shakapacker 7.2.0 → 7.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: ae742f19f77532f469332730b57bb1e381c6f238ace6cd5eb113a95f607bde68
4
- data.tar.gz: 246d1e8dba39d501d219d1e37f4665c8b9f1ab401825173f22cbe270bf95a933
3
+ metadata.gz: 1e486b8d36133595f767f26dd8461b1b57fbea6daeba86eaa79b2f3ffcf7dbd2
4
+ data.tar.gz: 94b19f6397652a9abbfc3e80ef51ead55d0aec78191ab7bd36383e3ae37f5fce
5
5
  SHA512:
6
- metadata.gz: d57fc47ab68b52626fa66d643d5d62ceeb62fd27b707844c5b187c5ef4e29a15cbb8296a3bbb9204740ecd3769371c05c1ea6046ac2deffc7771bbf2b0839484
7
- data.tar.gz: 5af5dc61cf4d3f01b17eaca403a8f09ae8a63fe3d2adffdb3dd91969c0e71684118ae0365a893a27690ed4275c03fb1d46a20b30fcb56f8821fdae44110b212e
6
+ metadata.gz: 328d290b9d5bf040aea4239675196975569fb0606e1d93c49bdaf73b0b87d5d2267b3f1069ff26297991016e1c6aad5a8d9fad782bfa17a4898cac95cf421d6d
7
+ data.tar.gz: d3067ddec4711898c5a0dcc63b854372917600ecb2019b57c4153bd2a16bf24ce56ec015de3023f46980f7a660ee25e610623339a5b49b1f0e342cbb7dfbead4
@@ -1,6 +1,10 @@
1
1
  name: Dummy specs
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  test:
@@ -1,6 +1,10 @@
1
1
  name: Generator specs
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  test:
@@ -35,6 +39,11 @@ jobs:
35
39
  - uses: ruby/setup-ruby@v1
36
40
  with:
37
41
  ruby-version: ${{ matrix.ruby }}
42
+ # Bundler 2.5.0 dropped support for Ruby 2.6 and 2.7
43
+ - name: Use Bundler 2.4.22
44
+ run: |
45
+ gem install bundler -v '2.4.22'
46
+ bundle config --local path vendor/bundle
38
47
  - name: Install dependencies
39
48
  run: bundle install
40
49
  - run: bundle exec rake run_spec:generator
@@ -1,6 +1,10 @@
1
1
  name: Jest specs
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  jest:
@@ -1,6 +1,10 @@
1
1
  name: JS lint
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  lint:
@@ -1,6 +1,10 @@
1
1
  name: Rubocop
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  rubocop:
@@ -1,6 +1,10 @@
1
1
  name: Ruby specs - Backward compatibility
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  test:
@@ -1,6 +1,10 @@
1
1
  name: Ruby specs
2
2
 
3
- on: [push, pull_request]
3
+ on:
4
+ push:
5
+ branches:
6
+ - 'master'
7
+ pull_request:
4
8
 
5
9
  jobs:
6
10
  test:
data/CHANGELOG.md CHANGED
@@ -9,19 +9,26 @@ Changes since the last non-beta release.
9
9
 
10
10
  _Please add entries here for your pull requests that are not yet released._
11
11
 
12
+ ## [v7.2.1] - December 30, 2023
13
+
14
+ ### Fixed
15
+ - Show deprecation message for `relative_url_root` only if it is set. [PR 400](https://github.com/shakacode/shakapacker/pull/400) by [ahangarha](https://github.com/ahangarha).
16
+
17
+ ## [v7.2.0] - December 28, 2023
18
+
12
19
  ### Added
13
20
  - Experimental support for other JS package managers using `package_json` gem [PR 349](https://github.com/shakacode/shakapacker/pull/349) by [G-Rath](https://github.com/g-rath).
14
21
  - Support `hmr: only` configuration [PR 378](https://github.com/shakacode/shakapacker/pull/378) by [SimenB](https://github.com/SimenB).
15
22
  - Use `config/shakapacker.yml` as the secondary source for `asset_host` and `relative_url_root` configurations [PR 376](https://github.com/shakacode/shakapacker/pull/376) by [ahangarha](https://github.com/ahangarha).
16
23
 
17
24
  ### Fixed
18
- - Recommend `server` option instead of deprecated `https` option when `--https` is provided [PR 380](https://github.com/shakacode/shakapacker/pull/380) by [G-Rath](https://github.com/g-rath)
25
+ - Recommend `server` option instead of the deprecated `https` option when `--https` is provided [PR 380](https://github.com/shakacode/shakapacker/pull/380) by [G-Rath](https://github.com/g-rath)
19
26
  - Recompile assets on asset host change [PR 364](https://github.com/shakacode/shakapacker/pull/364) by [ahangarha](https://github.com/ahangarha).
20
27
  - Add deprecation warning for `https` option in `shakapacker.yml` (use `server: 'https'` instead) [PR 382](https://github.com/shakacode/shakapacker/pull/382) by [G-Rath](https://github.com/g-rath).
21
28
  - Disable Hot Module Replacement in `webpack-dev-server` when `hmr: false` [PR 392](https://github.com/shakacode/shakapacker/pull/392) by [thedanbob](https://github.com/thedanbob).
22
29
 
23
30
  ### Deprecated
24
- - The usage of relative_url_root is deprecated in Shakapacker and will be removed in v8. [PR 376](https://github.com/shakacode/shakapacker/pull/376) by [ahangarha](https://github.com/ahangarha).
31
+ - The usage of `relative_url_root` is deprecated in Shakapacker and will be removed in v8. [PR 376](https://github.com/shakacode/shakapacker/pull/376) by [ahangarha](https://github.com/ahangarha).
25
32
 
26
33
  ## [v7.1.0] - September 30, 2023
27
34
 
@@ -290,7 +297,9 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions
290
297
  ## v5.4.3 and prior changes from rails/webpacker
291
298
  See [CHANGELOG.md in rails/webpacker (up to v5.4.3)](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
292
299
 
293
- [Unreleased]: https://github.com/shakacode/shakapacker/compare/v7.1.0...master
300
+ [Unreleased]: https://github.com/shakacode/shakapacker/compare/v7.2.1...master
301
+ [v7.2.1]: https://github.com/shakacode/shakapacker/compare/v7.2.0...v7.2.1
302
+ [v7.2.0]: https://github.com/shakacode/shakapacker/compare/v7.1.0...v7.2.0
294
303
  [v7.1.0]: https://github.com/shakacode/shakapacker/compare/v7.0.3...v7.1.0
295
304
  [v7.0.3]: https://github.com/shakacode/shakapacker/compare/v7.0.2...v7.0.3
296
305
  [v7.0.2]: https://github.com/shakacode/shakapacker/compare/v7.0.1...v7.0.2
@@ -124,12 +124,16 @@ class Shakapacker::Configuration
124
124
  end
125
125
 
126
126
  def relative_url_root
127
- Shakapacker.puts_deprecation_message "The usage of relative_url_root is deprecated in Shakapacker and will be removed in v8."
128
-
129
- ENV.fetch(
127
+ result = ENV.fetch(
130
128
  "SHAKAPACKER_RELATIVE_URL_ROOT",
131
129
  fetch(:relative_url_root) || ActionController::Base.relative_url_root
132
130
  )
131
+
132
+ if result
133
+ Shakapacker.puts_deprecation_message("The usage of relative_url_root is deprecated in Shakapacker and will be removed in v8.")
134
+ end
135
+
136
+ result
133
137
  end
134
138
 
135
139
  private
@@ -1,4 +1,4 @@
1
1
  module Shakapacker
2
2
  # Change the version in package.json too, please!
3
- VERSION = "7.2.0".freeze
3
+ VERSION = "7.2.1".freeze
4
4
  end
data/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "shakapacker",
3
- "version": "7.2.0",
3
+ "version": "7.2.1",
4
4
  "description": "Use webpack to manage app-like JavaScript modules in Rails",
5
5
  "homepage": "https://github.com/shakacode/shakapacker",
6
6
  "bugs": {
@@ -383,14 +383,17 @@ describe "Shakapacker::Configuration" do
383
383
  )
384
384
  end
385
385
 
386
- it "shows deprecation message" do
387
- expect { config.relative_url_root }.to output(/deprecated/).to_stdout
388
- end
389
-
390
- it "returns the value of SHAKAPACKER_RELATIVE_URL_ROOT if set" do
391
- expect(ENV).to receive(:fetch).with("SHAKAPACKER_RELATIVE_URL_ROOT", nil).and_return("custom_value")
386
+ context "with SHAKAPACKER_RELATIVE_URL_ROOT set" do
387
+ before do
388
+ expect(ENV).to receive(:fetch).with("SHAKAPACKER_RELATIVE_URL_ROOT", nil).and_return("custom_value")
389
+ end
390
+ it "shows deprecation message" do
391
+ expect { config.relative_url_root }.to output(/deprecated/).to_stdout
392
+ end
392
393
 
393
- expect(config.relative_url_root).to eq "custom_value"
394
+ it "returns the value of SHAKAPACKER_RELATIVE_URL_ROOT" do
395
+ expect(config.relative_url_root).to eq "custom_value"
396
+ end
394
397
  end
395
398
 
396
399
  context "without SHAKAPACKER_RELATIVE_URL_ROOT set" do
@@ -415,6 +418,10 @@ describe "Shakapacker::Configuration" do
415
418
 
416
419
  expect(config.relative_url_root).to be nil
417
420
  end
421
+
422
+ it "doesn't shows deprecation message" do
423
+ expect { config.relative_url_root }.to_not output(/deprecated/).to_stdout
424
+ end
418
425
  end
419
426
  end
420
427
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: shakapacker
3
3
  version: !ruby/object:Gem::Version
4
- version: 7.2.0
4
+ version: 7.2.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
10
10
  autorequire:
11
11
  bindir: bin
12
12
  cert_chain: []
13
- date: 2023-12-29 00:00:00.000000000 Z
13
+ date: 2024-01-01 00:00:00.000000000 Z
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
16
16
  name: activesupport
@@ -566,7 +566,7 @@ homepage: https://github.com/shakacode/shakapacker
566
566
  licenses:
567
567
  - MIT
568
568
  metadata:
569
- source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.2.0
569
+ source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.2.1
570
570
  post_install_message:
571
571
  rdoc_options: []
572
572
  require_paths: