shakapacker 7.1.0 → 7.2.0.rc.0

data/spec/backward_compatibility_specs/dev_server_runner_spec.rb

@@ -17,48 +17,108 @@ describe "DevServerRunner" do
 
   let(:test_app_path) { File.expand_path("webpacker_test_app", __dir__) }
 
-  it "supports running via node modules" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
+    context "when using package_json with #{fallback_manager} as the manager" do
+      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
 
-    verify_command(cmd, use_node_modules: true)
-  end
+      let(:package_json) { PackageJson.read(test_app_path) }
 
-  it "supports running via yarn" do
-    cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+      require "package_json"
 
-    verify_command(cmd, use_node_modules: false)
-  end
+      it "uses the expected package manager", unless: fallback_manager == "yarn_classic" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
 
-  it "passes on arguments" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
+        manager_name = fallback_manager.split("_")[0]
 
-    verify_command(cmd, argv: (["--quiet"]))
-  end
+        expect(cmd).to start_with(manager_name)
+      end
+
+      it "runs the command using the manager" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+
+        verify_command(cmd)
+      end
+
+      it "passes on arguments" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"])
 
-  it "supports the https flag" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
+        verify_command(cmd, argv: (["--quiet"]))
+      end
+
+      it "supports the https flag" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"])
+
+        dev_server = double()
+        allow(dev_server).to receive(:host).and_return("localhost")
+        allow(dev_server).to receive(:port).and_return("3035")
+        allow(dev_server).to receive(:pretty?).and_return(false)
+        allow(dev_server).to receive(:https?).and_return(true)
+        allow(dev_server).to receive(:hmr?).and_return(false)
+
+        allow(Shakapacker::DevServer).to receive(:new) do
+          verify_command(cmd, argv: (["--https"]))
+        end.and_return(dev_server)
+      end
+
+      it "accepts environment variables" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+        env = Webpacker::Compiler.env.dup
 
-    dev_server = double()
-    allow(dev_server).to receive(:host).and_return("localhost")
-    allow(dev_server).to receive(:port).and_return("3035")
-    allow(dev_server).to receive(:pretty?).and_return(false)
-    allow(dev_server).to receive(:https?).and_return(true)
-    allow(dev_server).to receive(:hmr?).and_return(false)
+        # ENV["WEBPACKER_CONFIG"] is the interface and env["SHAKAPACKER_CONFIG"] is internal
+        ENV["WEBPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
+        env["WEBPACK_SERVE"] = "true"
 
-    allow(Webpacker::DevServer).to receive(:new) do
-      verify_command(cmd, argv: (["--https"]))
-    end.and_return(dev_server)
+        verify_command(cmd, env: env)
+      end
+    end
   end
 
-  it "accepts environment variables" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-    env = Webpacker::Compiler.env.dup
+  context "when not using package_json" do
+    with_use_package_json_gem(enabled: false)
 
-    # ENV["WEBPACKER_CONFIG"] is the interface and env["SHAKAPACKER_CONFIG"] is internal
-    ENV["WEBPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
-    env["WEBPACK_SERVE"] = "true"
+    it "supports running via node modules" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
-    verify_command(cmd, env: env)
+      verify_command(cmd, use_node_modules: true)
+    end
+
+    it "supports running via yarn" do
+      cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
+      verify_command(cmd, use_node_modules: false)
+    end
+
+    it "passes on arguments" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
+
+      verify_command(cmd, argv: (["--quiet"]))
+    end
+
+    it "supports the https flag" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
+
+      dev_server = double()
+      allow(dev_server).to receive(:host).and_return("localhost")
+      allow(dev_server).to receive(:port).and_return("3035")
+      allow(dev_server).to receive(:pretty?).and_return(false)
+      allow(dev_server).to receive(:https?).and_return(true)
+      allow(dev_server).to receive(:hmr?).and_return(false)
+
+      allow(Shakapacker::DevServer).to receive(:new) do
+        verify_command(cmd, argv: (["--https"]))
+      end.and_return(dev_server)
+    end
+
+    it "accepts environment variables" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+      env = Webpacker::Compiler.env.dup
+
+      # ENV["WEBPACKER_CONFIG"] is the interface and env["SHAKAPACKER_CONFIG"] is internal
+      ENV["WEBPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
+      env["WEBPACK_SERVE"] = "true"
+
+      verify_command(cmd, env: env)
+    end
   end
 
   private

data/spec/backward_compatibility_specs/engine_rake_tasks_spec.rb

@@ -9,16 +9,38 @@ describe "EngineRakeTasks" do
     remove_webpack_binstubs
   end
 
-  it "mounts app:webpacker task successfully" do
-    output = Dir.chdir(mounted_app_path) { `rake -T` }
+  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
+    context "when using package_json with #{fallback_manager} as the manager" do
+      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
 
-    expect(output).to match /app:webpacker.+DEPRECATED/
-    expect(output).to match /app:webpacker:binstubs.+DEPRECATED/
+      it "mounts app:webpacker task successfully" do
+        output = Dir.chdir(mounted_app_path) { `rake -T` }
+
+        expect(output).to match /app:webpacker.+DEPRECATED/
+        expect(output).to match /app:webpacker:binstubs.+DEPRECATED/
+      end
+
+      it "only adds expected files to bin directory when binstubs is run" do
+        Dir.chdir(mounted_app_path) { `bundle exec rake app:webpacker:binstubs` }
+        expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+      end
+    end
   end
 
-  it "only adds expected files to bin directory when binstubs is run" do
-    Dir.chdir(mounted_app_path) { `bundle exec rake app:webpacker:binstubs` }
-    expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+  context "when not using package_json" do
+    with_use_package_json_gem(enabled: false)
+
+    it "mounts app:webpacker task successfully" do
+      output = Dir.chdir(mounted_app_path) { `rake -T` }
+
+      expect(output).to match /app:webpacker.+DEPRECATED/
+      expect(output).to match /app:webpacker:binstubs.+DEPRECATED/
+    end
+
+    it "only adds expected files to bin directory when binstubs is run" do
+      Dir.chdir(mounted_app_path) { `bundle exec rake app:webpacker:binstubs` }
+      expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+    end
   end
 
   private

data/spec/backward_compatibility_specs/webpack_runner_spec.rb

@@ -15,22 +15,56 @@ describe "WebpackRunner" do
 
   let(:test_app_path) { File.expand_path("./webpacker_test_app", __dir__) }
 
-  it "supports running via node_modules" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
+    context "when using package_json with #{fallback_manager} as the manager" do
+      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
 
-    verify_command(cmd, use_node_modules: true)
-  end
+      let(:package_json) { PackageJson.read(test_app_path) }
+
+      require "package_json"
+
+      it "uses the expected package manager", unless: fallback_manager == "yarn_classic" do
+        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+
+        manager_name = fallback_manager.split("_")[0]
+
+        expect(cmd).to start_with(manager_name)
+      end
+
+      it "runs the command using the manager" do
+        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js"])
 
-  it "supports running via yarn" do
-    cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+        verify_command(cmd)
+      end
 
-    verify_command(cmd, use_node_modules: false)
+      it "passes on arguments" do
+        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"])
+
+        verify_command(cmd, argv: (["--watch"]))
+      end
+    end
   end
 
-  it "passes on arguments" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"]
+  context "when not using package_json" do
+    with_use_package_json_gem(enabled: false)
+
+    it "supports running via node_modules" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
+      verify_command(cmd, use_node_modules: true)
+    end
+
+    it "supports running via yarn" do
+      cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
-    verify_command(cmd, argv: ["--watch"])
+      verify_command(cmd, use_node_modules: false)
+    end
+
+    it "passes on arguments" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"]
+
+      verify_command(cmd, argv: ["--watch"])
+    end
   end
 
   private

data/spec/generator_specs/e2e_template/template.rb

@@ -1,13 +1,34 @@
-# install react
-system("yarn add react react-dom @babel/preset-react")
-
-# update webpack presets for react
-package_json_path = Rails.root.join("./package.json")
-insert_into_file(
-  package_json_path,
-  %(      "@babel/preset-react",\n),
-  after: /"presets": \[\n/
-)
+require "shakapacker/utils/misc"
+
+if Shakapacker::Utils::Misc.use_package_json_gem
+  Shakapacker::Utils::Misc.require_package_json_gem
+
+  package_json = PackageJson.new
+
+  # install react
+  package_json.manager.add(["react", "react-dom", "@babel/preset-react"])
+
+  # update webpack presets for react
+  package_json.merge! do |pj|
+    babel = pj.fetch("babel", {})
+
+    babel["presets"] ||= []
+    babel["presets"].unshift("@babel/preset-react")
+
+    { "babel" => babel }
+  end
+else
+  # install react
+  system("yarn add react react-dom @babel/preset-react")
+
+  # update webpack presets for react
+  package_json_path = Rails.root.join("./package.json")
+  insert_into_file(
+    package_json_path,
+    %(      "@babel/preset-react",\n),
+    after: /"presets": \[\n/
+  )
+end
 
 # install rspec-rails
 system("bundle add rspec-rails --group development,test")

data/spec/generator_specs/fake-bin/bun

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+binary = "bun"
+major_version = "1"
+
+unless ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] == binary
+  raise StandardError, "(#{binary}) this is not the package manager you're looking for..."
+end
+
+exec("npx", "-y", "#{binary}@#{major_version}", *ARGV)

data/spec/generator_specs/fake-bin/npm

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+binary = "npm"
+major_version = "9"
+
+unless ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] == binary
+  raise StandardError, "(#{binary}) this is not the package manager you're looking for..."
+end
+
+exec("npx", "-y", "#{binary}@#{major_version}", *ARGV)

data/spec/generator_specs/fake-bin/pnpm

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+binary = "pnpm"
+major_version = "8"
+
+unless ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] == binary
+  raise StandardError, "(#{binary}) this is not the package manager you're looking for..."
+end
+
+exec("npx", "-y", "#{binary}@#{major_version}", *ARGV)

data/spec/generator_specs/fake-bin/yarn

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+binary = "yarn"
+major_version = "1"
+
+unless ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] == "#{binary}_classic"
+  raise StandardError, "(#{binary}) this is not the package manager you're looking for..."
+end
+
+exec("npx", "-y", "#{binary}@#{major_version}", *ARGV)

data/spec/generator_specs/generator_spec.rb

@@ -3,6 +3,7 @@ require "rake"
 require "json"
 require "shakapacker/utils/misc"
 require "shakapacker/utils/version_syntax_converter"
+require "package_json"
 
 GEM_ROOT = Pathname.new(File.expand_path("../../..", __FILE__))
 SPEC_PATH = Pathname.new(File.expand_path("../", __FILE__))
@@ -12,13 +13,13 @@ TEMP_RAILS_APP_PATH = SPEC_PATH.join("temp-rails-app")
 describe "Generator" do
   before :all do
     # Don't use --skip-git because we want .gitignore file to exist in the project
-    sh_in_dir(SPEC_PATH, %(
+    sh_in_dir({}, SPEC_PATH, %(
       rails new base-rails-app --skip-javascript --skip-bundle --skip-spring
       rm -rf base-rails-app/.git
     ))
 
     Bundler.with_unbundled_env do
-      sh_in_dir(BASE_RAILS_APP_PATH, %(
+      sh_in_dir({}, BASE_RAILS_APP_PATH, %(
         gem update bundler
         bundle add shakapacker --path "#{GEM_ROOT}"
       ))
@@ -31,12 +32,144 @@ describe "Generator" do
   end
 
   describe "shakapacker:install" do
-    context "in a normal Rails project" do
+    # TODO: ideally "yarn_berry" should be here too, but it requires more complex setup
+    NODE_PACKAGE_MANAGERS.reject { |fm| fm == "yarn_berry" }.each do |fallback_manager|
+      context "when using package_json with #{fallback_manager} as the manager" do
+        before :all do
+          sh_opts = { fallback_manager: fallback_manager }
+
+          sh_in_dir(sh_opts, SPEC_PATH, "cp -r '#{BASE_RAILS_APP_PATH}' '#{TEMP_RAILS_APP_PATH}'")
+
+          Bundler.with_unbundled_env do
+            sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "FORCE=true bundle exec rails shakapacker:install")
+          end
+        end
+
+        after :all do
+          Dir.chdir(SPEC_PATH)
+          FileUtils.rm_rf(TEMP_RAILS_APP_PATH)
+        end
+
+        it "creates `config/shakapacker.yml`" do
+          config_file_relative_path = "config/shakapacker.yml"
+          actual_content = read(path_in_the_app(config_file_relative_path))
+          expected_content = read(path_in_the_gem(config_file_relative_path))
+
+          expect(actual_content).to eq expected_content
+        end
+
+        it "replaces package.json with the template file" do
+          package_json = PackageJson.read(path_in_the_app)
+
+          expect(package_json.fetch("name", "")).to eq("app")
+        end
+
+        it "creates webpack config directory and its files" do
+          expected_files = [
+            "webpack.config.js"
+          ]
+
+          Dir.chdir(path_in_the_app("config/webpack")) do
+            existing_files_in_config_webpack_dir = Dir.glob("*")
+            expect(existing_files_in_config_webpack_dir).to eq expected_files
+          end
+        end
+
+        it "adds binstubs" do
+          expected_binstubs = []
+          Dir.chdir(File.join(GEM_ROOT, "lib/install/bin")) do
+            expected_binstubs = Dir.glob("bin/*")
+          end
+
+          Dir.chdir(File.join(TEMP_RAILS_APP_PATH, "bin")) do
+            actual_binstubs = Dir.glob("*")
+            expect(actual_binstubs).to include(*expected_binstubs)
+          end
+        end
+
+        it "modifies .gitignore" do
+          actual_content = read(path_in_the_app(".gitignore"))
+
+          expect(actual_content).to match ".yarn-integrity"
+        end
+
+        it 'adds <%= javascript_pack_tag "application" %>' do
+          actual_content = read(path_in_the_app("app/views/layouts/application.html.erb"))
+
+          expect(actual_content).to match '<%= javascript_pack_tag "application" %>'
+        end
+
+        it "updates `bin/setup`" do
+          package_json = PackageJson.read(path_in_the_app)
+          cmd = package_json.manager.native_install_command.join(" ")
+
+          setup_file_content = read(path_in_the_app("bin/setup"))
+
+          expect(setup_file_content).to match %r(^\s*system!\(['"]#{cmd}['"]\))
+        end
+
+        it "adds relevant shakapacker version in package.json depending on gem version" do
+          npm_version = Shakapacker::Utils::VersionSyntaxConverter.new.rubygem_to_npm(Shakapacker::VERSION)
+
+          package_json = PackageJson.read(path_in_the_app)
+          actual_version = package_json.fetch("dependencies", {})["shakapacker"]
+
+          expect(actual_version).to eq(npm_version)
+        end
+
+        it "adds Shakapacker peer dependencies to package.json" do
+          package_json = PackageJson.read(path_in_the_app)
+          actual_dependencies = package_json.fetch("dependencies", {}).keys
+
+          expected_dependencies = %w(
+            @babel/core
+            @babel/plugin-transform-runtime
+            @babel/preset-env
+            @babel/runtime
+            babel-loader
+            compression-webpack-plugin
+            terser-webpack-plugin
+            webpack
+            webpack-assets-manifest
+            webpack-cli
+            webpack-merge
+          )
+
+          expect(actual_dependencies).to include(*expected_dependencies)
+        end
+
+        it "adds Shakapacker peer dev dependencies to package.json" do
+          package_json = PackageJson.read(path_in_the_app)
+          actual_dev_dependencies = package_json.fetch("devDependencies", {}).keys
+
+          expected_dev_dependencies = %w(
+            webpack-dev-server
+          )
+
+          expect(actual_dev_dependencies).to include(*expected_dev_dependencies)
+        end
+
+        context "with a basic react app setup" do
+          it "passes the test for rendering react component on the page" do
+            sh_opts = { fallback_manager: fallback_manager }
+
+            Bundler.with_unbundled_env do
+              sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "./bin/rails app:template LOCATION=../e2e_template/template.rb")
+              expect(sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "bundle exec rspec")).to be_truthy
+            end
+          end
+        end
+      end
+    end
+
+    context "when not using package_json" do
       before :all do
-        sh_in_dir(SPEC_PATH, "cp -r '#{BASE_RAILS_APP_PATH}' '#{TEMP_RAILS_APP_PATH}'")
+        sh_opts = { fallback_manager: nil }
+
+        sh_in_dir(sh_opts, SPEC_PATH, "cp -r '#{BASE_RAILS_APP_PATH}' '#{TEMP_RAILS_APP_PATH}'")
 
         Bundler.with_unbundled_env do
-          sh_in_dir(TEMP_RAILS_APP_PATH, "FORCE=true bundle exec rails shakapacker:install")
+          sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "FORCE=true bundle exec rails shakapacker:install")
         end
       end
 
@@ -53,10 +186,10 @@ describe "Generator" do
         expect(actual_content).to eq expected_content
       end
 
-      it "replaces package.json with the template file" do
-        actual_content = read(path_in_the_app("package.json"))
+      it "replaces package.json with template file" do
+        package_json = PackageJson.read(path_in_the_app)
 
-        expect(actual_content).to match /"name": "app",/
+        expect(package_json.fetch("name", "")).to eq("app")
       end
 
       it "creates the webpack config directory and its files" do
@@ -104,14 +237,15 @@ describe "Generator" do
       it "uses the shakapacker version in package.json depending on gem version" do
         npm_version = Shakapacker::Utils::VersionSyntaxConverter.new.rubygem_to_npm(Shakapacker::VERSION)
 
-        actual_content = read(path_in_the_app("package.json"))
+        package_json = PackageJson.read(path_in_the_app)
+        actual_version = package_json.fetch("dependencies", {})["shakapacker"]
 
-        expect(actual_content).to match /"shakapacker": "#{npm_version}",/
+        expect(actual_version).to eq(npm_version)
       end
 
       it "adds Shakapacker peer dependencies to package.json" do
-        package_json = JSON.parse(File.read(path_in_the_app("package.json")))
-        actual_dependencies = package_json["dependencies"]&.keys
+        package_json = PackageJson.read(path_in_the_app)
+        actual_dependencies = package_json.fetch("dependencies", {}).keys
 
         expected_dependencies = %w(
           @babel/core
@@ -131,8 +265,8 @@ describe "Generator" do
       end
 
       it "adds Shakapacker peer dev dependencies to package.json" do
-        package_json = JSON.parse(File.read(path_in_the_app("package.json")))
-        actual_dev_dependencies = package_json["devDependencies"]&.keys
+        package_json = PackageJson.read(path_in_the_app)
+        actual_dev_dependencies = package_json.fetch("devDependencies", {}).keys
 
         expected_dev_dependencies = %w(
           webpack-dev-server
@@ -143,10 +277,12 @@ describe "Generator" do
 
       context "with a basic react app setup" do
         it "passes the test for rendering react component on the page" do
+          sh_opts = { fallback_manager: nil }
+
           Bundler.with_unbundled_env do
-            sh_in_dir(TEMP_RAILS_APP_PATH, "./bin/rails app:template LOCATION=../e2e_template/template.rb")
+            sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "./bin/rails app:template LOCATION=../e2e_template/template.rb")
 
-            expect(sh_in_dir(TEMP_RAILS_APP_PATH, "bundle exec rspec")).to be_truthy
+            expect(sh_in_dir(sh_opts, TEMP_RAILS_APP_PATH, "bundle exec rspec")).to be_truthy
           end
         end
       end
@@ -167,7 +303,21 @@ describe "Generator" do
       File.read(path)
     end
 
-    def sh_in_dir(dir, *shell_commands)
+    def sort_out_package_json(opts)
+      ENV["PATH"] = "#{SPEC_PATH}/fake-bin:#{ENV["PATH"]}"
+
+      if opts[:fallback_manager].nil?
+        ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] = "yarn_classic"
+        ENV["SHAKAPACKER_USE_PACKAGE_JSON_GEM"] = "false"
+      else
+        ENV["SHAKAPACKER_EXPECTED_PACKAGE_MANGER"] = opts[:fallback_manager]
+        ENV["SHAKAPACKER_USE_PACKAGE_JSON_GEM"] = "true"
+        ENV["PACKAGE_JSON_FALLBACK_MANAGER"] = opts[:fallback_manager]
+      end
+    end
+
+    def sh_in_dir(opts, dir, *shell_commands)
+      sort_out_package_json(opts)
       Shakapacker::Utils::Misc.sh_in_dir(dir, *shell_commands)
     end
 end

data/spec/mounted_app/package.json

@@ -0,0 +1 @@
+{}

data/spec/shakapacker/compiler_spec.rb

@@ -50,10 +50,14 @@ describe "Shakapacker::Compiler" do
     expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_ASSET_HOST"]).to be nil
     expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_RELATIVE_URL_ROOT"]).to be nil
 
-    ENV["SHAKAPACKER_ASSET_HOST"] = "foo.bar"
-    ENV["SHAKAPACKER_RELATIVE_URL_ROOT"] = "/baz"
-
-    expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_ASSET_HOST"]).to eq "foo.bar"
-    expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_RELATIVE_URL_ROOT"]).to eq "/baz"
+    custom_env_variables = {
+      "SHAKAPACKER_ASSET_HOST" => "foo.bar",
+      "SHAKAPACKER_RELATIVE_URL_ROOT" => "/baz"
+    }
+
+    with_env_variable(custom_env_variables) do
+      expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_ASSET_HOST"]).to eq "foo.bar"
+      expect(Shakapacker.compiler.send(:webpack_env)["SHAKAPACKER_RELATIVE_URL_ROOT"]).to eq "/baz"
+    end
   end
 end