shakapacker 7.0.3 → 7.2.0.rc.0

data/spec/shakapacker/dev_server_runner_spec.rb

@@ -16,57 +16,122 @@ describe "DevServerRunner" do
 
   let(:test_app_path) { File.expand_path("./test_app", __dir__) }
 
-  it "run cmd via node modules" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-    verify_command(cmd, use_node_modules: true)
-  end
-  it "run cmd via yarn" do
-    cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-    verify_command(cmd, use_node_modules: false)
-  end
-  it "run cmd argv" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
-    verify_command(cmd, argv: (["--quiet"]))
-  end
-  it "run cmd argv with https" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
-
-    dev_server = double()
-    allow(dev_server).to receive(:host).and_return("localhost")
-    allow(dev_server).to receive(:port).and_return("3035")
-    allow(dev_server).to receive(:pretty?).and_return(false)
-    allow(dev_server).to receive(:https?).and_return(true)
-    allow(dev_server).to receive(:hmr?).and_return(false)
-
-    allow(Shakapacker::DevServer).to receive(:new) do
-      verify_command(cmd, argv: (["--https"]))
-    end.and_return(dev_server)
+  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
+    context "when using package_json with #{fallback_manager} as the manager" do
+      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
+
+      let(:package_json) { PackageJson.read(test_app_path) }
+
+      require "package_json"
+
+      it "uses the expected package manager", unless: fallback_manager == "yarn_classic" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+
+        manager_name = fallback_manager.split("_")[0]
+
+        expect(cmd).to start_with(manager_name)
+      end
+
+      it "runs the command using the manager" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+
+        verify_command(cmd)
+      end
+
+      it "passes on arguments" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"])
+
+        verify_command(cmd, argv: (["--quiet"]))
+      end
+
+      it "supports the https flag" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"])
+
+        dev_server = double()
+        allow(dev_server).to receive(:host).and_return("localhost")
+        allow(dev_server).to receive(:port).and_return("3035")
+        allow(dev_server).to receive(:pretty?).and_return(false)
+        allow(dev_server).to receive(:https?).and_return(true)
+        allow(dev_server).to receive(:hmr?).and_return(false)
+
+        allow(Shakapacker::DevServer).to receive(:new) do
+          verify_command(cmd, argv: (["--https"]))
+        end.and_return(dev_server)
+      end
+
+      it "accepts environment variables" do
+        cmd = package_json.manager.native_exec_command("webpack", ["serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"])
+
+        env = Shakapacker::Compiler.env.dup
+        ENV["SHAKAPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/shakapacker_other_location.yml"
+        env["WEBPACK_SERVE"] = "true"
+
+        verify_command(cmd, env: env)
+      end
+    end
   end
-  it "accepts environment variables" do
-    cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-    env = Shakapacker::Compiler.env.dup
-    ENV["SHAKAPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/shakapacker_other_location.yml"
-    env["WEBPACK_SERVE"] = "true"
-    verify_command(cmd, env: env)
+
+  context "when not using package_json" do
+    with_use_package_json_gem(enabled: false)
+
+    it "supports running via node modules" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
+      verify_command(cmd, use_node_modules: true)
+    end
+
+    it "supports running via yarn" do
+      cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
+      verify_command(cmd, use_node_modules: false)
+    end
+
+    it "passes on arguments" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
+
+      verify_command(cmd, argv: (["--quiet"]))
+    end
+
+    it "supports the https flag" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
+
+      dev_server = double()
+      allow(dev_server).to receive(:host).and_return("localhost")
+      allow(dev_server).to receive(:port).and_return("3035")
+      allow(dev_server).to receive(:pretty?).and_return(false)
+      allow(dev_server).to receive(:https?).and_return(true)
+      allow(dev_server).to receive(:hmr?).and_return(false)
+
+      allow(Shakapacker::DevServer).to receive(:new) do
+        verify_command(cmd, argv: (["--https"]))
+      end.and_return(dev_server)
+    end
+
+    it "accepts environment variables" do
+      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+      env = Shakapacker::Compiler.env.dup
+
+      ENV["SHAKAPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/shakapacker_other_location.yml"
+      env["WEBPACK_SERVE"] = "true"
+
+      verify_command(cmd, env: env)
+    end
   end
 
   private
 
     def verify_command(cmd, use_node_modules: true, argv: [], env: Shakapacker::Compiler.env)
-      cwd = Dir.pwd
-      Dir.chdir(test_app_path)
-      klass = Shakapacker::DevServerRunner
-      instance = klass.new(argv)
-
-      allow(klass).to receive(:new).and_return(instance)
-      allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
-      allow(Kernel).to receive(:exec).with(env, *cmd)
+      Dir.chdir(test_app_path) do
+        klass = Shakapacker::DevServerRunner
+        instance = klass.new(argv)
 
-      klass.run(argv)
+        allow(klass).to receive(:new).and_return(instance)
+        allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
+        allow(Kernel).to receive(:exec).with(env, *cmd)
 
-      expect(Kernel).to have_received(:exec).with(env, *cmd)
+        klass.run(argv)
 
-      ensure
-        Dir.chdir(cwd)
+        expect(Kernel).to have_received(:exec).with(env, *cmd)
+      end
     end
 end

data/spec/shakapacker/dev_server_spec.rb

@@ -41,7 +41,7 @@ describe "DevServer" do
     end
   end
 
-  it "users SHAKAPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
+  it "uses SHAKAPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
     expect(Shakapacker::DevServer::DEFAULT_ENV_PREFIX).to eq "SHAKAPACKER_DEV_SERVER"
   end
 

data/spec/shakapacker/digest_strategy_spec.rb

@@ -23,6 +23,7 @@ describe "DigestStrategy" do
 
   it "is fresh after compilation" do
     @digest_strategy.after_compile_hook
+
     expect(@digest_strategy.stale?).to be false
     expect(@digest_strategy.fresh?).to be true
   end
@@ -30,6 +31,7 @@ describe "DigestStrategy" do
   it "generates correct compilation_digest_path" do
     actual_path = @digest_strategy.send(:compilation_digest_path).basename.to_s
     expected_path = "last-compilation-digest-#{Shakapacker.env}"
+
     expect(actual_path).to eq expected_path
   end
 end

data/spec/shakapacker/engine_rake_tasks_spec.rb

@@ -9,14 +9,36 @@ describe "EngineRakeTasks" do
     remove_webpack_binstubs
   end
 
-  it "mounts app:shakapacker task successfully" do
-    output = Dir.chdir(mounted_app_path) { `rake -T` }
-    expect(output).to include "app:shakapacker"
+  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
+    context "when using package_json with #{fallback_manager} as the manager" do
+      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
+
+      it "mounts app:shakapacker task successfully" do
+        output = Dir.chdir(mounted_app_path) { `rake -T` }
+
+        expect(output).to include "app:shakapacker"
+      end
+
+      it "only adds expected files to bin directory when binstubs is run" do
+        Dir.chdir(mounted_app_path) { `bundle exec rake app:shakapacker:binstubs` }
+        expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+      end
+    end
   end
 
-  it "binstubs adds only expected files to bin directory" do
-    Dir.chdir(mounted_app_path) { `bundle exec rake app:shakapacker:binstubs` }
-    expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+  context "when not using package_json" do
+    with_use_package_json_gem(enabled: false)
+
+    it "mounts app:shakapacker task successfully" do
+      output = Dir.chdir(mounted_app_path) { `rake -T` }
+
+      expect(output).to include "app:shakapacker"
+    end
+
+    it "only adds expected files to bin directory when binstubs is run" do
+      Dir.chdir(mounted_app_path) { `bundle exec rake app:shakapacker:binstubs` }
+      expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
+    end
   end
 
   private

data/spec/shakapacker/helper_spec.rb

@@ -22,17 +22,17 @@ module ActionView::TestCase::Behavior
       @javascript_pack_tag_loaded = nil
     end
 
-    it "#asset_pack_path generates correct path" do
+    it "#asset_pack_path generates the correct path" do
       expect(asset_pack_path("bootstrap.js")).to eq "/packs/bootstrap-300631c4f0e0f9c865bc.js"
       expect(asset_pack_path("bootstrap.css")).to eq "/packs/bootstrap-c38deda30895059837cf.css"
     end
 
-    it "#asset_pack_url generates correct url" do
+    it "#asset_pack_url generates the correct url" do
       expect(asset_pack_url("bootstrap.js")).to eq "https://example.com/packs/bootstrap-300631c4f0e0f9c865bc.js"
       expect(asset_pack_url("bootstrap.css")).to eq "https://example.com/packs/bootstrap-c38deda30895059837cf.css"
     end
 
-    it "#image_pack_path generates correct path" do
+    it "#image_pack_path generates the correct path" do
       expect(image_pack_path("application.png")).to eq "/packs/application-k344a6d59eef8632c9d1.png"
       expect(image_pack_path("image.jpg")).to eq "/packs/static/image-c38deda30895059837cf.jpg"
       expect(image_pack_path("static/image.jpg")).to eq "/packs/static/image-c38deda30895059837cf.jpg"
@@ -40,7 +40,7 @@ module ActionView::TestCase::Behavior
       expect(image_pack_path("static/nested/image.jpg")).to eq "/packs/static/nested/image-c38deda30895059837cf.jpg"
     end
 
-    it "#image_pack_url generates correct path" do
+    it "#image_pack_url generates the correct path" do
       expect(image_pack_url("application.png")).to eq "https://example.com/packs/application-k344a6d59eef8632c9d1.png"
       expect(image_pack_url("image.jpg")).to eq "https://example.com/packs/static/image-c38deda30895059837cf.jpg"
       expect(image_pack_url("static/image.jpg")).to eq "https://example.com/packs/static/image-c38deda30895059837cf.jpg"
@@ -48,7 +48,7 @@ module ActionView::TestCase::Behavior
       expect(image_pack_url("static/nested/image.jpg")).to eq "https://example.com/packs/static/nested/image-c38deda30895059837cf.jpg"
     end
 
-    it "#image_pack_tag generates correct tags" do
+    it "#image_pack_tag generates the correct tags" do
       expect(image_pack_tag("application.png", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/application-k344a6d59eef8632c9d1.png\" width=\"16\" height=\"10\" />"
       expect(image_pack_tag("image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
       expect(image_pack_tag("static/image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
@@ -57,7 +57,7 @@ module ActionView::TestCase::Behavior
       expect(image_pack_tag("static/image.jpg", srcset: { "static/image-2x.jpg" => "2x" })).to eq "<img srcset=\"/packs/static/image-2x-7cca48e6cae66ec07b8e.jpg 2x\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" />"
     end
 
-    it "#favicon_pack_tag generates correct tags" do
+    it "#favicon_pack_tag generates the correct tags" do
       expect(favicon_pack_tag("application.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/application-k344a6d59eef8632c9d1.png\" />"
       expect(favicon_pack_tag("mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/mb-icon-c38deda30895059837cf.png\" />"
       expect(favicon_pack_tag("static/mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/mb-icon-c38deda30895059837cf.png\" />"
@@ -65,7 +65,7 @@ module ActionView::TestCase::Behavior
       expect(favicon_pack_tag("static/nested/mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/nested/mb-icon-c38deda30895059837cf.png\" />"
     end
 
-    it "#preload_pack_asset generates correct tag" do
+    it "#preload_pack_asset generates the correct tag" do
       if self.class.method_defined?(:preload_link_tag)
         expect(preload_pack_asset("fonts/fa-regular-400.woff2")).to eq %(<link rel="preload" href="/packs/fonts/fa-regular-400-944fb546bd7018b07190a32244f67dc9.woff2" as="font" type="font/woff2" crossorigin="anonymous">)
       else
@@ -73,7 +73,7 @@ module ActionView::TestCase::Behavior
       end
     end
 
-    it "#javascript_pack_tag generates correct tags" do
+    it "#javascript_pack_tag generates the correct tags" do
       expected = <<~HTML.chomp
         <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
         <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
@@ -84,7 +84,7 @@ module ActionView::TestCase::Behavior
       expect(javascript_pack_tag("application", "bootstrap")).to eq expected
     end
 
-    it "#javascript_pack_tag generates correct tags by passing `defer: false`" do
+    it "#javascript_pack_tag generates the correct tags when passing `defer: false`" do
       expected = <<~HTML.chomp
         <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js"></script>
         <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js"></script>
@@ -95,7 +95,7 @@ module ActionView::TestCase::Behavior
       expect(javascript_pack_tag("application", "bootstrap", defer: false)).to eq expected
     end
 
-    it "#javascript_pack_tag generates correct appended tag" do
+    it "#javascript_pack_tag generates the correct appended tag" do
       append_javascript_pack_tag("bootstrap", defer: false)
 
       expected = <<~HTML.chomp
@@ -108,7 +108,7 @@ module ActionView::TestCase::Behavior
       expect(javascript_pack_tag("application")).to eq expected
     end
 
-    it "#javascript_pack_tag generates correct prepended tag" do
+    it "#javascript_pack_tag generates the correct prepended tag" do
       append_javascript_pack_tag("bootstrap")
       prepend_javascript_pack_tag("main")
 
@@ -123,7 +123,7 @@ module ActionView::TestCase::Behavior
       expect(javascript_pack_tag("application")).to eq expected
     end
 
-    it "#append_javascript_pack_tag raises error if called after calling #javascript_pack_tag" do
+    it "#append_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call append_javascript_pack_tag before javascript_pack_tag helper. " +
         "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
@@ -134,7 +134,7 @@ module ActionView::TestCase::Behavior
       }.to raise_error(expected_error_message)
     end
 
-    it "#prepend_javascript_pack_tag raises error if called after calling #javascript_pack_tag" do
+    it "#prepend_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call prepend_javascript_pack_tag before javascript_pack_tag helper. " +
         "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
@@ -145,7 +145,7 @@ module ActionView::TestCase::Behavior
       }.to raise_error(expected_error_message)
     end
 
-    it "#javascript_pack_tag generates correct tags by passing `defer: true`" do
+    it "#javascript_pack_tag generates the correct tags when passing `defer: true`" do
       expected = <<~HTML.chomp
         <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
         <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
@@ -155,7 +155,7 @@ module ActionView::TestCase::Behavior
       expect(javascript_pack_tag("application", defer: true)).to eq expected
     end
 
-    it "#javascript_pack_tag generates correct tags by passing symbol" do
+    it "#javascript_pack_tag generates the correct tags when passing a symbol" do
       expected = <<~HTML.chomp
         <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
         <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
@@ -175,7 +175,7 @@ module ActionView::TestCase::Behavior
       }.to raise_error(expected_error_message)
     end
 
-    it "#stylesheet_pack_tag generates correct link tag with string arguments" do
+    it "#stylesheet_pack_tag generates the correct link tag with string arguments" do
       expected = (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks)
         .uniq
         .map { |chunk| stylesheet_link_tag(chunk) }
@@ -184,7 +184,7 @@ module ActionView::TestCase::Behavior
       expect(stylesheet_pack_tag("application", "hello_stimulus")).to eq expected
     end
 
-    it "#stylesheet_pack_tag generates correct link tag with symbol arguments" do
+    it "#stylesheet_pack_tag generates the correct link tag with symbol arguments" do
       expected = (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks)
         .uniq
         .map { |chunk| stylesheet_link_tag(chunk) }
@@ -193,7 +193,7 @@ module ActionView::TestCase::Behavior
       expect(stylesheet_pack_tag(:application, :hello_stimulus)).to eq expected
     end
 
-    it "#stylesheet_pack_tag generates correct link tag with mixed arguments" do
+    it "#stylesheet_pack_tag generates the correct link tag with mixed arguments" do
       expected = (application_stylesheet_chunks)
         .map { |chunk| stylesheet_link_tag(chunk, media: "all") }
         .join("\n")
@@ -215,7 +215,7 @@ module ActionView::TestCase::Behavior
       }.to_not raise_error
     end
 
-    it "#stylesheet_pack_tag appends" do
+    it "#stylesheet_pack_tag appends tags" do
       append_stylesheet_pack_tag(:hello_stimulus)
 
       expect(stylesheet_pack_tag(:application)).to eq \
@@ -230,7 +230,7 @@ module ActionView::TestCase::Behavior
         (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks).uniq.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
     end
 
-    it "#stylesheet_pack_tag supports multiple invocations with different media attr" do
+    it "#stylesheet_pack_tag supports multiple invocations with different media attr values" do
       app_style = stylesheet_pack_tag(:application)
       app_style_with_media = stylesheet_pack_tag(:application, media: "print")
       hello_stimulus_style_with_media = stylesheet_pack_tag(:hello_stimulus, media: "all")

data/spec/shakapacker/instance_spec.rb

@@ -13,14 +13,14 @@ describe "Shakapacker::Instance" do
     Shakapacker.instance = Shakapacker::Instance.new
   end
 
-  it "uses default config path if no env variable defined" do
+  it "uses the default config path if no env variable defined" do
     actual_config_path = Rails.root.join("config/shakapacker.yml")
     expected_config_path = Shakapacker.config.config_path
 
     expect(expected_config_path).to eq(actual_config_path)
   end
 
-  it "uses SHAKAPACKER_CONFIG env variable for config file" do
+  it "uses the SHAKAPACKER_CONFIG env variable for the config file path" do
     ENV["SHAKAPACKER_CONFIG"] = "/some/random/path.yml"
 
     actual_config_path = "/some/random/path.yml"

data/spec/shakapacker/manifest_spec.rb

@@ -3,7 +3,7 @@ require_relative "spec_helper_initializer"
 describe "Shakapacker::Manifest" do
   let(:manifest_path) { File.expand_path File.join(File.dirname(__FILE__), "./test_app/public/packs", "manifest.json").to_s }
 
-  it "#lookup! throws exception for a non-existing asset file" do
+  it "#lookup! raises an exception for a non-existing asset file" do
     asset_file = "calendar.js"
     expected_error_message = "Shakapacker can't find #{asset_file} in #{manifest_path}"
 
@@ -14,7 +14,7 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup! throws exception for a non-existing asset file with type and without extension" do
+  it "#lookup! raises an exception for a non-existing asset file with type and without an extension" do
     asset_file = "calendar"
     expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
 
@@ -25,57 +25,57 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup! returns path to bundled bootstrap.js" do
+  it "#lookup! returns the path to the bundled bootstrap.js" do
     actual = Shakapacker.manifest.lookup!("bootstrap.js")
     expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_pack_with_chunks! returns array of path to bundled bootstrap with type of javascript" do
+  it "#lookup_pack_with_chunks! returns an array of paths to the bundled bootstrap of type javascript" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("bootstrap", type: :javascript)
     expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled bootstrap.js with type of javascript" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled bootstrap.js of type javascript" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("bootstrap.js", type: :javascript)
     expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled 'print/application' without extension and in a sub-directory" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application' without an extension and in a sub-directory" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("print/application", type: :css)
     expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled 'print/application.css' in a sub-directory" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application.css' in a sub-directory" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("print/application.css", type: :css)
     expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup returns nil for non-existing asset file" do
+  it "#lookup returns nil for non-existing asset files" do
     expect(Shakapacker.manifest.lookup("foo.js")).to be nil
   end
 
-  it "#lookup_pack_with_chunks returns nil for non-existing asset file" do
+  it "#lookup_pack_with_chunks returns nil for non-existing asset files" do
     expect(Shakapacker.manifest.lookup_pack_with_chunks("foo.js")).to be nil
   end
 
-  it "#lookup returns path for bootstrap.js" do
+  it "#lookup returns the path for bootstrap.js" do
     actual = Shakapacker.manifest.lookup("bootstrap.js")
     expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_pack_with_chunks! throws exception for a non-existing asset file" do
+  it "#lookup_pack_with_chunks! raises an exception for non-existing asset files" do
     asset_file = "calendar"
 
     expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
@@ -87,7 +87,7 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup_pack_with_chunks! returns array of paths to bundled js files with 'application' in their name" do
+  it "#lookup_pack_with_chunks! returns an array of paths to bundled js files with 'application' in their name" do
     actual_application_entrypoints = Shakapacker.manifest.lookup_pack_with_chunks!("application", type: :javascript)
     expected_application_entrypoints = [
       "/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js",

data/spec/shakapacker/mtime_strategy_spec.rb

@@ -5,7 +5,7 @@ describe "Shakapacker::MtimeStrategy" do
   let(:manifest_timestamp) { Time.parse("2021-01-01 12:34:56 UTC") }
 
   describe "#fresh?" do
-    it "returns false when manifest is missing" do
+    it "returns false when the manifest is missing" do
       latest_timestamp = manifest_timestamp + 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i, manifest_exists: false) do
@@ -13,7 +13,7 @@ describe "Shakapacker::MtimeStrategy" do
       end
     end
 
-    it "returns false when manifest is older" do
+    it "returns false when the manifest is older" do
       latest_timestamp = manifest_timestamp + 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i) do
@@ -21,7 +21,7 @@ describe "Shakapacker::MtimeStrategy" do
       end
     end
 
-    it "returns true when manifest is new" do
+    it "returns true when the manifest is new" do
       latest_timestamp = manifest_timestamp - 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i) do

data/spec/shakapacker/rake_tasks_spec.rb

@@ -8,7 +8,7 @@ describe "RakeTasks" do
     expect(output).to include "shakapacker"
     expect(output).to include "shakapacker:check_binstubs"
     expect(output).to include "shakapacker:check_node"
-    expect(output).to include "shakapacker:check_yarn"
+    expect(output).to include "shakapacker:check_manager"
     expect(output).to include "shakapacker:clean"
     expect(output).to include "shakapacker:clobber"
     expect(output).to include "shakapacker:compile"
@@ -18,22 +18,26 @@ describe "RakeTasks" do
 
   it "`shakapacker:check_binstubs` doesn't get 'webpack binstub not found' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_binstubs 2>&1` }
+
     expect(output).to_not include "webpack binstub not found."
   end
 
   it "`shakapacker:check_node` doesn't get 'shakapacker requires Node.js' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_node 2>&1` }
+
     expect(output).to_not include "Shakapacker requires Node.js"
   end
 
-  it "`shakapacker:check_yarn` doesn't get error related to yarn" do
-    output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_yarn 2>&1` }
-    expect(output).to_not include "Yarn not installed"
-    expect(output).to_not include "Shakapacker requires Yarn"
+  # TODO: currently this test depends on external conditions & PACKAGE_JSON_FALLBACK_MANAGER
+  it "`shakapacker:check_manager` doesn't get errors related to the package manager" do
+    output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_manager 2>&1` }
+
+    expect(output).to_not include "not installed"
+    expect(output).to_not include "Shakapacker requires"
   end
 
   describe "`shakapacker:check_binstubs`" do
-    def with_temporary_file(file_name, &block)
+    def with_temporary_file(file_name)
       FileUtils.touch(file_name, verbose: false)
       yield if block_given?
     ensure

data/spec/shakapacker/shakapacker_spec.rb

@@ -12,11 +12,11 @@ describe "Shakapacker" do
       allow(dev_server).to receive(:running?).and_return(true)
     end
 
-    it "returns nil with disabled dev_server" do
+    it "returns nil when the dev server is disabled" do
       expect(Shakapacker.inlining_css?).to be nil
     end
 
-    it "returns true with enabled hmr" do
+    it "returns true when hmr is enabled" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(true)
 
@@ -25,7 +25,7 @@ describe "Shakapacker" do
       expect(Shakapacker.inlining_css?).to be true
     end
 
-    it "returns false with enabled hmr and explicitly setting inline_css to false" do
+    it "returns false when hmr is enabled and inline_css is explicitly set to false" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(false)
 
@@ -35,7 +35,7 @@ describe "Shakapacker" do
     end
   end
 
-  it "has app_autoload_paths cleanup" do
+  it "automatically cleans up app_autoload_paths" do
     expect($test_app_autoload_paths_in_initializer).to eq []
   end
 end

data/spec/shakapacker/spec_helper_initializer.rb

@@ -22,3 +22,21 @@ ensure
   Rails.env = ActiveSupport::StringInquirer.new(original)
   reloaded_config
 end
+
+# Temportarily set env variables to a custom value
+# arg: a hash with key:value for each custom env
+#      Keys could be string or symbol
+def with_env_variable(custom_env_hash)
+  original_env = {}
+  custom_env_hash.each do |key, new_value|
+    upcased_key = key.to_s.upcase
+    original_env[upcased_key] = new_value
+    ENV[upcased_key] = new_value
+  end
+
+  yield
+ensure
+  original_env.each do |key, original_value|
+    ENV[key] = original_value
+  end
+end