shakapacker 7.0.3 → 7.1.0

data/spec/shakapacker/rake_tasks_spec.rb

@@ -18,22 +18,25 @@ describe "RakeTasks" do
 
   it "`shakapacker:check_binstubs` doesn't get 'webpack binstub not found' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_binstubs 2>&1` }
+
     expect(output).to_not include "webpack binstub not found."
   end
 
   it "`shakapacker:check_node` doesn't get 'shakapacker requires Node.js' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_node 2>&1` }
+
     expect(output).to_not include "Shakapacker requires Node.js"
   end
 
-  it "`shakapacker:check_yarn` doesn't get error related to yarn" do
+  it "`shakapacker:check_yarn` doesn't get errors related to yarn" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_yarn 2>&1` }
+
     expect(output).to_not include "Yarn not installed"
     expect(output).to_not include "Shakapacker requires Yarn"
   end
 
   describe "`shakapacker:check_binstubs`" do
-    def with_temporary_file(file_name, &block)
+    def with_temporary_file(file_name)
       FileUtils.touch(file_name, verbose: false)
       yield if block_given?
     ensure

data/spec/shakapacker/shakapacker_spec.rb

@@ -12,11 +12,11 @@ describe "Shakapacker" do
       allow(dev_server).to receive(:running?).and_return(true)
     end
 
-    it "returns nil with disabled dev_server" do
+    it "returns nil when the dev server is disabled" do
       expect(Shakapacker.inlining_css?).to be nil
     end
 
-    it "returns true with enabled hmr" do
+    it "returns true when hmr is enabled" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(true)
 
@@ -25,7 +25,7 @@ describe "Shakapacker" do
       expect(Shakapacker.inlining_css?).to be true
     end
 
-    it "returns false with enabled hmr and explicitly setting inline_css to false" do
+    it "returns false when hmr is enabled and inline_css is explicitly set to false" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(false)
 
@@ -35,7 +35,7 @@ describe "Shakapacker" do
     end
   end
 
-  it "has app_autoload_paths cleanup" do
+  it "automatically cleans up app_autoload_paths" do
     expect($test_app_autoload_paths_in_initializer).to eq []
   end
 end