shakapacker 7.0.0 → 7.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0eef3643fb556af4dc928c1d651fa46cfe5543fc6d5a227d29fcbfd7b3876c3c
-  data.tar.gz: 4530e671bb02c0af5bbfc37ba1696fff4e81548c40af6df65a06e2bc2d0a9815
+  metadata.gz: d4aaa412d5721d91a27e137f18413f5c3782c8a922911b35fa712f776d04e31b
+  data.tar.gz: afabe31c503c8bfabe21d52fa0e401c9f4b80696a274013058ef417f0b419c26
 SHA512:
-  metadata.gz: a7803b77d1d0e9dff88d6cdb25f88c1a89fb4c036153e03d153fe994b216a82a69aaa85d446331945a528443fbd097ac4f49cb64661e66f29b5941a5971315a8
-  data.tar.gz: 98aba0b391b59a50932d43cab666604998d66c5bcf548f8ceea06c77919a9196ba5ca2861a204ce3f66cd490d69b64e0e8c0dfb10610b6ba64842049f49d2df4
+  metadata.gz: 0b2367ca20d0cb3da0ff8265ad22551bf288706d76afa84ace8700d091a99b6c201bf11d44116481bd1e89336ea154972314f3a2117cb14ad6dd3bd2152012d9
+  data.tar.gz: f1cbdf73ce49838513d888ccc86c20185331bc4d0e7934ff88d7ee7d2c4a89efed8e98253c511351ce32bec9faefc0d73c899e07a268fb977cacd772788b841d

data/CHANGELOG.md

@@ -9,6 +9,9 @@ Changes since last non-beta release.
 
 _Please add entries here for your pull requests that are not yet released._
 
+### Fixed
+- Fixed the condition for showing warning for setting `useContentHash` to `false` in the production environment. [PR 320](https://github.com/shakacode/shakapacker/pull/320) by [ahangarha](https://github.com/ahangarha).
+
 ### Breaking changes
 - Removes defaults passed to `@babel/preset-typescript`. [PR 273](https://github.com/shakacode/shakapacker/pull/273) by [tomdracz](https://github.com/tomdracz).
 

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "7.0.0".freeze
+  VERSION = "7.0.1".freeze
 end

data/package/environments/__tests__/production.js

@@ -23,6 +23,19 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test("doesn't shows any warning message", () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      config.useContentHash = true
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 
   describe('with config.useContentHash = false', () => {
@@ -36,6 +49,19 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test('shows a warning message', () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      config.useContentHash = false
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 
   describe('with unset config.useContentHash', () => {
@@ -49,5 +75,18 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test("doesn't shows any warning message", () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      delete config.useContentHash
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 })

data/package/environments/production.js

@@ -77,7 +77,7 @@ const productionConfig = {
   }
 }
 
-if (config.useContentHash === true) {
+if (config.useContentHash === false) {
   // eslint-disable-next-line no-console
   console.warn(`⚠️ WARNING
 Setting 'useContentHash' to 'false' in the production environment (specified by NODE_ENV environment variable) is not allowed!

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "7.0.0",
+  "version": "7.0.1",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
   "files": [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 7.0.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-23 00:00:00.000000000 Z
+date: 2023-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -528,7 +528,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.0.0
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.0.1
 post_install_message:
 rdoc_options: []
 require_paths: