shakapacker 6.6.0 → 7.0.0.rc.1

data/package/index.js

@@ -10,19 +10,42 @@ const config = require('./config')
 const devServer = require('./dev_server')
 const env = require('./env')
 const { moduleExists, canProcess } = require('./utils/helpers')
-const inliningCss = require('./inliningCss')
+const inliningCss = require('./utils/inliningCss')
 
-const webpackConfig = () => {
+const globalMutableWebpackConfig = () => {
   const { nodeEnv } = env
   const path = resolve(__dirname, 'environments', `${nodeEnv}.js`)
   const environmentConfig = existsSync(path) ? require(path) : baseConfig
   return environmentConfig
 }
 
+const generateWebpackConfig = () => {
+  const environmentConfig = globalMutableWebpackConfig()
+  const immutable = webpackMerge.merge({}, environmentConfig)
+  return immutable
+}
+
+const webpackConfigForBackwardCompatibility = () => {
+  // eslint-disable-next-line no-console
+  console.log(`⚠️
+DEPRECATION NOTICE:
+The 'webpackConfig' is deprecated and will be removed in a future version.
+Please use 'globalMutableWebpackConfig' instead, or use
+'generateWebpackConfig()' to avoid unwanted config manipulation across the app.
+
+For more information, see version 7 upgrade documentation at:
+https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md
+`)
+
+  return globalMutableWebpackConfig()
+}
+
 module.exports = {
-  config,
+  config, // shakapacker.yml
   devServer,
-  webpackConfig: webpackConfig(),
+  generateWebpackConfig,
+  globalMutableWebpackConfig: globalMutableWebpackConfig(),
+  webpackConfig: webpackConfigForBackwardCompatibility(),
   baseConfig,
   env,
   rules,

data/package/rules/__tests__/__utils__/webpack.js

@@ -16,7 +16,7 @@ const createTrackLoader = () => {
 
 const node_modules = path.resolve("node_modules");
 const node_modules_included = path.resolve("node_modules/included");
-const app_javascript = path.resolve("app/packs");
+const app_javascript = path.resolve("app/javascript");
 
 const createInMemoryFs = () => {
   const fs = new MemoryFS();

data/package/rules/__tests__/file.js

@@ -32,4 +32,31 @@ describe('file', () => {
     ]
     types.forEach(type => expect(file.exclude.test(type)).toBe(true))
   })
+
+  test('correct generated output path is returned for top level files', () => {
+    const pathData = {
+      filename: 'app/javascript/image.svg',
+    };
+    expect(file.generator.filename(pathData)).toEqual(
+      'static/[name]-[hash][ext][query]'
+    );
+  });
+
+  test('correct generated output path is returned for nested files', () => {
+    const pathData = {
+      filename: 'app/javascript/images/image.svg',
+    };
+    expect(file.generator.filename(pathData)).toEqual(
+      'static/images/[name]-[hash][ext][query]'
+    );
+  })
+
+  test('correct generated output path is returned for deeply nested files', () => {
+    const pathData = {
+      filename: 'app/javascript/images/nested/deeply/image.svg',
+    };
+    expect(file.generator.filename(pathData)).toEqual(
+      'static/images/nested/deeply/[name]-[hash][ext][query]'
+    );
+  });
 })

data/package/rules/__tests__/swc.js

@@ -1,4 +1,3 @@
-const path = require("path");
 const {
   app_javascript,
   node_modules,
@@ -36,7 +35,7 @@ const createWebpackConfig = (file, use) => {
 };
 
 describe("swc", () => {
-  test("process source path", async () => {
+  test("process files in source_path", async () => {
     const normalPath = `${app_javascript}/a.js`;
     const [tracked, loader] = createTrackLoader();
     const compiler = createTestCompiler(

data/package/rules/file.js

@@ -8,9 +8,9 @@ module.exports = {
   generator: {
     filename: (pathData) => {
       const folders = dirname(pathData.filename)
-        .replace(`${sourcePath}/`, '')
+        .replace(`${sourcePath}`, '')
         .split('/')
-        .slice(1)
+        .filter(Boolean)
 
       const foldersWithStatic = ['static', ...folders].join('/')
       return `${foldersWithStatic}/[name]-[hash][ext][query]`

data/package/utils/configPath.js

@@ -0,0 +1,19 @@
+const fs = require('fs')
+const { resolve } = require('path')
+const { setShakapackerEnvVariablesForBackwardCompatibility } = require('./helpers')
+
+setShakapackerEnvVariablesForBackwardCompatibility()
+
+// For backward compatibility
+const resolveToPhysicalFilePath = () => {
+  const shakapackerConfigPath = resolve('config', 'shakapacker.yml')
+  const webpackerConfigPath = resolve('config', 'webpacker.yml')
+
+  if (fs.existsSync(shakapackerConfigPath)) return shakapackerConfigPath
+  if (fs.existsSync(webpackerConfigPath)) return webpackerConfigPath
+
+  // If neither of files exist, try to resolve to shakapacker.yml to get more relevant error
+  return shakapackerConfigPath
+}
+
+module.exports = process.env.SHAKAPACKER_CONFIG || resolveToPhysicalFilePath()

data/package/utils/defaultConfigPath.js

@@ -0,0 +1,2 @@
+const path = require.resolve('../../lib/install/config/shakapacker.yml')
+module.exports = path

data/package/utils/get_style_rule.js

@@ -1,6 +1,6 @@
 /* eslint global-require: 0 */
 const { canProcess, moduleExists } = require('./helpers')
-const inliningCss = require('../inliningCss')
+const inliningCss = require('./inliningCss')
 
 const getStyleRule = (test, preprocessors = []) => {
   if (moduleExists('css-loader')) {
@@ -18,7 +18,10 @@ const getStyleRule = (test, preprocessors = []) => {
         loader: require.resolve('css-loader'),
         options: {
           sourceMap: true,
-          importLoaders: 2
+          importLoaders: 2,
+          modules: {
+            auto: true
+          }
         }
       },
       tryPostcss(),

data/package/utils/helpers.js

@@ -2,7 +2,16 @@ const isArray = (value) => Array.isArray(value)
 const isBoolean = (str) => /^true/.test(str) || /^false/.test(str)
 const chdirTestApp = () => {
   try {
-    return process.chdir('spec/test_app')
+    return process.chdir('spec/shakapacker/test_app')
+  } catch (e) {
+    return null
+  }
+}
+
+// For backward compatibility
+const chdirWebpackerTestApp = () => {
+  try {
+    return process.chdir('spec/backward_compatibility_specs/webpacker_test_app')
   } catch (e) {
     return null
   }
@@ -48,15 +57,29 @@ const loaderMatches = (configLoader, loaderToCheck, fn) => {
 
   if (!moduleExists(loaderName)) {
     throw new Error(
-      `Your webpacker config specified using ${configLoader}, but ${loaderName} package is not installed. Please install ${loaderName} first.`
+      `Your Shakapacker config specified using ${configLoader}, but ${loaderName} package is not installed. Please install ${loaderName} first.`
     )
   }
 
   return fn()
 }
 
+// For backward compatibility
+// Set SHAKAPACKER_XYZ only if SHAKAPACKER_XYZ is not defined but WEBPACKER_XYZ is.
+const setShakapackerEnvVariablesForBackwardCompatibility = () => {
+  const webpackerEnvVariables = Object.entries(process.env).filter((key) => /^WEBPACKER_/.test(key))
+  webpackerEnvVariables.forEach(([webpackerEnvKey, webpackerEnvValue]) => {
+    const shakapackerKey = webpackerEnvKey.replace(/^WEBPACKER/, 'SHAKAPACKER')
+    if (!process.env[shakapackerKey]) {
+      process.env[shakapackerKey] = webpackerEnvValue
+    }
+  })
+}
+
 module.exports = {
   chdirTestApp,
+  chdirWebpackerTestApp,
+  setShakapackerEnvVariablesForBackwardCompatibility,
   chdirCwd,
   isArray,
   isBoolean,

data/package/utils/inliningCss.js

@@ -0,0 +1,7 @@
+const { runningWebpackDevServer } = require('../env')
+const devServer = require('../dev_server')
+
+// This logic is tied to lib/shakapacker/instance.rb
+const inliningCss = runningWebpackDevServer && devServer.hmr && devServer.inline_css !== false
+
+module.exports = inliningCss

data/package/utils/snakeToCamelCase

@@ -0,0 +1,7 @@
+function snakeToCamelCase(s) {
+  return s.replace(/(_\w)/g, function (match) {
+    return match[1].toUpperCase()
+  })
+}
+
+module.exports = snakeToCamelCase

data/package/webpackDevServerConfig.js

@@ -0,0 +1,68 @@
+const shakapackerDevServerYamlConfig = require('./dev_server')
+const snakeToCamelCase = require('./utils/snakeToCamelCase')
+const { outputPath: contentBase, publicPath } = require('./config')
+
+const webpackDevServerMappedKeys = new Set([
+  // client, server, liveReload, devMiddleware are handled separately
+  'allowedHosts',
+  'bonjour',
+  'compress',
+  'headers',
+  'historyApiFallback',
+  'host',
+  'hot',
+  'http2',
+  'https',
+  'ipc',
+  'magicHtml',
+  'onAfterSetupMiddleware',
+  'onBeforeSetupMiddleware',
+  'open',
+  'port',
+  'proxy',
+  'server',
+  'setupExitSignals',
+  'setupMiddlewares',
+  'watchFiles',
+  'webSocketServer'
+])
+
+function createDevServerConfig() {
+  const devServerYamlConfig = { ...shakapackerDevServerYamlConfig }
+  const liveReload = devServerYamlConfig.live_reload !== undefined ? devServerYamlConfig.live_reload : !devServerYamlConfig.hmr
+  delete devServerYamlConfig.live_reload
+
+  const config = {
+    devMiddleware: {
+      publicPath
+    },
+    liveReload,
+    historyApiFallback: {
+      disableDotRule: true
+    },
+    static: {
+      publicPath: contentBase
+    }
+  }
+
+  if (devServerYamlConfig.static) {
+    config.static = { ...config.static, ...devServerYamlConfig.static }
+    delete devServerYamlConfig.static
+  }
+
+  if (devServerYamlConfig.client) {
+    config.client = devServerYamlConfig.client
+    delete devServerYamlConfig.client
+  }
+
+  Object.keys(devServerYamlConfig).forEach((yamlKey) => {
+    const camelYamlKey = snakeToCamelCase(yamlKey)
+    if (webpackDevServerMappedKeys.has(camelYamlKey)) {
+      config[camelYamlKey] = devServerYamlConfig[yamlKey]
+    }
+  })
+
+  return config
+}
+
+module.exports = createDevServerConfig

data/package.json

@@ -1,11 +1,11 @@
 {
   "name": "shakapacker",
-  "version": "6.6.0",
+  "version": "7.0.0-rc.1",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
   "files": [
     "package",
-    "lib/install/config/webpacker.yml"
+    "lib/install/config/shakapacker.yml"
   ],
   "engines": {
     "node": "^12.13.0 || ^14 || >=16",

data/{webpacker.gemspec → shakapacker.gemspec}

@@ -1,16 +1,16 @@
 $:.push File.expand_path("../lib", __FILE__)
-require "webpacker/version"
+require "shakapacker/version"
 
 Gem::Specification.new do |s|
   s.name     = "shakapacker"
-  s.version  = Webpacker::VERSION
+  s.version  = Shakapacker::VERSION
   s.authors  = [ "David Heinemeier Hansson", "Gaurav Tiwari", "Justin Gordon" ]
   s.email    = [ "david@basecamp.com", "gaurav@gauravtiwari.co.uk", "justin@shakacode.com" ]
   s.summary  = "Use webpack to manage app-like JavaScript modules in Rails"
   s.homepage = "https://github.com/shakacode/shakapacker"
   s.license  = "MIT"
 
-  npm_version = Webpacker::VERSION.gsub(".rc", "-rc")
+  npm_version = Shakapacker::VERSION.gsub(".rc", "-rc")
   s.metadata = {
     "source_code_uri" => "https://github.com/shakacode/shakapacker/tree/v#{npm_version}",
   }

data/spec/{command_spec.rb → backward_compatibility_specs/command_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "Command" do
   before do
     allow(Webpacker.logger).to receive(:info)

data/spec/{compiler_spec.rb → backward_compatibility_specs/compiler_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "Webpacker::Compiler" do
   it "accepts custom environment variables" do
     expect(Webpacker.compiler.send(:webpack_env)["FOO"]).to be nil
@@ -45,13 +47,13 @@ describe "Webpacker::Compiler" do
   end
 
   it "accepts external env variables" do
-    expect(Webpacker.compiler.send(:webpack_env)["WEBPACKER_ASSET_HOST"]).to be nil
-    expect(Webpacker.compiler.send(:webpack_env)["WEBPACKER_RELATIVE_URL_ROOT"]).to be nil
+    expect(Webpacker.compiler.send(:webpack_env)["SHAKAPACKER_ASSET_HOST"]).to be nil
+    expect(Webpacker.compiler.send(:webpack_env)["SHAKAPACKER_RELATIVE_URL_ROOT"]).to be nil
 
     ENV["WEBPACKER_ASSET_HOST"] = "foo.bar"
     ENV["WEBPACKER_RELATIVE_URL_ROOT"] = "/baz"
 
-    expect(Webpacker.compiler.send(:webpack_env)["WEBPACKER_ASSET_HOST"]).to eq "foo.bar"
-    expect(Webpacker.compiler.send(:webpack_env)["WEBPACKER_RELATIVE_URL_ROOT"]).to eq "/baz"
+    expect(Webpacker.compiler.send(:webpack_env)["SHAKAPACKER_ASSET_HOST"]).to eq "foo.bar"
+    expect(Webpacker.compiler.send(:webpack_env)["SHAKAPACKER_RELATIVE_URL_ROOT"]).to eq "/baz"
   end
 end

data/spec/{compiler_strategy_spec.rb → backward_compatibility_specs/compiler_strategy_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "Webpacker::CompilerStrategy" do
   describe "#from_config" do
     it "returns and instance of MtimeStrategy when compiler_strategy is set to mtime" do

data/spec/{configuration_spec.rb → backward_compatibility_specs/configuration_spec.rb}

@@ -1,47 +1,49 @@
+require_relative "spec_helper_initializer"
+
 describe "Webpacker::Configuration" do
-  ROOT_PATH = Pathname.new(File.expand_path("test_app", __dir__))
+  ROOT_PATH = Pathname.new(File.expand_path("webpacker_test_app", __dir__))
 
   context "with standard webpacker.yml" do
     let(:config) do
       Webpacker::Configuration.new(
         root_path: ROOT_PATH,
-        config_path: Pathname.new(File.expand_path("./test_app/config/webpacker.yml", __dir__)),
+        config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker.yml", __dir__)),
         env: "production"
       )
     end
 
     it "#source_path returns correct path" do
-      source_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs").to_s
+      source_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs").to_s
       expect(config.source_path.to_s).to eq source_path
     end
 
     it "#source_entry_path returns correct path" do
-      source_entry_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs", "entrypoints").to_s
+      source_entry_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs", "entrypoints").to_s
       expect(config.source_entry_path.to_s).to eq source_entry_path
     end
 
     it "#public_root_path returns correct path" do
-      public_root_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public").to_s
+      public_root_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public").to_s
       expect(config.public_path.to_s).to eq public_root_path
     end
 
     it "#public_output_path returns correct path" do
-      public_output_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public/packs").to_s
+      public_output_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs").to_s
       expect(config.public_output_path.to_s).to eq public_output_path
     end
 
     it "#public_manifest_path returns correct path" do
-      public_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public/packs", "manifest.json").to_s
+      public_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s
       expect(config.public_manifest_path.to_s).to eq public_manifest_path
     end
 
     it "#manifest_path returns correct path" do
-      manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public/packs", "manifest.json").to_s
+      manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s
       expect(config.manifest_path.to_s).to eq manifest_path
     end
 
     it "#cache_path returns correct path" do
-      cache_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/tmp/webpacker").to_s
+      cache_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/tmp/webpacker").to_s
       expect(config.cache_path.to_s).to eq cache_path
     end
 
@@ -123,7 +125,8 @@ describe "Webpacker::Configuration" do
 
     describe "#webpacker_precompile?" do
       before :each do
-        ENV["WEBPACKER_PRECOMPILE"] = nil
+        ENV.delete("SHAKAPACKER_PRECOMPILE")
+        ENV.delete("WEBPACKER_PRECOMPILE")
       end
 
       subject { config.webpacker_precompile? }
@@ -177,7 +180,7 @@ describe "Webpacker::Configuration" do
   context "with webpacker config file containing public_output_path entry" do
     config = Webpacker::Configuration.new(
       root_path: ROOT_PATH,
-      config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_public_root.yml", __dir__)),
+      config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_public_root.yml", __dir__)),
       env: "production"
     )
 
@@ -190,12 +193,12 @@ describe "Webpacker::Configuration" do
   context "with webpacker config file containing manifext_path entry" do
     config = Webpacker::Configuration.new(
       root_path: ROOT_PATH,
-      config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_manifest_path.yml", __dir__)),
+      config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_manifest_path.yml", __dir__)),
       env: "production"
     )
 
     it "#manifest_path returns correct expected value" do
-      expected_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs", "manifest.json").to_s
+      expected_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs", "manifest.json").to_s
       expect(config.manifest_path.to_s).to eq expected_manifest_path
     end
   end
@@ -203,13 +206,14 @@ describe "Webpacker::Configuration" do
   context "with webpacker_precompile entry set to false" do
     describe "#webpacker_precompile?" do
       before :each do
-        ENV["WEBPACKER_PRECOMPILE"] = nil
+        ENV.delete("WEBPACKER_PRECOMPILE")
+        ENV.delete("SHAKAPACKER_PRECOMPILE")
       end
 
       let(:config) {
         Webpacker::Configuration.new(
           root_path: ROOT_PATH,
-          config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_no_precompile.yml", __dir__)),
+          config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_no_precompile.yml", __dir__)),
           env: "production"
         )
       }
@@ -225,8 +229,9 @@ describe "Webpacker::Configuration" do
         expect(subject).to be true
       end
 
-      it "returns false with WEBPACKER_PRECOMPILE set to nil" do
-        ENV["WEBPACKER_PRECOMPILE"] = nil
+      it "returns false with WEBPACKER_PRECOMPILE set to falsy value" do
+        # ENV["WEBPACKER_PRECOMPILE"] = "no"
+        ENV.delete("WEBPACKER_PRECOMPILE")
         expect(subject).to be false
       end
     end
@@ -235,7 +240,7 @@ describe "Webpacker::Configuration" do
   context "with webpacker config file containing invalid path" do
     config = Webpacker::Configuration.new(
       root_path: ROOT_PATH,
-      config_path: Pathname.new(File.expand_path("./test_app/config/invalid_path.yml", __dir__)),
+      config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/invalid_path.yml", __dir__)),
       env: "default"
     )
 
@@ -248,7 +253,7 @@ describe "Webpacker::Configuration" do
     let(:config) do
       Webpacker::Configuration.new(
         root_path: ROOT_PATH,
-        config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_defaults_fallback.yml", __dir__)),
+        config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_defaults_fallback.yml", __dir__)),
         env: "default"
       )
     end
@@ -266,7 +271,7 @@ describe "Webpacker::Configuration" do
     let(:config) do
       Webpacker::Configuration.new(
         root_path: ROOT_PATH,
-        config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_defaults_fallback.yml", __dir__)),
+        config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_defaults_fallback.yml", __dir__)),
         env: "staging"
       )
     end

data/spec/{dev_server_runner_spec.rb → backward_compatibility_specs/dev_server_runner_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+# Requiring from webpacker directory to ensure old ./bin/webpacker-dev-server works fine
 require "webpacker/dev_server_runner"
 
 describe "DevServerRunner" do
@@ -13,20 +15,23 @@ describe "DevServerRunner" do
     ENV["WEBPACKER_CONFIG"] = @original_webpacker_config
   end
 
-  let(:test_app_path) { File.expand_path("test_app", __dir__) }
+  let(:test_app_path) { File.expand_path("webpacker_test_app", __dir__) }
 
   it "run cmd via node modules" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
     verify_command(cmd, use_node_modules: true)
   end
+
   it "run cmd via yarn" do
     cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
     verify_command(cmd, use_node_modules: false)
   end
+
   it "run cmd argv" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
     verify_command(cmd, argv: (["--quiet"]))
   end
+
   it "run cmd argv with https" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
 
@@ -41,10 +46,13 @@ describe "DevServerRunner" do
       verify_command(cmd, argv: (["--https"]))
     end.and_return(dev_server)
   end
+
   it "accepts environment variables" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
     env = Webpacker::Compiler.env.dup
-    ENV["WEBPACKER_CONFIG"] = env["WEBPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
+
+    # ENV["WEBPACKER_CONFIG"] is the interface and env["SHAKAPACKER_CONFIG"] is internal
+    ENV["WEBPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
     env["WEBPACK_SERVE"] = "true"
     verify_command(cmd, env: env)
   end

data/spec/{dev_server_spec.rb → backward_compatibility_specs/dev_server_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "DevServer" do
   it "doesn't run by default" do
     expect(Webpacker.dev_server.running?).to be_falsy
@@ -39,7 +41,7 @@ describe "DevServer" do
     end
   end
 
-  it "users WEBPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
-    expect(Webpacker::DevServer::DEFAULT_ENV_PREFIX).to eq "WEBPACKER_DEV_SERVER"
+  it "users SHAKAPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
+    expect(Webpacker::DevServer::DEFAULT_ENV_PREFIX).to eq "SHAKAPACKER_DEV_SERVER"
   end
 end

data/spec/{digest_strategy_spec.rb → backward_compatibility_specs/digest_strategy_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "DigestStrategy" do
   def remove_compilation_digest_path
     @digest_strategy.send(:compilation_digest_path).tap do |path|

data/spec/{engine_rake_tasks_spec.rb → backward_compatibility_specs/engine_rake_tasks_spec.rb}

@@ -1,3 +1,5 @@
+require_relative "spec_helper_initializer"
+
 describe "EngineRakeTasks" do
   before :context do
     remove_webpack_binstubs
@@ -9,38 +11,33 @@ describe "EngineRakeTasks" do
 
   it "mounts app:webpacker task successfully" do
     output = Dir.chdir(mounted_app_path) { `rake -T` }
-    expect(output).to include "app:webpacker"
+    expect(output).to match /app:webpacker.+DEPRECATED/
+    expect(output).to match /app:webpacker:binstubs.+DEPRECATED/
   end
 
   it "binstubs adds only expected files to bin directory" do
-    original_files_in_bin = current_files_in_bin
-
     Dir.chdir(mounted_app_path) { `bundle exec rake app:webpacker:binstubs` }
-    webpack_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
-
-    # and no other files are added
-    expect(current_files_in_bin - webpack_binstub_paths).to match_array original_files_in_bin
+    expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
   end
 
   private
     def mounted_app_path
-      File.expand_path("mounted_app", __dir__)
+      File.expand_path("../mounted_app", __dir__)
     end
 
     def current_files_in_bin
       Dir.glob("#{mounted_app_path}/test/dummy/bin/*")
     end
 
-    def webpack_binstub_paths
-      [
-        "#{mounted_app_path}/test/dummy/bin/yarn",
-        "#{mounted_app_path}/test/dummy/bin/webpacker",
-        "#{mounted_app_path}/test/dummy/bin/webpacker-dev-server",
-      ]
+    def expected_binstub_paths
+      gem_path = File.expand_path("../..", __dir__)
+      Dir.chdir("#{gem_path}/lib/install/bin") do
+        Dir.glob("*").map { |file| "#{mounted_app_path}/test/dummy/bin/#{file}" }
+      end
     end
 
     def remove_webpack_binstubs
-      webpack_binstub_paths.each do |path|
+      expected_binstub_paths.each do |path|
         File.delete(path) if File.exist?(path)
       end
     end

data/spec/{env_spec.rb → backward_compatibility_specs/env_spec.rb}

@@ -1,4 +1,6 @@
-RSpec.describe "Env" do
+require_relative "spec_helper_initializer"
+
+RSpec.describe "Webpacker.env" do
   it "uses the same env for Rails and Webpacker" do
     expect(Webpacker.env).to eq Rails.env
   end