shakapacker 6.5.5 → 6.6.0

data/{test/webpack_runner_test.rb → spec/webpack_runner_spec.rb}

@@ -1,30 +1,29 @@
-require "test_helper"
 require "webpacker/webpack_runner"
 
-class WebpackRunnerTest < Webpacker::Test
-  def setup
+describe "WebpackRunner" do
+  before :all do
     @original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
     @original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
   end
 
-  def teardown
+  after :all do
     ENV["NODE_ENV"] = @original_node_env
     ENV["RAILS_ENV"] = @original_rails_env
   end
 
-  def test_run_cmd_via_node_modules
+  it "runs cmd via node_modules" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
     verify_command(cmd, use_node_modules: true)
   end
 
-  def test_run_cmd_via_yarn
+  it "runs cmd via yarn" do
     cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
     verify_command(cmd, use_node_modules: false)
   end
 
-  def test_run_cmd_argv
+  it "runs cmd argv" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"]
 
     verify_command(cmd, argv: ["--watch"])
@@ -41,16 +40,14 @@ class WebpackRunnerTest < Webpacker::Test
 
       klass = Webpacker::WebpackRunner
       instance = klass.new(argv)
-      mock = Minitest::Mock.new
-      mock.expect(:call, nil, [Webpacker::Compiler.env, *cmd])
 
-      klass.stub(:new, instance) do
-        instance.stub(:node_modules_bin_exist?, use_node_modules) do
-          Kernel.stub(:exec, mock) { klass.run(argv) }
-        end
-      end
+      allow(klass).to receive(:new).and_return(instance)
+      allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
+      allow(Kernel).to receive(:exec)
 
-      mock.verify
+      klass.run(argv)
+
+      expect(Kernel).to have_received(:exec).with(Webpacker::Compiler.env, *cmd)
     ensure
       Dir.chdir(cwd)
     end

data/spec/webpacker_spec.rb

@@ -0,0 +1,61 @@
+describe "Webpacker" do
+  describe "#inline_css?" do
+    let(:dev_server) { instance_double("Webpacker::DevServer") }
+
+    before :each do
+      allow(dev_server).to receive(:host).and_return("localhost")
+      allow(dev_server).to receive(:port).and_return("3035")
+      allow(dev_server).to receive(:pretty?).and_return(false)
+      allow(dev_server).to receive(:https?).and_return(true)
+      allow(dev_server).to receive(:running?).and_return(true)
+    end
+
+    it "returns nil with disabled dev_server" do
+      expect(Webpacker.inlining_css?).to be nil
+    end
+
+    it "returns true with enabled hmr" do
+      allow(dev_server).to receive(:hmr?).and_return(true)
+      allow(dev_server).to receive(:inline_css?).and_return(true)
+
+      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
+
+      expect(Webpacker.inlining_css?).to be true
+    end
+
+    it "returns false with enabled hmr and explicitly setting inline_css to false" do
+      allow(dev_server).to receive(:hmr?).and_return(true)
+      allow(dev_server).to receive(:inline_css?).and_return(false)
+
+      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
+
+      expect(Webpacker.inlining_css?).to be false
+    end
+  end
+
+  describe "configurable config" do
+    before do
+      @original_webpacker_config = ENV["WEBPACKER_CONFIG"]
+    end
+
+    after do
+      ENV["WEBPACKER_CONFIG"] = @original_webpacker_config
+    end
+
+    it "allows config file to be changed based on ENV variable" do
+      ENV.delete("WEBPACKER_CONFIG")
+      Webpacker.instance = nil
+      expect(Webpacker.config.config_path.to_s).to eq(Rails.root.join("config/webpacker.yml").to_s)
+    end
+
+    it "allows config file to be changed based on ENV variable" do
+      ENV["WEBPACKER_CONFIG"] = "/some/random/path.yml"
+      Webpacker.instance = nil
+      expect(Webpacker.config.config_path.to_s).to eq("/some/random/path.yml")
+    end
+  end
+
+  it "has app_autoload_paths cleanup" do
+    expect($test_app_autoload_paths_in_initializer).to eq []
+  end
+end