shakapacker 6.5.4 → 7.0.2

data/spec/backward_compatibility_specs/helper_spec.rb

@@ -0,0 +1,243 @@
+require_relative "spec_helper_initializer"
+
+module ActionView::TestCase::Behavior
+  attr_accessor :request
+
+  describe "Webpacker::Helper" do
+    let(:application_stylesheet_chunks) { %w[/packs/1-c20632e7baf2c81200d3.chunk.css /packs/application-k344a6d59eef8632c9d1.chunk.css] }
+    let(:hello_stimulus_stylesheet_chunks) { %w[/packs/1-c20632e7baf2c81200d3.chunk.css /packs/hello_stimulus-k344a6d59eef8632c9d1.chunk.css] }
+
+    before :each do
+      extend Webpacker::Helper
+      extend ActionView::Helpers
+      extend ActionView::Helpers::AssetTagHelper
+      extend ActionView::TestCase::Behavior
+
+      @request = Class.new do
+        def send_early_hints(links) end
+        def base_url
+          "https://example.com"
+        end
+      end.new
+      @javascript_pack_tag_loaded = nil
+    end
+
+    it "#asset_pack_path generates correct path" do
+      expect(asset_pack_path("bootstrap.js")).to eq "/packs/bootstrap-300631c4f0e0f9c865bc.js"
+      expect(asset_pack_path("bootstrap.css")).to eq "/packs/bootstrap-c38deda30895059837cf.css"
+    end
+
+    it "#asset_pack_url generates correct url" do
+      expect(asset_pack_url("bootstrap.js")).to eq "https://example.com/packs/bootstrap-300631c4f0e0f9c865bc.js"
+      expect(asset_pack_url("bootstrap.css")).to eq "https://example.com/packs/bootstrap-c38deda30895059837cf.css"
+    end
+
+    it "#image_pack_path generates correct path" do
+      expect(image_pack_path("application.png")).to eq "/packs/application-k344a6d59eef8632c9d1.png"
+      expect(image_pack_path("image.jpg")).to eq "/packs/static/image-c38deda30895059837cf.jpg"
+      expect(image_pack_path("static/image.jpg")).to eq "/packs/static/image-c38deda30895059837cf.jpg"
+      expect(image_pack_path("nested/image.jpg")).to eq "/packs/static/nested/image-c38deda30895059837cf.jpg"
+      expect(image_pack_path("static/nested/image.jpg")).to eq "/packs/static/nested/image-c38deda30895059837cf.jpg"
+    end
+
+    it "#image_pack_url generates correct path" do
+      expect(image_pack_url("application.png")).to eq "https://example.com/packs/application-k344a6d59eef8632c9d1.png"
+      expect(image_pack_url("image.jpg")).to eq "https://example.com/packs/static/image-c38deda30895059837cf.jpg"
+      expect(image_pack_url("static/image.jpg")).to eq "https://example.com/packs/static/image-c38deda30895059837cf.jpg"
+      expect(image_pack_url("nested/image.jpg")).to eq "https://example.com/packs/static/nested/image-c38deda30895059837cf.jpg"
+      expect(image_pack_url("static/nested/image.jpg")).to eq "https://example.com/packs/static/nested/image-c38deda30895059837cf.jpg"
+    end
+
+    it "#image_pack_tag generates correct tags" do
+      expect(image_pack_tag("application.png", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/application-k344a6d59eef8632c9d1.png\" width=\"16\" height=\"10\" />"
+      expect(image_pack_tag("image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
+      expect(image_pack_tag("static/image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
+      expect(image_pack_tag("nested/image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
+      expect(image_pack_tag("static/nested/image.jpg", size: "16x10", alt: "Edit Entry")).to eq "<img alt=\"Edit Entry\" src=\"/packs/static/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />"
+      expect(image_pack_tag("static/image.jpg", srcset: { "static/image-2x.jpg" => "2x" })).to eq "<img srcset=\"/packs/static/image-2x-7cca48e6cae66ec07b8e.jpg 2x\" src=\"/packs/static/image-c38deda30895059837cf.jpg\" />"
+    end
+
+    it "#favicon_pack_tag generates correct tags" do
+      expect(favicon_pack_tag("application.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/application-k344a6d59eef8632c9d1.png\" />"
+      expect(favicon_pack_tag("mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/mb-icon-c38deda30895059837cf.png\" />"
+      expect(favicon_pack_tag("static/mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/mb-icon-c38deda30895059837cf.png\" />"
+      expect(favicon_pack_tag("nested/mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/nested/mb-icon-c38deda30895059837cf.png\" />"
+      expect(favicon_pack_tag("static/nested/mb-icon.png", rel: "apple-touch-icon", type: "image/png")).to eq "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/static/nested/mb-icon-c38deda30895059837cf.png\" />"
+    end
+
+    it "#preload_pack_asset generates correct tag" do
+      if self.class.method_defined?(:preload_link_tag)
+        expect(preload_pack_asset("fonts/fa-regular-400.woff2")).to eq %(<link rel="preload" href="/packs/fonts/fa-regular-400-944fb546bd7018b07190a32244f67dc9.woff2" as="font" type="font/woff2" crossorigin="anonymous">)
+      else
+        expect { preload_pack_asset("fonts/fa-regular-400.woff2") }.to raise_error "You need Rails >= 5.2 to use this tag."
+      end
+    end
+
+    it "#javascript_pack_tag generates correct tags" do
+      expected = <<~HTML.chomp
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>
+        <script src="/packs/bootstrap-300631c4f0e0f9c865bc.js" defer="defer"></script>
+      HTML
+
+      expect(javascript_pack_tag("application", "bootstrap")).to eq expected
+    end
+
+    it "#javascript_pack_tag generates correct tags by passing `defer: false`" do
+      expected = <<~HTML.chomp
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js"></script>
+        <script src="/packs/bootstrap-300631c4f0e0f9c865bc.js"></script>
+      HTML
+
+      expect(javascript_pack_tag("application", "bootstrap", defer: false)).to eq expected
+    end
+
+    it "#javascript_pack_tag generates correct appended tag" do
+      append_javascript_pack_tag("bootstrap", defer: false)
+
+      expected = <<~HTML.chomp
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>
+        <script src="/packs/bootstrap-300631c4f0e0f9c865bc.js"></script>
+      HTML
+
+      expect(javascript_pack_tag("application")).to eq expected
+    end
+
+    it "#javascript_pack_tag generates correct prepended tag" do
+      append_javascript_pack_tag("bootstrap")
+      prepend_javascript_pack_tag("main")
+
+      expected = <<~HTML.chomp
+        <script src="/packs/main-e323a53c7f30f5d53cbb.js" defer="defer"></script>
+        <script src="/packs/bootstrap-300631c4f0e0f9c865bc.js" defer="defer"></script>
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>
+      HTML
+
+      expect(javascript_pack_tag("application")).to eq expected
+    end
+
+    it "#append_javascript_pack_tag raises error if called after calling #javascript_pack_tag" do
+      expected_error_message = \
+        "You can only call append_javascript_pack_tag before javascript_pack_tag helper. " +
+        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+
+      expect {
+        javascript_pack_tag("application")
+        append_javascript_pack_tag("bootstrap", defer: false)
+      }.to raise_error(expected_error_message)
+    end
+
+    it "#prepend_javascript_pack_tag raises error if called after calling #javascript_pack_tag" do
+      expected_error_message = \
+        "You can only call prepend_javascript_pack_tag before javascript_pack_tag helper. " +
+        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+
+      expect {
+        javascript_pack_tag("application")
+        prepend_javascript_pack_tag("bootstrap", defer: false)
+      }.to raise_error(expected_error_message)
+    end
+
+    it "#javascript_pack_tag generates correct tags by passing `defer: true`" do
+      expected = <<~HTML.chomp
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>
+      HTML
+
+      expect(javascript_pack_tag("application", defer: true)).to eq expected
+    end
+
+    it "#javascript_pack_tag generates correct tags by passing symbol" do
+      expected = <<~HTML.chomp
+        <script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>
+        <script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>
+        <script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>
+      HTML
+
+      expect(javascript_pack_tag(:application)).to eq expected
+    end
+
+    it "#javascript_pack_tag rases error on multiple invocations" do
+      expected_error_message = "To prevent duplicated chunks on the page, you should call javascript_pack_tag only once on the page. " +
+      "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
+
+      expect {
+        javascript_pack_tag(:application)
+        javascript_pack_tag(:bootstrap)
+      }.to raise_error(expected_error_message)
+    end
+
+    it "#stylesheet_pack_tag generates correct link tag with string arguments" do
+      expected = (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks)
+        .uniq
+        .map { |chunk| stylesheet_link_tag(chunk) }
+        .join("\n")
+
+      expect(stylesheet_pack_tag("application", "hello_stimulus")).to eq expected
+    end
+
+    it "#stylesheet_pack_tag generates correct link tag with symbol arguments" do
+      expected = (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks)
+        .uniq
+        .map { |chunk| stylesheet_link_tag(chunk) }
+        .join("\n")
+
+      expect(stylesheet_pack_tag(:application, :hello_stimulus)).to eq expected
+    end
+
+    it "#stylesheet_pack_tag generates correct link tag with mixed arguments" do
+      expected = (application_stylesheet_chunks)
+        .map { |chunk| stylesheet_link_tag(chunk, media: "all") }
+        .join("\n")
+
+      expect(stylesheet_pack_tag("application", media: "all")).to eq expected
+    end
+
+    it "#stylesheet_pack_tag allows multiple invocations" do
+      app_style = stylesheet_pack_tag(:application)
+      stimulus_style = stylesheet_pack_tag(:hello_stimulus)
+
+      expect(app_style).to eq application_stylesheet_chunks.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
+
+      expect(stimulus_style).to eq hello_stimulus_stylesheet_chunks.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
+
+      expect {
+        stylesheet_pack_tag(:application)
+        stylesheet_pack_tag(:hello_stimulus)
+      }.to_not raise_error
+    end
+
+    it "#stylesheet_pack_tag appends" do
+      append_stylesheet_pack_tag(:hello_stimulus)
+
+      expect(stylesheet_pack_tag(:application)).to eq \
+        (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks).uniq.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
+    end
+
+    it "#stylesheet_pack_tag appends duplicate" do
+      append_stylesheet_pack_tag(:hello_stimulus)
+      append_stylesheet_pack_tag(:application)
+
+      expect(stylesheet_pack_tag(:application)).to eq \
+        (application_stylesheet_chunks + hello_stimulus_stylesheet_chunks).uniq.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
+    end
+
+    it "#stylesheet_pack_tag supports multiple invocations with different media attr" do
+      app_style = stylesheet_pack_tag(:application)
+      app_style_with_media = stylesheet_pack_tag(:application, media: "print")
+      hello_stimulus_style_with_media = stylesheet_pack_tag(:hello_stimulus, media: "all")
+
+      expect(app_style).to eq application_stylesheet_chunks.map { |chunk| stylesheet_link_tag(chunk) }.join("\n")
+      expect(app_style_with_media).to eq application_stylesheet_chunks.map { |chunk| stylesheet_link_tag(chunk, media: "print") }.join("\n")
+      expect(hello_stimulus_style_with_media).to eq hello_stimulus_stylesheet_chunks.map { |chunk| stylesheet_link_tag(chunk, media: "all") }.join("\n")
+    end
+  end
+end

data/spec/backward_compatibility_specs/instance_spec.rb

@@ -0,0 +1,31 @@
+require_relative "spec_helper_initializer"
+
+describe "Webpacker::Instance" do
+  before :each do
+    ENV.delete("WEBPACKER_CONFIG")
+    ENV.delete("SHAKAPACKER_CONFIG")
+    Webpacker.instance = Webpacker::Instance.new
+  end
+
+  after :each do
+    ENV.delete("WEBPACKER_CONFIG")
+    ENV.delete("SHAKAPACKER_CONFIG")
+    Webpacker.instance = Webpacker::Instance.new
+  end
+
+  it "uses default config path if no env variable defined" do
+    actual_config_path = Rails.root.join("config/webpacker.yml")
+    expected_config_path = Webpacker.config.config_path
+
+    expect(expected_config_path).to eq(actual_config_path)
+  end
+
+  it "uses WEBPACKER_CONFIG env variable for config file" do
+    ENV["WEBPACKER_CONFIG"] = "/some/random/path.yml"
+
+    actual_config_path = "/some/random/path.yml"
+    expected_config_path = Webpacker.config.config_path.to_s
+
+    expect(Webpacker.config.config_path.to_s).to eq("/some/random/path.yml")
+  end
+end

data/spec/backward_compatibility_specs/manifest_spec.rb

@@ -0,0 +1,100 @@
+require_relative "spec_helper_initializer"
+
+describe "Webpacker::Manifest" do
+  let(:manifest_path) { File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s }
+
+  it "#lookup! throws exception for a non-existing asset file" do
+    asset_file = "calendar.js"
+    expected_error_message = "Shakapacker can't find #{asset_file} in #{manifest_path}"
+
+    allow(Webpacker.config).to receive(:compile?).and_return(false)
+
+    expect {
+      Webpacker.manifest.lookup!(asset_file)
+    }.to raise_error(Webpacker::Manifest::MissingEntryError, /#{expected_error_message}/)
+  end
+
+  it "#lookup! throws exception for a non-existing asset file with type and without extension" do
+    asset_file = "calendar"
+    expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
+
+    allow(Webpacker.config).to receive(:compile?).and_return(false)
+
+    expect {
+      Webpacker.manifest.lookup!(asset_file, type: :javascript)
+    }.to raise_error(Webpacker::Manifest::MissingEntryError, /#{expected_error_message}/)
+  end
+
+  it "#lookup! returns path to bundled bootstrap.js" do
+    actual = Webpacker.manifest.lookup!("bootstrap.js")
+    expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup_pack_with_chunks! returns array of path to bundled bootstrap with type of javascript" do
+    actual = Webpacker.manifest.lookup_pack_with_chunks!("bootstrap", type: :javascript)
+    expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup_with_chunks! returns array of path to bundled bootstrap.js with type of javascript" do
+    actual = Webpacker.manifest.lookup_pack_with_chunks!("bootstrap.js", type: :javascript)
+    expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup_with_chunks! returns array of path to bundled 'print/application' without extension and in a sub-directory" do
+    actual = Webpacker.manifest.lookup_pack_with_chunks!("print/application", type: :css)
+    expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup_with_chunks! returns array of path to bundled 'print/application.css' in a sub-directory" do
+    actual = Webpacker.manifest.lookup_pack_with_chunks!("print/application.css", type: :css)
+    expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup returns nil for non-existing asset file" do
+    expect(Webpacker.manifest.lookup("foo.js")).to be nil
+  end
+
+  it "#lookup_pack_with_chunks returns nil for non-existing asset file" do
+    expect(Webpacker.manifest.lookup_pack_with_chunks("foo.js")).to be nil
+  end
+
+  it "#lookup returns path for bootstrap.js" do
+    actual = Webpacker.manifest.lookup("bootstrap.js")
+    expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
+
+    expect(actual).to eq expected
+  end
+
+  it "#lookup_pack_with_chunks! throws exception for a non-existing asset file" do
+    asset_file = "calendar"
+
+    expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
+
+    allow(Webpacker.config).to receive(:compile?).and_return(false)
+
+    expect {
+      Webpacker.manifest.lookup_pack_with_chunks!(asset_file, type: :javascript)
+    }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
+  end
+
+  it "#lookup_pack_with_chunks! returns array of paths to bundled js files with 'application' in their name" do
+    actual_application_entrypoints = Webpacker.manifest.lookup_pack_with_chunks!("application", type: :javascript)
+    expected_application_entrypoints = [
+      "/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js",
+      "/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js",
+      "/packs/application-k344a6d59eef8632c9d1.js"
+    ]
+
+    expect(actual_application_entrypoints).to eq expected_application_entrypoints
+  end
+end

data/spec/backward_compatibility_specs/mtime_strategy_spec.rb

@@ -0,0 +1,55 @@
+require_relative "spec_helper_initializer"
+
+describe "Webpacker::MtimeStrategy" do
+  let(:mtime_strategy) { Webpacker::MtimeStrategy.new }
+  let(:manifest_timestamp) { Time.parse("2021-01-01 12:34:56 UTC") }
+
+  describe "#fresh?" do
+    it "returns false when manifest is missing" do
+      latest_timestamp = manifest_timestamp + 3600
+
+      with_stubs(latest_timestamp: latest_timestamp.to_i, manifest_exists: false) do
+        expect(mtime_strategy.fresh?).to be false
+      end
+    end
+
+    it "returns false when manifest is older" do
+      latest_timestamp = manifest_timestamp + 3600
+
+      with_stubs(latest_timestamp: latest_timestamp.to_i) do
+        expect(mtime_strategy.fresh?).to be false
+      end
+    end
+
+    it "returns true when manifest is new" do
+      latest_timestamp = manifest_timestamp - 3600
+
+      with_stubs(latest_timestamp: latest_timestamp.to_i) do
+        expect(mtime_strategy.fresh?).to be true
+      end
+    end
+  end
+
+  describe "#stale?" do
+    it "returns false when #fresh? is true" do
+      expect(mtime_strategy).to receive(:fresh?).and_return(true)
+
+      expect(mtime_strategy.stale?).to be false
+    end
+
+    it "returns true when #fresh? is false" do
+      expect(mtime_strategy).to receive(:fresh?).and_return(false)
+
+      expect(mtime_strategy.stale?).to be true
+    end
+  end
+
+  private
+
+    def with_stubs(latest_timestamp:, manifest_exists: true)
+      allow(mtime_strategy).to receive(:latest_modified_timestamp).and_return(latest_timestamp)
+      allow(FileTest).to receive(:exist?).and_return(manifest_exists)
+      allow(File).to receive(:mtime).and_return(manifest_timestamp)
+      yield
+    end
+end

data/spec/backward_compatibility_specs/rake_tasks_spec.rb

@@ -0,0 +1,37 @@
+require_relative "spec_helper_initializer"
+
+describe "RakeTasks" do
+  let(:test_app_path) { File.expand_path("webpacker_test_app", __dir__) }
+
+  it "`rake -T` lists Webpacker tasks" do
+    output = Dir.chdir(test_app_path) { `rake -T` }
+    expect(output).to match /webpacker .+DEPRECATED/
+    expect(output).to match /webpacker:check_binstubs.+DEPRECATED/
+    expect(output).to match /webpacker:check_node.+DEPRECATED/
+    expect(output).to match /webpacker:check_yarn.+DEPRECATED/
+    expect(output).to match /webpacker:clean.+DEPRECATED/
+    expect(output).to match /webpacker:clobber.+DEPRECATED/
+    expect(output).to match /webpacker:compile.+DEPRECATED/
+    expect(output).to match /webpacker:install.+DEPRECATED/
+    expect(output).to match /webpacker:verify_install.+DEPRECATED/
+  end
+
+  it "`webpacker:check_binstubs` doesn't get 'webpack binstub not found' error" do
+    output = Dir.chdir(test_app_path) { `rake webpacker:check_binstubs 2>&1` }
+    expect(output).to_not include "webpack binstub not found."
+    expect(output).to include "DEPRECATION"
+  end
+
+  it "`webpacker:check_node` doesn't get 'webpacker requires Node.js' error" do
+    output = Dir.chdir(test_app_path) { `rake webpacker:check_node 2>&1` }
+    expect(output).to_not include "Shakapacker requires Node.js"
+    expect(output).to include "DEPRECATION"
+  end
+
+  it "`webpacker:check_yarn` doesn't get error related to yarn" do
+    output = Dir.chdir(test_app_path) { `rake webpacker:check_yarn 2>&1` }
+    expect(output).to_not include "Yarn not installed"
+    expect(output).to_not include "Shakapacker requires Yarn"
+    expect(output).to include "DEPRECATION"
+  end
+end

data/spec/backward_compatibility_specs/spec_helper_initializer.rb

@@ -0,0 +1,24 @@
+require_relative "webpacker_test_app/config/environment"
+
+Rails.env = "production"
+
+Webpacker.instance = ::Webpacker::Instance.new
+
+def reloaded_config
+  Webpacker.instance.instance_variable_set(:@env, nil)
+  Webpacker.instance.instance_variable_set(:@config, nil)
+  Webpacker.instance.instance_variable_set(:@dev_server, nil)
+  Webpacker.env
+  Webpacker.config
+  Webpacker.dev_server
+end
+
+def with_rails_env(env)
+  original = Rails.env
+  Rails.env = ActiveSupport::StringInquirer.new(env)
+  reloaded_config
+  yield
+ensure
+  Rails.env = ActiveSupport::StringInquirer.new(original)
+  reloaded_config
+end

data/{test/webpack_runner_test.rb → spec/backward_compatibility_specs/webpack_runner_spec.rb}

@@ -1,30 +1,31 @@
-require "test_helper"
+require_relative "spec_helper_initializer"
+# Requiring from webpacker directory to ensure old ./bin/webpacker-dev-server works fine
 require "webpacker/webpack_runner"
 
-class WebpackRunnerTest < Webpacker::Test
-  def setup
+describe "WebpackRunner" do
+  before :all do
     @original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
     @original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
   end
 
-  def teardown
+  after :all do
     ENV["NODE_ENV"] = @original_node_env
     ENV["RAILS_ENV"] = @original_rails_env
   end
 
-  def test_run_cmd_via_node_modules
+  it "runs cmd via node_modules" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
     verify_command(cmd, use_node_modules: true)
   end
 
-  def test_run_cmd_via_yarn
+  it "runs cmd via yarn" do
     cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
 
     verify_command(cmd, use_node_modules: false)
   end
 
-  def test_run_cmd_argv
+  it "runs cmd argv" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"]
 
     verify_command(cmd, argv: ["--watch"])
@@ -32,7 +33,7 @@ class WebpackRunnerTest < Webpacker::Test
 
   private
     def test_app_path
-      File.expand_path("test_app", __dir__)
+      File.expand_path("webpacker_test_app", __dir__)
     end
 
     def verify_command(cmd, use_node_modules: true, argv: [])
@@ -41,16 +42,14 @@ class WebpackRunnerTest < Webpacker::Test
 
       klass = Webpacker::WebpackRunner
       instance = klass.new(argv)
-      mock = Minitest::Mock.new
-      mock.expect(:call, nil, [Webpacker::Compiler.env, *cmd])
 
-      klass.stub(:new, instance) do
-        instance.stub(:node_modules_bin_exist?, use_node_modules) do
-          Kernel.stub(:exec, mock) { klass.run(argv) }
-        end
-      end
+      allow(klass).to receive(:new).and_return(instance)
+      allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
+      allow(Kernel).to receive(:exec)
 
-      mock.verify
+      klass.run(argv)
+
+      expect(Kernel).to have_received(:exec).with(Webpacker::Compiler.env, *cmd)
     ensure
       Dir.chdir(cwd)
     end

data/spec/backward_compatibility_specs/webpacker_spec.rb

@@ -0,0 +1,41 @@
+require_relative "spec_helper_initializer"
+
+describe "webpacker" do
+  describe "#inline_css?" do
+    let(:dev_server) { instance_double("Webpacker::DevServer") }
+
+    before :each do
+      allow(dev_server).to receive(:host).and_return("localhost")
+      allow(dev_server).to receive(:port).and_return("3035")
+      allow(dev_server).to receive(:pretty?).and_return(false)
+      allow(dev_server).to receive(:https?).and_return(true)
+      allow(dev_server).to receive(:running?).and_return(true)
+    end
+
+    it "returns nil with disabled dev_server" do
+      expect(Webpacker.inlining_css?).to be nil
+    end
+
+    it "returns true with enabled hmr" do
+      allow(dev_server).to receive(:hmr?).and_return(true)
+      allow(dev_server).to receive(:inline_css?).and_return(true)
+
+      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
+
+      expect(Webpacker.inlining_css?).to be true
+    end
+
+    it "returns false with enabled hmr and explicitly setting inline_css to false" do
+      allow(dev_server).to receive(:hmr?).and_return(true)
+      allow(dev_server).to receive(:inline_css?).and_return(false)
+
+      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
+
+      expect(Webpacker.inlining_css?).to be false
+    end
+  end
+
+  it "has app_autoload_paths cleanup" do
+    expect($test_app_autoload_paths_in_initializer).to eq []
+  end
+end

data/spec/backward_compatibility_specs/webpacker_test_app/.gitignore

@@ -0,0 +1,2 @@
+log/
+tmp/

data/{test/test_app → spec/backward_compatibility_specs/webpacker_test_app}/app/packs/entrypoints/application.js

@@ -7,4 +7,4 @@
 // To reference this file, add <%= javascript_pack_tag 'application' %> to the appropriate
 // layout file, like app/views/layouts/application.html.erb
 
-console.log('Hello World from Webpacker')
+console.log('Hello World from shakapacker')

data/spec/backward_compatibility_specs/webpacker_test_app/config/application.rb

@@ -0,0 +1,11 @@
+require "action_controller/railtie"
+require "action_view/railtie"
+require "shakapacker"
+
+module WebpackerTestApp
+  class Application < ::Rails::Application
+    config.secret_key_base = "abcdef"
+    config.eager_load = true
+    config.active_support.test_order = :sorted
+  end
+end

data/{test/test_app → spec/backward_compatibility_specs/webpacker_test_app}/config/webpacker.yml

@@ -1,4 +1,4 @@
-# Note: You must restart bin/webpacker-dev-server for changes to take effect
+# Note: You must restart bin/shakapacker-dev-server for changes to take effect
 
 default: &default
   source_path: app/packs

data/{test/test_app → spec/backward_compatibility_specs/webpacker_test_app}/config/webpacker_css_extract_ignore_order_warnings.yml

@@ -1,4 +1,4 @@
-# Note: You must restart bin/webpacker-dev-server for changes to take effect
+# Note: You must restart bin/shakapacker-dev-server for changes to take effect
 
 default: &default
   source_path: app/packs

data/{test/test_app → spec/backward_compatibility_specs/webpacker_test_app}/config/webpacker_defaults_fallback.yml

@@ -1,4 +1,4 @@
-# Note: You must restart bin/webpacker-dev-server for changes to take effect
+# Note: You must restart bin/shakapacker-dev-server for changes to take effect
 
 default: &default
   # cache_manifest will be fetched from bundled defaults