shakapacker 6.5.2 → 6.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04b356abe12d2beb26692d9b9edc2b491a4d9e698ecab73b06e700e51d049733
-  data.tar.gz: 2e6c8f79c48ff1602e303d43293fc1d66413121e687538a6e7ac32fecc72518a
+  metadata.gz: 57e24ac7fbe67a903f0a5f0d6725544b37b2c8a1bae324cd487642e69a525b8d
+  data.tar.gz: 704a88906fec3e37ec10b2b5cce8fd3ea8ad2c1a556e5badc89aef887d7c02cc
 SHA512:
-  metadata.gz: ba8b18d95721f62d512dc330681b17fa650b3d292ce3afc51c37261a22bfbde8c9aec7db5763cc2d5b959d1c2948aaf72fcf2dcefbe6e75a90a7b1fdd4da6fa8
-  data.tar.gz: 5edd7194484e7c68310ac01700e2bce920f100ca2b4ad83975686da6af86cf4ac3c9c811a1eedf17c121d4c7285954a0ba3ca4e32a9da6b6ac253d85de9007d3
+  metadata.gz: 918d57502a80582726426833b6a6a57848ab771c9d7acb1d2ab5748b3d5407a4ee44c6ece9849ee2db2879d3329761577678377aaccc1f67ce6a6fd72f3d5e38
+  data.tar.gz: ac9f9397b1922969a360d8c8963a3ba298eea656ae5eca1925ed419788fa40ae3d3f17d2cc8ddacb459c23cadfe2ba67cbf7827b8b9e499f52e59694cf59253f

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -11,7 +11,7 @@ A bug is a crash or incorrect behavior. If you have a debugging or troubleshooti
 
 Ruby version:
 Rails version:
-Webpacker version:
+Shakapacker version:
 
 Expected behavior:
 

data/.github/ISSUE_TEMPLATE/feature-request.md

@@ -11,7 +11,7 @@ A feature request describes a suggested improvement. If you have a debugging or
 
 Ruby version:
 Rails version:
-Webpacker version:
+Shakapacker version:
 
 Desired behavior:
 

data/CHANGELOG.md

@@ -1,6 +1,6 @@
 * For the changelog of versions prior to v6, see the [5.x stable branch of rails/webpacker](https://github.com/rails/webpacker/tree/5-x-stable).
 * Please see the [v6 Upgrade Guide](./docs/v6_upgrade.md) to go from versions prior to v6.
-* [ShakaCode](https://www.shakacode.com) offers support for upgrading from webpacker or using Shakapacker. If interested, contact Justin Gordon, [justin@shakacode.com](mailto:justin@shakacode.com).
+* [ShakaCode](https://www.shakacode.com) offers support for upgrading from Webpacker or using Shakapacker. If interested, contact Justin Gordon, [justin@shakacode.com](mailto:justin@shakacode.com).
 
 ## Versions
 ## [Unreleased]
@@ -8,6 +8,17 @@ Changes since last non-beta release.
 
 _Please add entries here for your pull requests that are not yet released._
 
+## [v6.5.4] - November 4, 2022
+### Fixed
+- Fixed regression caused by 6.5.3. PR #192 introduce extra split() call. [PR 202](https://github.com/shakacode/shakapacker/pull/202) by [Eric-Guo](https://github.com/Eric-Guo).
+
+## [v6.5.3] - November 1, 2022
+
+### Improved
+- Set RAILS_ENV and BUNDLE_GEMFILE env values before requiring `bundler/setup`, `webpacker`, and `webpacker/webpack_runner`. [PR 190](https://github.com/shakacode/shakapacker/pull/190) by [betmenslido](https://github.com/betmenslido).
+- The `mini-css-extract-plugin` may cause various warnings indicating CSS order conflicts when using a [File-System-based automated bundle generation feature](https://www.shakacode.com/react-on-rails/docs/guides/file-system-based-automated-bundle-generation/).
+CSS order warnings can be disabled in projects where CSS ordering has been mitigated by consistent use of scoping or naming conventions. Added `css_extract_ignore_order_warnings` flag to webpacker configuration to disable the order warnings by [pulkitkkr](https://github.com/shakacode/shakapacker/pull/185) in [PR 192](https://github.com/shakacode/shakapacker/pull/192).
+
 ## [v6.5.2] - September 8, 2022
 
 ### Upgrade
@@ -175,7 +186,9 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions
 ## v5.4.3 and prior changes from rails/webpacker
 See [CHANGELOG.md in rails/webpacker (up to v5.4.3)](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
 
-[Unreleased]: https://github.com/shakacode/shakapacker/compare/v6.5.2...master
+[Unreleased]: https://github.com/shakacode/shakapacker/compare/v6.5.4...master
+[v6.5.4]: https://github.com/shakacode/shakapacker/compare/v6.5.3...v6.5.4
+[v6.5.3]: https://github.com/shakacode/shakapacker/compare/v6.5.2...v6.5.3
 [v6.5.2]: https://github.com/shakacode/shakapacker/compare/v6.5.1...v6.5.2
 [v6.5.1]: https://github.com/shakacode/shakapacker/compare/v6.5.0...v6.5.1
 [v6.5.0]: https://github.com/shakacode/shakapacker/compare/v6.4.1...v6.5.0

data/lib/install/bin/webpacker

@@ -1,13 +1,12 @@
 #!/usr/bin/env ruby
 
-require "pathname"
+ENV["RAILS_ENV"] ||= "development"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
+
 require "bundler/setup"
 require "webpacker"
 require "webpacker/webpack_runner"
 
-ENV["RAILS_ENV"] ||= "development"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", Pathname.new(__FILE__).realpath)
-
 APP_ROOT = File.expand_path("..", __dir__)
 Dir.chdir(APP_ROOT) do
   Webpacker::WebpackRunner.run(ARGV)

data/lib/install/bin/webpacker-dev-server

@@ -1,13 +1,9 @@
 #!/usr/bin/env ruby
 
 ENV["RAILS_ENV"] ||= "development"
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
 
 require "bundler/setup"
-
 require "webpacker"
 require "webpacker/dev_server_runner"
 

data/lib/install/config/webpacker.yml

@@ -11,6 +11,12 @@ default: &default
   # You cannot set this option to true if you set source_entry_path to '/'
   nested_entries: false
 
+  #  While using a File-System-based automated bundle generation feature, miscellaneous warnings suggesting css order
+  #  conflicts may arise due to the mini-css-extract-plugin. For projects where css ordering has been mitigated through
+  #  consistent use of scoping or naming conventions, the css order warnings can be disabled by setting
+  #  css_extract_ignore_order_warnings to true
+  css_extract_ignore_order_warnings: false
+
   public_root_path: public
   public_output_path: packs
   cache_path: tmp/webpacker

data/lib/webpacker/version.rb

@@ -1,4 +1,4 @@
 module Webpacker
   # Change the version in package.json too, please!
-  VERSION = "6.5.2".freeze
+  VERSION = "6.5.4".freeze
 end

data/package/environments/__tests__/base.js

@@ -24,6 +24,17 @@ describe('Base config', () => {
       )
     })
 
+    test('should return false for css_extract_ignore_order_warnings when using default config', () => {
+      expect(config.css_extract_ignore_order_warnings).toEqual(false)
+    })
+
+    test('should return true for css_extract_ignore_order_warnings when configured', () => {
+      process.env.WEBPACKER_CONFIG = 'config/webpacker_css_extract_ignore_order_warnings.yml'
+      const config = require("../../config");
+
+      expect(config.css_extract_ignore_order_warnings).toEqual(true)
+    })
+
     test('should return only 2 entry points with config.nested_entries == false', () => {
       expect(config.nested_entries).toEqual(false)
 

data/package/environments/base.js

@@ -73,7 +73,11 @@ const getPlugins = () => {
     plugins.push(
       new MiniCssExtractPlugin({
         filename: `css/[name]${hash}.css`,
-        chunkFilename: `css/[id]${hash}.css`
+        chunkFilename: `css/[id]${hash}.css`,
+        // For projects where css ordering has been mitigated through consistent use of scoping or naming conventions,
+        // the css order warnings can be disabled by setting the ignoreOrder flag.
+        // Read: https://stackoverflow.com/questions/51971857/mini-css-extract-plugin-warning-in-chunk-chunkname-mini-css-extract-plugin-con
+        ignoreOrder: config.css_extract_ignore_order_warnings
       })
     )
   }

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "6.5.2",
+  "version": "6.5.4",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
   "files": [

data/test/test_app/config/webpacker_css_extract_ignore_order_warnings.yml

@@ -0,0 +1,84 @@
+# Note: You must restart bin/webpacker-dev-server for changes to take effect
+
+default: &default
+  source_path: app/packs
+  source_entry_path: entrypoints
+  nested_entries: true
+  public_root_path: public
+  public_output_path: packs
+  cache_path: tmp/webpacker
+  webpack_compile_output: false
+  webpack_loader: babel
+  css_extract_ignore_order_warnings: true
+
+  # Location for manifest.json, defaults to {public_output_path}/manifest.json if unset
+  # manifest_path: public/packs/manifest.json
+
+  # Additional paths webpack should look up modules
+  # ['app/assets', 'engine/foo/app/assets']
+  additional_paths:
+    - app/assets
+    - /etc/yarn
+    - some.config.js
+    - app/elm
+
+  # Reload manifest.json on all requests so we reload latest compiled packs
+  cache_manifest: false
+
+  static_assets_extensions:
+    - .jpg
+    - .jpeg
+    - .png
+    - .gif
+    - .tiff
+    - .ico
+    - .svg
+
+  extensions:
+    - .mjs
+    - .js
+
+development:
+  <<: *default
+  compile: true
+  ensure_consistent_versioning: true
+
+  # Reference: https://webpack.js.org/configuration/dev-server/
+  dev_server:
+    https: false
+    host: localhost
+    port: 3035
+    public: localhost:3035
+    hmr: false
+    overlay: true
+    disable_host_check: true
+    use_local_ip: false
+    pretty: false
+
+test:
+  <<: *default
+  compile: true
+
+  # Compile test packs to a separate directory
+  public_output_path: packs-test
+
+production:
+  <<: *default
+
+  # Production depends on precompilation of packs prior to booting for performance.
+  compile: false
+
+  # Cache manifest.json for performance
+  cache_manifest: true
+
+staging:
+  <<: *default
+
+  # Production depends on precompilation of packs prior to booting for performance.
+  compile: false
+
+  # Cache manifest.json for performance
+  cache_manifest: true
+
+  # Compile staging packs to a separate directory
+  public_output_path: packs-staging

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 6.5.2
+  version: 6.5.4
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-08 00:00:00.000000000 Z
+date: 2022-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -316,6 +316,7 @@ files:
 - test/test_app/config/initializers/inspect_autoload_paths.rb
 - test/test_app/config/webpack/webpack.config.js
 - test/test_app/config/webpacker.yml
+- test/test_app/config/webpacker_css_extract_ignore_order_warnings.yml
 - test/test_app/config/webpacker_defaults_fallback.yml
 - test/test_app/config/webpacker_manifest_path.yml
 - test/test_app/config/webpacker_nested_entries.yml
@@ -336,7 +337,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v6.5.2
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v6.5.4
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -432,6 +433,7 @@ test_files:
 - test/test_app/config/initializers/inspect_autoload_paths.rb
 - test/test_app/config/webpack/webpack.config.js
 - test/test_app/config/webpacker.yml
+- test/test_app/config/webpacker_css_extract_ignore_order_warnings.yml
 - test/test_app/config/webpacker_defaults_fallback.yml
 - test/test_app/config/webpacker_manifest_path.yml
 - test/test_app/config/webpacker_nested_entries.yml