shakapacker 6.2.0 → 6.3.0

data/test/helper_test.rb

@@ -115,6 +115,28 @@ class HelperTest < ActionView::TestCase
       javascript_pack_tag("application", "bootstrap", defer: false)
   end
 
+  def test_javascript_pack_with_append
+    append_javascript_pack_tag("bootstrap", defer: false)
+    assert_equal \
+      %(<script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>\n) +
+        %(<script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js" defer="defer"></script>\n) +
+        %(<script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>\n) +
+        %(<script src="/packs/bootstrap-300631c4f0e0f9c865bc.js"></script>),
+      javascript_pack_tag("application")
+  end
+
+  def test_append_javascript_pack_tag_raises
+    error = assert_raises do
+      javascript_pack_tag("application")
+      append_javascript_pack_tag("bootstrap", defer: false)
+    end
+
+    assert_equal \
+      "You can only call append_javascript_pack_tag before javascript_pack_tag helper. " +
+        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#usage for the usage guide",
+      error.message
+  end
+
   def test_javascript_pack_tag_splat
     assert_equal \
       %(<script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js" defer="defer"></script>\n) +

data/test/manifest_test.rb

@@ -8,7 +8,7 @@ class ManifestTest < Minitest::Test
       Webpacker.manifest.lookup!(asset_file)
     end
 
-    assert_match "Webpacker can't find #{asset_file} in #{manifest_path}", error.message
+    assert_match "Shakapacker can't find #{asset_file} in #{manifest_path}", error.message
   end
 
   def test_lookup_with_type_exception!
@@ -18,7 +18,7 @@ class ManifestTest < Minitest::Test
       Webpacker.manifest.lookup!(asset_file, type: :javascript)
     end
 
-    assert_match "Webpacker can't find #{asset_file}.js in #{manifest_path}", error.message
+    assert_match "Shakapacker can't find #{asset_file}.js in #{manifest_path}", error.message
   end
 
   def test_lookup_success!
@@ -60,7 +60,7 @@ class ManifestTest < Minitest::Test
       Webpacker.manifest.lookup_pack_with_chunks!(asset_file, type: :javascript)
     end
 
-    assert_match "Webpacker can't find #{asset_file}.js in #{manifest_path}", error.message
+    assert_match "Shakapacker can't find #{asset_file}.js in #{manifest_path}", error.message
   end
 
   def test_lookup_entrypoint

data/test/mtime_strategy_test.rb

@@ -0,0 +1,42 @@
+require "test_helper"
+
+class MtimeStrategyTest < Minitest::Test
+  def setup
+    @mtime_strategy = Webpacker::MtimeStrategy.new
+    @manifest_timestamp = Time.parse("2021-01-01 12:34:56 UTC")
+  end
+
+  def with_stubs(latest_timestamp:, manifest_exists: true)
+    @mtime_strategy.stub :latest_modified_timestamp, latest_timestamp do
+      FileTest.stub :exist?, manifest_exists do
+        File.stub :mtime, @manifest_timestamp do
+          yield
+        end
+      end
+    end
+  end
+
+  def test_freshness_when_manifest_missing
+    latest_timestamp = @manifest_timestamp + 3600
+
+    with_stubs(latest_timestamp: latest_timestamp.to_i, manifest_exists: false) do
+      assert @mtime_strategy.stale?
+    end
+  end
+
+  def test_freshness_when_manifest_older
+    latest_timestamp = @manifest_timestamp + 3600
+
+    with_stubs(latest_timestamp: latest_timestamp.to_i) do
+      assert @mtime_strategy.stale?
+    end
+  end
+
+  def test_freshness_when_manifest_newer
+    latest_timestamp = @manifest_timestamp - 3600
+
+    with_stubs(latest_timestamp: latest_timestamp.to_i) do
+      assert @mtime_strategy.fresh?
+    end
+  end
+end

data/test/test_app/config/webpacker_no_precompile.yml

@@ -0,0 +1,7 @@
+# Note: You must restart bin/webpacker-dev-server for changes to take effect
+
+default: &default
+  webpacker_precompile: false
+
+production:
+  <<: *default