shakapacker 10.2.0 → 10.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 441942bb193dab20df1d0956197e3d441adb6fef5e25001a4eb1f05c69543312
-  data.tar.gz: 4aea05e5fa5f72da3b65fd108514400ca6c7140c85cdf7d10aa1d6edf6118d43
+  metadata.gz: 9066233e8c71edd7018db4b397e132013a8dcde79a111acbd6f3a79617fa9367
+  data.tar.gz: 1e7d899486f7bf0c43cebb923ba4a013bd5bdb7e4348193662872a5b77278208
 SHA512:
-  metadata.gz: a2d3907c1a2d5121c7b70f72cb46c8ea09157e263241803b67ce2d250f7183121442bc0e0b6387d1552008565a3802e5a57c6447f4f6bee0d3e3f9214f16786f
-  data.tar.gz: 3b59158ac878b1403defdc3a22293a2559bb99d13c106175d2c72d637596ad4dfbdd5174aea80222070f50ee911bb7e585a1cae830886bb75be9f942f310e6ed
+  metadata.gz: 6becce7cfd7598aeb8b6cb734882e0dbd6668125e61c711608d81e242724c8b27d613efdf5cecff77e737ca46d8f8c5c727938c5bbb13551f3394f7149d495a0
+  data.tar.gz: f56d65242942ce8ce7b372af52b28a7a62dd6ce47c7fce5b4268bd638d22691276166796620179682b0b61ad2cc4028d951219d208652f84a99cb60bf0d8757a

data/CHANGELOG.md

@@ -1,4 +1,5 @@
 - For the changelog of versions prior to v6, see the [5.x stable branch of rails/webpacker](https://github.com/rails/webpacker/tree/5-x-stable).
+- **Please see the [v10 Upgrade Guide](./docs/v10_upgrade.md) for upgrading to version 10 and accounting for breaking changes.**
 - **Please see the [v9 Upgrade Guide](./docs/v9_upgrade.md) for upgrading to version 9 and accounting for breaking changes.**
 - Please see the [v8 Upgrade Guide](./docs/v8_upgrade.md) for upgrading to version 8 and accounting for breaking changes.
 - Please see the [v7 Upgrade Guide](./docs/v7_upgrade.md) for upgrading to new spelling in version 7.
@@ -9,6 +10,18 @@
 
 ## [Unreleased]
 
+## [v10.3.0] - July 5, 2026
+
+### Added
+
+- **Allowed `webpack-dev-server` v6**. [PR #1102](https://github.com/shakacode/shakapacker/pull/1102) by [G-Rath](https://github.com/G-Rath).
+
+### Fixed
+
+- **Fixed implicit SWC defaults for existing webpack/Babel apps without `swc-loader`.** [PR #1206](https://github.com/shakacode/shakapacker/pull/1206) by [justin808](https://github.com/justin808). Webpack apps that omit both `javascript_transpiler` and the deprecated `webpack_loader` now fall back to Babel with a warning when Shakapacker's bundled SWC default is active, `swc-loader` is missing, and Babel is present. Explicit transpiler settings, webpack apps with `swc-loader`, and Rspack's built-in SWC path keep their existing behavior. Closes [#1203](https://github.com/shakacode/shakapacker/issues/1203).
+- **Fixed JavaScript config loading for missing Rails environments to use the production fallback.** [PR #1206](https://github.com/shakacode/shakapacker/pull/1206) by [justin808](https://github.com/justin808). When `RAILS_ENV` has no matching section in `config/shakapacker.yml`, the Node package config now merges the `production` section instead of only bundled defaults, matching Ruby configuration loading and honoring explicit production `javascript_transpiler`, `source_path`, `dev_server`, and related settings for custom environments such as staging.
+- **Fixed helper binstubs delegating Node resolution to Ruby `exec` in unset and empty `PATH` environments.** [PR #1200](https://github.com/shakacode/shakapacker/pull/1200) and [PR #1201](https://github.com/shakacode/shakapacker/pull/1201) by [justin808](https://github.com/justin808). Restores shell-compatible Node lookup for `bin/shakapacker-config` and `bin/diff-bundler-config` after the `v10.2.0` Ruby-binstub regression, while keeping friendly missing-Node errors for `ENOENT` and `EACCES`.
+
 ## [v10.2.0] - July 3, 2026
 
 ### Added
@@ -973,7 +986,8 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions
 
 See [CHANGELOG.md in rails/webpacker (up to v5.4.3)](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
 
-[Unreleased]: https://github.com/shakacode/shakapacker/compare/v10.2.0...main
+[Unreleased]: https://github.com/shakacode/shakapacker/compare/v10.3.0...main
+[v10.3.0]: https://github.com/shakacode/shakapacker/compare/v10.2.0...v10.3.0
 [v10.2.0]: https://github.com/shakacode/shakapacker/compare/v10.1.0...v10.2.0
 [v10.1.0]: https://github.com/shakacode/shakapacker/compare/v10.0.0...v10.1.0
 [v10.0.0]: https://github.com/shakacode/shakapacker/compare/v9.7.0...v10.0.0

data/README.md

@@ -114,7 +114,8 @@ and release-to-release upgrade paths.
 
 Older major-version docs:
 
-- [v10.0.0 release notes](https://github.com/shakacode/shakapacker/releases/tag/v10.0.0)
+- [v10 upgrade guide](https://github.com/shakacode/shakapacker/blob/main/docs/v10_upgrade.md)
+  ([docs site](https://shakapacker.com/docs/v10_upgrade/))
 - [v9 upgrade guide](https://shakapacker.com/docs/v9_upgrade/)
 - [v8 upgrade guide](https://shakapacker.com/docs/v8_upgrade/)
 - [v7 upgrade guide](https://shakapacker.com/docs/v7_upgrade/)

data/lib/install/bin/diff-bundler-config

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "rbconfig"
 require "yaml"
 
 # This binstub is managed by Shakapacker. Delete it and rerun the install or init command to regenerate it.
@@ -14,36 +13,39 @@ def shakapacker_app_root
   Dir.pwd
 end
 
-def shakapacker_executable_candidates(executable)
-  extensions = [
-    RbConfig::CONFIG["EXEEXT"],
-    *ENV.fetch("PATHEXT", "").split(File::PATH_SEPARATOR)
-  ].compact.reject(&:empty?)
-  return [executable] if extensions.empty? || File.extname(executable) != ""
+def shakapacker_node_binary
+  "node"
+end
 
-  ([executable] + extensions.map { |extension| "#{executable}#{extension}" }).uniq
+def shakapacker_warn_missing_node
+  warn '[Shakapacker] Could not find Node.js executable "node". ' \
+       "Install Node.js and try again."
+  exit 1
 end
 
-def shakapacker_find_executable(executable)
-  ENV.fetch("PATH", "").split(File::PATH_SEPARATOR, -1).each do |path|
-    search_path = path.empty? ? Dir.pwd : path
+def shakapacker_exec_env(launch_dir)
+  return {} unless ENV.key?("PATH")
 
-    shakapacker_executable_candidates(executable).each do |candidate|
-      executable_path = File.join(search_path, candidate)
-      return executable_path if File.file?(executable_path) && File.executable?(executable_path)
-    end
-  end
+  path_entries = ENV["PATH"].split(File::PATH_SEPARATOR, -1)
+  path_entries = [""] if path_entries.empty?
 
-  nil
+  normalized_path = path_entries.map do |entry|
+    entry.empty? ? launch_dir : File.absolute_path(entry, launch_dir)
+  end.join(File::PATH_SEPARATOR)
+
+  { "PATH" => normalized_path }
 end
 
-def shakapacker_node_binary
-  node_bin = shakapacker_find_executable("node")
-  return node_bin if node_bin
+def shakapacker_exec_node(script_path, argv, launch_dir)
+  exec_env = shakapacker_exec_env(launch_dir)
 
-  warn '[Shakapacker] Could not find Node.js executable "node". ' \
-       "Install Node.js and try again."
-  exit 1
+  if exec_env.empty?
+    exec shakapacker_node_binary, script_path, *argv
+  else
+    exec exec_env, shakapacker_node_binary, script_path, *argv
+  end
+rescue Errno::ENOENT, Errno::EACCES
+  shakapacker_warn_missing_node
 end
 
 def shakapacker_node_env
@@ -130,9 +132,9 @@ end
 ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
 ENV["NODE_ENV"] ||= shakapacker_node_env
 
+launch_dir = Dir.pwd
 app_root = shakapacker_app_root
 client_root = shakapacker_client_root(app_root)
-node_bin = shakapacker_node_binary
 script_paths = shakapacker_package_script_paths(app_root, client_root, "diff-bundler-config.cjs")
 script_path = script_paths.find { |path| File.file?(path) }
 
@@ -142,5 +144,5 @@ unless script_path
 end
 
 Dir.chdir(app_root) do
-  exec node_bin, script_path, *ARGV
+  shakapacker_exec_node(script_path, ARGV, launch_dir)
 end

data/lib/install/bin/shakapacker-config

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "rbconfig"
 require "yaml"
 
 # This binstub is managed by Shakapacker. Delete it and rerun the install or init command to regenerate it.
@@ -14,36 +13,39 @@ def shakapacker_app_root
   Dir.pwd
 end
 
-def shakapacker_executable_candidates(executable)
-  extensions = [
-    RbConfig::CONFIG["EXEEXT"],
-    *ENV.fetch("PATHEXT", "").split(File::PATH_SEPARATOR)
-  ].compact.reject(&:empty?)
-  return [executable] if extensions.empty? || File.extname(executable) != ""
+def shakapacker_node_binary
+  "node"
+end
 
-  ([executable] + extensions.map { |extension| "#{executable}#{extension}" }).uniq
+def shakapacker_warn_missing_node
+  warn '[Shakapacker] Could not find Node.js executable "node". ' \
+       "Install Node.js and try again."
+  exit 1
 end
 
-def shakapacker_find_executable(executable)
-  ENV.fetch("PATH", "").split(File::PATH_SEPARATOR, -1).each do |path|
-    search_path = path.empty? ? Dir.pwd : path
+def shakapacker_exec_env(launch_dir)
+  return {} unless ENV.key?("PATH")
 
-    shakapacker_executable_candidates(executable).each do |candidate|
-      executable_path = File.join(search_path, candidate)
-      return executable_path if File.file?(executable_path) && File.executable?(executable_path)
-    end
-  end
+  path_entries = ENV["PATH"].split(File::PATH_SEPARATOR, -1)
+  path_entries = [""] if path_entries.empty?
 
-  nil
+  normalized_path = path_entries.map do |entry|
+    entry.empty? ? launch_dir : File.absolute_path(entry, launch_dir)
+  end.join(File::PATH_SEPARATOR)
+
+  { "PATH" => normalized_path }
 end
 
-def shakapacker_node_binary
-  node_bin = shakapacker_find_executable("node")
-  return node_bin if node_bin
+def shakapacker_exec_node(script_path, argv, launch_dir)
+  exec_env = shakapacker_exec_env(launch_dir)
 
-  warn '[Shakapacker] Could not find Node.js executable "node". ' \
-       "Install Node.js and try again."
-  exit 1
+  if exec_env.empty?
+    exec shakapacker_node_binary, script_path, *argv
+  else
+    exec exec_env, shakapacker_node_binary, script_path, *argv
+  end
+rescue Errno::ENOENT, Errno::EACCES
+  shakapacker_warn_missing_node
 end
 
 def shakapacker_node_env
@@ -130,9 +132,9 @@ end
 ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
 ENV["NODE_ENV"] ||= shakapacker_node_env
 
+launch_dir = Dir.pwd
 app_root = shakapacker_app_root
 client_root = shakapacker_client_root(app_root)
-node_bin = shakapacker_node_binary
 script_paths = shakapacker_package_script_paths(app_root, client_root, "shakapacker-config.cjs")
 script_path = script_paths.find { |path| File.file?(path) }
 
@@ -142,5 +144,5 @@ unless script_path
 end
 
 Dir.chdir(app_root) do
-  exec node_bin, script_path, *ARGV
+  shakapacker_exec_node(script_path, ARGV, launch_dir)
 end

data/lib/install/config/shakapacker.yml

@@ -59,7 +59,9 @@ default: &default
   cache_manifest: false
 
   # Select JavaScript transpiler to use
-  # Available options: 'swc' (default, 20x faster), 'babel', 'esbuild', or 'none'
+  # Available options: 'swc' (bundled default), 'babel', 'esbuild', or 'none'
+  # Webpack apps that omit this setting use the bundled SWC default when swc-loader is
+  # installed, but fall back to Babel with a warning when only Babel tooling is present.
   # Use 'none' when providing a completely custom webpack configuration
   # Note: When using rspack, swc is used automatically regardless of this setting
   javascript_transpiler: "swc"

data/lib/install/package.json

@@ -11,7 +11,7 @@
     "webpack": "^5.101.0",
     "webpack-assets-manifest": "^5.0.6 || ^6.0.0",
     "webpack-cli": "^4.9.2 || ^5.0.0 || ^6.0.0 || ^7.0.0",
-    "webpack-dev-server": "^5.2.2",
+    "webpack-dev-server": "^5.2.2 || ^6.0.0",
     "webpack-merge": "^5.8.0 || ^6.0.0",
     "webpack-subresource-integrity": "^5.1.0"
   },

data/lib/shakapacker/configuration.rb

@@ -50,6 +50,13 @@ class Shakapacker::Configuration
     /\A(?:--config|-c|--node-env|--nodeEnv|--bundler|--build|--init|--list-builds)(?:=.*)?\z/
   private_constant :SHAKAPACKER_MANAGED_COMPILE_FLAG_PATTERN
 
+  IMPLICIT_SWC_BABEL_FALLBACK_WARNING =
+    "`javascript_transpiler` is not set in config/shakapacker.yml. " \
+    "Shakapacker defaults to SWC, but swc-loader is not installed and Babel was detected, so Babel will be used. " \
+    "Set `javascript_transpiler: babel` (or `swc`) explicitly to silence this message. " \
+    "See https://github.com/shakacode/shakapacker/blob/main/docs/transpiler-migration.md"
+  private_constant :IMPLICIT_SWC_BABEL_FALLBACK_WARNING
+
   DISALLOWED_WEBPACK_COMPILE_FLAGS =
     (SHAKAPACKER_NODE_FLAGS + SHAKAPACKER_RUNNER_COMMANDS + SHAKAPACKER_WATCH_FLAGS +
       SHAKAPACKER_MANAGED_COMPILE_FLAGS).freeze
@@ -357,24 +364,54 @@ class Shakapacker::Configuration
   # Resolution order:
   # 1. javascript_transpiler setting in config file
   # 2. webpack_loader setting in config file (deprecated)
-  # 3. Default based on bundler (swc for rspack, babel for webpack)
+  # 3. Bundled defaults
+  # 4. Babel fallback for implicit webpack/SWC defaults when swc-loader is missing
   #
   # Validates that the configured transpiler matches installed packages.
   #
   # @return [String] "babel", "swc", or "esbuild"
   def javascript_transpiler
-    # Show deprecation warning if using old 'webpack_loader' key
-    if data.has_key?(:webpack_loader) && !data.has_key?(:javascript_transpiler)
-      $stderr.puts "⚠️  DEPRECATION WARNING: The 'webpack_loader' configuration option is deprecated. Please use 'javascript_transpiler' instead as it better reflects its purpose of configuring JavaScript transpilation regardless of the bundler used."
-    end
+    return @javascript_transpiler if defined?(@javascript_transpiler)
+
+    @javascript_transpiler =
+      begin
+        javascript_transpiler_configured = config_value_configured?(:javascript_transpiler)
+        webpack_loader_configured = config_value_present?(:webpack_loader)
+
+        # Show deprecation warning if using old 'webpack_loader' key
+        if webpack_loader_configured && !javascript_transpiler_configured
+          $stderr.puts "⚠️  DEPRECATION WARNING: The 'webpack_loader' configuration option is deprecated. Please use 'javascript_transpiler' instead as it better reflects its purpose of configuring JavaScript transpilation regardless of the bundler used."
+        end
+
+        # Use explicit config if set, otherwise default based on bundler
+        current_javascript_transpiler =
+          if javascript_transpiler_configured
+            fetch(:javascript_transpiler)
+          elsif data.has_key?(:javascript_transpiler)
+            defaults[:javascript_transpiler]
+          else
+            fetch(:javascript_transpiler)
+          end
+
+        transpiler =
+          if webpack_loader_configured && !javascript_transpiler_configured
+            fetch(:webpack_loader) || default_javascript_transpiler
+          else
+            current_javascript_transpiler || fetch(:webpack_loader) || default_javascript_transpiler
+          end
 
-    # Use explicit config if set, otherwise default based on bundler
-    transpiler = fetch(:javascript_transpiler) || fetch(:webpack_loader) || default_javascript_transpiler
+        if !javascript_transpiler_configured &&
+            !webpack_loader_configured &&
+            implicit_swc_to_babel_fallback?(transpiler)
+          $stderr.puts IMPLICIT_SWC_BABEL_FALLBACK_WARNING
+          transpiler = "babel"
+        end
 
-    # Validate transpiler configuration
-    validate_transpiler_configuration(transpiler) unless self.class.installing
+        # Validate transpiler configuration
+        validate_transpiler_configuration(transpiler) unless self.class.installing
 
-    transpiler
+        transpiler
+      end
   end
 
   # Deprecated alias for {#javascript_transpiler}
@@ -461,42 +498,124 @@ class Shakapacker::Configuration
       rspack? ? "swc" : "babel"
     end
 
+    def implicit_swc_to_babel_fallback?(transpiler)
+      webpack? &&
+        transpiler == "swc" &&
+        !package_dependency?("swc-loader") &&
+        package_dependency?("babel-loader")
+    end
+
+    def package_dependency?(package_name)
+      declared_package_dependencies.key?(package_name)
+    end
+
+    def config_value_present?(key)
+      return false unless data.has_key?(key)
+
+      value = data[key]
+      value.is_a?(String) && !value.strip.empty?
+    end
+
+    def config_value_configured?(key)
+      return false unless data.has_key?(key)
+
+      value = data[key]
+      return false if value.nil?
+      return false if value.is_a?(String) && value.strip.empty?
+
+      true
+    end
+
+    def declared_package_dependencies
+      return @declared_package_dependencies if defined?(@declared_package_dependencies)
+
+      @declared_package_dependencies =
+        package_json_paths.reverse_each.each_with_object({}) do |path, dependencies|
+          package_json = parse_package_json(path)
+          next unless package_json
+
+          dependencies.merge!(installable_package_dependencies(package_json))
+        end
+    end
+
+    def installable_package_dependencies(package_json)
+      (package_json["optionalDependencies"] || {})
+        .merge(package_json["devDependencies"] || {})
+        .merge(package_json["dependencies"] || {})
+    end
+
+    def package_json_paths
+      @package_json_paths ||= package_root_paths
+        .map { |path| path.join("package.json") }
+        .select(&:exist?)
+    end
+
+    def parse_package_json(path)
+      JSON.parse(File.read(path))
+    rescue JSON::ParserError, SystemCallError
+      nil
+    end
+
+    def package_root_paths
+      @package_root_paths ||= [javascript_package_root_path, root_path].uniq
+    end
+
+    def javascript_package_root_path
+      @javascript_package_root_path ||= begin
+        resolved_source_path = source_path.expand_path
+        app_root = root_path.expand_path
+
+        if path_within?(resolved_source_path, app_root)
+          current = resolved_source_path
+          loop do
+            break current if current.join("package.json").exist?
+            break root_path if current == app_root
+
+            parent = current.dirname
+            break root_path if parent == current
+
+            current = parent
+          end
+        else
+          root_path
+        end
+      rescue StandardError
+        root_path
+      end
+    end
+
+    def path_within?(path, parent)
+      path.to_s == parent.to_s || path.to_s.start_with?("#{parent}#{File::SEPARATOR}")
+    end
+
     def validate_transpiler_configuration(transpiler)
       return unless ENV["NODE_ENV"] != "test" # Skip validation in test environment
 
       # Skip validation if transpiler is set to 'none' (custom webpack config)
       return if transpiler == "none"
 
-      # Check if package.json exists
-      package_json_path = root_path.join("package.json")
-      return unless package_json_path.exist?
+      all_deps = declared_package_dependencies
+      return if all_deps.empty?
 
-      begin
-        package_json = JSON.parse(File.read(package_json_path))
-        all_deps = (package_json["dependencies"] || {}).merge(package_json["devDependencies"] || {})
-
-        # Check for transpiler mismatch
-        has_babel = all_deps.keys.any? { |pkg| pkg.start_with?("@babel/", "babel-") }
-        has_swc = all_deps.keys.any? { |pkg| pkg.include?("swc") }
-        has_esbuild = all_deps.keys.any? { |pkg| pkg.include?("esbuild") }
-
-        case transpiler
-        when "babel"
-          if !has_babel && has_swc
-            warn_transpiler_mismatch("Babel", "SWC packages found but Babel is configured")
-          end
-        when "swc"
-          if !has_swc && has_babel
-            warn_transpiler_mismatch("SWC", "Babel packages found but SWC is configured")
-          end
-        when "esbuild"
-          if !has_esbuild && (has_babel || has_swc)
-            other = has_babel ? "Babel" : "SWC"
-            warn_transpiler_mismatch("esbuild", "#{other} packages found but esbuild is configured")
-          end
+      # Check for transpiler mismatch
+      has_babel = all_deps.keys.any? { |pkg| pkg.start_with?("@babel/", "babel-") }
+      has_swc = all_deps.keys.any? { |pkg| pkg.include?("swc") }
+      has_esbuild = all_deps.keys.any? { |pkg| pkg.include?("esbuild") }
+
+      case transpiler
+      when "babel"
+        if !has_babel && has_swc
+          warn_transpiler_mismatch("Babel", "SWC packages found but Babel is configured")
+        end
+      when "swc"
+        if !has_swc && has_babel
+          warn_transpiler_mismatch("SWC", "Babel packages found but SWC is configured")
+        end
+      when "esbuild"
+        if !has_esbuild && (has_babel || has_swc)
+          other = has_babel ? "Babel" : "SWC"
+          warn_transpiler_mismatch("esbuild", "#{other} packages found but esbuild is configured")
         end
-      rescue JSON::ParserError
-        # Ignore if package.json is malformed
       end
     end
 

data/lib/shakapacker/doctor.rb

@@ -511,12 +511,14 @@ module Shakapacker
 
       def check_javascript_transpiler_dependencies
         transpiler = explicit_javascript_transpiler
+        implicit_babel_fallback = false
 
         if transpiler.nil?
-          @info << "No javascript_transpiler configured - defaulting to SWC (20x faster than Babel)"
-          transpiler = "swc"
+          transpiler = javascript_transpiler
+          implicit_babel_fallback = transpiler == "babel"
         end
 
+        @resolved_javascript_transpiler = transpiler
         return if transpiler == "none"
 
         bundler = assets_bundler
@@ -541,7 +543,7 @@ module Shakapacker
         case transpiler
         when "babel"
           check_babel_dependencies
-          check_babel_performance_suggestion
+          check_babel_performance_suggestion unless implicit_babel_fallback
         when "swc"
           check_swc_dependencies(bundler) unless inferred_hybrid_graph
         when "esbuild"
@@ -573,6 +575,20 @@ module Shakapacker
         @info << "Consider switching to SWC for 20x faster compilation. Set javascript_transpiler: 'swc' in shakapacker.yml"
       end
 
+      def implicit_javascript_transpiler
+        if assets_bundler == "webpack" && !package_installed?("swc-loader") && package_installed?("babel-loader")
+          @info << "`javascript_transpiler` is not set in config/shakapacker.yml. " \
+                   "Shakapacker defaults to SWC, but swc-loader is not installed and Babel was detected, so Babel will be used. " \
+                   "Set `javascript_transpiler: babel` (or `swc`) explicitly to silence this message. " \
+                   "See https://github.com/shakacode/shakapacker/blob/main/docs/transpiler-migration.md"
+          "babel"
+        else
+          @info << "No javascript_transpiler configured - using bundled SWC default. " \
+                   "Set javascript_transpiler: 'swc' or 'babel' explicitly in shakapacker.yml to silence this message."
+          "swc"
+        end
+      end
+
       def check_swc_dependencies(bundler)
         if bundler == "webpack"
           unless package_installed?("@swc/core")
@@ -1271,13 +1287,20 @@ module Shakapacker
 
       def javascript_transpiler_configured?
         !javascript_transpiler_env_override.nil? ||
-          config_key_defined?(:javascript_transpiler) ||
-          config_key_defined?(:webpack_loader)
+          config_key_configured?(:javascript_transpiler) ||
+          config_key_present?(:webpack_loader)
       end
 
       def javascript_transpiler
-        transpiler = javascript_transpiler_env_override || config.javascript_transpiler
-        blank_config_value?(transpiler) ? default_javascript_transpiler : transpiler
+        return @resolved_javascript_transpiler if defined?(@resolved_javascript_transpiler)
+
+        @resolved_javascript_transpiler =
+          if javascript_transpiler_configured?
+            transpiler = javascript_transpiler_env_override || config.javascript_transpiler
+            blank_config_value?(transpiler) ? default_javascript_transpiler : transpiler
+          else
+            implicit_javascript_transpiler
+          end
       end
 
       def explicit_javascript_transpiler
@@ -1329,7 +1352,7 @@ module Shakapacker
       end
 
       def blank_config_value?(value)
-        value.nil? || (value.respond_to?(:empty?) && value.empty?)
+        value.nil? || (value.is_a?(String) && value.strip.empty?) || (value.respond_to?(:empty?) && value.empty?)
       end
 
       def default_javascript_transpiler
@@ -1337,14 +1360,15 @@ module Shakapacker
       end
 
       def config_key_present?(key)
-        !blank_config_value?(config_value(key))
+        value = config_value(key)
+        value.is_a?(String) && !value.strip.empty?
       end
 
-      def config_key_defined?(key)
+      def config_key_configured?(key)
         return false unless config.respond_to?(:data)
 
         data = config.data
-        data.respond_to?(:key?) && data.key?(key)
+        data.respond_to?(:key?) && data.key?(key) && !blank_config_value?(data[key])
       end
 
       def config_value(key)
@@ -1383,7 +1407,7 @@ module Shakapacker
           if path_within?(source_path, app_root)
             current = source_path
             loop do
-              break current if package_root_marker?(current)
+              break current if current.join("package.json").exist?
               break root_path if current == app_root
 
               parent = current.dirname
@@ -1458,7 +1482,7 @@ module Shakapacker
       def detect_package_manager
         root_package_manager = package_manager_for(root_path)
 
-        package_root_paths.each do |package_root|
+        package_manager_root_paths.each do |package_root|
           next if package_root == root_path
 
           package_manager_name = package_manager_for(package_root)
@@ -1478,6 +1502,34 @@ module Shakapacker
         nil
       end
 
+      def package_manager_root_paths
+        @package_manager_root_paths ||= [javascript_package_manager_root_path, root_path].uniq
+      end
+
+      def javascript_package_manager_root_path
+        @javascript_package_manager_root_path ||= begin
+          source_path = config.source_path.expand_path
+          app_root = root_path.expand_path
+
+          if path_within?(source_path, app_root)
+            current = source_path
+            loop do
+              break current if package_root_marker?(current)
+              break root_path if current == app_root
+
+              parent = current.dirname
+              break root_path if parent == current
+
+              current = parent
+            end
+          else
+            root_path
+          end
+        rescue StandardError
+          root_path
+        end
+      end
+
       def versions_compatible?(gem_version, npm_version)
         # Handle pre-release versions and ranges properly
         npm_clean = npm_version.gsub(/[\^~]/, "")

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "10.2.0".freeze
+  VERSION = "10.3.0".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "10.2.0",
+  "version": "10.3.0",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {
@@ -127,7 +127,7 @@
     "webpack": "^5.101.0",
     "webpack-assets-manifest": "^5.0.6 || ^6.0.0",
     "webpack-cli": "^4.9.2 || ^5.0.0 || ^6.0.0 || ^7.0.0",
-    "webpack-dev-server": "^5.2.2",
+    "webpack-dev-server": "^5.2.2 || ^6.0.0",
     "webpack-subresource-integrity": "^5.1.0"
   },
   "peerDependenciesMeta": {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 10.2.0
+  version: 10.3.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -225,7 +225,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v10.2.0
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v10.3.0
 rdoc_options: []
 require_paths:
 - lib