sfax 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74afcc0d5d5f12617755eb6a4f7e278ec822550e
-  data.tar.gz: 2f3847a6d32c964084bec36f96c856bf6791e909
+  metadata.gz: 5fdaa7dc60428262e6a5e7329b1472404011e5ac
+  data.tar.gz: 15ff36354f2180a0a85179f22ec134a30f093378
 SHA512:
-  metadata.gz: 0f9dfb22c0fa53fac0f78aef202835ccf7e4225d9eec7b5e00be899c0ce6123500ab5b5dfa2c16fb3bdf121eb53f126b60c687c01db1025cf6a860e031d6c4f2
-  data.tar.gz: c2abb34593bb8fbe8f2d301f3806581e5a4e1597435ae6062a7fff39b8f17a78891c7e223bc2b0b80833226844a08176caba100ac962fc353fa0f4c089b281bb
+  metadata.gz: 2fa0aad3bfb66aed503049d66802e23133fbd21231fe18b64069d414254061caa223eca4be737a806b5c9d81c3225782e931ae26f86062c423e434d253cd3692
+  data.tar.gz: d0d558856c8f2a9dcb4b6fd4973fcacf9b8c280f760c6115ec787df6e5f8cd3c8f85e5b1645f55f14519fd3cb6aefeae301eae9bdf9767040ed2189c17d1bad7

data/lib/sfax/client.rb

@@ -35,8 +35,17 @@ module SFax
         fetch('SendFaxQueueId')
       end
 
+      def response_object.success?
+        fetch('isSuccess')
+      end
+
+      def response_object.message
+        fetch('message')
+      end
+
       response_object.tap do |o|
-        raise SendFaxError if o.fax_id == -1
+        raise SendFaxError, o.message unless o.success?
+        raise SendFaxError, o.message if o.fax_id.to_s == SEND_FAX_QUEUE_ID_ERROR_VALUE
       end
     end
 

data/lib/sfax/constants.rb

@@ -2,5 +2,7 @@ module SFax
   module Constants
     SFAX_URL = 'https://api.sfaxme.com'.freeze
     SEND_FAX_PATH = '/api/sendfax'.freeze
+
+    SEND_FAX_QUEUE_ID_ERROR_VALUE = '-1'.freeze
   end
 end

data/lib/sfax/version.rb

@@ -1,3 +1,3 @@
 module SFax
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/spec/sfax_client_spec.rb

@@ -17,7 +17,9 @@ RSpec.describe SFax::Client do
     let(:file) { StringIO.new('data') }
     let(:recipient_name) { nil }
     let(:token) { SecureRandom.hex }
+    let(:message) { SecureRandom.hex }
     let(:send_fax_queue_id) { rand(1_000_000) }
+    let(:is_success) { true }
     let!(:send_fax_request) do
       stub_request(:post, 'https://api.sfaxme.com/api/sendfax').with(query: {
         'token' => token,
@@ -26,6 +28,8 @@ RSpec.describe SFax::Client do
         'RecipientName' => recipient_name,
       }).and_return(body: {
         'SendFaxQueueId' => send_fax_queue_id,
+        'isSuccess' => is_success,
+        'message' => message,
       }.to_json)
     end
 
@@ -50,12 +54,24 @@ RSpec.describe SFax::Client do
       end
 
       context 'send_fax_queue_id is -1' do
-        let(:send_fax_queue_id) { -1 }
+        let(:send_fax_queue_id) { '-1' }
 
         specify do
           expect {
             subject.send_fax(fax_number: fax_number, file: file, recipient_name: recipient_name)
-          }.to raise_error(described_class::SendFaxError)
+          }.to raise_error(described_class::SendFaxError, message)
+
+          expect(send_fax_request).to have_been_requested
+        end
+      end
+
+      context 'isSuccess is false' do
+        let(:is_success) { false }
+
+        specify do
+          expect {
+            subject.send_fax(fax_number: fax_number, file: file, recipient_name: recipient_name)
+          }.to raise_error(described_class::SendFaxError, message)
 
           expect(send_fax_request).to have_been_requested
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sfax
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Derek Schneider
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-31 00:00:00.000000000 Z
+date: 2017-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday