sewing_kit 0.95.0 → 0.95.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b602141d9384dbe196746242130707db37ed8cc877f50b36364b3c8e15a018f
-  data.tar.gz: b9669c5e2666ae28ae2f3ad6228cff9b6e969e73da05855224ba8acc837cf437
+  metadata.gz: 41ebcd8335cbea9ad813df8116ee2d9eb628ae279a01ad072d167980a534e932
+  data.tar.gz: cc99f63e71559984cf6616b5594f2dcba064916bfa452bdd623fc9152ee7b04e
 SHA512:
-  metadata.gz: e05bd301abc39d37c44b660cc56d35874de2a4d527012e872a6bf76f46b88079d8e683a8dd983ea3eadd267a3a7f054f4ad65685f823dac5784d2f655e39672c
-  data.tar.gz: 53129c412805f4a5cc602566d0add516693a1e5f723045def7826498884dbaa314f8338b9ae887ae095b6b3182586c117a68af68d3c1f8d4214e3cc573399e9a
+  metadata.gz: f525e31bf2ac93cd30c426cc89c0db275d8126d99a370cc883b913dc70868e4bfea26b674365984bedfe9cc08d2afd97d1fec7544db9758d461e404babe6b614
+  data.tar.gz: 5aa0cc16500aa6a98404da3ac96402d04ea0f85b453581f83a3b996914955467587d120f4ddca4d2d89a3598f51e1bb09eb41713c152b6f5e25b8ae9d03ecf08

data/README.md

@@ -229,11 +229,17 @@ By moving everything into `package.json#dependencies`. This is necessary because
 Ideally, by deploying to a `staging` environment. If that is not possible, a production-like local development experience is available via:
 
 ```sh
-NODE_ENV=production bundle exec rake assets:precompile
+NODE_ENV=production SK_SIMULATE_PRODUCTION=1 bundle exec rake assets:precompile
 NODE_ENV=production SK_SIMULATE_PRODUCTION=1 dev run
 ```
 
-Note that code changes will not be automatically recompiled in this state. After verifying production behaviour, run `bundle exec rake assets:clobber` to get back to development mode.
+Note:
+
+- Code changes will not be automatically recompiled in this state
+- `SK_SIMULATE_PRODUCTION` does not make Rails itself run in production mode
+- The most accurate way to gauge performance of the production version of an application is via a `staging` environment
+
+After verifying production behaviour, run `bundle exec rake assets:clobber` to get back to development mode.
 
 ### My project is using `sprockets-commoner`, can I use sewing_kit too?
 

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.95.0"
+  VERSION = "0.95.1"
 end

data/lib/sewing_kit/webpack/manifest/production.rb

@@ -1,13 +1,17 @@
 # frozen_string_literal: true
 require 'sewing_kit/webpack/manifest/base'
+require 'benchmark'
 require 'browserslist_useragent'
 
 module SewingKit
   module Webpack
     class Manifest
       class Production < Base
-        @metadata = nil
-        @metadata_path = nil
+        def initialize
+          @cache_by_user_agent = {}
+          @metadata = nil
+          @metadata_path = nil
+        end
 
         def asset_bundle_name(user_agent)
           metadata_for(user_agent)['name']
@@ -25,14 +29,20 @@ module SewingKit
         private
 
         def metadata_for(user_agent)
-          if metadata.is_a?(Array)
-            find_matching_metadata(metadata, user_agent)
-          else
-            metadata
+          time = Benchmark.realtime do
+            @cache_by_user_agent[user_agent] ||= find_matching_metadata(metadata, user_agent)
           end
+
+          Rails.logger.debug(
+            "[sewing_kit] found asset metadata for #{user_agent} in  #{time * 1000} milliseconds"
+          )
+
+          @cache_by_user_agent[user_agent]
         end
 
         def find_matching_metadata(consolidated_metadata, user_agent)
+          return metadata unless metadata.is_a?(Array)
+
           found = consolidated_metadata.find do |metadata|
             return nil if metadata["resolvedBrowsers"].nil?
             matcher = BrowserslistUseragent::Match.new(metadata["resolvedBrowsers"], user_agent)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.95.0
+  version: 0.95.1
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-11 00:00:00.000000000 Z
+date: 2019-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties