sewing_kit 0.128.0 → 0.129.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a461122bbd1f59afece53f1695188abeb57f7a70bf397c9871a1389a5c3dace0
-  data.tar.gz: 606ece89a71cf2748dd13bf2a1884e428d41365cbdabb9fe98dbbe2c7184e143
+  metadata.gz: 192f93794571de06b57d5125eec9da37d1331c3dbb47a2c530e29d6f4693cb47
+  data.tar.gz: d06a650795388f99d0680e007e7402b8d964562be69610aa92032e9e24abdac1
 SHA512:
-  metadata.gz: 9725a50c0872da10cb36d7882d446d9606177af40055bd309c7874f78de953768c201aacaf02853ce9b83f8ed6c80462e3df81552a225d5c1727e66a64e2df5a
-  data.tar.gz: 14f2b69ef3a1afc0b2cc99275933dd219767dcf9784026fd79d01d3b33c52f2a6adc36fcc2d3b88fc97dad481293f34cc9959e0400c59cf3ee71590721f468a4
+  metadata.gz: 773c4e613be0301501b9d8e31b12bce81027f7aaf39aabafa87c07a5a76430498b6c39d81801f4af44b1ea48e47cf127edddca88e7c2031dc22c44ffc202fe58
+  data.tar.gz: 056bdc1ff814b70f35ffac31bcba3b7d95560002437272f8e615ae93d8e6a4bdcb49bb08b0d8db9961c99f88488ff3cd616cb991b044c125578ca41f660455de

data/README.md

@@ -2,7 +2,11 @@
 
 Zero configuration, high performance front end development at organization scale.
 
-`sewing_kit` facilitates legacy Rails integration using ERB tags. For a more complete modern stack with performance-as-a-feature, consider [quilt_rails](https://github.com/Shopify/quilt/tree/master/gems/quilt_rails). For details of the `sewing-kit` node package's configuration and usage, see the [sewing-kit README](/README.md).
+`sewing_kit` can be used in a Rails application instead of [Webpacker](https://github.com/rails/webpacker), allowing to embed bundled/compiled javascript in erb pages.
+
+For a more complete and modern stack with performance-as-a-feature, consider [quilt_rails](https://github.com/Shopify/quilt/tree/master/gems/quilt_rails).
+
+For details on configuring and usage of the `sewing-kit` node package, see the [sewing-kit README](/README.md).
 
 ## Quick Start
 

data/lib/generators/sewing_kit/install_generator.rb

@@ -19,16 +19,16 @@ module SewingKit
       @javascript_path = options[:javascript_path]
 
       if Project.uses_webpacker?
-        warn "
+        warn("
           WARNING: We've detected you currently have webpacker config at config/webpacker.yml.
           You may experience conflicts between sewing-kit and webpacker's behaviour as build tools.
           If your app was made with `rails new`, try rerunning it with `--skip-webpack-install --skip-javascript`
-        "
+        ")
       end
     end
 
     def create_config_files
-      say "Creating JS tooling config files"
+      say("Creating JS tooling config files")
       copy_file("editorconfig", ".editorconfig")
       copy_file("eslintignore", ".eslintignore")
       copy_file("prettierignore", ".prettierignore")
@@ -39,7 +39,7 @@ module SewingKit
 
     def install_js_dependencies
       return if options.skip_yarn?
-      say "Installing javascript dependencies"
+      say("Installing javascript dependencies")
       system("yarn add @shopify/sewing-kit")
       system("yarn add typescript")
     end

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.128.0"
+  VERSION = "0.129.0"
 end

data/lib/sewing_kit/webpack/compiler.rb

@@ -8,7 +8,7 @@ module SewingKit
         def initialize
           super(
             "nodejs is not installed.  " \
-            "Try creating a `.buildpack` file in the root of the project with following content:
+            "Try creating a `.buildpacks` file in the root of the project with following content:
 
             https://github.com/heroku/heroku-buildpack-nodejs.git
             https://github.com/heroku/heroku-buildpack-ruby.git

data/lib/sewing_kit/webpack/dev.rb

@@ -39,13 +39,13 @@ module SewingKit
 
       def handle_exit
         return if $ERROR_INFO.nil?
-        Process.kill 'SIGTERM', pid
+        Process.kill('SIGTERM', pid)
       rescue Errno::ESRCH
         nil
       end
 
       def detach
-        Process.detach pid
+        Process.detach(pid)
       end
 
       def command
@@ -54,7 +54,7 @@ module SewingKit
           heap_config,
           sewing_kit_bin,
           'dev',
-          '--logLevel',
+          '--log-level',
           log_level,
         ].compact.concat(options)
 

data/lib/sewing_kit/webpack/helper.rb

@@ -16,7 +16,7 @@ module SewingKit
 
         assets = SewingKit::Webpack::Manifest.asset_dependencies(entrypoint_name, request.user_agent)
 
-        raise UnknownAssetError, "#{entrypoint_name} was not found in manifest." if raise_unknown_error? assets
+        raise UnknownAssetError, "#{entrypoint_name} was not found in manifest." if raise_unknown_error?(assets)
         return [] unless assets && assets[extension]
 
         dependencies = assets[extension]
@@ -56,7 +56,7 @@ module SewingKit
       private
 
       def create_asset_tag(tag_type, asset, tag_options)
-        raise ArgumentError, "Invalid tag type: #{tag_type}" unless [:script, :link].include? tag_type
+        raise ArgumentError, "Invalid tag type: #{tag_type}" unless [:script, :link].include?(tag_type)
 
         options = tag_options.clone
 

data/lib/sewing_kit/webpack/manifest.rb

@@ -24,14 +24,14 @@ module SewingKit
       # Raised if the node-generated manifest cannot be read from the filesystem.
       class ManifestLoadError < StandardError
         def initialize(path, cause)
-          super "Could not load manifest from #{path} (original error #{cause})"
+          super("Could not load manifest from #{path} (original error #{cause})")
         end
       end
 
       # Raised if the node-generated manifest returns unparseable JSON.
       class ManifestParseError < StandardError
         def initialize(cause)
-          super "Could not parse manifest JSON (original error #{cause})"
+          super("Could not parse manifest JSON (original error #{cause})")
         end
       end
 

data/lib/sewing_kit/webpack/manifest/development.rb

@@ -43,7 +43,9 @@ module SewingKit
               return normalize_metadata(result)
             end
           rescue => e
-            Rails.logger.warn "[sewing_kit] could not read manifest from #{@metadata_path}; falling back to node.  #{e}"
+            Rails.logger.warn(
+              "[sewing_kit] could not read manifest from #{@metadata_path}; falling back to node.  #{e}"
+            )
             @metadata_path = nil
           end
 
@@ -81,8 +83,8 @@ module SewingKit
 
       class OnlyUseInProductionError < StandardError
         def initialize
-          super "The SewingKit::Webpack::Manifest#manifest is intended "\
-          "for deploying assets to a CDN. Do not use it in development."
+          super("The SewingKit::Webpack::Manifest#manifest is intended "\
+          "for deploying assets to a CDN. Do not use it in development.")
         end
       end
     end

data/lib/sewing_kit/webpack/manifest/production.rb

@@ -8,8 +8,8 @@ module SewingKit
     class Manifest
       class Production < Base
         def initialize
+          super
           @cache_by_user_agent = {}
-          @metadata = nil
           @metadata_path = nil
         end
 

data/lib/tasks/sewing_kit.rake

@@ -29,3 +29,11 @@ if Rake::Task.task_defined?("assets:precompile")
 else
   Rake::Task.define_task("assets:precompile" => %w(sewing_kit:build))
 end
+
+unless Rake::Task.task_defined?('assets:clean')
+  namespace :assets do
+    task :clean do
+      # This empty task is to offer the same interface than sprockets and webpacker
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.128.0
+  version: 0.129.0
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-28 00:00:00.000000000 Z
+date: 2020-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.56'
+        version: 0.89.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.56'
+        version: 0.89.1
 - !ruby/object:Gem::Dependency
   name: rubocop-git
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.1.3
+- !ruby/object:Gem::Dependency
+  name: rubocop-shopify
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.5
 description: 
 email:
 - chris.sauve@shopify.com