sewing_kit 0.114.2 → 0.125.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0134a2424e936702521db2dcbc10e900862ca6720e459fffabf0309d4d4823c3
-  data.tar.gz: b72bed1c690ada5e98756632634c0eb7988351c933ff9c5f26a33984f107c0d1
+  metadata.gz: 564314c05cfa0473a306cf5fbb6564a6e1761705009aa0e1db2510a0133ab3ff
+  data.tar.gz: 50694443b9a1ef590f2968186864bdaedca0c0537fedde76be889a1297ff7770
 SHA512:
-  metadata.gz: 1f68e6f089f390d7f615d5d11d4bfda4884430ce4f6d79510e083089cfd9e7e26c82bad02e35da42a68ebaabad41cd2ea2342ec432745368f772ca92bc6b2cb8
-  data.tar.gz: 3bef3f7fa71412e2cda8768e0f1c65137798fe0c729c664ccc7f9343d053955b8625e4a6f4d3f562e0f2f3acf792cbba3774ca7233a3515df7a0c37f73188776
+  metadata.gz: 67d879b2d836ed5a77e71e7950c9179451b644fc65140265efb28c179d576d153584da2b9f7d28809a8cdfe45ff910a2cf8aa58502063ae2fabf34a0e9a63209
+  data.tar.gz: d8bef03cd01d4b708a8dd956769c8a42cd008c41f5d9dbf3a7275cb6ed0eb351a2ac8ce1b87b8c2895df06916b1720a81b2364fbfcb07f6a21f3ba2f50f58541

data/README.md

@@ -19,6 +19,12 @@ yarn
 dev up
 ```
 
+### Run generator
+
+`rails generate sewing_kit:install`
+
+will generate a package.json file with common sewing-kit script tasks, default lint, format configuration; a sewing-kit configuration file, and other project default configurations.
+
 ### Add JavaScript
 
 sewing_kit looks for JavaScript in `app/ui/index.js`. The code in `index.js` (and any imported JS/CSS) will be built into a `main` bundle.
@@ -146,7 +152,7 @@ If sewing-kit makes a breaking change, this gem's minor version will be bumped t
 
 By moving everything into `package.json#dependencies`. This is necessary because Rails 5.2 prunes `devDependencies` during asset compilation.
 
-### How can I test a production verison of my changes?
+### How can I test a production version of my changes?
 
 Ideally, by deploying to a `staging` environment. If that is not possible, a production-like local development experience is available via:
 
@@ -155,6 +161,9 @@ NODE_ENV=production SK_SIMULATE_PRODUCTION=1 bundle exec rake assets:precompile
 NODE_ENV=production SK_SIMULATE_PRODUCTION=1 dev run
 ```
 
+If your application includes a node server (eg. uses `quilt_rails`), you can run the node server in a separate terminal window with:
+`bin/rails sewing_kit:server:start`
+
 Note:
 
 - Code changes will not be automatically recompiled in this state
@@ -176,3 +185,15 @@ SewingKit.configure do |config|
  config.log_level = :warn # may be `:inherit`, `:debug`, `:info`, `:warn`, or `:error`
 end
 ```
+
+### How do I run sewing-kit in debug mode?
+
+You can launch sewing-kit in debug mode by setting the `SK_DEBUG` environment flag.
+
+```bash
+$ SK_DEBUG=1 dev run
+```
+
+This runs your rails app with the sewing-kit development server in debug mode. This is useful for when you want to debug sewing-kit from a rails app.
+
+Tip: Install the [Node.js V8 --inspector Manager (NiM)](https://chrome.google.com/webstore/detail/nodejs-v8-inspector-manag/gnhhdgbaldcilmgcpfddgdbkhjohddkj?hl=en) Chrome extension. This will launch a chrome debugger automatically for you.

data/lib/generators/sewing_kit/USAGE

@@ -0,0 +1,5 @@
+Description:
+    This generator creates a sewing-kit config file.
+
+Example:
+    rails generate sewing_kit:install

data/lib/generators/sewing_kit/install_generator.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module SewingKit
+  class InstallGenerator < Rails::Generators::Base
+    source_root File.expand_path('templates', __dir__)
+
+    desc "This generator creates a sewing-kit config file."
+
+    def initialize(args, *options)
+      @application_name = Rails.application.class.module_parent.to_s.underscore
+      super(args, *options)
+    end
+
+    def create_package_json
+      package_json_path = "package.json"
+
+      copy_file(package_json_path)
+      gsub_file(package_json_path, "\${application_name}", @application_name)
+    end
+
+    def install_js_dependencies
+      say "Installing react and types dependencies"
+      system("yarn add @shopify/sewing-kit") unless Rails.env.test?
+    end
+
+    def create_sk_config
+      sk_config_path = "config/sewing-kit.config.ts"
+
+      copy_file("sewing-kit.config.ts", sk_config_path)
+      gsub_file(sk_config_path, "\${application_name}", @application_name)
+    end
+
+    def create_config_files
+      copy_file("editorconfig", ".editorconfig")
+      copy_file("eslintignore", ".eslintignore")
+      copy_file("prettierignore", ".prettierignore")
+    end
+  end
+end

data/lib/generators/sewing_kit/templates/editorconfig

@@ -0,0 +1,15 @@
+# editorconfig.org
+root = true
+
+[*]
+charset = utf-8
+indent_size = 2
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+# Markdown syntax specifies that trailing whitespaces can be meaningful,
+# so let’s not trim those. e.g. 2 trailing spaces = linebreak (<br />)
+# See https://daringfireball.net/projects/markdown/syntax#p
+[*.md]
+trim_trailing_whitespace = false

data/lib/generators/sewing_kit/templates/eslintignore

@@ -0,0 +1,2 @@
+node_modules
+build

data/lib/generators/sewing_kit/templates/package.json

@@ -0,0 +1,31 @@
+{
+  "name": "${application_name}",
+  "private": true,
+  "sideEffects": false,
+  "scripts": {
+    "dev": "sewing-kit dev",
+    "check": "sewing-kit check",
+    "lint": "sewing-kit lint",
+    "type-check": "sewing-kit type-check",
+    "nuke": "sewing-kit nuke",
+    "test": "sewing-kit test"
+  },
+  "eslintConfig": {
+    "extends": [
+      "plugin:@shopify/typescript",
+      "plugin:@shopify/react",
+      "plugin:@shopify/prettier",
+      "plugin:@shopify/jest",
+      "plugin:@shopify/polaris"
+    ]
+  },
+  "prettier": "@shopify/prettier-config",
+  "stylelint": {
+    "extends": [
+      "@shopify/stylelint-plugin/prettier"
+    ]
+  },
+  "resolutions": {
+    "babel-plugin-dynamic-import-node": "2.3.0"
+  }
+}

data/lib/generators/sewing_kit/templates/prettierignore

@@ -0,0 +1,7 @@
+package.json
+.sewing-kit
+.dev
+node_modules
+tmp
+public
+*.svg

data/lib/generators/sewing_kit/templates/sewing-kit.config.ts

@@ -0,0 +1,11 @@
+/* eslint-env node */
+
+import {Plugins, Env} from '@shopify/sewing-kit';
+
+export default function sewingKitConfig(plugins: Plugins, env: Env) {
+  return {
+    name: '${application_name}',
+    // remove cdn plugin when using dev
+    plugins: [plugins.cdn(env.isDevelopment ? 'http://localhost:8080/webpack/assets/' : undefined)],
+  };
+}

data/lib/sewing_kit/railtie.rb

@@ -1,18 +1,11 @@
 # frozen_string_literal: true
 require 'rails'
 require 'rails/railtie'
-begin
-  # Force assets:precompile to be defined before sewing_kit's railtie tries to
-  # extend it.
-  require "sprockets/railtie" if defined? Rails
-# rubocop:disable Lint/HandleExceptions
-rescue
-  #
-end
-# rubocop:enable Lint/HandleExceptions
+
 require 'sewing_kit/webpack/compiler'
 require 'sewing_kit/webpack/helper'
 require 'sewing_kit/webpack/dev'
+require 'sewing_kit/webpack/server'
 
 module SewingKit
   class Railtie < ::Rails::Railtie

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.114.2"
+  VERSION = "0.125.0"
 end

data/lib/sewing_kit/webpack/compiler.rb

@@ -22,7 +22,7 @@ module SewingKit
         raise NodeSewingKitNotRunnable, node_env unless File.exist?('node_modules/.bin/sewing-kit')
 
         result = Kernel.system(
-          { 'NODE_ENV' => node_env },
+          environment,
           *command,
           chdir: Rails.root.to_s,
           out: $stdout,
@@ -47,6 +47,18 @@ module SewingKit
         ].concat(options).reject(&:empty?)
       end
 
+      def environment
+        environment = {
+          'NODE_ENV' => node_env,
+        }
+
+        if defined?(ShopifyCloud)
+          environment['SK_ASSET_DIR'] = ShopifyCloud::AssetUploader.asset_directory
+        end
+
+        environment
+      end
+
       def node_env
         ENV['NODE_ENV'] || Rails.env.to_s
       end

data/lib/sewing_kit/webpack/server.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module SewingKit
+  module Webpack
+    class Server
+      class DefaultEntrypointMissing < StandardError
+        def initialize
+          super(
+            "Default entrypoint build/server/main.js is missing."
+          )
+        end
+      end
+
+      def start
+        raise DefaultEntrypointMissing unless File.exist?(default_entrypoint)
+
+        result = Kernel.system(
+          {},
+          *command,
+          chdir: Rails.root.to_s,
+          out: $stdout,
+          err: $stderr
+        )
+
+        unless result
+          puts "sewing_kit:server:start failed"
+          exit(1)
+        end
+
+        result
+      end
+
+      private
+
+      def command
+        command_list = [
+          'node',
+          default_entrypoint,
+        ].compact
+
+        command_list.join(' ')
+      end
+
+      def default_entrypoint
+        'build/server/main.js'
+      end
+    end
+  end
+end

data/lib/sewing_kit/webpack/webpack.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-def highlight(message)
-  "\u001b[1m\u001b[37m#{message}\u001b[39m\u001b[22m"
-end
-
 module SewingKit
   module Webpack
     # Raised if the node sewing-kit isn't installed/runnable.
@@ -24,6 +20,10 @@ module SewingKit
           (cause ? "Original error #{cause}" : '')
         )
       end
+
+      def highlight(message)
+        "\u001b[1m\u001b[37m#{message}\u001b[39m\u001b[22m"
+      end
     end
   end
 end

data/lib/tasks/sewing_kit.rake

@@ -12,10 +12,20 @@ namespace :sewing_kit do
     compiler = SewingKit::Webpack::Compiler.new
     compiler.compile
   end
+
+  namespace :server do
+    desc "Starts the production server"
+    task start: :environment do
+      server = SewingKit::Webpack::Server.new
+      server.start
+    end
+  end
 end
 
-if Rake::Task.task_defined?('assets:precompile')
-  Rake::Task['assets:precompile'].enhance do
+if Rake::Task.task_defined?("assets:precompile")
+  Rake::Task["assets:precompile"].enhance do
     Rake::Task['sewing_kit:build'].invoke
   end
+else
+  Rake::Task.define_task("assets:precompile" => %w(sewing_kit:build))
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.114.2
+  version: 0.125.0
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-28 00:00:00.000000000 Z
+date: 2020-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -102,6 +102,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - README.md
+- lib/generators/sewing_kit/USAGE
+- lib/generators/sewing_kit/install_generator.rb
+- lib/generators/sewing_kit/templates/editorconfig
+- lib/generators/sewing_kit/templates/eslintignore
+- lib/generators/sewing_kit/templates/package.json
+- lib/generators/sewing_kit/templates/prettierignore
+- lib/generators/sewing_kit/templates/sewing-kit.config.ts
 - lib/hacks/user_agent_parser.rb
 - lib/sewing_kit.rb
 - lib/sewing_kit/configuration.rb
@@ -116,6 +123,7 @@ files:
 - lib/sewing_kit/webpack/manifest/development.rb
 - lib/sewing_kit/webpack/manifest/production.rb
 - lib/sewing_kit/webpack/manifest/test_with_no_assets.rb
+- lib/sewing_kit/webpack/server.rb
 - lib/sewing_kit/webpack/webpack.rb
 - lib/tasks/sewing_kit.rake
 homepage: https://github.com/Shopify/sewing-kit/tree/master/gems/sewing_kit
@@ -123,6 +131,7 @@ licenses:
 - MIT
 metadata:
   changelog_uri: https://github.com/Shopify/sewing-kit/blob/master/gems/sewing_kit/CHANGELOG.md
+  allowed_push_host: https://rubygems.org
 post_install_message: 
 rdoc_options: []
 require_paths: