sevencop 0.9.3 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d3ab099568a85aea228ce2fcf282f4e0bc7a2e2c6f3315191c2e9e14367a173
-  data.tar.gz: aeba9572d3eeb74d5d4da5473b30b62d291b0e01d8f5644f041ca41ecd43994f
+  metadata.gz: '0977a1a38e5da28e989cde731824234e1a8aaa2f926cf416d31c4acbe9fb4a3d'
+  data.tar.gz: 3bbf77f3ad02d92ed82ca989908deb42cbced1e8ff7b9cd830a8a3b4b46c40e2
 SHA512:
-  metadata.gz: 643b778e5c44256e590b1a7344825f46c1057a18d3e424076583b522a21f957ca1acf37e2ba6f59d58b72a66e929e2aada551c627cf039d065dbea2646d4e485
-  data.tar.gz: 723e43f5d54dab22c1be3d02bb1074d6899783aec74c64c1fa6ead9294b01ffde02d5aae1b1792e483082d5d297f784de393a20285d34a303e892febc2522ae6
+  metadata.gz: 327acfe1f5b8d48ec9d11f369e32287b13972efdbe69c7e85f7f7a0ea7dfb520c5ac6d1be803e0b727bff6de6e231096d35c5b6a8e516aa0b3dfd98f1aec0eac
+  data.tar.gz: 6eb86ca1c5caa944ad099e556dcbc5d881b8c8be7c63e1d4bd6cccbc14d5fdfadfd4808e03c8461726f5f9e1ba97e0dcc247f0c34874eb8dc01152f6243ad14f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.9.3)
+    sevencop (0.11.0)
       rubocop
 
 GEM

data/README.md

@@ -67,6 +67,25 @@ belongs_to :group, options
 
 This is useful for migration of `config.active_record.belongs_to_required_by_default`.
 
+### Sevencop/FactoryBotCreateList
+
+Finds possible substitutions for `FactoryBot.create_list`.
+
+```ruby
+# bad
+Array.new(2) do
+  create(:user)
+end
+
+# good
+create_list(:user, 2)
+
+# good
+Array.new(2) do |i|
+  create(:user, order: i)
+end
+```
+
 ### Sevencop/HashLiteralOrder
 
 Sort Hash literal entries by key.
@@ -105,6 +124,26 @@ RSpec.describe User
 RSpec.describe User, type: :request
 ```
 
+### Sevencop/MethodDefinitionMultilineArguments
+
+Inserts new lines between method definition parameters.
+
+```ruby
+# bad
+def foo(a, b)
+end
+
+# good
+def foo(
+  a,
+  b
+)
+
+# good
+def foo(a)
+end
+```
+
 ### Sevencop/OrderField
 
 Identifies a String including "field" is passed to `order` or `reorder`.

data/config/default.yml

@@ -5,6 +5,12 @@ Sevencop/BelongsToOptional:
   Safe: false
   VersionAdded: '0.5'
 
+Sevencop/FactoryBotCreateList:
+  Description: |
+    Finds possible substitutions for `FactoryBot.create_list`.
+  Enabled: false
+  VersionAdded: '0.10'
+
 Sevencop/HashLiteralOrder:
   Description: |
     Sort Hash literal entries by key.
@@ -17,6 +23,12 @@ Sevencop/InferredSpecType:
   Enabled: false
   VersionAdded: '0.9'
 
+Sevencop/MethodDefinitionMultilineArguments:
+  Description: |
+    Inserts new lines between method definition parameters.
+  Enabled: false
+  VersionAdded: '0.11'
+
 Sevencop/OrderField:
   Description: |
     Wrap safe SQL String by `Arel.sql`.

data/lib/rubocop/cop/sevencop/factory_bot_create_list.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Finds possible substitutions for `FactoryBot.create_list`.
+      #
+      # @example
+      #
+      #   # bad
+      #   Array.new(2) do
+      #     create(:user)
+      #   end
+      #
+      #   # good
+      #   create_list(:user, 2)
+      #
+      #   # good
+      #   Array.new(2) do |i|
+      #     create(:user, order: i)
+      #   end
+      #
+      # @note
+      #   This cop does not support `Integer#times` intentionally because it
+      #   should be treated by `Performance/TimesMap` cop.
+      #
+      class FactoryBotCreateList < Base
+        extend AutoCorrector
+
+        MSG = 'Use `create_list` instead.'
+
+        # @param node [RuboCop::AST::BlockNode]
+        # @return [void]
+        def on_block(node)
+          count_node, factory_name_node, extra_argument_nodes = extract(node)
+          return unless count_node
+
+          add_offense(node) do |corrector|
+            corrector.replace(
+              node,
+              format(
+                'create_list(%<arguments>s)',
+                arguments: [
+                  factory_name_node,
+                  count_node,
+                  *extra_argument_nodes
+                ].map(&:source).join(', ')
+              )
+            )
+          end
+        end
+
+        private
+
+        # @!method extract(node)
+        #   @param node [RuboCop::AST::BlockNode]
+        #   @return [Array(Integer, RuboCop::AST::SendNode)]
+        def_node_matcher :extract, <<~PATTERN
+          (block
+            (send
+              (const {nil? | cbase} :Array)
+              :new
+              $(int _)
+            )
+            (args)
+            (send
+              nil?
+              :create
+              $(sym _) $(...)?
+            )
+          )
+        PATTERN
+
+        # @param corrector [RuboCop::Cop::Corrector]
+        # @param node [RuboCop::AST::BlockNode]
+        # @return [void]
+        def autocorrect(corrector, node)
+          count_node, factory_name_node, extra_argument_nodes = extract(node)
+          corrector.replace(
+            node,
+            format(
+              'create_list(%<arguments>s)',
+              arguments: [
+                factory_name_node,
+                count_node,
+                *extra_argument_nodes
+              ].map(&:source).join(', ')
+            )
+          )
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sevencop/method_definition_multiline_arguments.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Inserts new lines between method definition parameters.
+      #
+      # @example
+      #   # bad
+      #   def foo(a, b)
+      #   end
+      #
+      #   # good
+      #   def foo(
+      #     a,
+      #     b
+      #   )
+      #
+      #   # good
+      #   def foo(a)
+      #   end
+      class MethodDefinitionMultilineArguments < Base
+        extend AutoCorrector
+
+        MSG = 'Insert new lines between method definition parameters.'
+
+        # @param node [RuboCop::AST::ArgsNode]
+        def on_args(node)
+          return if method_args?(node) && multilined?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        private
+
+        # @param corrector [RuboCop::AST::Corrector]
+        # @param node [RuboCop::AST::ArgsNode]
+        # @return [String]
+        def autocorrect(corrector, node)
+          indent = ' ' * node.parent.location.expression.column
+
+          corrector.replace(
+            node.location.expression.with(
+              begin_pos: node.parent.location.name.end_pos
+            ),
+            [
+              "(\n#{indent}  ",
+              node.children.map(&:source).join(",\n#{indent}  "),
+              "\n#{indent})"
+            ].join
+          )
+        end
+
+        # @param node [RuboCop::AST::ArgsNode]
+        # @return [Boolean]
+        def multilined?(node)
+          node.children.map do |child|
+            child.location.expression.line
+          end.uniq.length == node.children.length
+        end
+
+        # @return [Boolean]
+        def method_args?(node)
+          !node.parent.nil? && node.parent.def_type?
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.9.3'
+  VERSION = '0.11.0'
 end

data/lib/sevencop.rb

@@ -1,14 +1,13 @@
 # frozen_string_literal: true
 
-require 'pathname'
-require 'yaml'
-
 require_relative 'sevencop/rubocop_extension'
 require_relative 'sevencop/version'
 
 require_relative 'rubocop/cop/sevencop/belongs_to_optional'
+require_relative 'rubocop/cop/sevencop/factory_bot_create_list'
 require_relative 'rubocop/cop/sevencop/hash_literal_order'
 require_relative 'rubocop/cop/sevencop/inferred_spec_type'
+require_relative 'rubocop/cop/sevencop/method_definition_multiline_arguments'
 require_relative 'rubocop/cop/sevencop/order_field'
 require_relative 'rubocop/cop/sevencop/redundant_existence_check'
 require_relative 'rubocop/cop/sevencop/to_s_with_argument'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.11.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-27 00:00:00.000000000 Z
+date: 2022-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -42,8 +42,10 @@ files:
 - Rakefile
 - config/default.yml
 - lib/rubocop/cop/sevencop/belongs_to_optional.rb
+- lib/rubocop/cop/sevencop/factory_bot_create_list.rb
 - lib/rubocop/cop/sevencop/hash_literal_order.rb
 - lib/rubocop/cop/sevencop/inferred_spec_type.rb
+- lib/rubocop/cop/sevencop/method_definition_multiline_arguments.rb
 - lib/rubocop/cop/sevencop/order_field.rb
 - lib/rubocop/cop/sevencop/redundant_existence_check.rb
 - lib/rubocop/cop/sevencop/to_s_with_argument.rb