sevencop 0.42.0 → 0.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3948e119b6a873e0226f93921268a1120b1c0bd8067c6dd2eedf80cd449db92d
-  data.tar.gz: bd864bf33c85003b21ac7a14dd88bfb581f383edc3f1b072d1b59f4b14739e9d
+  metadata.gz: 27ef12a9d73af780d2df174d7f5e76a7c882a364310a90de25a5b74a7f805c89
+  data.tar.gz: 41b9ec3b0ba6639bd6b12b60da6d70cd7c7ded19f35bb1d97527ec98ecdaeca3
 SHA512:
-  metadata.gz: c25ad4ee15137b961661fc5ec92a3e930116c53fd19c01d28a5886448668c0307d30448b990367f3890d2bfc2f4c2aaafc4b1e5f9fb8143b8c54822071d5005e
-  data.tar.gz: 2815ccf2f38067606967043985d1aa898c3220694a20098fc3e28fdb7ca5faa9456363579a69a5bc7decf4c3e61fe571ea4579f7115bcf71864194636fd5c4e0
+  metadata.gz: f96546be70eefad0cc889efdf726aabd3417db9e3e29af83e2961f8066bff6cfa1974b6f058c2c96a9366a6e7309441c34139cc50f716fd05ee92fc6673ffdde
+  data.tar.gz: 278fbde7bc95f4a592f5e249aafb16f22874b75961e85336d814dd4726f446165058682ac3acfb9318add398841c1a81e6bdbb47a3024ee76bc53721ab3420a9

data/.rubocop.yml

@@ -42,6 +42,7 @@ RSpec/FilePath:
     RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
+    RSpecRailsStatusCodeCheckBySubject: rspec_rails_status_code_check_by_subject
 
 RSpec/MultipleExpectations:
   Enabled: false
@@ -54,6 +55,7 @@ RSpec/SpecFilePathFormat:
     RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
+    RSpecRailsStatusCodeCheckBySubject: rspec_rails_status_code_check_by_subject
 
 Sevencop/AutoloadOrdered:
   Enabled: true

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    sevencop (0.42.0)
+    sevencop (0.43.0)
       activesupport
       rubocop
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3.2)
+    activesupport (7.1.3.3)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -29,7 +29,7 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.22.3)
+    minitest (5.23.1)
     mutex_m (0.2.0)
     parallel (1.24.0)
     parser (3.3.0.5)

data/README.md

@@ -50,6 +50,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecMatcherConsistentParentheses](lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
 - [Sevencop/RSpecRailsHaveHttpStatus](lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb)
+- [Sevencop/RSpecRailsStatusCodeCheckBySubject](lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb)
 
 ## Notes
 

data/config/default.yml

@@ -67,12 +67,16 @@ Sevencop/RailsRouteAs:
   Description: |
     Always use `as` option on routing methods.
   Enabled: false
+  Include:
+    - config/routes.rb
 
 Sevencop/RailsRouteOrdered:
   Description: |
     Sort routes by path and HTTP method.
   Enabled: false
   Safe: false
+  Include:
+    - config/routes.rb
 
 Sevencop/RailsSpecificActionName:
   Description: |
@@ -145,3 +149,11 @@ Sevencop/RSpecRailsHaveHttpStatus:
   Include:
     - "**/spec/controllers/**/*.rb"
     - "**/spec/requests/**/*.rb"
+
+Sevencop/RSpecRailsStatusCodeCheckBySubject:
+  Description: |
+    Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.
+  Enabled: false
+  Include:
+    - "**/spec/controllers/**/*.rb"
+    - "**/spec/requests/**/*.rb"

data/lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.
+      #
+      # @example
+      #   # bad
+      #   is_expected.to eq(200)
+      #
+      #   # good
+      #   expect(response).to have_http_status(200)
+      #
+      #   # bad
+      #   is_expected.to eq(:ok)
+      #
+      #   # good
+      #   expect(response).to have_http_status(:ok)
+      class RSpecRailsStatusCodeCheckBySubject < Base
+        extend AutoCorrector
+
+        MSG = 'Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.'
+
+        RESTRICT_ON_SEND = %i[
+          to
+        ].freeze
+
+        # @param [RuboCop::AST::SendNode] node
+        # @return [void]
+        def on_send(node)
+          return unless is_expected_to_eq_code?(node)
+
+          add_offense(node) do |corrector|
+            corrector.insert_before(node, "subject\n")
+            corrector.replace(node.receiver, 'expect(response)')
+            corrector.replace(node.first_argument.location.selector, 'have_http_status')
+          end
+        end
+
+        private
+
+        # @!method is_expected_to_eq_code?(node)
+        #   @param [RuboCop::AST::SendNode] node
+        #   @return [Boolean]
+        def_node_matcher :is_expected_to_eq_code?, <<~PATTERN
+          (send (send nil? :is_expected) :to (send nil? :eq {int sym}))
+        PATTERN
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.42.0'
+  VERSION = '0.43.0'
 end

data/lib/sevencop.rb

@@ -26,3 +26,4 @@ require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
 require_relative 'rubocop/cop/sevencop/rspec_matcher_consistent_parentheses'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
 require_relative 'rubocop/cop/sevencop/rspec_rails_have_http_status'
+require_relative 'rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.42.0
+  version: 0.43.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-05-13 00:00:00.000000000 Z
+date: 2024-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,6 +78,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
 - lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb
+- lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb