sevencop 0.38.0 → 0.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9dc6aed08986989bb0d31d172c6c08426a9581f2aac31c85a9730ba4ba2f5ea8
-  data.tar.gz: 62a2bdf5a54bf07578bcb40c6accb56075f85ff6ff56a45435efde1836413e42
+  metadata.gz: 01427c343e05de1b3f41b169f44ab8e7343cbff90b7d843281f5b2a8f9ea1485
+  data.tar.gz: b5ba91998a6cd7f993c44205d553227e5f146c51bafe73cd0210b7a4a90dbb52
 SHA512:
-  metadata.gz: 236dab0fff5322449648b6a99223b5800d2d9444bcaf02f0e69b1cee63c2fb0fb91b3ad792407c9ef8a79cac502e3099f460955f01e93c7da412291214e44cb6
-  data.tar.gz: 4066d32b53e2618e2d3e138742ba0b23652c266561b36ba34670519401f4d823654a0f25f4d06b3dc3f38345cb960d69bed51e37d2025b31624d0f34d89a2675
+  metadata.gz: ff51acef6e03fcb4da1d5e53802150e055f8066270e742691920a66f42b3245d62689fe76c680930d53a1361741733132653ce1f134cc1ecbcbc9185367f92f8
+  data.tar.gz: 20dc6769ffeb7b03dc262aa720120d2b1f35de0c61b8617dafbdc7d54f8b25085118b3b01d97630525064befc99126be4d8224474a28d7c888a830e9ff5f3986

data/.rubocop.yml

@@ -39,6 +39,7 @@ RSpec/FilePath:
     RSpecDescribeHttpEndpoint: rspec_describe_http_endpoint
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
+    RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
 
@@ -50,6 +51,7 @@ RSpec/SpecFilePathFormat:
     RSpecDescribeHttpEndpoint: rspec_describe_http_endpoint
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
+    RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
 

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    sevencop (0.38.0)
+    sevencop (0.40.0)
       activesupport
       rubocop
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3)
+    activesupport (7.1.3.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -20,17 +20,16 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.6)
+    bigdecimal (3.1.8)
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     diff-lcs (1.5.0)
-    drb (2.2.0)
-      ruby2_keywords
-    i18n (1.14.1)
+    drb (2.2.1)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.22.2)
+    minitest (5.22.3)
     mutex_m (0.2.0)
     parallel (1.24.0)
     parser (3.3.0.5)
@@ -81,7 +80,6 @@ GEM
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
-    ruby2_keywords (0.0.5)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)

data/README.md

@@ -47,6 +47,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecDescribeHttpEndpoint](lib/rubocop/cop/sevencop/rspec_describe_http_endpoint.rb)
 - [Sevencop/RSpecEmptyLineAfterLet](lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb)
 - [Sevencop/RSpecExamplesInSameGroup](lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb)
+- [Sevencop/RSpecMatcherConsistentParentheses](lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
 - [Sevencop/RSpecRailsHaveHttpStatus](lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb)
 

data/config/default.yml

@@ -137,6 +137,13 @@ Sevencop/RSpecExamplesInSameGroup:
     - "**/spec/controllers/**/*.rb"
     - "**/spec/requests/**/*.rb"
 
+Sevencop/RSpecMatcherConsistentParentheses:
+  Description: |
+    Keep RSpec matcher parentheses style consistent.
+  Enabled: false
+  Include:
+    - "**/spec/**/*.rb"
+
 Sevencop/RSpecMemoizedHelperBlockDelimiter:
   Description: |
     Use do-end block delimiter on RSpec memoized helper.

data/lib/rubocop/cop/sevencop/rspec_describe_http_endpoint.rb

@@ -27,6 +27,7 @@ module RuboCop
         SUPPORTED_HTTP_METHODS = %w[
           DELETE
           GET
+          HEAD
           PATCH
           POST
           PUT

data/lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Keep RSpec matcher parentheses style consistent.
+      #
+      # @example
+      #   # bad
+      #   is_expected.to eq 1
+      #
+      #   # good
+      #   is_expected.to eq(1)
+      class RSpecMatcherConsistentParentheses < Base
+        extend AutoCorrector
+
+        MSG = 'Keep matcher parentheses style consistent.'
+
+        RESTRICT_ON_SEND = %i[to].freeze
+
+        # @param [RuboCop::AST::SendNode] node
+        # @return [void]
+        def on_send(node)
+          return unless to?(node)
+
+          first_argument = node.first_argument
+          return unless inconsistent?(first_argument)
+
+          add_offense(first_argument) do |corrector|
+            add_parentheses(first_argument, corrector)
+          end
+        end
+
+        private
+
+        # @!method expectation?(node)
+        #   @param [RuboCop::AST::SendNode] node
+        #   @return [Boolean]
+        def_node_matcher :expectation?, <<~PATTERN
+          (send nil? { :is_expected :expect } ...)
+        PATTERN
+
+        # @param [RuboCop::AST::Node, nil] node
+        # @return [Boolean]
+        def inconsistent?(node)
+          node.send_type? && missing_parentheses?(node)
+        end
+
+        # @param [RuboCop::AST::SendNode] node
+        # @return [Boolean]
+        def missing_parentheses?(node)
+          !node.arguments.empty? &&
+            !node.operator_method? &&
+            !node.parenthesized?
+        end
+
+        # @param [RuboCop::AST::SendNode] node
+        # @return [Boolean]
+        def to?(node)
+          expectation?(node.receiver)
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.38.0'
+  VERSION = '0.40.0'
 end

data/lib/sevencop.rb

@@ -23,5 +23,6 @@ require_relative 'rubocop/cop/sevencop/rails_where_not'
 require_relative 'rubocop/cop/sevencop/rspec_describe_http_endpoint'
 require_relative 'rubocop/cop/sevencop/rspec_empty_line_after_let'
 require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
+require_relative 'rubocop/cop/sevencop/rspec_matcher_consistent_parentheses'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
 require_relative 'rubocop/cop/sevencop/rspec_rails_have_http_status'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.38.0
+  version: 0.40.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-19 00:00:00.000000000 Z
+date: 2024-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -75,6 +75,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_describe_http_endpoint.rb
 - lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb
 - lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb
+- lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
 - lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb
 - lib/sevencop.rb
@@ -106,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: Opinionated custom cops for RuboCop.