sevencop 0.36.0 → 0.38.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41302972abfb2a785a3a9fcffb8b9b229d34d8182125f75cc34062720ef7262c
-  data.tar.gz: ac07370e67a54572895b3d49c5992da0521aa474de7e9e47d3b998a740b9f087
+  metadata.gz: 9dc6aed08986989bb0d31d172c6c08426a9581f2aac31c85a9730ba4ba2f5ea8
+  data.tar.gz: 62a2bdf5a54bf07578bcb40c6accb56075f85ff6ff56a45435efde1836413e42
 SHA512:
-  metadata.gz: 05fccfbdc29de4b5f0dda00caa7a30528068e98e665ba6ace777d1531c968dedce672c429226b4c0c5c167d986b0fcfb9ead8d7244ea359abd27b1edc8d15b3b
-  data.tar.gz: 07a7d923cc6f06c0b9df3ede1de081b23ea116d1bba328faf9529fe6b2174d691ab1c99ea3f6eaa175d8e762e7b61b2c1dc34457cbe5d6ace012b58a0be83066
+  metadata.gz: 236dab0fff5322449648b6a99223b5800d2d9444bcaf02f0e69b1cee63c2fb0fb91b3ad792407c9ef8a79cac502e3099f460955f01e93c7da412291214e44cb6
+  data.tar.gz: 4066d32b53e2618e2d3e138742ba0b23652c266561b36ba34670519401f4d823654a0f25f4d06b3dc3f38345cb960d69bed51e37d2025b31624d0f34d89a2675

data/.rubocop.yml

@@ -19,6 +19,7 @@ Layout/LineLength:
 Lint/UselessAccessModifier:
   MethodCreatingMethods:
     - def_node_matcher
+    - def_node_search
 
 Metrics:
   Enabled: false
@@ -39,6 +40,7 @@ RSpec/FilePath:
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
+    RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
 
 RSpec/MultipleExpectations:
   Enabled: false
@@ -49,6 +51,7 @@ RSpec/SpecFilePathFormat:
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
+    RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
 
 Sevencop/AutoloadOrdered:
   Enabled: true

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.36.0)
+    sevencop (0.38.0)
       activesupport
       rubocop
 
@@ -30,7 +30,7 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.21.2)
+    minitest (5.22.2)
     mutex_m (0.2.0)
     parallel (1.24.0)
     parser (3.3.0.5)

data/README.md

@@ -48,6 +48,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecEmptyLineAfterLet](lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb)
 - [Sevencop/RSpecExamplesInSameGroup](lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
+- [Sevencop/RSpecRailsHaveHttpStatus](lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb)
 
 ## Notes
 

data/config/default.yml

@@ -24,12 +24,9 @@ Sevencop/FactoryBotAssociationStyle:
   NonImplicitAssociationMethodNames:
     - skip_create
   Include:
-    - factories.rb
-    - factories/*.rb
-    - spec/factories.rb
-    - spec/factories/*.rb
-    - test/factories.rb
-    - test/factories/*.rb
+    - "**/factories.rb"
+    - "**/spec/factories/*.rb"
+    - "**/test/factories/*.rb"
 
 Sevencop/HashElementOrdered:
   Description: |
@@ -103,7 +100,7 @@ Sevencop/RailsSpecificActionName:
     - show
     - update
   Include:
-    - app/controllers/**/*.rb
+    - "**/app/controllers/**/*.rb"
 
 Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity:
   Description: |
@@ -122,14 +119,14 @@ Sevencop/RSpecDescribeHttpEndpoint:
     Pass HTTP endpoint identifier (e.g. `GET /users`) to top-level `describe` on request-specs.
   Enabled: false
   Include:
-    - spec/requests/**/*.rb
+    - "**/spec/requests/**/*.rb"
 
 Sevencop/RSpecEmptyLineAfterLet:
   Description: |
     Insert empty line after `let`.
   Enabled: false
   Include:
-    - spec/**/*
+    - "**/spec/**/*.rb"
 
 Sevencop/RSpecExamplesInSameGroup:
   Description: |
@@ -137,12 +134,20 @@ Sevencop/RSpecExamplesInSameGroup:
   Enabled: false
   IncludeSharedExamples: false
   Include:
-    - spec/controllers/**/*
-    - spec/requests/**/*
+    - "**/spec/controllers/**/*.rb"
+    - "**/spec/requests/**/*.rb"
 
 Sevencop/RSpecMemoizedHelperBlockDelimiter:
   Description: |
     Use do-end block delimiter on RSpec memoized helper.
   Enabled: false
   Include:
-    - spec/**/*
+    - "**/spec/**/*.rb"
+
+Sevencop/RSpecRailsHaveHttpStatus:
+  Description: |
+    Always check status code with `have_http_status`.
+  Enabled: false
+  Include:
+    - "**/spec/controllers/**/*.rb"
+    - "**/spec/requests/**/*.rb"

data/lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Always check status code with `have_http_status`.
+      #
+      # @example
+      #   # bad
+      #   it 'creates a new post' do
+      #     expect { subject }.to change(Post, :count).by(1)
+      #   end
+      #
+      #   # good
+      #   it 'creates a new post' do
+      #     expect { subject }.to change(Post, :count).by(1)
+      #     expect(response).to have_http_status(200)
+      #   end
+      #
+      #   # good
+      #   it 'creates a new post' do
+      #     expect { subject }.to change(Post, :count).by(1)
+      #     expect(response).to redirect_to(posts_path)
+      #   end
+      class RSpecRailsHaveHttpStatus < Base
+        MSG = 'Always check status code with `have_http_status`.'
+
+        EXAMPLE_METHOD_NAMES = %i[
+          example
+          it
+          specify
+        ].to_set.freeze
+
+        STATUS_CHECK_METHOD_NAMES = %i[
+          have_http_status
+          redirect_to
+        ].to_set.freeze
+
+        # @param [RuboCop::AST::BlockNode] node
+        # @return [void]
+        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
+          return unless example_method?(node)
+          return if including_status_check_method?(node)
+
+          add_offense(node)
+        end
+
+        private
+
+        # @!method example_method?(node)
+        #   @param [RuboCop::AST::BlockNode] node
+        #   @return [Boolean]
+        def_node_matcher :example_method?, <<~PATTERN
+          (block (send nil? EXAMPLE_METHOD_NAMES ...) ...)
+        PATTERN
+
+        # @!method including_status_check_method?(node)
+        #   @param [RuboCop::AST::BlockNode] node
+        #   @return [Boolean]
+        def_node_search :including_status_check_method?, <<~PATTERN
+          (send nil? STATUS_CHECK_METHOD_NAMES ...)
+        PATTERN
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.36.0'
+  VERSION = '0.38.0'
 end

data/lib/sevencop.rb

@@ -24,3 +24,4 @@ require_relative 'rubocop/cop/sevencop/rspec_describe_http_endpoint'
 require_relative 'rubocop/cop/sevencop/rspec_empty_line_after_let'
 require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
+require_relative 'rubocop/cop/sevencop/rspec_rails_have_http_status'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.38.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-27 00:00:00.000000000 Z
+date: 2024-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -76,6 +76,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb
 - lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
+- lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb