sevencop 0.29.1 → 0.31.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df805d1a45b205a9edf69411d7900ee8896d7d36da95bb608e0f1d45750d2441
-  data.tar.gz: f8318114a6fc158134f381e39a4b095957343ea35db94f86639b702a35ead7c1
+  metadata.gz: ee749fe11f72d661269fa08344e0b5f578a21517375a75d58f5c2bab1877fdcd
+  data.tar.gz: 15a392c82cc473f1a5c327e2b1a6f0e1620d3b8e405aa6e548b020559bd24afd
 SHA512:
-  metadata.gz: 2aa56f5b6fc473ce25c3758e754dd98bd5ca635c3984fd8b6af1347821bdd7fc5b3bfd213a57db0866b96b4a5a3464cd5097b253782dc30c05471ca09afed09c
-  data.tar.gz: d16d7cf8fe6cff81a82277a140ef6738a9089072afea4163d96d839bf3ec6f62848a5c061b7226b927cfd5da1d01c9318d216fc262271c1371886c657190c2fb
+  metadata.gz: 9c2ea95803821697a72157ab0608459b44467cb2ec868ba66dc21f2613f7ac4eb52745d69d19d5ea43dff6fb40e70ebc2b59110a7bd58ff9ece189b401532c74
+  data.tar.gz: f3e26944c43c61b5ccf1f0875117ce77aba7b1ca8f223e5b174ea7a2d4737407b949bc1e362aa1363ee350106b60dc1852ee89af55b5953393b5d7dec432c8d2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.29.1)
+    sevencop (0.31.0)
       activesupport
       rubocop
 

data/README.md

@@ -29,6 +29,7 @@ Note that all cops are `Enabled: false` by default.
 ## Cops
 
 - [Sevencop/AutoloadOrdered](lib/rubocop/cop/sevencop/autoload_ordered.rb)
+- [Sevencop/ConstantBase](lib/rubocop/cop/sevencop/constant_base.rb)
 - [Sevencop/FactoryBotAssociationOption](lib/rubocop/cop/sevencop/factory_bot_association_option.rb)
 - [Sevencop/FactoryBotAssociationStyle](lib/rubocop/cop/sevencop/factory_bot_association_style.rb)
 - [Sevencop/HashElementOrdered](lib/rubocop/cop/sevencop/hash_element_ordered.rb)
@@ -38,7 +39,6 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/MethodDefinitionOrdered](lib/rubocop/cop/sevencop/method_definition_ordered.rb)
 - [Sevencop/RailsBelongsToOptional](lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb)
 - [Sevencop/RailsDateAndTimeCalculation](lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb)
-- [Sevencop/RailsInferredSpecType](lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb)
 - [Sevencop/RailsOrderField](lib/rubocop/cop/sevencop/rails_order_field.rb)
 - [Sevencop/RailsSpecificActionName](lib/rubocop/cop/sevencop/rails_specific_action_name.rb)
 - [Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity](lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb)

data/config/default.yml

@@ -5,6 +5,12 @@ Sevencop/AutoloadOrdered:
   Safe: false
   VersionAdded: '0.12'
 
+Sevencop/ConstantBase:
+  Description: |
+    Remove unnecessary `::` prefix from constant.
+  Enabled: false
+  VersionAdded: '0.31'
+
 Sevencop/FactoryBotAssociationOption:
   Description: |
     Remove redundant options from FactoryBot associations.
@@ -82,13 +88,6 @@ Sevencop/RailsDateAndTimeCalculation:
   Safe: false
   VersionAdded: '0.26'
 
-Sevencop/RailsInferredSpecType:
-  Description: |
-    Identifies redundant spec type.
-  Enabled: false
-  Safe: false
-  VersionAdded: '0.9'
-
 Sevencop/RailsOrderField:
   Description: |
     Wrap safe SQL String by `Arel.sql`.

data/lib/rubocop/cop/sevencop/constant_base.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Remove unnecessary `::` prefix from constant.
+      #
+      # @example
+      #   # bad
+      #   ::Const
+      #
+      #   # good
+      #   Const
+      #
+      #   # bad
+      #   class << self
+      #     ::Const
+      #   end
+      #
+      #   # good
+      #   class << self
+      #     Const
+      #   end
+      #
+      #   # good
+      #   class Klass
+      #     ::Const
+      #   end
+      #
+      #   # good
+      #   class module
+      #     ::Const
+      #   end
+      class ConstantBase < Base
+        extend AutoCorrector
+
+        MSG = 'Remove unnecessary `::` prefix from constant.'
+
+        # @param node [RuboCop::AST::CbaseNode]
+        # @return [void]
+        def on_cbase(node)
+          return unless bad?(node)
+
+          add_offense(node) do |corrector|
+            corrector.remove(node)
+          end
+        end
+
+        private
+
+        # @!method named_class_or_module?(node)
+        #   @param node [RuboCop::AST::Node]
+        #   @return [Boolean]
+        def_node_matcher :named_class_or_module?, <<~PATTERN
+          ({class module} const ...)
+        PATTERN
+
+        # @param node [RuboCop::AST::CbaseNode]
+        # @return [Boolean]
+        def bad?(node)
+          node.each_ancestor(:class, :module).none?
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.29.1'
+  VERSION = '0.31.0'
 end

data/lib/sevencop.rb

@@ -5,6 +5,7 @@ require_relative 'sevencop/rubocop_extension'
 require_relative 'sevencop/version'
 
 require_relative 'rubocop/cop/sevencop/autoload_ordered'
+require_relative 'rubocop/cop/sevencop/constant_base'
 require_relative 'rubocop/cop/sevencop/factory_bot_association_option'
 require_relative 'rubocop/cop/sevencop/factory_bot_association_style'
 require_relative 'rubocop/cop/sevencop/hash_element_ordered'
@@ -14,7 +15,6 @@ require_relative 'rubocop/cop/sevencop/method_definition_keyword_argument_ordere
 require_relative 'rubocop/cop/sevencop/method_definition_ordered'
 require_relative 'rubocop/cop/sevencop/rails_belongs_to_optional'
 require_relative 'rubocop/cop/sevencop/rails_date_and_time_calculation'
-require_relative 'rubocop/cop/sevencop/rails_inferred_spec_type'
 require_relative 'rubocop/cop/sevencop/rails_order_field'
 require_relative 'rubocop/cop/sevencop/rails_specific_action_name'
 require_relative 'rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.29.1
+  version: 0.31.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-11 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -57,6 +57,7 @@ files:
 - config/default.yml
 - data/reserved_words_mysql.txt
 - lib/rubocop/cop/sevencop/autoload_ordered.rb
+- lib/rubocop/cop/sevencop/constant_base.rb
 - lib/rubocop/cop/sevencop/factory_bot_association_option.rb
 - lib/rubocop/cop/sevencop/factory_bot_association_style.rb
 - lib/rubocop/cop/sevencop/hash_element_ordered.rb
@@ -66,7 +67,6 @@ files:
 - lib/rubocop/cop/sevencop/method_definition_ordered.rb
 - lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb
 - lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb
-- lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb
 - lib/rubocop/cop/sevencop/rails_order_field.rb
 - lib/rubocop/cop/sevencop/rails_specific_action_name.rb
 - lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb

data/lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb

@@ -1,125 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Sevencop
-      # Identifies redundant spec type.
-      # This is automatically set by `config.infer_spec_type_from_file_location!`.
-      #
-      # @example
-      #
-      #   # bad
-      #   # spec/models/user_spec.rb
-      #   RSpec.describe User, type: :model
-      #
-      #   # good
-      #   # spec/models/user_spec.rb
-      #   RSpec.describe User
-      #
-      #   # good
-      #   # spec/models/user_spec.rb
-      #   RSpec.describe User, type: :request
-      #
-      class RailsInferredSpecType < Base
-        extend AutoCorrector
-
-        # @return [Array<Hash>]
-        INFERENCES = [
-          { prefix: 'spec/channels/', type: :channel },
-          { prefix: 'spec/controllers/', type: :controller },
-          { prefix: 'spec/features/', type: :feature },
-          { prefix: 'spec/generator/', type: :generator },
-          { prefix: 'spec/helpers/', type: :helper },
-          { prefix: 'spec/jobs/', type: :job },
-          { prefix: 'spec/mailboxes/', type: :mailbox },
-          { prefix: 'spec/mailers/', type: :mailer },
-          { prefix: 'spec/models/', type: :model },
-          { prefix: 'spec/requests/', type: :request },
-          { prefix: 'spec/integration/', type: :request },
-          { prefix: 'spec/api/', type: :request },
-          { prefix: 'spec/routing/', type: :routing },
-          { prefix: 'spec/system/', type: :system },
-          { prefix: 'spec/views/', type: :view }
-        ].freeze
-
-        MSG = 'Remove redundant spec type.'
-
-        RESTRICT_ON_SEND = %i[
-          describe
-        ].freeze
-
-        # @param [RuboCop::AST::SendNode] node
-        def on_send(node)
-          pair_node = describe_with_type(node)
-          return unless pair_node
-          return unless inferred_type?(pair_node)
-
-          removable_node = detect_removable_node(pair_node)
-          add_offense(removable_node) do |corrector|
-            autocorrect(corrector, removable_node)
-          end
-        end
-
-        private
-
-        # @!method describe_with_type(node)
-        #   @param [RuboCop::AST::SendNode] node
-        #   @return [RuboCop::AST::PairNode, nil]
-        def_node_matcher :describe_with_type, <<~PATTERN
-          (send
-            { (const nil? :RSpec) | nil? }
-            _
-            _
-            _*
-            (hash
-              (pair ...)*
-              $(pair (sym :type) sym)
-              (pair ...)*
-            )
-          )
-        PATTERN
-
-        # @param [RuboCop::AST::Corrector] corrector
-        # @param [RuboCop::AST::Node] node
-        def autocorrect(
-          corrector,
-          node
-        )
-          corrector.remove(
-            node.location.expression.with(
-              begin_pos: node.left_sibling.location.expression.end_pos
-            )
-          )
-        end
-
-        # @param [RuboCop::AST::PairNode] node
-        # @return [RuboCop::AST::Node]
-        def detect_removable_node(node)
-          if node.parent.pairs.size == 1
-            node.parent
-          else
-            node
-          end
-        end
-
-        # @return [String]
-        def file_path
-          processed_source.file_path
-        end
-
-        # @param [RuboCop::AST::PairNode] node
-        # @return [Boolean]
-        def inferred_type?(node)
-          inferred_type_from_file_path.inspect == node.value.source
-        end
-
-        # @return [Symbol, nil]
-        def inferred_type_from_file_path
-          INFERENCES.find do |inference|
-            break inference[:type] if file_path.include?(inference[:prefix])
-          end
-        end
-      end
-    end
-  end
-end