sevencop 0.27.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2d0d56a1f5cbd0bc259bf81abbd5f2120f0a79e535ff9fafe6793de262dfb0
-  data.tar.gz: a43deda18fed1e061b3442a4bfb6ed27f7af6b71522adde160fe530326462722
+  metadata.gz: d415f24d882b17eb832c22fa9a17d40ebf1ea91fda15e5a25e8e5ceea6824633
+  data.tar.gz: b770d04a2620d1ef6e5f7a0e0b0cd1e6f440b44a5173bd8c26890f0707a4e9b5
 SHA512:
-  metadata.gz: f4888e9cd333099c4ec83c9d0b71349572ad471f4788efe1d8eee377f10286eb6d5c8534e6bb427ad52303f5fcf24e77fc7f3df9aab9ebc35ac726e0098b940f
-  data.tar.gz: 1cc3e089fa3e922131dd91e4e2c1c7fa6f835a1619bc8c9234f7f86af4e677a0d033583ea8f4eb1cfc3f1da5abc93222eb8506749c616c434350275a18859af0
+  metadata.gz: ddd45cdafff3edc2512a962f32d817cd5836f5435547d987c76f96a0d3a873f8398506dc567caea00ed165f7bd206378bcdbea71eec0516fe05ce7249a2b88e9
+  data.tar.gz: 737bd07f00679aa77fce2209f9692b5babff560362a03c412f228584f74d4cd213bbfc5a1223ed999e3ba66abb3f6f7cd7cfcd1d702ee4fed7f8f80d4940e0a3

data/.rubocop.yml

@@ -16,6 +16,10 @@ Gemspec/RequireMFA:
 Layout/LineLength:
   Enabled: false
 
+Lint/UselessAccessModifier:
+  MethodCreatingMethods:
+    - def_node_matcher
+
 Metrics:
   Enabled: false
 
@@ -35,6 +39,7 @@ RSpec/FilePath:
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
+    RSpecRailsResponseParsedBody: rspec_rails_response_parsed_body
 
 RSpec/MultipleExpectations:
   Enabled: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.27.0)
+    sevencop (0.29.0)
       activesupport
       rubocop
 

data/README.md

@@ -36,11 +36,11 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/MethodDefinitionInIncluded](lib/rubocop/cop/sevencop/method_definition_in_included.rb)
 - [Sevencop/MethodDefinitionKeywordArgumentOrdered](lib/rubocop/cop/sevencop/method_definition_keyword_argument_ordered.rb)
 - [Sevencop/MethodDefinitionOrdered](lib/rubocop/cop/sevencop/method_definition_ordered.rb)
-- [Sevencop/RailsActionName](lib/rubocop/cop/sevencop/rails_action_name.rb)
 - [Sevencop/RailsBelongsToOptional](lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb)
 - [Sevencop/RailsDateAndTimeCalculation](lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb)
 - [Sevencop/RailsInferredSpecType](lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb)
 - [Sevencop/RailsOrderField](lib/rubocop/cop/sevencop/rails_order_field.rb)
+- [Sevencop/RailsSpecificActionName](lib/rubocop/cop/sevencop/rails_specific_action_name.rb)
 - [Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity](lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb)
 - [Sevencop/RailsWhereNot](lib/rubocop/cop/sevencop/rails_where_not.rb)
 - [Sevencop/RequireOrdered](lib/rubocop/cop/sevencop/require_ordered.rb)
@@ -48,6 +48,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecEmptyLineAfterLet](lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb)
 - [Sevencop/RSpecExamplesInSameGroup](lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
+- [Sevencop/RSpecRailsResponseParsedBody](lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb)
 
 ## Notes
 

data/config/default.yml

@@ -68,22 +68,6 @@ Sevencop/MethodDefinitionKeywordArgumentOrdered:
   Safe: false
   VersionAdded: '0.13'
 
-Sevencop/RailsActionName:
-  Description: |
-    Use only specific action names.
-  Enabled: false
-  VersionAdded: '0.24'
-  ActionNames:
-    - create
-    - destroy
-    - edit
-    - index
-    - new
-    - show
-    - update
-  Include:
-    - app/controllers/**/*.rb
-
 Sevencop/RailsBelongsToOptional:
   Description: |
     Force `belongs_to` with `optional: true` option.
@@ -112,6 +96,23 @@ Sevencop/RailsOrderField:
   Safe: false
   VersionAdded: '0.4'
 
+Sevencop/RailsSpecificActionName:
+  Description: |
+    Use only specific action names.
+  Enabled: false
+  VersionAdded: '0.24'
+  VersionChanged: '0.29'
+  ActionNames:
+    - create
+    - destroy
+    - edit
+    - index
+    - new
+    - show
+    - update
+  Include:
+    - app/controllers/**/*.rb
+
 Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity:
   Description: |
     Specify :case_sensitivity option on use of UniquenessValidator.
@@ -166,3 +167,13 @@ Sevencop/RSpecMemoizedHelperBlockDelimiter:
   VersionAdded: '0.27'
   Include:
     - spec/**/*
+
+Sevencop/RSpecRailsResponseParsedBody:
+  Description: |
+    Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+  Enabled: false
+  Safe: false
+  VersionAdded: '0.28'
+  Include:
+    - spec/controllers/**/*
+    - spec/requests/**/*

data/lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb

@@ -71,7 +71,7 @@ module RuboCop
             _
             _
             _*
-            ({ hash | kwargs }
+            (hash
               (pair ...)*
               $(pair (sym :type) sym)
               (pair ...)*

data/lib/rubocop/cop/sevencop/{rails_action_name.rb → rails_specific_action_name.rb}

@@ -5,6 +5,9 @@ module RuboCop
     module Sevencop
       # Use only specific action names.
       #
+      # It is good practice to separate controller classes rather than adding more actions as needed.
+      # By default, the 7 CRUD action names are specified that are generated by the Rails scaffold.
+      #
       # @example
       #   # bad
       #   class UsersController < ApplicationController
@@ -17,7 +20,7 @@ module RuboCop
       #     def index
       #     end
       #   end
-      class RailsActionName < Base
+      class RailsSpecificActionName < Base
         include VisibilityHelp
 
         MSG = 'Use only specific action names.'
@@ -27,7 +30,13 @@ module RuboCop
         def on_def(node)
           return unless bad?(node)
 
-          add_offense(node.location.name)
+          add_offense(
+            node.location.name,
+            message: format(
+              'Use only specific action names (%<action_names>s).',
+              action_names: configured_action_names.join(', ')
+            )
+          )
         end
 
         private

data/lib/rubocop/cop/sevencop/rails_where_not.rb

@@ -22,7 +22,7 @@ module RuboCop
         def_node_matcher :rails_where_not_with_multiple_elements_hash?, <<~PATTERN
           (send
             (send _ :where) :not
-            ({ hash | kwargs }
+            (hash
               (pair _ _)
               (pair _ _)+))
         PATTERN

data/lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+      #
+      # @safety
+      #   This cop is unsafe because Content-Type may not be `application/json`.
+      #
+      # @example
+      #   # bad
+      #   JSON.parse(response.body)
+      #
+      #   # good
+      #   response.parsed_body
+      class RSpecRailsResponseParsedBody < Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `response.parsed_body` to `JSON.parse(response.body)`.'
+
+        RESTRICT_ON_SEND = %i[parse].freeze
+
+        # @param node [RuboCop::AST::SendNode]
+        # @return [void]
+        def on_send(node)
+          return unless bad?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        private
+
+        # @!method json_parse_response_body?(node)
+        #   @param node [RuboCop::AST::Node]
+        #   @return [Boolean]
+        def_node_matcher :json_parse_response_body?, <<~PATTERN
+          (send
+            (const
+              {nil? cbase}
+              :JSON
+            )
+            :parse
+            (send
+              (send
+                nil?
+                :response
+              )
+              :body
+            )
+          )
+        PATTERN
+        alias bad? json_parse_response_body?
+
+        # @param corrector [RuboCop::Cop::Corrector]
+        # @param node [RuboCop::AST::SendNode]
+        # @return [void]
+        def autocorrect(
+          corrector,
+          node
+        )
+          corrector.replace(node, 'response.parsed_body')
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.27.0'
+  VERSION = '0.29.0'
 end

data/lib/sevencop.rb

@@ -12,11 +12,11 @@ require_relative 'rubocop/cop/sevencop/method_definition_arguments_multiline'
 require_relative 'rubocop/cop/sevencop/method_definition_in_included'
 require_relative 'rubocop/cop/sevencop/method_definition_keyword_argument_ordered'
 require_relative 'rubocop/cop/sevencop/method_definition_ordered'
-require_relative 'rubocop/cop/sevencop/rails_action_name'
 require_relative 'rubocop/cop/sevencop/rails_belongs_to_optional'
 require_relative 'rubocop/cop/sevencop/rails_date_and_time_calculation'
 require_relative 'rubocop/cop/sevencop/rails_inferred_spec_type'
 require_relative 'rubocop/cop/sevencop/rails_order_field'
+require_relative 'rubocop/cop/sevencop/rails_specific_action_name'
 require_relative 'rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity'
 require_relative 'rubocop/cop/sevencop/rails_where_not'
 require_relative 'rubocop/cop/sevencop/require_ordered'
@@ -24,3 +24,4 @@ require_relative 'rubocop/cop/sevencop/rspec_describe_http_endpoint'
 require_relative 'rubocop/cop/sevencop/rspec_empty_line_after_let'
 require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
+require_relative 'rubocop/cop/sevencop/rspec_rails_response_parsed_body'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
+date: 2022-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -64,11 +64,11 @@ files:
 - lib/rubocop/cop/sevencop/method_definition_in_included.rb
 - lib/rubocop/cop/sevencop/method_definition_keyword_argument_ordered.rb
 - lib/rubocop/cop/sevencop/method_definition_ordered.rb
-- lib/rubocop/cop/sevencop/rails_action_name.rb
 - lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb
 - lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb
 - lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb
 - lib/rubocop/cop/sevencop/rails_order_field.rb
+- lib/rubocop/cop/sevencop/rails_specific_action_name.rb
 - lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb
 - lib/rubocop/cop/sevencop/rails_where_not.rb
 - lib/rubocop/cop/sevencop/require_ordered.rb
@@ -76,6 +76,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb
 - lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
+- lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb