sevencop 0.27.0 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2d0d56a1f5cbd0bc259bf81abbd5f2120f0a79e535ff9fafe6793de262dfb0
-  data.tar.gz: a43deda18fed1e061b3442a4bfb6ed27f7af6b71522adde160fe530326462722
+  metadata.gz: 79bb602015c9eea9c89de44bfbd22274ef1197412a420f274280cc3cac7fe8c5
+  data.tar.gz: 8fe918f1ad6031ec0b4886a778e5333d9574ecf23c5658f133e32423349d2a28
 SHA512:
-  metadata.gz: f4888e9cd333099c4ec83c9d0b71349572ad471f4788efe1d8eee377f10286eb6d5c8534e6bb427ad52303f5fcf24e77fc7f3df9aab9ebc35ac726e0098b940f
-  data.tar.gz: 1cc3e089fa3e922131dd91e4e2c1c7fa6f835a1619bc8c9234f7f86af4e677a0d033583ea8f4eb1cfc3f1da5abc93222eb8506749c616c434350275a18859af0
+  metadata.gz: 0bdc4d1d137ea5c3a3b2048e8c1aa37bfff81672aef0b10d75cc361f4ff10938d9327ec1193f7936b6180b8fc2e2f6e51909723a9b036279c2852d76e810990b
+  data.tar.gz: 4235669bbd83b5f460663877b3e47272bffa0aadec21e1f413a7e957c6f0bdafe851443d0bbff5985553978b495e4b8c0d418b7736b9ebc9f2ee941859885f85

data/.rubocop.yml

@@ -16,6 +16,10 @@ Gemspec/RequireMFA:
 Layout/LineLength:
   Enabled: false
 
+Lint/UselessAccessModifier:
+  MethodCreatingMethods:
+    - def_node_matcher
+
 Metrics:
   Enabled: false
 
@@ -35,6 +39,7 @@ RSpec/FilePath:
     RSpecEmptyLineAfterLet: rspec_empty_line_after_let
     RSpecExamplesInSameGroup: rspec_examples_in_same_group
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
+    RSpecRailsResponseParsedBody: rspec_rails_response_parsed_body
 
 RSpec/MultipleExpectations:
   Enabled: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.27.0)
+    sevencop (0.28.0)
       activesupport
       rubocop
 

data/README.md

@@ -48,6 +48,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecEmptyLineAfterLet](lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb)
 - [Sevencop/RSpecExamplesInSameGroup](lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
+- [Sevencop/RSpecRailsResponseParsedBody](lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb)
 
 ## Notes
 

data/config/default.yml

@@ -166,3 +166,13 @@ Sevencop/RSpecMemoizedHelperBlockDelimiter:
   VersionAdded: '0.27'
   Include:
     - spec/**/*
+
+Sevencop/RSpecRailsResponseParsedBody:
+  Description: |
+    Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+  Enabled: false
+  Safe: false
+  VersionAdded: '0.28'
+  Include:
+    - spec/controllers/**/*
+    - spec/requests/**/*

data/lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb

@@ -71,7 +71,7 @@ module RuboCop
             _
             _
             _*
-            ({ hash | kwargs }
+            (hash
               (pair ...)*
               $(pair (sym :type) sym)
               (pair ...)*

data/lib/rubocop/cop/sevencop/rails_where_not.rb

@@ -22,7 +22,7 @@ module RuboCop
         def_node_matcher :rails_where_not_with_multiple_elements_hash?, <<~PATTERN
           (send
             (send _ :where) :not
-            ({ hash | kwargs }
+            (hash
               (pair _ _)
               (pair _ _)+))
         PATTERN

data/lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+      #
+      # @safety
+      #   This cop is unsafe because Content-Type may not be `application/json`.
+      #
+      # @example
+      #   # bad
+      #   JSON.parse(response.body)
+      #
+      #   # good
+      #   response.parsed_body
+      class RSpecRailsResponseParsedBody < Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `response.parsed_body` to `JSON.parse(response.body)`.'
+
+        RESTRICT_ON_SEND = %i[parse].freeze
+
+        # @param node [RuboCop::AST::SendNode]
+        # @return [void]
+        def on_send(node)
+          return unless bad?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        private
+
+        # @!method json_parse_response_body?(node)
+        #   @param node [RuboCop::AST::Node]
+        #   @return [Boolean]
+        def_node_matcher :json_parse_response_body?, <<~PATTERN
+          (send
+            (const
+              {nil? cbase}
+              :JSON
+            )
+            :parse
+            (send
+              (send
+                nil?
+                :response
+              )
+              :body
+            )
+          )
+        PATTERN
+        alias bad? json_parse_response_body?
+
+        # @param corrector [RuboCop::Cop::Corrector]
+        # @param node [RuboCop::AST::SendNode]
+        # @return [void]
+        def autocorrect(
+          corrector,
+          node
+        )
+          corrector.replace(node, 'response.parsed_body')
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.27.0'
+  VERSION = '0.28.0'
 end

data/lib/sevencop.rb

@@ -24,3 +24,4 @@ require_relative 'rubocop/cop/sevencop/rspec_describe_http_endpoint'
 require_relative 'rubocop/cop/sevencop/rspec_empty_line_after_let'
 require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
+require_relative 'rubocop/cop/sevencop/rspec_rails_response_parsed_body'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.28.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
+date: 2022-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -76,6 +76,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_empty_line_after_let.rb
 - lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
+- lib/rubocop/cop/sevencop/rspec_rails_response_parsed_body.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb