sevencop 0.10.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee9785d463d0e83d3f55dc1554e250e826a9cbd5aa6aacb510f11a4bdfb1947a
-  data.tar.gz: 9ca8456b525226ba8a599c4ef87f08ea208000268fa73ccf9f1501531682d294
+  metadata.gz: f5145711881e4ff729c76af2973e3c7af5c4ad5d7a72318dc28ea4346b7530e0
+  data.tar.gz: 3bade2432dfd3a659d4c689c005cc36c0ecb16da14dd99d338a815876ec8951f
 SHA512:
-  metadata.gz: edc7f9620eaa81224e47c8e8785df67bc29c51a0c6969f30bd24a3d6869a64be26686ccce7c3b43c89bc89f06b9283b67030587c86eb0b7ef5598d42ee1dc90b
-  data.tar.gz: 9a3bf2ecc2eed54ae8dd6207d0f0cd93c13f577bbcab69cdc9992e42f87687e416d9612136f1483952cfb51bdf22890727b14d6d66653e9294732dcb1da8d389
+  metadata.gz: 8011ea16ecaf3d1e8eb34156ca6b30f1f545d3d01406a4a1fa189b5cfb5bd74a4b0a6d177762c750023ac50c645e1ef8378028d44f4c710ea6744577fa7c5a64
+  data.tar.gz: '0392eb84b36bff0120d79e637d84fa3d893935d10c4dfd5dbd004bacdff75bf524137dc38976705e69aaa6c420fe4ad01160b89c36a49bc6c764d8cccae4079c'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.10.0)
+    sevencop (0.11.1)
       rubocop
 
 GEM

data/README.md

@@ -124,6 +124,26 @@ RSpec.describe User
 RSpec.describe User, type: :request
 ```
 
+### Sevencop/MethodDefinitionMultilineArguments
+
+Inserts new lines between method definition parameters.
+
+```ruby
+# bad
+def foo(a, b)
+end
+
+# good
+def foo(
+  a,
+  b
+)
+
+# good
+def foo(a)
+end
+```
+
 ### Sevencop/OrderField
 
 Identifies a String including "field" is passed to `order` or `reorder`.

data/config/default.yml

@@ -23,6 +23,12 @@ Sevencop/InferredSpecType:
   Enabled: false
   VersionAdded: '0.9'
 
+Sevencop/MethodDefinitionMultilineArguments:
+  Description: |
+    Inserts new lines between method definition parameters.
+  Enabled: false
+  VersionAdded: '0.11'
+
 Sevencop/OrderField:
   Description: |
     Wrap safe SQL String by `Arel.sql`.

data/lib/rubocop/cop/sevencop/method_definition_multiline_arguments.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Inserts new lines between method definition parameters.
+      #
+      # @example
+      #   # bad
+      #   def foo(a, b)
+      #   end
+      #
+      #   # good
+      #   def foo(
+      #     a,
+      #     b
+      #   )
+      #
+      #   # good
+      #   def foo(a)
+      #   end
+      class MethodDefinitionMultilineArguments < Base
+        extend AutoCorrector
+
+        MSG = 'Insert new lines between method definition parameters.'
+
+        # @param node [RuboCop::AST::ArgsNode]
+        def on_args(node)
+          return unless method_args?(node)
+          return if multilined?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        private
+
+        # @param corrector [RuboCop::AST::Corrector]
+        # @param node [RuboCop::AST::ArgsNode]
+        # @return [String]
+        def autocorrect(corrector, node)
+          indent = ' ' * node.parent.location.expression.column
+
+          corrector.replace(
+            node.location.expression.with(
+              begin_pos: node.parent.location.name.end_pos
+            ),
+            [
+              "(\n#{indent}  ",
+              node.children.map(&:source).join(",\n#{indent}  "),
+              "\n#{indent})"
+            ].join
+          )
+        end
+
+        # @param node [RuboCop::AST::ArgsNode]
+        # @return [Boolean]
+        def multilined?(node)
+          node.children.map do |child|
+            child.location.expression.line
+          end.uniq.length == node.children.length
+        end
+
+        # @return [Boolean]
+        def method_args?(node)
+          !node.parent.nil? && node.parent.def_type?
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.10.0'
+  VERSION = '0.11.1'
 end

data/lib/sevencop.rb

@@ -7,6 +7,7 @@ require_relative 'rubocop/cop/sevencop/belongs_to_optional'
 require_relative 'rubocop/cop/sevencop/factory_bot_create_list'
 require_relative 'rubocop/cop/sevencop/hash_literal_order'
 require_relative 'rubocop/cop/sevencop/inferred_spec_type'
+require_relative 'rubocop/cop/sevencop/method_definition_multiline_arguments'
 require_relative 'rubocop/cop/sevencop/order_field'
 require_relative 'rubocop/cop/sevencop/redundant_existence_check'
 require_relative 'rubocop/cop/sevencop/to_s_with_argument'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-30 00:00:00.000000000 Z
+date: 2022-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -45,6 +45,7 @@ files:
 - lib/rubocop/cop/sevencop/factory_bot_create_list.rb
 - lib/rubocop/cop/sevencop/hash_literal_order.rb
 - lib/rubocop/cop/sevencop/inferred_spec_type.rb
+- lib/rubocop/cop/sevencop/method_definition_multiline_arguments.rb
 - lib/rubocop/cop/sevencop/order_field.rb
 - lib/rubocop/cop/sevencop/redundant_existence_check.rb
 - lib/rubocop/cop/sevencop/to_s_with_argument.rb