sevencop 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: b59b9e87fae854412dd7555c8e0afb4d6c8c5e2a4a629ceb0b5840d94bfbd25c
+  data.tar.gz: d2a7a9cf5eb6b2722e44bb1f29f84ff3557e8be03fab8ecfd7441fb5723b64ec
+SHA512:
+  metadata.gz: a8be2a642fcda52bb7b779032bb1714366ef300a44fc2b0d435333c0239d16b7aff7802e8a43206a65e105e328c6d42c400fbf132d2baa40eecadbf54e16b177
+  data.tar.gz: 8581bf84c297111f877db7d3e51eeddea2c1000af8ebaae49dbac164f229d9e73f7ef878a4cfe8520d8a40d1ec01954b04eaafe4370a3e7359e78f8573a45715

data/.rspec

@@ -0,0 +1,3 @@
+--format documentation
+--color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,17 @@
+AllCops:
+  NewCops: enable
+  SuggestExtensions: false
+  TargetRubyVersion: 2.6
+
+Layout/LineLength:
+  Enabled: false
+
+Metrics:
+  Enabled: false
+
+Naming/FileName:
+ Exclude:
+   - lib/sevencop.rb
+
+Style/Documentation:
+  Enabled: false

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## Unreleased
+
+## 0.1.0 - 2022-06-07
+
+### Added
+
+- Initial release.
+- Add `Sevencop/RedundantExistenceCheck` cop.

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,84 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at r7kamura@gmail.com. All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior,  harassment of an individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0,
+available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations.

data/Gemfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in sevencop.gemspec
+gemspec
+
+gem 'rake', '~> 13.0'
+gem 'rspec', '~> 3.0'
+gem 'rubocop', '~> 1.21'

data/Gemfile.lock

@@ -0,0 +1,56 @@
+PATH
+  remote: .
+  specs:
+    sevencop (0.1.0)
+      rubocop (>= 1.27)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.2)
+    diff-lcs (1.5.0)
+    parallel (1.21.0)
+    parser (3.1.1.0)
+      ast (~> 2.4.1)
+    rainbow (3.1.1)
+    rake (13.0.6)
+    regexp_parser (2.2.1)
+    rexml (3.2.5)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    rubocop (1.27.0)
+      parallel (~> 1.10)
+      parser (>= 3.1.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.16.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.16.0)
+      parser (>= 3.1.1.0)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.1.0)
+
+PLATFORMS
+  x86_64-linux
+
+DEPENDENCIES
+  rake (~> 13.0)
+  rspec (~> 3.0)
+  rubocop (~> 1.21)
+  sevencop!
+
+BUNDLED WITH
+   2.3.6

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2022 Ryo Nakamura
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -0,0 +1,54 @@
+# sevencop
+
+[![test](https://github.com/r7kamura/sevencop/actions/workflows/test.yml/badge.svg)](https://github.com/r7kamura/sevencop/actions/workflows/test.yml)
+[![Gem Version](https://badge.fury.io/rb/sevencop.svg)](https://rubygems.org/gems/sevencop)
+
+Custom cops for [RuboCop](https://github.com/rubocop/rubocop).
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'sevencop', require: false
+```
+
+And then execute:
+
+```
+bundle install
+```
+
+Or install it yourself as:
+
+```
+gem install sevencop
+```
+
+## Usage
+
+```yaml
+# .rubocop.yml
+require:
+  - sevencop
+```
+
+## Cops
+
+### `Sevencop/RedundantExistenceCheck`
+
+Identifies redundant existent check before file operation.
+
+```ruby
+# bad
+FileUtils.mkdir(a) unless FileTest.exist?(a)
+
+# good
+FileUtils.mkdir(a)
+
+# bad
+FileUtils.rm(a) if FileTest.exist?(a)
+
+# good
+FileUtils.rm(a)
+```

data/Rakefile

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+require 'rubocop/rake_task'
+
+RuboCop::RakeTask.new
+
+task default: %i[spec rubocop]
+
+desc 'Generate a new cop with a template'
+task :new_cop, [:cop] do |_task, args|
+  require 'rubocop'
+
+  cop_name = args.fetch(:cop) do
+    warn 'usage: bundle exec rake new_cop[Department/Name]'
+    exit!
+  end
+
+  generator = RuboCop::Cop::Generator.new(cop_name)
+
+  generator.write_source
+  generator.write_spec
+  generator.inject_require(root_file_path: 'lib/rubocop/cop/rails_deprecation_cops.rb')
+  generator.inject_config(config_file_path: 'config/default.yml')
+
+  puts generator.todo
+end

data/config/default.yml

@@ -0,0 +1,5 @@
+Sevencop/RedundantExistenceCheck:
+  Description: Avoid redundant existent check before file operation.
+  Enabled: true
+  Safe: false
+  VersionAdded: '0.1'

data/lib/rubocop/cop/sevencop/redundant_existence_check.rb

@@ -0,0 +1,132 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Identifies redundant existent check before file operation.
+      #
+      # @safety
+      #   This cop is unsafe because it can register a false positive
+      #   where the check is truly needed.
+      #
+      # @example
+      #
+      #   # bad
+      #   FileUtils.mkdir(a) unless FileTest.exist?(a)
+      #
+      #   # good
+      #   FileUtils.mkdir(a)
+      #
+      #   # bad
+      #   FileUtils.rm(a) if FileTest.exist?(a)
+      #
+      #   # good
+      #   FileUtils.rm(a)
+      #
+      class RedundantExistenceCheck < Base
+        extend AutoCorrector
+
+        CLASS_NAMES_FOR_EXIST = ::Set[
+          :File,
+          :FileTest,
+        ]
+
+        METHOD_NAMES_FOR_MAKE = ::Set[
+          :makedirs,
+          :mkdir,
+          :mkdir_p,
+          :mkpath,
+          :touch,
+        ]
+
+        METHOD_NAMES_FOR_REMOVE = ::Set[
+          :remove,
+          :remove_dir,
+          :remove_entry,
+          :remove_entry_secure,
+          :remove_file,
+          :rm,
+          :rm_f,
+          :rm_r,
+          :rm_rf,
+          :rmdir,
+          :rmtree,
+          :safe_unlink,
+        ]
+
+        METHOD_NAMES_FOR_EXIST = ::Set[
+          :exist?,
+          :exists?,
+        ]
+
+        MSG = 'Avoid redundant existent check before file operation.'
+
+        def_node_matcher :make_unless_exist?, <<~PATTERN
+          (if
+            (send (const nil? CLASS_NAMES_FOR_EXIST) METHOD_NAMES_FOR_EXIST _)
+            nil?
+            (send (const nil? :FileUtils) METHOD_NAMES_FOR_MAKE ...)
+          )
+        PATTERN
+
+        def_node_matcher :remove_if_exist?, <<~PATTERN
+          (if
+            (send (const nil? CLASS_NAMES_FOR_EXIST) METHOD_NAMES_FOR_EXIST _)
+            (send (const nil? :FileUtils) METHOD_NAMES_FOR_REMOVE ...)
+            nil?
+          )
+        PATTERN
+
+        def on_if(node)
+          if redundant_on_if(node)
+            add_offense(node) do |rewriter|
+              remove_if(
+                node: node,
+                rewriter: rewriter
+              )
+            end
+          elsif redundant_on_unless(node)
+            add_offense(node) do |rewriter|
+              remove_unless(
+                node: node,
+                rewriter: rewriter
+              )
+            end
+          end
+        end
+
+        private
+
+        def redundant_on_if(node)
+          remove_if_exist?(node) && same_argument_on_if(node)
+        end
+
+        def redundant_on_unless(node)
+          make_unless_exist?(node) && same_argument_on_unless(node)
+        end
+
+        def remove_if(node:, rewriter:)
+          rewriter.replace(
+            node.location.expression,
+            node.children[1].source
+          )
+        end
+
+        def remove_unless(node:, rewriter:)
+          rewriter.replace(
+            node.location.expression,
+            node.children[2].source
+          )
+        end
+
+        def same_argument_on_if(node)
+          node.children[0].children[2] == node.children[1].children[2]
+        end
+
+        def same_argument_on_unless(node)
+          node.children[0].children[2] == node.children[2].children[2]
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/inject.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+# The original code is from https://github.com/rubocop/rubocop-rspec/blob/main/lib/rubocop/rspec/inject.rb
+# See https://github.com/rubocop/rubocop-rspec/blob/main/MIT-LICENSE.md
+module Sevencop
+  module Inject
+    def self.defaults!
+      path = CONFIG_DEFAULT.to_s
+      hash = ::RuboCop::ConfigLoader.send(:load_yaml_configuration, path)
+      config = ::RuboCop::Config.new(hash, path).tap(&:make_excludes_absolute)
+      puts "configuration from #{path}" if ::RuboCop::ConfigLoader.debug?
+      config = ::RuboCop::ConfigLoader.merge_with_default(config, path)
+      ::RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module Sevencop
+  VERSION = '0.1.0'
+end

data/lib/sevencop.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'pathname'
+require 'yaml'
+
+require_relative 'sevencop/inject'
+require_relative 'sevencop/version'
+
+require_relative 'rubocop/cop/sevencop/redundant_existence_check'
+
+module Sevencop
+  PROJECT_ROOT = ::Pathname.new(__dir__).parent.expand_path.freeze
+
+  CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+
+  CONFIG = ::YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+  private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
+end
+
+Sevencop::Inject.defaults!

data/rubocop-rails_deprecation.gemspec

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require_relative 'lib/sevencop/version'
+
+Gem::Specification.new do |spec|
+  spec.name = 'sevencop'
+  spec.version = Sevencop::VERSION
+  spec.authors = ['Ryo Nakamura']
+  spec.email = ['r7kamura@gmail.com']
+
+  spec.summary = 'Custom cops for RuboCop.'
+  spec.homepage = 'https://github.com/r7kamura/sevencop'
+  spec.license = 'MIT'
+  spec.required_ruby_version = '>= 2.6.0'
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['changelog_uri'] = "#{spec.homepage}/blob/main/CHANGELOG.md"
+  spec.metadata['rubygems_mfa_required'] = 'true'
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
+
+  spec.add_runtime_dependency 'rubocop', '>= 1.27'
+end

metadata

@@ -0,0 +1,76 @@
+--- !ruby/object:Gem::Specification
+name: sevencop
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Ryo Nakamura
+autorequire:
+bindir: exe
+cert_chain: []
+date: 2022-06-06 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.27'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.27'
+description:
+email:
+- r7kamura@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".rspec"
+- ".rubocop.yml"
+- CHANGELOG.md
+- CODE_OF_CONDUCT.md
+- Gemfile
+- Gemfile.lock
+- LICENSE.txt
+- README.md
+- Rakefile
+- config/default.yml
+- lib/rubocop/cop/sevencop/redundant_existence_check.rb
+- lib/sevencop.rb
+- lib/sevencop/inject.rb
+- lib/sevencop/version.rb
+- rubocop-rails_deprecation.gemspec
+homepage: https://github.com/r7kamura/sevencop
+licenses:
+- MIT
+metadata:
+  homepage_uri: https://github.com/r7kamura/sevencop
+  source_code_uri: https://github.com/r7kamura/sevencop
+  changelog_uri: https://github.com/r7kamura/sevencop/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
+post_install_message:
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.6.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubygems_version: 3.3.7
+signing_key:
+specification_version: 4
+summary: Custom cops for RuboCop.
+test_files: []