setting_accessors 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ee5a9907251833eaa146db7fbac4a5018c2de9560ce5e6e20f3bea46f37fe24
-  data.tar.gz: 6bfa23385d8e0457139faf0965b0bf966cde9234145a86b10f9671bc4830b13b
+  metadata.gz: 8d10252f28011080f4515a87d93e9142f6cb549058051750cadabf23541ad36d
+  data.tar.gz: 89651781d75a48777e4b5c746e5bb58686dff71394b7f33b91734b3858533a49
 SHA512:
-  metadata.gz: a03c398cdc4458249af5ef3a5ca29742460e477d2c4c55df30e81ac3d8db539d20ae06859cef4462e2bc3805ae944083c0d488b219d251989752a99cf145fbbb
-  data.tar.gz: 340c2ea4add256ddd50c57868957c223feffbec345332fa4e5e7f5e7e310206724f896f143c200814a745ab785abd66d67f28c3dcccaea1dc327035806c02ece
+  metadata.gz: 852a0cbc26936d8d2f3621d10e4eff8abb4687d26d3bb8182ead157977c21cbaa73afa9ffdafb96a2235ae5b6063782d78e22a430e9549de6ee0725704235e7a
+  data.tar.gz: 52ce5cce974c81aa9ec6f64b1777157ba3b6a3eedf4a0de3098ac0bd05bdfb1e705f0891874c68ddfb365fb43118b13fa1ae0f6916b1793179d27e166b710503

data/.travis.yml

@@ -20,7 +20,7 @@ gemfile:
   - gemfiles/rails_5.1.gemfile
   - gemfiles/rails_5.2.gemfile
 
-before_install: 'gem install bundler'
+before_install: 'gem install bundler -v 1.17.3'
 
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

data/CHANGELOG.md

@@ -1,6 +1,17 @@
 # Changelog
 
-## 1.2.0
+## [2.0.0] - 2019-09-27
+
+New major version as the change to the `touch` behavior might break existing apps
+and therefore is not backwards compatible.
+
+### Fixed
+
+- For AR >= 5.1, records are no longer `touch`ed after saving if
+  - [#19] the lifecycle was halted using `throw(:abort)` (props to @Haniyya)
+  - [#20] neither attributes nor settings were changed (basically `Model.first.save`)
+
+## [1.2.0]
 
 This is a major bugfix release as the gem was basically broken when being installed in a fresh Rails 5 application.
 
@@ -20,7 +31,7 @@ This is a major bugfix release as the gem was basically broken when being instal
 * Calls to `#as_json` as well as probably other parts of the AR API would fail if the gem was only included
   but not used (#17)
 
-## 1.1.0
+## [1.1.0]
 
 A bugfix and slight refactoring release which takes care of several issues regarding
 changing setting-values in-place without actually setting them before. (#13)
@@ -28,7 +39,7 @@ changing setting-values in-place without actually setting them before. (#13)
 * More and better specs
 * Better handling of non-existent settings through exception handling rather than multiple error prone tests
 
-## 1.0.0
+## [1.0.0]
 
 This is almost a complete refactoring of the gem which also removes some not really needed functionality.  
 It is the first release fully compatible with Rails 5.  
@@ -65,6 +76,6 @@ New minimum versions:
 * `setting_accessor` no longer supports the `fallback` option.  
    If a `default` option is given, it is automatically used as fallback.
 
-## 0.3.0
+## [0.3.0]
 
 * Fixed a bug that caused setting accessors not being initialized when being called as part of a rake task chain (#6)

data/README.md

@@ -16,7 +16,7 @@ and ActiveRecord integration to add virtual columns to models without having to
 Version Information / Backwards Compatibility
 ---------------------------------------------
 
-The current version (1.x) is only compatible with Ruby >= 2.3 and Rails >= 4.2.  
+The current version (2.x) is only compatible with Ruby >= 2.3 and Rails >= 4.2.  
 Versions 0.x support older versions of both Ruby and Rails. 
 
 Version 0.x also supported validations and type conversions for globally defined settings
@@ -197,6 +197,15 @@ validates :my_string, presence: true
 validates :my_number, numericality: {only_integer: true}
 ```
 
+Contributors
+------------
+
+<a href="https://github.com/stex/setting_accessors/graphs/contributors">
+  <img src="https://contributors-img.firebaseapp.com/image?repo=stex/setting_accessors" />
+</a>
+
+Made with [contributors-img](https://contributors-img.firebaseapp.com).
+
 Contributing
 ------------
 

data/gemfiles/rails_4.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    setting_accessors (1.2.0)
+    setting_accessors (2.0.0)
       rails (>= 4.2, < 5.3)
 
 GEM

data/gemfiles/rails_5.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    setting_accessors (1.2.0)
+    setting_accessors (2.0.0)
       rails (>= 4.2, < 5.3)
 
 GEM

data/gemfiles/rails_5.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    setting_accessors (1.2.0)
+    setting_accessors (2.0.0)
       rails (>= 4.2, < 5.3)
 
 GEM

data/gemfiles/rails_5.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    setting_accessors (1.2.0)
+    setting_accessors (2.0.0)
       rails (>= 4.2, < 5.3)
 
 GEM

data/lib/setting_accessors/integration.rb

@@ -82,8 +82,12 @@ module SettingAccessors
     if Gem.loaded_specs['activerecord'].version >= Gem::Version.create('5.1')
       def _update_record(*)
         super.tap do |affected_rows|
-          # Workaround to trigger a #touch if necessary, see +after_save+ callback further up
-          @_setting_accessors_touch_assignable = affected_rows.zero?
+          # The callback chain can, if a filter was provided for a certain callback and the callback throws and :abort,
+          # return +false+ instead of a number so we have to address both cases here.
+          unless affected_rows == false
+            # Workaround to trigger a #touch if necessary, see +after_save+ callback further up
+            @_setting_accessors_touch_assignable = affected_rows.zero? && settings.changed_settings.present?
+          end
         end
       end
     end

data/lib/setting_accessors/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SettingAccessors
-  VERSION = '1.2.0'
+  VERSION = '2.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: setting_accessors
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Stefan Exner
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-08 00:00:00.000000000 Z
+date: 2019-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal