setting_accessors 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c84a9d183c4d530e76b1c5fa3ef5e361732ac4aa
-  data.tar.gz: 57c5def39a8c796f5d0ecaeb2474a53ff27e541d
+  metadata.gz: 4bfc4d6c136c888e3ab70d330ace8ba0b118c9f6
+  data.tar.gz: 01bf15e9041976abd2c2804511daf0aeaadc5df5
 SHA512:
-  metadata.gz: aa28c3070e77ce1a3abaf62ca71335cd9118b6846e5327885572fa4bbe09143d8b932e9b5544615e11bf20327223df9507e2740d59a4793eefea540277d7d44c
-  data.tar.gz: f849a1ef5b62ed6c9658194fdf3399e1670b32ff3154aaee18729fadb08c256eccf228bc611c34078a14025863a4952ea7451c3f596e0b94a6790db4f66ed38e
+  metadata.gz: 071dd2ed23e8ab80dc529999a341d50c1f2d889e587992cb26fe7dce060d9d6c7138a8e5bfb5edcd345f44bc8f166187dd7d13f58e2eae9013660a0e2ad66da1
+  data.tar.gz: 0b9715953ce927a4d00db6cb15083650f1939c775e62f67ce2ed227982543488c43d97d0f538ba189fdf77d4f51b5487760a9b404c532bd3498d1bde1fa1ba4b

data/lib/setting_accessors/integration.rb

@@ -2,9 +2,9 @@ module SettingAccessors::Integration
   def self.included(base)
     base.validates_with SettingAccessors::IntegrationValidator
 
-    #After the main record was saved, we can save its settings.
-    #This is necessary as the record might have been a new record
-    #without an ID yet
+    # After the main record was saved, we can save its settings.
+    # This is necessary as the record might have been a new record
+    # without an ID yet
     base.after_save do
       settings.send(:persist!)
     end
@@ -84,8 +84,28 @@ module SettingAccessors::Integration
     end
   end
 
-  def as_json(*args)
-    json = super(*args)
+  #
+  # Previously read setting values have to be refreshed if a record is reloaded.
+  # Without this, #reload'ing a record would not update its setting values to the
+  # latest database version if they were previously read.
+  #
+  # Example to demonstrate the problem with this override:
+  #   user = User.create(:a_boolean => true)
+  #   user_alias = User.find(user.id)
+  #   user.a_boolean = !user_alias.a_boolean
+  #   user.save
+  #   user_alias.reload
+  #   user_alias.a_boolean
+  #   #=> true
+  #
+  def reload(*)
+    super
+    @settings_accessor = nil
+    self
+  end
+
+  def as_json(*)
+    json = super
     SettingAccessors::Internal.setting_accessor_names(self.class).each do |setting_name|
       json[setting_name.to_s] = send(setting_name)
     end
@@ -95,4 +115,4 @@ module SettingAccessors::Integration
   def settings
     @settings_accessor ||= SettingAccessors::Accessor.new(self)
   end
-end
+end

data/lib/setting_accessors/version.rb

@@ -1,3 +1,3 @@
 module SettingAccessors
-  VERSION = '0.0.11'
+  VERSION = '0.0.12'
 end

data/test/dummy/test/models/user_test.rb

@@ -38,6 +38,22 @@ class UserTest < ActiveSupport::TestCase
     end
   end
 
+  context 'the read set (@temp_settings)' do
+    setup do
+      @user = User.create
+      @user_alias = User.find(@user.id)
+
+      # Use @user_alias here to ensure that the setting value is saved in the instance's read set
+      @user.a_boolean = !@user_alias.a_boolean
+      assert @user.save
+    end
+
+    should 'be refreshed with the new values on #reload' do
+      assert @user_alias.reload
+      assert_equal @user.a_boolean, @user_alias.a_boolean
+    end
+  end
+
   context 'Polymorphic class-wise settings' do
     setup do
       @user = User.create

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: setting_accessors
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Stefan Exner