setting_accessors 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b57b02b1ed6e6025882eb8f66f00811e31187d0
-  data.tar.gz: 9e9f7ce1783329c95f1cc1d3a22a40c39e605d97
+  metadata.gz: c84a9d183c4d530e76b1c5fa3ef5e361732ac4aa
+  data.tar.gz: 57c5def39a8c796f5d0ecaeb2474a53ff27e541d
 SHA512:
-  metadata.gz: e0c62a32615cf53c34729be73ca94be87826bdfef304e231333cf1cbfad1d0543bf23cc9a10a4ba8633626e92269e750ced273080d26430b195b064cbd4d7bc6
-  data.tar.gz: 29fd6bb464c1a5ea65f9cc0a018a2659a7f96d4521d41e59febb4819f90139c48f7ace193da1833dcdc2e1decffd58d1d95c2682c73748def7f7420125b4554f
+  metadata.gz: aa28c3070e77ce1a3abaf62ca71335cd9118b6846e5327885572fa4bbe09143d8b932e9b5544615e11bf20327223df9507e2740d59a4793eefea540277d7d44c
+  data.tar.gz: f849a1ef5b62ed6c9658194fdf3399e1670b32ff3154aaee18729fadb08c256eccf228bc611c34078a14025863a4952ea7451c3f596e0b94a6790db4f66ed38e

data/lib/setting_accessors/accessor.rb

@@ -1,7 +1,6 @@
 #
 # Helper class to make accessing record specific settings easier
 #
-
 class SettingAccessors::Accessor
 
   def initialize(record)
@@ -10,10 +9,24 @@ class SettingAccessors::Accessor
   end
 
   #
-  # Gets a setting's value
+  # Tries to retrieve the given setting's value from the temp settings
+  # (already read/written values in this instance). If the setting hasn't been
+  # used before, its value is retrieved from the database.
+  #
+  # If a setting hasn't been read by this record (instance) before, its value
+  # is stored in the local read set.
+  #
+  # TODO: See if this causes problems with read settings not being updated by external changes.
+  #       User1: Read Setting X
+  #       User2: Update Setting X
+  #       User1: Read Setting X -> Gets old value from temp settings.
+  #   This shouldn't be too dangerous as the system state will be refreshed with every request though.
   #
   def [](key)
-    has_key?(key) ? @temp_settings[key.to_sym] : SettingAccessors.setting_class.get(key, @record)
+    return @temp_settings[key.to_sym] if has_key?(key)
+    value = SettingAccessors.setting_class.get(key, @record)
+    @temp_settings[key.to_sym] = value unless value.nil?
+    value
   end
 
   #

data/lib/setting_accessors/integration.rb

@@ -95,4 +95,4 @@ module SettingAccessors::Integration
   def settings
     @settings_accessor ||= SettingAccessors::Accessor.new(self)
   end
-end
+end

data/lib/setting_accessors/version.rb

@@ -1,3 +1,3 @@
 module SettingAccessors
-  VERSION = '0.0.10'
+  VERSION = '0.0.11'
 end

data/test/dummy/test/models/user_test.rb

@@ -43,25 +43,54 @@ class UserTest < ActiveSupport::TestCase
       @user = User.create
     end
 
-    should 'be updated in database if their whole value changes' do
-      @user.polymorphic_setting = {:a => :b}
-      assert @user.save
-      assert_equal User.last, @user
-      assert_equal User.last.polymorphic_setting, {:a => :b}
-    end
+    context 'when being assigned an initial value' do
+      should 'be created in database' do
+        @user.polymorphic_setting = {:a => :b}
+        assert @user.save
+        assert_equal User.last, @user
+        assert_equal User.last.polymorphic_setting, {:a => :b}
+      end
 
-    should 'be updated in database if a property of their value changes' do
-      @user.polymorphic_setting[:new_key] = 'new_value'
-      assert @user.save
-      assert_equal User.last, @user
-      assert_equal User.last.polymorphic_setting, {:new_key => 'new_value'}
+      should 'be created in database if one of their properties changes' do
+        @user.polymorphic_setting[:new_key] = 'new_value'
+        assert @user.save
+        assert_equal User.last, @user
+        assert_equal({:new_key => 'new_value'}, User.last.polymorphic_setting)
+      end
+
+      should 'not change the value of other assignable settings' do
+        @user2 = User.create
+        @user2.polymorphic_setting = {:foo => :bar}
+        assert @user2.save
+        assert_equal User.first.polymorphic_setting, {}
+      end
     end
 
-    should 'not update other assignable settings' do
-      @user2 = User.create
-      @user2.polymorphic_setting = {:foo => :bar}
-      assert @user2.save
-      assert_equal User.first.polymorphic_setting, {}
+    context 'when being updated' do
+      setup do
+        @user.polymorphic_setting = {:a => :b}
+        assert @user.save
+        assert @user.reload
+        assert_equal({:a => :b}, @user.polymorphic_setting)
+        assert_equal({:a => :b}, User.last.polymorphic_setting)
+      end
+
+      # Single hash value changed, etc.
+      should 'be saved if one of their properties changes' do
+        @user.polymorphic_setting[:a] = :c
+        assert @user.save
+        assert @user.reload
+        assert_equal({:a => :c}, @user.polymorphic_setting)
+        assert_equal({:a => :c}, User.last.polymorphic_setting)
+      end
+
+      should 'be updated if their whole value changes' do
+        @user.polymorphic_setting = {:a => :c}
+        assert @user.save
+        assert @user.reload
+        assert_equal({:a => :c}, @user.polymorphic_setting)
+        assert_equal({:a => :c}, User.last.polymorphic_setting)
+      end
     end
   end
 end

data/test/test_helper.rb

@@ -7,7 +7,6 @@ require 'active_support'
 require 'minitest'
 require 'shoulda'
 require "rails/test_help"
-require 'byebug'
 
 Rails.backtrace_cleaner.remove_silencers!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: setting_accessors
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Stefan Exner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-26 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler