setler 0.0.10 → 0.0.14

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: cbe29674970fc77e130e8ab2927c5afb9697f2f60d0c6b1edd0f7e95c9fa4710
+  data.tar.gz: 896867601cf7eee4ae4eeb4cca788952a334f450e9980c123ba38f54568778af
+SHA512:
+  metadata.gz: e9f90bc4f78b627a5d512cdf18bdedc7947a80f20fe7ef46acedbdad4f3321e02f76c7d8ab86278c41aee252a9607a2688d31086ee1621123c9ed8e4deec5aef
+  data.tar.gz: e01e2a723f9b0db1b77625f5f50912f670edfe71b519f07a975ae07412a360f9d3f7a727fd1b58cc1eb8a9bcc2d04aebf3d44c7c20a12513f046f1d7b6523e20

data/.ruby-gemset

@@ -0,0 +1 @@
+setler

data/.ruby-version

@@ -0,0 +1 @@
+2.6.5

data/.travis.yml

@@ -0,0 +1,22 @@
+language: ruby
+rvm:
+  - 2.3.8
+  - 2.4.7
+  - 2.5.7
+  - 2.6.5
+before_install: "gem install bundler:1.17.2"
+cache: bundler
+script: "bundle exec rake test"
+notifications:
+  email: false
+gemfile:
+  - gemfiles/rails_4.gemfile
+  - gemfiles/rails_5.gemfile
+  - gemfiles/rails_6_edge.gemfile
+matrix:
+  fast_finish: true
+  exclude:
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_6_edge.gemfile
+    - rvm: 2.4.7
+      gemfile: gemfiles/rails_6_edge.gemfile

data/Appraisals

@@ -0,0 +1,14 @@
+appraise "rails-4" do
+  gem "rails", "4.2.11.1"
+  gem 'sqlite3', '1.3.13' # 5/13/2019: LOCKED DOWN AGAIN.
+end
+
+appraise "rails-5" do
+  gem "rails", "5.2.3"
+  gem 'sqlite3'
+end
+
+appraise "rails-6-edge" do
+  gem 'rails', git: 'https://github.com/rails/rails'
+  gem 'sqlite3'
+end

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in setler.gemspec
 gemspec

data/README.rdoc

@@ -2,20 +2,27 @@
 
 Setler is a Gem that lets one easily implement the "Feature Flags" pattern, or add settings to individual models. This is a cleanroom implementation of what the 'rails-settings' gem does. It's been forked all over the place, and my favorite version of it doesn't have any tests and doesn't work with settings associated with models.
 
+{<img src="https://travis-ci.org/ckdake/setler.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/ckdake/setler]
+{<img src="https://badge.fury.io/rb/setler.svg" alt="Gem Version" />}[http://badge.fury.io/rb/setler]
+
+While Setler enables you to create both app-level and model-level settings, they are two separate things and don't mix. For example, if you create defaults for the app, they won't appear as defaults for individual models.
+
 == Setup
 
 Install the gem by adding this to your Gemfile:
 
   gem "setler"
-  
+
 Generate the model:
 
   rails g setler <model_name>
-  
+
 Run the migration:
 
   rake db:migrate
-  
+
+If you are using the `protected_attributes` gem you must add `attr_protected` to the top of you setler model.
+
 == Usage
 
 Create/Update settings:
@@ -23,22 +30,22 @@ Create/Update settings:
   # Method calls and []= are synonymous
   Featureflags.bacon_dispenser_enabled = true
   Settings[:allowed_meats] = ['bacon', 'crunchy bacon']
-  
+
 Read settings:
 
   Featureflags.bacon_dispenser_enabled # true
   Settings[:allowed_meats].include?('bacon')  # true
-  
+
 Destroy them:
 
   Featureflags.destroy :bacon_dispenser_enabled
   Settings.destroy :allowed_meats
-  
-List all:
 
-  Featureflags.all
-  Settings.all
-  
+List all settings:
+
+  Featureflags.all_settings
+  Settings.all_settings
+
 Set defaults in an initializer with something like:
 
   Featureflags.defaults[:bacon_dispenser_enabled] = false
@@ -46,20 +53,20 @@ Set defaults in an initializer with something like:
 
 To revert to the default after changing a setting, destroy it.
 Note: Updating the setting to nil or false no longer makes it the default setting (> 0.0.6), but changes the setting to nil or false.
-  
+
 Add them to any ActiveRecord object:
 
   class User < ActiveRecord::Base
-    has_setler as: :settings
+    has_setler  :settings
   end
-  
+
 Then you get:
-  
+
   user = User.first
   user.settings.favorite_meat = :bacon
   user.settings.favorite_meat  # :bacon
   user.settings.all # { "favorite_meat" => :bacon }
-  
+
 TODO: And look em up:
 
   User.with_settings_for('favorite_meat') # => scope of users with the favorite_meat setting
@@ -70,8 +77,9 @@ Getting started is pretty straightforward:
 
   1. Check out the code:  `git clone git://github.com/ckdake/setler.git`
   2. Bundle install:  `bundle install`
-  3. Run the tests and make sure they all pass and code coverage is still 100%:  `rake test`
-  
+  3. Run:  `appraisal install`  to generate the appraisal's gemfiles.
+  4. Run the tests for all supported releases in Appraisals file and make sure they all pass and code coverage is still the same:  `appraisal rake test`
+
 If you'd like to contribute code, make your changes and submit a pull request that includes appropriate tests
 
 For building the gem: `rake build` and to release a gem to github and Rubygems: `rake release`

data/Rakefile

@@ -1,26 +1,33 @@
-require 'rake/testtask'
+# encoding: utf-8
+
+require 'rubygems'
+require 'bundler/setup'
 require 'bundler/gem_tasks'
 
+require 'rake'
+require 'rake/testtask'
+require 'appraisal'
+
 Rake::TestTask.new(:test) do |test|
   test.libs << 'lib' << 'test'
   test.pattern = 'test/**/*_test.rb'
   test.verbose = true
 end
 
-task default: [:test]
+require 'bundler/gem_tasks'
 
-namespace :cover_me do
-  desc "Generates and opens code coverage report."
-  task :report do
-    require 'cover_me'
-    CoverMe.complete!
-  end
-end
+require 'rake'
+require 'appraisal'
 
-task :test do
-  Rake::Task['cover_me:report'].invoke
+desc 'Default'
+task :default do
+  if ENV['BUNDLE_GEMFILE'] =~ /gemfiles/
+    task default: [:test]
+  else
+    Rake::Task['appraise'].invoke
+  end
 end
 
-task :spec do
-  Rake::Task['cover_me:report'].invoke
+task :appraise do
+  exec 'appraisal install && appraisal rake test'
 end

data/contributors.txt

@@ -4,3 +4,8 @@ Phil Ostler github.com/philostler
 Rachel Heaton github.com/rheaton
 Corey Innis github.com/coreyti
 Steven Harman github.com/stevenharman
+Chris Stefano github.com/virtualstaticvoid
+Brian Stanwyck github.com/brianstanwyck
+Jay Hayes github.com/iamvery
+Al Snow github.com/jasnow
+Gal Tsubery github.com/tsubery

data/gemfiles/rails_4.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "4.2.11.1"
+gem "sqlite3", "1.3.13"
+
+gemspec path: "../"

data/gemfiles/rails_4.gemfile.lock

@@ -0,0 +1,128 @@
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (4.2.11.1)
+      actionpack (= 4.2.11.1)
+      actionview (= 4.2.11.1)
+      activejob (= 4.2.11.1)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+    actionpack (4.2.11.1)
+      actionview (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      rack (~> 1.6)
+      rack-test (~> 0.6.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      builder (~> 3.1)
+      erubis (~> 2.7.0)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      globalid (>= 0.3.0)
+    activemodel (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      builder (~> 3.1)
+    activerecord (4.2.11.1)
+      activemodel (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      arel (~> 6.0)
+    activesupport (4.2.11.1)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (6.0.4)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubis (2.7.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (1.6.13)
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rails (4.2.11.1)
+      actionmailer (= 4.2.11.1)
+      actionpack (= 4.2.11.1)
+      actionview (= 4.2.11.1)
+      activejob (= 4.2.11.1)
+      activemodel (= 4.2.11.1)
+      activerecord (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.2.11.1)
+      sprockets-rails
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.9)
+      activesupport (>= 4.2.0, < 5.0)
+      nokogiri (~> 1.6)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (4.2.11.1)
+      actionpack (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.3.13)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails (= 4.2.11.1)
+  rake
+  setler!
+  simplecov
+  sqlite3 (= 1.3.13)
+
+BUNDLED WITH
+   1.17.3

data/gemfiles/rails_5.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "5.2.3"
+gem "sqlite3"
+
+gemspec path: "../"

data/gemfiles/rails_5.gemfile.lock

@@ -0,0 +1,143 @@
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (5.2.3)
+      actionpack (= 5.2.3)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailer (5.2.3)
+      actionpack (= 5.2.3)
+      actionview (= 5.2.3)
+      activejob (= 5.2.3)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.2.3)
+      actionview (= 5.2.3)
+      activesupport (= 5.2.3)
+      rack (~> 2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.2.3)
+      activesupport (= 5.2.3)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.3)
+      activesupport (= 5.2.3)
+      globalid (>= 0.3.6)
+    activemodel (5.2.3)
+      activesupport (= 5.2.3)
+    activerecord (5.2.3)
+      activemodel (= 5.2.3)
+      activesupport (= 5.2.3)
+      arel (>= 9.0)
+    activestorage (5.2.3)
+      actionpack (= 5.2.3)
+      activerecord (= 5.2.3)
+      marcel (~> 0.3.1)
+    activesupport (5.2.3)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubi (1.9.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (1.8.2)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.2)
+    mimemagic (0.3.4)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nio4r (2.5.2)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (2.2.1)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (5.2.3)
+      actioncable (= 5.2.3)
+      actionmailer (= 5.2.3)
+      actionpack (= 5.2.3)
+      actionview (= 5.2.3)
+      activejob (= 5.2.3)
+      activemodel (= 5.2.3)
+      activerecord (= 5.2.3)
+      activestorage (= 5.2.3)
+      activesupport (= 5.2.3)
+      bundler (>= 1.3.0)
+      railties (= 5.2.3)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (5.2.3)
+      actionpack (= 5.2.3)
+      activesupport (= 5.2.3)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.19.0, < 2.0)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.1)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails (= 5.2.3)
+  rake
+  setler!
+  simplecov
+  sqlite3
+
+BUNDLED WITH
+   1.17.3

data/gemfiles/rails_6_edge.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", git: "https://github.com/rails/rails"
+gem "sqlite3"
+
+gemspec path: "../"

data/gemfiles/rails_6_edge.gemfile.lock

@@ -0,0 +1,167 @@
+GIT
+  remote: https://github.com/rails/rails
+  revision: c77a949299fcddd0f6f35d9bc21888b862ff665c
+  specs:
+    actioncable (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      mail (>= 2.7.1)
+    actionmailer (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      rack (~> 2.0, >= 2.0.8)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      nokogiri (>= 1.8.5)
+    actionview (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      globalid (>= 0.3.6)
+    activemodel (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+    activerecord (6.1.0.alpha)
+      activemodel (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+    activestorage (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      marcel (~> 0.3.1)
+    activesupport (6.1.0.alpha)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    rails (6.1.0.alpha)
+      actioncable (= 6.1.0.alpha)
+      actionmailbox (= 6.1.0.alpha)
+      actionmailer (= 6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      actiontext (= 6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activemodel (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      bundler (>= 1.3.0)
+      railties (= 6.1.0.alpha)
+      sprockets-rails (>= 2.0.0)
+    railties (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      method_source
+      rake (>= 0.8.7)
+      thor (~> 1.0)
+
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubi (1.9.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (1.8.2)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.2)
+    mimemagic (0.3.4)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nio4r (2.5.2)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (2.2.1)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.1)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
+    zeitwerk (2.2.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails!
+  rake
+  setler!
+  simplecov
+  sqlite3
+
+BUNDLED WITH
+   1.17.3

data/lib/generators/setler/templates/migration.rb

@@ -9,6 +9,7 @@ class SetlerCreate<%= table_name.camelize %> < ActiveRecord::Migration
     end
 
     add_index :<%= table_name %>, [ :thing_type, :thing_id, :var ], unique: true
+    add_index :<%= table_name %>, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
   end
 
   def self.down

data/lib/setler/scoped_settings.rb

@@ -2,6 +2,7 @@ module Setler
   class ScopedSettings < Settings
     def self.for_thing(object, scopename)
       self.table_name = scopename
+      self.defaults = settings_constantize(scopename).defaults
       @object = object
       self
     end
@@ -10,5 +11,11 @@ module Setler
       self.base_class.where(thing_type: @object.class.base_class.to_s, thing_id: @object.id)
     end
 
+    # do not use rails default to singularize because setler examples
+    # user plural class names
+    def self.settings_constantize(scopename)
+      Object.const_get(scopename.to_s.camelize)
+    end
+
   end
 end

data/lib/setler/settings.rb

@@ -1,10 +1,26 @@
+require 'rails/version'
+
 module Setler
   class Settings < ActiveRecord::Base
     serialize :value
     self.abstract_class = true
 
-    cattr_accessor :defaults
-    @@defaults = {}.with_indifferent_access
+    def self.defaults
+      @defaults ||= {}.with_indifferent_access
+    end
+
+    def self.defaults=(defaults)
+      @defaults = defaults.with_indifferent_access
+    end
+
+    if Rails::VERSION::MAJOR == 3
+      attr_accessible :var, :value
+
+      def self.all
+        warn '[DEPRECATED] Setler::Settings#all is deprecated. Please use #all_settings'
+        all_settings
+      end
+    end
 
     # Get and Set variables when the calling method is the variable name
     def self.method_missing(method, *args, &block)
@@ -14,6 +30,8 @@ module Setler
         method_name = method.to_s
         if method_name.ends_with?("=")
           self[method_name[0..-2]] = args.first
+        elsif method_name.ends_with?("?")
+          self[method_name[0..-2]].present?
         else
           self[method_name]
         end
@@ -22,7 +40,7 @@ module Setler
 
     def self.[](var)
       the_setting = thing_scoped.find_by_var(var.to_s)
-      the_setting.present? ? the_setting.value : @@defaults[var]
+      the_setting.present? ? the_setting.value : defaults[var]
     end
 
     def self.[]=(var, value)
@@ -30,11 +48,19 @@ module Setler
       # thing_scoped.find_or_create_by_var(method_name[0..-2]) should work but doesnt for some reason
       # When @object is present, thing_scoped sets the where scope for the polymorphic association
       # but the find_or_create_by wasn't using the thing_type and thing_id
-      thing_scoped.find_or_create_by_var_and_thing_type_and_thing_id(
-        var.to_s,
-        @object.try(:class).try(:base_class).try(:to_s),
-        @object.try(:id)
-      ).update_attributes({ :value => value })
+      if Rails::VERSION::MAJOR == 3
+        thing_scoped.find_or_create_by_var_and_thing_type_and_thing_id(
+          var.to_s,
+          @object.try(:class).try(:base_class).try(:to_s),
+          @object.try(:id)
+        ).update({ :value => value })
+      else
+        thing_scoped.find_or_create_by(
+          var: var.to_s,
+          thing_type: @object.try(:class).try(:base_class).try(:to_s),
+          thing_id: @object.try(:id)
+        ).update({ :value => value })
+      end
     end
 
     def self.destroy(var_name)
@@ -47,8 +73,8 @@ module Setler
       end
     end
 
-    def self.all
-      @@defaults.merge(Hash[thing_scoped.all.collect{ |s| [s.var, s.value] }])
+    def self.all_settings
+      defaults.merge(Hash[thing_scoped.all.collect{ |s| [s.var, s.value] }])
     end
 
     def self.thing_scoped

data/lib/setler/version.rb

@@ -1,3 +1,3 @@
 module Setler
-  VERSION = "0.0.10"
+  VERSION = "0.0.14"
 end

data/setler.gemspec

@@ -7,21 +7,22 @@ Gem::Specification.new do |s|
   s.version     = Setler::VERSION
   s.authors     = ["Chris Kelly"]
   s.email       = ["ckdake@ckdake.com"]
+  s.license     = 'MIT'
   s.homepage    = "https://github.com/ckdake/setler"
   s.summary     = %q{Settler lets you use the 'Feature Flags' pettern or add settings to models.}
   s.description = %q{Setler is a Gem that lets one easily implement the "Feature Flags" pattern, or add settings to individual models. This is a cleanroom implementation of what the 'rails-settings' gem does. It's been forked all over the place, and my favorite version of it doesn't have any tests and doesn't work with settings associated with models.}
 
-  s.rubyforge_project = "setler"
-
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
-  
+
   s.add_dependency('activerecord', '>=3.0.0')
   s.add_dependency('rails',        '>=3.0.0')
+  s.add_dependency('sprockets',    '3.7.2') # 10/16/2019: LOCKED DOWN
 
-  s.add_development_dependency('sqlite3')
   s.add_development_dependency('rake')
-  s.add_development_dependency('cover_me')
+  s.add_development_dependency('minitest')
+  s.add_development_dependency('simplecov')
+  s.add_development_dependency('appraisal')
 end

data/test/settings_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class ::SettingsTest < Test::Unit::TestCase
+class ::SettingsTest < Minitest::Test
   setup_db
 
   def setup
@@ -10,7 +10,10 @@ class ::SettingsTest < Test::Unit::TestCase
 
   def teardown
     ::Settings.delete_all
+    ::Settings.defaults = {}.with_indifferent_access
+
     ::Preferences.delete_all
+    ::Preferences.defaults = {}.with_indifferent_access
   end
 
   def test_defaults
@@ -32,6 +35,13 @@ class ::SettingsTest < Test::Unit::TestCase
     assert_equal 'bar', ::Settings.test2
   end
 
+  def test_get_presence
+    ::Settings.truthy = [1,2,3]
+    ::Settings.falsy = []
+    assert_equal true, ::Settings.truthy?
+    assert_equal false, ::Settings.falsy?
+  end
+
   def test_get_with_array_syntax
     assert_equal 'foo', ::Settings["test"]
     assert_equal 'bar', ::Settings[:test2]
@@ -50,7 +60,7 @@ class ::SettingsTest < Test::Unit::TestCase
   def test_update_with_nil_and_default_not_nil
     ::Settings.defaults[:foo] = :test
     ::Settings.foo = nil
-    assert_equal nil, ::Settings.foo
+    assert_nil ::Settings.foo
   end
 
   def test_update_with_array_syntax
@@ -66,8 +76,20 @@ class ::SettingsTest < Test::Unit::TestCase
     assert_equal '123', ::Settings.onetwothree
   end
 
+  def test_multithreaded_create
+    s1 = Settings.new var: :conflict, value: 1
+    s2 = Settings.new var: :conflict, value: 2
+    s1.save!
+    exc = assert_raises ActiveRecord::RecordNotUnique, ActiveRecord::StatementInvalid do
+        s2.save!
+    end
+    unless exc.is_a?(ActiveRecord::RecordNotUnique)
+      assert exc.message.match(/UNIQUE/)
+    end
+  end
+
   def test_complex_serialization
-    complex = [1, '2', {:three => true}]
+    complex = [1, '2', {"three" => true}]
     ::Settings.complex = complex
     assert_equal complex, ::Settings.complex
   end
@@ -79,12 +101,12 @@ class ::SettingsTest < Test::Unit::TestCase
     assert_equal 0.02, ::Settings.float * 2
   end
 
-  def test_all
-    assert_equal({ "test2" => "bar", "test" => "foo" }, ::Settings.all)
+  def test_all_settings
+    assert_equal({ "test2" => "bar", "test" => "foo" }, ::Settings.all_settings)
   end
 
   def test_destroy
-    assert_not_nil ::Settings.test
+    refute_nil ::Settings.test
     ::Settings.destroy :test
     assert_nil ::Settings.test
   end
@@ -114,13 +136,13 @@ class ::SettingsTest < Test::Unit::TestCase
   def test_user_settings_all
     ::Settings.destroy_all
     user = User.create name: 'user 1'
-    assert_equal ::Preferences.all, user.preferences.all
+    assert_equal ::Preferences.all_settings, user.preferences.all_settings
     user.preferences.likes_bacon = true
     user.preferences.really_likes_bacon = true
-    assert user.preferences.all['likes_bacon']
-    assert !::Settings.all['likes_bacon']
-    assert user.preferences.all['really_likes_bacon']
-    assert !::Settings.all['really_likes_bacon']
+    assert user.preferences.all_settings['likes_bacon']
+    assert !::Settings.all_settings['likes_bacon']
+    assert user.preferences.all_settings['really_likes_bacon']
+    assert !::Settings.all_settings['really_likes_bacon']
   end
 
   def test_user_settings_override_defaults
@@ -148,7 +170,7 @@ class ::SettingsTest < Test::Unit::TestCase
   # end
 
   def test_destroy_when_setting_does_not_exist
-    assert_raise Setler::SettingNotFound do
+    assert_raises Setler::SettingNotFound do
       ::Settings.destroy :not_a_setting
     end
   end
@@ -157,11 +179,17 @@ class ::SettingsTest < Test::Unit::TestCase
     ::Preferences.create var: 'test',  value: 'preferences foo'
     ::Preferences.create var: 'test2', value: 'preferences bar'
 
-    assert_not_equal ::Settings.defaults, ::Preferences.defaults
+    refute_match ::Settings.all_settings, ::Preferences.all_settings
 
     assert_equal 'foo', ::Settings[:test]
     assert_equal 'bar', ::Settings[:test2]
     assert_equal 'preferences foo', ::Preferences[:test]
     assert_equal 'preferences bar', ::Preferences[:test2]
   end
+
+  def test_defaults_are_independent
+    ::Settings.defaults[:foo] = false
+
+    refute_equal ::Settings.defaults, ::Preferences.defaults
+  end
 end

data/test/test_helper.rb

@@ -1,6 +1,8 @@
-require 'cover_me'
 require 'rubygems'
 
+require 'simplecov'
+SimpleCov.start 'rails'
+
 require 'bundler'
 begin
   Bundler.setup(:default, :development)
@@ -10,8 +12,9 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
+require 'rails'
 require 'active_record'
-require 'test/unit'
+require 'minitest/autorun'
 
 require_relative '../lib/setler'
 
@@ -34,18 +37,20 @@ def setup_db
       t.text   :value, :null => true
       t.integer :thing_id, :null => true
       t.string :thing_type, :limit => 30, :null => true
-      t.timestamps
+      t.timestamps null: false
     end
     add_index :settings, [ :thing_type, :thing_id, :var ], :unique => true
+    add_index :settings, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
 
     create_table :preferences do |t|
       t.string :var, :null => false
       t.text   :value, :null => true
       t.integer :thing_id, :null => true
       t.string :thing_type, :limit => 30, :null => true
-      t.timestamps
+      t.timestamps null: false
     end
     add_index :preferences, [ :thing_type, :thing_id, :var ], :unique => true
+    add_index :preferences, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
 
     create_table :users do |t|
       t.string :name

metadata

@@ -1,94 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: setler
 version: !ruby/object:Gem::Version
-  version: 0.0.10
-  prerelease: 
+  version: 0.0.14
 platform: ruby
 authors:
 - Chris Kelly
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2012-07-31 00:00:00.000000000 Z
+date: 2021-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: sprockets
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.2
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: cover_me
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Setler is a Gem that lets one easily implement the "Feature Flags" pattern,
@@ -102,13 +119,22 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc
+- ".gitignore"
+- ".ruby-gemset"
+- ".ruby-version"
+- ".travis.yml"
+- Appraisals
 - Gemfile
 - MIT-LICENSE
 - README.rdoc
 - Rakefile
 - contributors.txt
+- gemfiles/rails_4.gemfile
+- gemfiles/rails_4.gemfile.lock
+- gemfiles/rails_5.gemfile
+- gemfiles/rails_5.gemfile.lock
+- gemfiles/rails_6_edge.gemfile
+- gemfiles/rails_6_edge.gemfile.lock
 - lib/generators/setler/setler_generator.rb
 - lib/generators/setler/templates/migration.rb
 - lib/generators/setler/templates/model.rb
@@ -122,28 +148,27 @@ files:
 - test/settings_test.rb
 - test/test_helper.rb
 homepage: https://github.com/ckdake/setler
-licenses: []
-post_install_message: 
+licenses:
+- MIT
+metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: setler
-rubygems_version: 1.8.24
-signing_key: 
-specification_version: 3
+rubygems_version: 3.2.22
+signing_key:
+specification_version: 4
 summary: Settler lets you use the 'Feature Flags' pettern or add settings to models.
 test_files:
 - test/settings_test.rb

data/.rvmrc

@@ -1 +0,0 @@
-rvm 1.9.2@setler