setl 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b1728e14e5c1c6a904512d241d340315ea4085a
-  data.tar.gz: f33f22366920fbd08bf2a0451a1e5257f279239c
+  metadata.gz: 3a89bb7b59c0609b79d8cf15d6028ec1f737beae
+  data.tar.gz: cc162c0522666a70fbf9180592e4b0d3e5d128aa
 SHA512:
-  metadata.gz: 0b4629edc8c4623270e7bdf7a65cec66dd04b4ef6e615421c3198228cf3d68e13d2553a6573675ac88d6476ba2fd3fa3e42be4c687407e5aa546305a11fe08e8
-  data.tar.gz: d2622daeb250e0022d6a055588a0ef205ad9279c38a346f5a1b9b605c100ec4a7e06c9f06f9d7509f8474ed7fbc53c38b9738b2608e8ccbae50e091dccf717b0
+  metadata.gz: 15e2d85fef8add097abbda5890201332de3fc251f73e4e61b7c15cb74dcc5f09c64352e039db1411cab8506fe91142157079bebcc96233aed039270a73e70244
+  data.tar.gz: 4c57e706725c5f33b6b5d820bb444590c0508b0b78a2bf47cf8ad9b6d1d6715fdd763e06f42da3a5f040a042d2b4511e4ad6a20c4dab0fd38c49da246e037a1a

data/lib/setl/delegates.rb

@@ -0,0 +1,43 @@
+require_relative 'errors'
+
+module Setl
+  class Delegator
+    def initialize(item, error_handler)
+      @item = item
+      @error_handler = error_handler
+    end
+
+    private
+
+    attr_reader :item, :error_handler
+  end
+
+  class Source < Delegator
+    def each(&block)
+      item.each(&block)
+    rescue StandardError => e
+      # Allow our errors to go through
+      if e.is_a? ETLError
+        raise e
+      else
+        error_handler.(SourceError.new("Failed to read from source"))
+      end
+    end
+  end
+
+  class Transform < Delegator
+    def call(row, &block)
+      item.call(row, &block)
+    rescue StandardError => e
+      error_handler.(ProcessingError.new(row, "Failed to process #{row}"))
+    end
+  end
+
+  class Destination < Delegator
+    def call(row, &block)
+      item.call(row, &block)
+    rescue StandardError => e
+      error_handler.(DestinationError.new(row, "Failed to send #{row}"))
+    end
+  end
+end

data/lib/setl/errors.rb

@@ -0,0 +1,25 @@
+module Setl
+  class ETLError < StandardError
+  end
+
+  class ProcessingError < ETLError
+    def initialize(row, message=nil)
+      super message
+      @row = row
+    end
+
+    attr_reader :row
+  end
+
+  class SourceError < ETLError
+  end
+
+  class DestinationError < ETLError
+    def initialize(row, message=nil)
+      super message
+      @row = row
+    end
+
+    attr_reader :row
+  end
+end

data/lib/setl/etl.rb

@@ -1,21 +1,21 @@
+require_relative 'delegates'
+
 module Setl
   class ETL
-    def initialize(source, destination, stop_on_errors: false, error_handler: nil)
-      @source = source
-      @destination = destination
+    def initialize(source, destination, transform, stop_on_errors: false, error_handler: nil)
       @stop_on_errors = stop_on_errors
       @error_handler = error_handler || DefaultHandler.new(stop_on_errors)
+
+      @source = Source.new(source, @error_handler)
+      @destination = Destination.new(destination, @error_handler)
+      @transform = Transform.new(transform, @error_handler)
     end
 
-    def process(transform)
+    def process
       source.each do |row|
         @last_row = row
 
-        begin
-          destination.(transform.(row))
-        rescue StandardError => e
-          error_handler.(row, e)
-        end
+        destination.(transform.(row))
       end
     end
 
@@ -23,10 +23,7 @@ module Setl
 
     private
 
-    attr_reader :source, :destination, :stop_on_errors, :error_handler
-  end
-
-  class ProcessingError < StandardError
+    attr_reader :source, :destination, :transform, :stop_on_errors, :error_handler
   end
 
   class DefaultHandler
@@ -34,8 +31,8 @@ module Setl
       @reraise = reraise
     end
 
-    def call(row, exception)
-      raise ProcessingError, "Failed to process #{row}" if reraise?
+    def call(exception)
+      raise exception if reraise?
     end
 
     private

data/lib/setl/version.rb

@@ -1,3 +1,3 @@
 module Setl
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/error_handling_spec.rb

@@ -3,7 +3,7 @@ require 'setl/etl'
 
 module Setl
   RSpec.describe 'error handling' do
-    let(:etl) { ETL.new(source, destination) }
+    let(:etl) { ETL.new(source, destination, transform) }
     let(:source) { [1, 2] }
     let(:destination) { double('Destination', call: true) }
     let(:transform) do
@@ -14,7 +14,7 @@ module Setl
       end
     end
 
-    let(:process) { etl.process(transform) }
+    let(:process) { etl.process }
 
     context 'by default' do
       it 'rescues the error' do
@@ -29,7 +29,7 @@ module Setl
     end
 
     context 'when configured to stop on errors' do
-      let(:etl) { ETL.new(source, destination, stop_on_errors: true) }
+      let(:etl) { ETL.new(source, destination, transform, stop_on_errors: true) }
 
       it 'stops processing when a processing error occurs' do
         expect { process }.to raise_error(ProcessingError, 'Failed to process 1')
@@ -45,14 +45,64 @@ module Setl
     end
 
     context 'when provided an error handler' do
-      let(:handler) { double('Error Handler') }
-      let(:etl) { ETL.new(source, destination, error_handler: handler) }
+      let(:handler) do
+        Class.new do
+          def self.call(exception)
+            raise exception
+          end
+        end
+      end
 
-      it 'sends the row and exception to the handler' do
-        expect(handler).to receive(:call).with(1, an_instance_of(RuntimeError))
+      let(:etl) { ETL.new(source, destination, transform, error_handler: handler) }
+
+      it 'sends a processing error to the handler' do
+        expect(handler).to receive(:call).with(an_instance_of(ProcessingError))
 
         process
       end
+
+      specify 'the error contains the original cause' do
+        begin
+          process
+        rescue ProcessingError => e
+          expect(e.cause).to be_a RuntimeError
+        end
+      end
+
+      context 'when the source raises an exception' do
+        let(:handler) { double('ErrorHandler', call: true) }
+
+        let(:source) do
+          Class.new do
+            def self.each
+              raise "nope"
+            end
+          end
+        end
+
+        it 'sends a SourceError to the handler' do
+          expect(handler).to receive(:call).with(an_instance_of(SourceError))
+
+          process
+        end
+      end
+
+      context 'when the destination raises an exception' do
+        let(:handler) { double('ErrorHandler', call: true) }
+        let(:destination) do
+          Class.new do
+            def self.call(row)
+              raise "lol"
+            end
+          end
+        end
+
+        it 'sends a destination error to the handler' do
+          expect(handler).to receive(:call).with(an_instance_of(DestinationError))
+
+          process
+        end
+      end
     end
   end
 end

data/spec/etl_spec.rb

@@ -3,7 +3,7 @@ require 'setl/etl'
 
 module Setl
   RSpec.describe 'etl' do
-    let(:etl) { ETL.new(source, destination) }
+    let(:etl) { ETL.new(source, destination, transform) }
 
     describe 'processing a row' do
       let(:row) { 'hello' }
@@ -13,7 +13,7 @@ module Setl
       let(:transform) { double('Transform', call: processed_data) }
 
       before do
-        etl.process(transform)
+        etl.process
       end
 
       it 'delegates the processing to the transform' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: setl
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Leonard Garvey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-21 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -70,6 +70,8 @@ files:
 - bin/rspec
 - lib/setl.rb
 - lib/setl/controller.rb
+- lib/setl/delegates.rb
+- lib/setl/errors.rb
 - lib/setl/etl.rb
 - lib/setl/version.rb
 - setl.gemspec
@@ -97,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Simple Extract Transform & Load - setl
@@ -106,3 +108,4 @@ test_files:
 - spec/error_handling_spec.rb
 - spec/etl_spec.rb
 - spec/spec_helper.rb
+has_rdoc: