serviz 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 996c470857cef304582ab365344d4918e3ee35c5baacd64b2d5b068a2b323707
-  data.tar.gz: 3c77f8932bee0fb30543975094f8d1ce025e8455ca031e028b9b97f1a134835d
+  metadata.gz: 4ac56a9462d7a2bc3b2b169cb1edb1c9d7102bc2266e7f947f08c85e1ba4dab8
+  data.tar.gz: e4ec1c19c41c32f779c3bc2127baec37f8e99f6c667d534b0c6d8e05cd9d1060
 SHA512:
-  metadata.gz: d5b429c64601d9a4b9f829cb723e99c995659c64cf5901eb34240047ee2611ab7b10bd2aa27a2ab54339e99c6b63466deab752d5998f3a74efd528d4d16afb9a
-  data.tar.gz: 7a89f2b36fe02e78d75cec00280659ae0fc7f740730a373c07e62b444534b844a784b1b828acb0291b9f8328833466d66bcbb1fd476f85337aaefab6604cc7ab
+  metadata.gz: 520b3c0d7ef65166ce098b6214f4f6a3a720dee5290cf7ff865e6453955bf8072a00419a729d12d88e28c4d1094b48269436aacabac9f61ff60b0c6cb9f22fdf
+  data.tar.gz: 939b2c3fe3fc39955fba3a25f8622cd319e4ef6b903e666ba315f93abb3cc3a4ffc9dfe8856dbb7d8ee1c5e68eff92c764707994aba7d40582d1a326c659eb27

data/lib/serviz/base.rb

@@ -0,0 +1,36 @@
+module Serviz
+  class Base
+    attr_accessor :errors, :result
+
+    def self.call(...)
+      instance = new(...)
+      instance.call
+
+      yield(instance) if block_given?
+
+      instance
+    end
+
+    def call
+      raise NotImplementedError
+    end
+
+    def errors
+      @errors ||= []
+    end
+
+    def error_messages(separator = ", ")
+      errors.join(separator)
+    end
+
+    def success?
+      !failure?
+    end
+    alias_method :ok?, :success?
+
+    def failure?
+      errors.any?
+    end
+    alias_method :error?, :failure?
+  end
+end

data/lib/serviz/version.rb

@@ -1,3 +1,3 @@
 module Serviz
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/lib/serviz/workflow.rb

@@ -0,0 +1,55 @@
+module Serviz
+  class Workflow < Base
+    def self.step(service_class, params: nil, if: nil)
+      steps << {
+        service_class: service_class,
+        params: params,
+        condition: binding.local_variable_get(:if)
+      }
+    end
+
+    def self.steps
+      @steps ||= []
+    end
+
+    def initialize(*args, **kwargs)
+      @last_step = nil
+      @args = args
+      @kwargs = kwargs
+    end
+
+    def call
+      self.class.steps.each do |step_config|
+        # Check if condition is provided and evaluate it
+        if step_config[:condition] && !step_config[:condition].call(@last_step)
+          next
+        end
+
+        # Determine parameters to use
+        operation = if step_config[:params]
+          # Use step-specific params
+          step_params = if step_config[:params].is_a?(Proc)
+                          step_config[:params].call(self)
+                        else
+                          step_config[:params]
+                        end
+          step_config[:service_class].call(**step_params)
+        else
+          # Use workflow args/kwargs
+          step_config[:service_class].call(*@args, **@kwargs)
+        end
+        
+        # Accumulate errors if the service failed
+        if operation.failure?
+          self.errors.concat(operation.errors)
+        end
+
+        # Update last result and overall result
+        @last_step = operation
+        self.result = operation.result
+      end
+
+      self
+    end
+  end
+end

data/lib/serviz.rb

@@ -1,44 +1,3 @@
 require 'serviz/version'
-
-module Serviz
-  class Base
-    attr_accessor :errors, :result
-
-    def self.call(*args, **kwargs)
-      instance = if args.length > 0 && kwargs.length > 0
-                   new(*args, **kwargs)
-                 elsif kwargs.length > 0
-                   new(**kwargs)
-                 else
-                   new(*args)
-                 end
-      instance.call
-
-      yield(instance) if block_given?
-
-      instance
-    end
-
-    def call
-      raise NotImplementedError
-    end
-
-    def errors
-      @errors ||= []
-    end
-
-    def error_messages(separator = ", ")
-      errors.join(separator)
-    end
-
-    def success?
-      !failure?
-    end
-    alias_method :ok?, :success?
-
-    def failure?
-      errors.any?
-    end
-    alias_method :error?, :failure?
-  end
-end
+require 'serviz/base'
+require 'serviz/workflow'

data/spec/scenarios.rb

@@ -25,3 +25,32 @@ end
 
 class NoCall < Serviz::Base
 end
+
+# Test services for Workflow
+class Step1 < Serviz::Base
+  def initialize(some_flag: nil)
+    @some_flag = some_flag
+  end
+
+  def call
+    if @some_flag
+      self.result = "step1_#{@some_flag}"
+    else
+      self.errors << 'Step1 failed'
+    end
+  end
+end
+
+class Step2 < Serviz::Base
+  def initialize(some_flag: nil)
+    @some_flag = some_flag
+  end
+
+  def call
+    if @some_flag
+      self.result = "step2_#{@some_flag}"
+    else
+      self.errors << 'Step2 failed'
+    end
+  end
+end

data/spec/workflow_spec.rb

@@ -0,0 +1,60 @@
+RSpec.describe Serviz::Workflow do
+  describe "basic workflow execution" do
+    it "executes steps in sequence and returns the last result" do
+      workflow = Class.new(Serviz::Workflow) do
+        step Step1, params: ->(instance) { { some_flag: instance.instance_variable_get(:@arg1) } }
+        step Step2, params: ->(instance) { { some_flag: instance.instance_variable_get(:@arg2) } }
+
+        def initialize(arg1, arg2)
+          super()
+          @arg1 = arg1
+          @arg2 = arg2
+        end
+      end
+
+      operation = workflow.call("test1", "test2")
+
+      expect(operation.success?).to eq true
+      expect(operation.result).to eq "step2_test2"
+    end
+
+    it "accumulates errors from failed steps" do
+      workflow = Class.new(Serviz::Workflow) do
+        step Step1, params: { some_flag: nil }  # This will fail
+        step Step2, params: { some_flag: "test" }
+      end
+
+      operation = workflow.call
+
+      expect(operation.failure?).to eq true
+      expect(operation.errors).to include('Step1 failed')
+    end
+  end
+
+  describe "conditional execution" do
+    it "skips steps when condition is false" do
+      workflow = Class.new(Serviz::Workflow) do
+        step Step1, params: { some_flag: nil }  # This will fail
+        step Step2, params: { some_flag: "test" }, if: ->(operation) { operation.success? }
+      end
+
+      operation = workflow.call
+
+      expect(operation.failure?).to eq true
+      expect(operation.errors).to eq(['Step1 failed'])
+      expect(operation.result).to be_nil
+    end
+
+    it "executes steps when condition is true" do
+      workflow = Class.new(Serviz::Workflow) do
+        step Step1, params: { some_flag: "test1" }  # This will succeed
+        step Step2, params: { some_flag: "test2" }, if: ->(operation) { operation.success? }
+      end
+
+      operation = workflow.call
+
+      expect(operation.success?).to eq true
+      expect(operation.result).to eq "step2_test2"
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: serviz
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - markets
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-19 00:00:00.000000000 Z
+date: 2025-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -60,10 +60,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/serviz.rb
+- lib/serviz/base.rb
 - lib/serviz/version.rb
+- lib/serviz/workflow.rb
+- spec/base_spec.rb
 - spec/scenarios.rb
-- spec/serviz_spec.rb
 - spec/spec_helper.rb
+- spec/workflow_spec.rb
 homepage: https://github.com/markets/serviz
 licenses:
 - MIT
@@ -88,6 +91,7 @@ signing_key:
 specification_version: 4
 summary: Command object Interface for Ruby
 test_files:
+- spec/base_spec.rb
 - spec/scenarios.rb
-- spec/serviz_spec.rb
 - spec/spec_helper.rb
+- spec/workflow_spec.rb