serviz 0.2.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 177871346c263a1cd84842ef37ffa32e1fd4a398242e4d050821b2c12e5b705c
-  data.tar.gz: 1e65d0ea46eae2a2e0914445a55b73fa32e5f256affdd4549a11d047c4cb4181
+  metadata.gz: 996c470857cef304582ab365344d4918e3ee35c5baacd64b2d5b068a2b323707
+  data.tar.gz: 3c77f8932bee0fb30543975094f8d1ce025e8455ca031e028b9b97f1a134835d
 SHA512:
-  metadata.gz: 6ab5a8ab13a585d3d76d434b97a8ef16d2280756ecae1eadbb38c20f2a408599f0ceebe60c98a42430d1ee55889affee566ee7ab4ada8a533008a8791e0275a0
-  data.tar.gz: 84b5f495b341bf886e68340dcac0b0ce1ff4afce744c7a6fa89e10e7c4b07bbbc7b454c79a802b794730f1c5af5fe9f50086ce74755bc7a25e6e6202e4ab22ca
+  metadata.gz: d5b429c64601d9a4b9f829cb723e99c995659c64cf5901eb34240047ee2611ab7b10bd2aa27a2ab54339e99c6b63466deab752d5998f3a74efd528d4d16afb9a
+  data.tar.gz: 7a89f2b36fe02e78d75cec00280659ae0fc7f740730a373c07e62b444534b844a784b1b828acb0291b9f8328833466d66bcbb1fd476f85337aaefab6604cc7ab

data/lib/serviz/version.rb

@@ -1,3 +1,3 @@
 module Serviz
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

data/lib/serviz.rb

@@ -4,10 +4,18 @@ module Serviz
   class Base
     attr_accessor :errors, :result
 
-    def self.call(*args)
-      instance = new(*args)
+    def self.call(*args, **kwargs)
+      instance = if args.length > 0 && kwargs.length > 0
+                   new(*args, **kwargs)
+                 elsif kwargs.length > 0
+                   new(**kwargs)
+                 else
+                   new(*args)
+                 end
       instance.call
 
+      yield(instance) if block_given?
+
       instance
     end
 
@@ -19,12 +27,18 @@ module Serviz
       @errors ||= []
     end
 
+    def error_messages(separator = ", ")
+      errors.join(separator)
+    end
+
     def success?
       !failure?
     end
+    alias_method :ok?, :success?
 
     def failure?
       errors.any?
     end
+    alias_method :error?, :failure?
   end
 end

data/spec/scenarios.rb

@@ -12,5 +12,16 @@ class RegisterUser < Serviz::Base
   end
 end
 
+class PositionalAndKeyword < Serviz::Base
+  def initialize(positional, keyword:)
+    @positional = positional
+    @keyword    = keyword
+  end
+
+  def call
+    self.result = [@positional, @keyword]
+  end
+end
+
 class NoCall < Serviz::Base
 end

data/spec/serviz_spec.rb

@@ -4,8 +4,10 @@ RSpec.describe Serviz::Base do
     operation = RegisterUser.call(user)
 
     expect(operation.success?).to eq true
+    expect(operation.ok?).to eq true
     expect(operation.failure?).to eq false
     expect(operation.errors).to be_empty
+    expect(operation.error_messages).to eq ''
     expect(operation.result).to eq user
   end
 
@@ -14,11 +16,26 @@ RSpec.describe Serviz::Base do
 
     expect(operation.success?).to eq false
     expect(operation.failure?).to eq true
+    expect(operation.error?).to eq true
     expect(operation.errors).not_to be_empty
+    expect(operation.error_messages).to eq 'No user!'
     expect(operation.result).to eq nil
   end
 
   it "raises exception if #call is not defined" do
     expect { NoCall.call }.to raise_error NotImplementedError
   end
+
+  it "accepts positional and keywords args" do
+    operation = PositionalAndKeyword.call('foo', keyword: 'bar')
+
+    expect(operation.success?).to eq true
+    expect(operation.result).to eq(['foo', 'bar'])
+  end
+
+  it "accepts a block" do
+    expect {
+      RegisterUser.call { |operation| puts 'error!' if operation.failure? }
+    }.to output("error!\n").to_stdout
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: serviz
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - markets
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-02 00:00:00.000000000 Z
+date: 2024-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -68,7 +68,7 @@ homepage: https://github.com/markets/serviz
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -83,8 +83,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Command object Interface for Ruby
 test_files: