services 4.3.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5bd1a27e2051a3dfce7845c6d24396c007f17c51
-  data.tar.gz: 55072f152a1356ce1f6be21d3b60ec92ba45ac78
+  metadata.gz: 7a54c2710e578f7af30ef239cd96b7f837630a02
+  data.tar.gz: a33159048724d2925ca48fb06acd92a67402833e
 SHA512:
-  metadata.gz: 5fba150903e4924d507e1f13526578e47f6b0164d170d89d6c6f7f96564d657ab2bc1dc5901d7a2e1bbbd9146ddc4de4d9e8d1a5c3f228ca9ca7aed2e864c1e7
-  data.tar.gz: 4ae154068e6e42f69b79f4b20555f77e73e5499c5e2e072a3e8c77ecb1e6049404b7883486c712351ee534277b68d941de9132f7d5c1e6a001ead12e553dcba6
+  metadata.gz: 3c117a3e88a73ef1f712407d5fab186500759ec62f66f5617685dbeebed75b2a3a58adf0fd2f225b8b2dcfd6015864d0fe70e8729932abebddd07c93f65a2144
+  data.tar.gz: 8c661d04be05bf37b2916f79033b16f2a5208fb99978a03e31b05c5eddf3f2d39825fd946b95bef7e304b9799c7c6cf48c08cbf192b27e27051fc099119ff7ff

data/README.md

@@ -126,8 +126,8 @@ Services::Users::Delete.call [1, 2, 3]                   # with an array of user
 
 # Execute asynchronously/in the background
 
-Services::Users::Delete.perform_async 1                  # with a user ID
-Services::Users::Delete.perform_async [1, 2, 3]          # with multiple user IDs
+Services::Users::Delete.call_async 1                     # with a user ID
+Services::Users::Delete.call_async [1, 2, 3]             # with multiple user IDs
 ```
 
 As you can see, you cannot use objects or a ActiveRecord::Relation as parameters when calling a service asynchronously since the arguments are serialized to Redis. This might change once Services works with [ActiveJob](https://github.com/rails/rails/tree/master/activejob) and [GlobalID](https://github.com/rails/globalid/).

data/lib/services/asyncable.rb

@@ -12,7 +12,9 @@ module Services
     extend ActiveSupport::Concern
 
     # The name of the parameter that is added to the parameter list when calling a method to be processed in the background.
-    TARGET_PARAM_NAME = :async_target_id
+    TARGET_PARAM_NAME = :async_target_id.freeze
+
+    ASYNC_METHOD_SUFFIXES = %i(async in at).freeze
 
     included do
       include Sidekiq::Worker
@@ -22,19 +24,24 @@ module Services
       # Bulk enqueue items
       # args can either be a one-dimensional or two-dimensional array,
       # each item in args should be the arguments for one job.
-      def bulk_perform_async(args)
-        # Convert args to two-dimensional array if it isn't already.
+      def bulk_call_async(args)
+        # Convert args to two-dimensional array if it isn't one already.
         args = args.map { |arg| [arg] } if args.none? { |arg| arg.is_a?(Array) }
         Sidekiq::Client.push_bulk 'class' => self, 'args' => args
       end
+
+      ASYNC_METHOD_SUFFIXES.each do |async_method_suffix|
+        define_method "call_#{async_method_suffix}" do |*args|
+          self.public_send "perform_#{async_method_suffix}", *args
+        end
+      end
     end
 
-    %w(perform_async perform_in).each do |method_name|
-      define_method method_name do |*args|
-        self.class.send method_name, *args, TARGET_PARAM_NAME => self.id
+    ASYNC_METHOD_SUFFIXES.each do |async_method_suffix|
+      define_method "call_#{async_method_suffix}" do |*args|
+        self.class.public_send "perform_#{async_method_suffix}", *args, TARGET_PARAM_NAME => self.id
       end
     end
-    alias_method :perform_at, :perform_in
 
     def perform(*args)
       return self.call(*args) if self.is_a?(Services::Base)
@@ -45,7 +52,7 @@ module Services
         self.class
       end
 
-      target.send *args
+      target.public_send *args
     end
   end
 end

data/lib/services/base.rb

@@ -9,9 +9,9 @@ module Services
     class << self
       def inherited(subclass)
         subclass.const_set :Error, Class.new(StandardError)
-        subclass.send :include, Rails.application.routes.url_helpers if defined?(Rails)
-        subclass.send :include, Asyncable if defined?(Asyncable)
-        subclass.send :prepend, CallLogger, ExceptionWrapper, UniquenessChecker
+        subclass.public_send :include, Rails.application.routes.url_helpers if defined?(Rails)
+        subclass.public_send :include, Asyncable if defined?(Asyncable)
+        subclass.public_send :prepend, CallLogger, ExceptionWrapper, UniquenessChecker
       end
 
       delegate :call, to: :new

data/lib/services/logger/file.rb

@@ -14,7 +14,7 @@ module Services
           [k, v].join('=')
         end
         @logger.tagged Time.now, severity.upcase, *tags do
-          @logger.send severity, message
+          @logger.public_send severity, message
         end
       end
     end

data/lib/services/logger/redis.rb

@@ -8,7 +8,7 @@ module Services
         Symbol,
         String,
         Numeric
-      ]
+      ].freeze
 
       InvalidMetaError                 = Class.new(StandardError)
       EmptyResponseFromRedisMultiError = Class.new(StandardError)

data/lib/services/modules/uniqueness_checker.rb

@@ -4,17 +4,17 @@ module Services
       KEY_PREFIX = %w(
         services
         uniqueness
-      ).join(':')
+      ).join(':').freeze
 
       ON_ERROR = %i(
         fail
         ignore
         reschedule
         return
-      )
+      ).freeze
 
-      MAX_RETRIES = 10
-      ONE_DAY     = 60 * 60 * 24
+      MAX_RETRIES = 10.freeze
+      ONE_DAY     = (60 * 60 * 24).freeze
 
       def self.prepended(mod)
         mod.const_set :NotUniqueError, Class.new(mod::Error)
@@ -95,7 +95,7 @@ module Services
           convert_for_rescheduling arg
         end
         log "Rescheduling to be executed in #{retry_delay} seconds." if self.respond_to?(:log)
-        self.class.perform_in retry_delay, *reschedule_args
+        self.class.call_in retry_delay, *reschedule_args
       end
 
       def error_count

data/lib/services/version.rb

@@ -1,3 +1,3 @@
 module Services
-  VERSION = '4.3.0'
+  VERSION = '5.0.0'.freeze
 end

data/spec/services/modules/uniqueness_checker_spec.rb

@@ -57,7 +57,7 @@ shared_examples 'checking the uniqueness properly' do
           fail_args.each do |fail_arg_group|
             service = service_class.new
             expect(service).to_not receive(:do_work)
-            expect(service_class).to receive(:perform_in).with(an_instance_of(Fixnum), *fail_arg_group, 'reschedule', false)
+            expect(service_class).to receive(:call_in).with(an_instance_of(Fixnum), *fail_arg_group, 'reschedule', false)
             expect { service.call(*fail_arg_group, 'reschedule', false) }.to_not raise_error
           end
         end
@@ -68,7 +68,7 @@ shared_examples 'checking the uniqueness properly' do
           pass_args.each do |pass_arg_group|
             service = service_class.new
             expect(service).to receive(:do_work)
-            expect(service_class).to_not receive(:perform_in)
+            expect(service_class).to_not receive(:call_in)
             expect { service.call(*pass_arg_group, 'reschedule', false) }.to_not raise_error
           end
         end

data/spec/support/helpers.rb

@@ -21,7 +21,7 @@ def wait_for_all_jobs_to_finish
 end
 
 def wait_for_job_to_run(job_class, *args, &block)
-  job_class.perform_async(*args).tap do |jid|
+  job_class.call_async(*args).tap do |jid|
     wait_for { worker_with_jid(jid) }
     block.call if block_given?
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: services
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Manuel Meurer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-13 00:00:00.000000000 Z
+date: 2016-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake