services 4.1.4 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1dc5bf4df6a1672dc93cdc1a8999dd2b60c67491
-  data.tar.gz: 72a50ae2edad15f05f509f8272c7a888ccf76d4d
+  metadata.gz: 5bd1a27e2051a3dfce7845c6d24396c007f17c51
+  data.tar.gz: 55072f152a1356ce1f6be21d3b60ec92ba45ac78
 SHA512:
-  metadata.gz: 6ae6a705a197f1ced734580b48153444b2f311bfb39c96079ba53afaa7623addadfc246de65853bc0100680c217533da534ebd7bdf0eb597b08f850d78ae6fd0
-  data.tar.gz: 306927ee9a380fa98928b085f1f4043da4a841dd526de227c51bf45a51cbf622af120599a7717df8f564478af0ac1ef7855cab0759e1e49131d2701b8568a4f7
+  metadata.gz: 5fba150903e4924d507e1f13526578e47f6b0164d170d89d6c6f7f96564d657ab2bc1dc5901d7a2e1bbbd9146ddc4de4d9e8d1a5c3f228ca9ca7aed2e864c1e7
+  data.tar.gz: 4ae154068e6e42f69b79f4b20555f77e73e5499c5e2e072a3e8c77ecb1e6049404b7883486c712351ee534277b68d941de9132f7d5c1e6a001ead12e553dcba6

data/.gitignore

@@ -1,2 +1,3 @@
 Gemfile.lock
+gemfiles/*.gemfile.lock
 spec/support/log/**/*.log

data/.travis.yml

@@ -1,11 +1,15 @@
 language: ruby
 rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-  - 2.3.0
+  - 2.2.5
+  - 2.3.1
 services:
   - redis-server
 before_install:
   - gem update --system
   - gem update bundler
+gemfile:
+  - gemfiles/rails_4.0.gemfile
+  - gemfiles/rails_4.1.gemfile
+  - gemfiles/rails_4.2.gemfile
+  - gemfiles/rails_5.0.gemfile
+sudo: false

data/Appraisals

@@ -0,0 +1,15 @@
+appraise 'rails_4.0' do
+  gem 'rails', '~> 4.0.0'
+end
+
+appraise 'rails_4.1' do
+  gem 'rails', '~> 4.1.0'
+end
+
+appraise 'rails_4.2' do
+  gem 'rails', '~> 4.2.0'
+end
+
+appraise 'rails_5.0' do
+  gem 'rails', '~> 5.0.0'
+end

data/Guardfile

@@ -62,7 +62,7 @@ module ::Guard
   end
 end
 
-guard 'rspec', cmd: 'bundle exec rspec' do
+guard 'rspec', cmd: 'bundle exec appraisal rspec' do
   callback ServicesGemHelpers::OnStart.new, :start_begin
   callback ServicesGemHelpers::OnStop.new,  :stop_begin
 

data/README.md

@@ -19,9 +19,9 @@ For disambiguation: in this README, when you read "Services" with a uppercase "S
 
 ### Requirements
 
-#### Ruby >= 2.0
+#### Ruby >= 2.2.3
 
-#### Rails >= 3.2
+#### Rails >= 4.0
 
 #### Redis >= 2.8
 
@@ -57,7 +57,8 @@ Follow these conventions when using Services in your Rails app, and you'll be fi
 * Let your services inherit from `Services::Base`
 * Let your query objects inherit from `Services::Query`
 * Put your services in `app/services/`
-* Namespace your services with the model they operate on and give them "verb names", e.g. `app/services/users/delete.rb` defines `Services::Users::Delete`. If a service operates on multiple models or no models at all, don't namespace them (`Services::DoStuff`) or namespace them by logical groups unrelated to models (`Services::Maintenance::CleanOldStuff`, `Services::Maintenance::SendDailySummary`, etc.)
+* Decide if you want to use a `Services` namespace or not. Namespacing your service allows you to use a name for them that some other class or module in your app has (e.g. you can have a `Services::Maintenance` service, yet also a `Maintenance` module in `lib`). Not using a namespace saves you from writing `Services::` everytime you want to reference a service in your app. Both approaches are fine, pick one and stick to it.
+* Give your services "verby" names, e.g. `app/services/users/delete.rb` defines `Users::Delete` (or `Services::Users::Delete`, see above). If a service operates on multiple models or no models at all, don't namespace them (`Services::DoStuff`) or namespace them by logical groups unrelated to models (`Services::Maintenance::CleanOldStuff`, `Services::Maintenance::SendDailySummary`, etc.)
 * Some services call other services. Try to not combine multiple calls to other services and business logic in one service. Instead, some services should contain only business logic and other services only a bunch of service calls but no (or little) business logic. This keeps your services nice and modular.
 
 ### Configuration
@@ -67,22 +68,22 @@ You can/should configure Services in an initializer:
 ```ruby
 # config/initializers/services.rb
 Services.configure do |config|
-  config.logger = Services::Logger::Redis.new(Redis.new)    # see Logging
-  config.redis  = Redis.new                                 # optional, if Redis.current is defined. Otherwise it is recommended to use
-                                                            # a [connection pool](https://github.com/mperham/connection_pool).
+  config.logger = Services::Logger::Redis.new(Redis.new)    # see [Logging](#Logging)
+  config.redis  = Redis.new                                 # optional, if `Redis.current` is defined. Otherwise it is recommended to use
+                                                            # a [connection pool](https://github.com/mperham/connection_pool) here instead of simply `Redis.new`.
 end
 ```
 
-### Rails autoload fix
+### Rails autoload fix for `Services` namespace
 
-By default, Rails expects `app/services/users/delete.rb` to define `Users::Delete`, but we want it to expect `Services::Users::Delete`. To make this work, add the `app` folder to the autoload path:
+By default, Rails expects `app/services/users/delete.rb` to define `Users::Delete`. If you want to use the `Services` namespace for your services, we want it to expect `Services::Users::Delete`. To make this work, add the `app` folder to the autoload path:
 
 ```ruby
 # config/application.rb
 config.autoload_paths += [config.root.join('app')]
 ```
 
-This looks as if it might break things, but I've never had any problems with it.
+This looks as if it might break things, but AFAIK it has never cause problems so far.
 
 ### Services::Base
 
@@ -227,7 +228,7 @@ to be described...
 
 ### Background/asynchronous processing
 
-to be described...
+Each service can run synchronously (i.e. blocking/in the foreground) or asynchronously (i.e. non-blocking/in the background). If you want to run a service in the background, make sure it takes only arguments that can be serialized without problems (i.e. integers, strings, etc.). The background processing is done by Sidekiq, so you must set up Sidekiq in the Services initializer.
 
 ## Installation
 

data/gemfiles/rails_4.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.0.0"
+
+gemspec :path => "../"

data/gemfiles/rails_4.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.1.0"
+
+gemspec :path => "../"

data/gemfiles/rails_4.2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.2.0"
+
+gemspec :path => "../"

data/gemfiles/rails_5.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+
+gemspec :path => "../"

data/lib/services/base.rb

@@ -60,7 +60,7 @@ module Services
       ids, objects = _split_ids_and_objects(ids_or_objects, klass)
       if ids.any?
         objects_from_ids = find_service(klass).call(ids)
-        object_ids = if objects_from_ids.respond_to?(:pluck)
+        object_ids = if objects_from_ids.is_a?(ActiveRecord::Relation)
           objects_from_ids.pluck(:id)
         else
           objects_from_ids.map(&:id)

data/lib/services/version.rb

@@ -1,3 +1,3 @@
 module Services
-  VERSION = '4.1.4'
+  VERSION = '4.3.0'
 end

data/services.gemspec

@@ -29,6 +29,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'tries',       '~> 0.3'
   gem.add_development_dependency 'timecop',     '~> 0.7'
   gem.add_development_dependency 'sqlite3',     '~> 1.3'
-  gem.add_runtime_dependency     'rails',       '>= 3.2.0'
+  gem.add_development_dependency 'appraisal',   '~> 2.1'
+  gem.add_runtime_dependency     'rails',       '>= 4.0.0'
   gem.add_runtime_dependency     'gem_config',  '~> 0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: services
 version: !ruby/object:Gem::Version
-  version: 4.1.4
+  version: 4.3.0
 platform: ruby
 authors:
 - Manuel Meurer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-10 00:00:00.000000000 Z
+date: 2016-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -122,20 +122,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: gem_config
   requirement: !ruby/object:Gem::Requirement
@@ -158,12 +172,17 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- Appraisals
 - CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- gemfiles/rails_4.0.gemfile
+- gemfiles/rails_4.1.gemfile
+- gemfiles/rails_4.2.gemfile
+- gemfiles/rails_5.0.gemfile
 - lib/services.rb
 - lib/services/asyncable.rb
 - lib/services/base.rb
@@ -214,7 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: A nifty service layer for your Rails app