services 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 27e055eee440bd9ed9a3dbd75cd00f7d3cb698f7
-  data.tar.gz: 2181326e31959eac2771f156dfbf70cd1823c879
+  metadata.gz: df1ba6063f4bba38b277be74e5ec56cc71872078
+  data.tar.gz: 63d57f90d5d3372c9c88e0aedc79b25a39f3c185
 SHA512:
-  metadata.gz: d7f8e924430f1cdcbcbcdf1ff641c6aa11ec7bc48a48e485af11116ae4e34a7423e4f3331bcd032a77fa6e030cf10f1611633cb8cfb8f034fcb7723903790b63
-  data.tar.gz: 04003c6e3ad8fb6ef39e48ec0c86d35ae039098884d3fe904e3bc2ff0d2efec903c75c12bb6907a62abb124a014d87157e4a81200e3c66f77474666e94c3381f
+  metadata.gz: b2ba9c8855a2c23bf6b559eb6023a8f72b0026e873e6307b7a3532ede57e9553bf3c8451dee1825f793ec183580a060bb4ff123604860dc6f1cd9d7b8a9f9636
+  data.tar.gz: 296aed48e3ce98785a24830bb944ab8763a0987cf38e31c91510372ebec2fbcd3dccd920bc23750e362976e9d146904db9e32e92e0acd62478df3dbcc205062e

data/lib/services/base/uniqueness_checker.rb

@@ -2,21 +2,33 @@ module Services
   class Base
     module UniquenessChecker
       def self.prepended(mod)
+        mod.instance_eval do
+          def check_uniqueness?
+            @check_uniqueness
+          end
+
+          def check_uniqueness!
+            @check_uniqueness = true
+          end
+        end
         mod.const_set :NotUniqueError, Class.new(mod::Error)
       end
 
       def call(*args)
-        # TODO: Check that Services.configuration.redis is set
-        key = unique_key(args)
-        if Services.configuration.redis.exists(key)
-          raise self.class::NotUniqueError
-        else
-          Services.configuration.redis.setex key, 60 * 60, Time.now
-          begin
-            super
-          ensure
-            Services.configuration.redis.del key
+        if self.class.check_uniqueness?
+          key = unique_key(args)
+          if Services.configuration.redis.exists(key)
+            raise self.class::NotUniqueError
+          else
+            Services.configuration.redis.setex key, 60 * 60, Time.now
+            begin
+              super
+            ensure
+              Services.configuration.redis.del key
+            end
           end
+        else
+          super
         end
       end
 

data/lib/services/version.rb

@@ -1,3 +1,3 @@
 module Services
-  VERSION = '0.0.2'
+  VERSION = '0.1.0'
 end

data/services.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'guard-rspec', '~> 4.2'
-  gem.add_development_dependency 'rspec', '>= 3.0.0.beta2', '< 4'
+  gem.add_development_dependency 'rspec', '>= 3.0.0.rc1', '< 4'
   gem.add_development_dependency 'sidekiq', '~> 3.0'
   gem.add_development_dependency 'redis', '~> 3.0'
   gem.add_runtime_dependency 'rails', '>= 3.0.0'

data/spec/services/base_spec.rb

@@ -64,12 +64,24 @@ describe Services::Base do
   end
 
   context 'checking for uniqueness' do
-    it 'raises an error when the same job is executed twice' do
-      LongRunningService.perform_async
-      sleep 0.5 # Wait for Sidekiq to start processing the job
-      expect do
-        LongRunningService.call
-      end.to raise_error(LongRunningService::NotUniqueError)
+    context 'when the service was set to check for uniqueness' do
+      it 'raises an error when the same job is executed twice' do
+        UniqueService.perform_async
+        sleep 0.5 # Wait for Sidekiq to start processing the job
+        expect do
+          UniqueService.call
+        end.to raise_error(UniqueService::NotUniqueError)
+      end
+    end
+
+    context 'when the service was not set to check for uniqueness' do
+      it 'does not raise an error when the same job is executed twice' do
+        NonUniqueService.perform_async
+        sleep 0.5 # Wait for Sidekiq to start processing the job
+        expect do
+          NonUniqueService.call
+        end.to_not raise_error
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -32,7 +32,7 @@ RSpec.configure do |config|
   config.filter_run :focus
   config.order = 'random'
 
-  config.before :all do
+  config.before :suite do
     # Start Redis
     redis_options = {
       daemonize:  'yes',
@@ -59,7 +59,7 @@ RSpec.configure do |config|
     system "bundle exec sidekiq #{options_hash_to_string(sidekiq_options)}"
   end
 
-  config.after :all do
+  config.after :suite do
     # Stop Sidekiq
     system "bundle exec sidekiqctl stop #{sidekiq_pidfile} #{sidekiq_timeout}"
     while File.exist?(sidekiq_pidfile)

data/spec/support/test_services.rb

@@ -1,5 +1,13 @@
-class LongRunningService < Services::Base
+class UniqueService < Services::Base
+  check_uniqueness!
+
   def call
-    sleep 2
+    sleep 1
+  end
+end
+
+class NonUniqueService < Services::Base
+  def call
+    sleep 1
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: services
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Manuel Meurer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-18 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -44,7 +44,7 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta2
+        version: 3.0.0.rc1
     - - <
       - !ruby/object:Gem::Version
         version: '4'
@@ -54,7 +54,7 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta2
+        version: 3.0.0.rc1
     - - <
       - !ruby/object:Gem::Version
         version: '4'