service_variables 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9917573589bdffb40472076662e882113636a230
-  data.tar.gz: c4ff4c6ae49c45b67c9d9658fe5a630cb108b6ae
+  metadata.gz: 7799d8f19f920e3736dc926274f6856dcaf2e533
+  data.tar.gz: 15255d19aaab87e8b8d799c6cdbdac42a8454f4d
 SHA512:
-  metadata.gz: bc15b66bb5a9794ceacfd55a03fef2689e52be9c205355f82f73bb86bc9912b7599ea9817f4af9edabbff1146da0fbac188320b491ae9be88681106e8716ef5d
-  data.tar.gz: 43ce7b6f14f95be633ae240b36b348b774a01ac0f2df5869e39a8ea83830327971c08dd12526215427d488d3b11ab87f3cfd18d0539df675cc049beee1e6c1d1
+  metadata.gz: 5ac95d7463716ed8d09f02959548a60289f7364340b9e40435867ac35fab98717da8426e6fed5a7c1d7b8b05abbd30e5ade24864e3c8bc21e37de7acb4631dac
+  data.tar.gz: 4aa7eeeeabfee449d12b1adf86a0be28e3c6f8b6ef38f1c773a2e30fe879d1817f76f8945982aefd785ceff7f3c5e37961586f8af65ebe1b239d5e444fc95e3d

data/lib/service_variables.rb

@@ -9,22 +9,27 @@ module ServiceVariables
 
   DEFAULT_REDIS_KEY = 'service_variables_redis_key'
   BOOLEAN_VALUES = [true, false, 'true', 'false'].freeze
+  FAILURE_MODES = %i[raise_exception use_default use_last_value].freeze
 
   attr_writer :service_variables_redis_client, :redis_key
 
-  def configure(redis_client:, redis_key: nil)
+  def configure(redis_client:, redis_key: nil, failure_mode: :raise_exception)
     @service_variables_redis_client = redis_client
     @redis_key = redis_key
+
+    raise InvalidValueError unless FAILURE_MODES.include?(failure_mode)
+    @failure_mode = failure_mode
+    @last_value_map = {}
   end
 
-  def boolean_option(name, default: nil)
+  def boolean_option(name, default: nil, failure_mode: @failure_mode)
     getter_method_name = "#{name}?".to_sym
     setter_method_name = "#{name}=".to_sym
 
     define_singleton_method getter_method_name do
       # Note that all values are stored in Redis as strings.
-      value = get(name)
-      value.nil? ? default : get(name) == 'true'
+      value = get(name, failure_mode)
+      value.nil? ? default : get(name, failure_mode) == 'true'
     end
 
     # Allow for `name` and `name?` accessors of boolean options.
@@ -36,9 +41,9 @@ module ServiceVariables
     end
   end
 
-  def integer_option(name, default: nil, min: nil, max: nil)
+  def integer_option(name, default: nil, min: nil, max: nil, failure_mode: @failure_mode)
     define_singleton_method name do
-      get(name)&.to_i || default
+      get(name, failure_mode)&.to_i || default
     end
 
     define_singleton_method "#{name}=" do |value|
@@ -49,9 +54,9 @@ module ServiceVariables
     end
   end
 
-  def float_option(name, default: nil, min: nil, max: nil)
+  def float_option(name, default: nil, min: nil, max: nil, failure_mode: @failure_mode)
     define_singleton_method name do
-      get(name)&.to_f || default
+      get(name, failure_mode)&.to_f || default
     end
 
     define_singleton_method "#{name}=" do |value|
@@ -62,9 +67,9 @@ module ServiceVariables
     end
   end
 
-  def string_option(name, default: nil, enum: nil)
+  def string_option(name, default: nil, enum: nil, failure_mode: @failure_mode)
     define_singleton_method name do
-      get(name) || default
+      get(name, failure_mode) || default
     end
 
     define_singleton_method "#{name}=" do |value|
@@ -75,8 +80,14 @@ module ServiceVariables
 
   private
 
-  def get(key)
+  def get(key, failure_mode)
     redis.hget(redis_hash_key, key)
+  rescue Redis::BaseConnectionError => e
+    raise e if failure_mode == :raise_exception
+    # If Redis returns a nil, then the default value is used, so we do the same with :use_default
+    return nil if failure_mode == :use_default
+    return @last_value_map[key] if failure_mode == :use_last_value
+    raise InvalidValueError unless FAILURE_MODES.include?(failure_mode)
   end
 
   def set(key, value)
@@ -85,6 +96,8 @@ module ServiceVariables
     else
       redis.hset(redis_hash_key, key, value)
     end
+
+    @last_value_map[key] = value
   end
 
   def redis

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: service_variables
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - coinbase
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: 0.49.0
 description: Wrapper for redis backed configuration variables accessible to multiple
   servers.
 email: opensource@coinbase.com
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Service level variables.