service_skeleton 0.0.0.30.g32b8169 → 0.0.0.48.g4a40599

data/lib/service_skeleton.rb

@@ -1,8 +1,13 @@
-require_relative "service_skeleton/config"
+# frozen_string_literal: true
+
+require_relative "service_skeleton/config_class"
 require_relative "service_skeleton/config_variables"
+require_relative "service_skeleton/generator"
 require_relative "service_skeleton/logging_helpers"
 require_relative "service_skeleton/metrics_methods"
-require_relative "service_skeleton/signal_handler"
+require_relative "service_skeleton/service_name"
+require_relative "service_skeleton/signals_methods"
+require_relative "service_skeleton/ultravisor_children"
 
 require "frankenstein/ruby_gc_metrics"
 require "frankenstein/ruby_vm_metrics"
@@ -11,195 +16,26 @@ require "frankenstein/server"
 require "prometheus/client/registry"
 require "sigdump"
 
-class ServiceSkeleton
-  extend ServiceSkeleton::ConfigVariables
-
+module ServiceSkeleton
   include ServiceSkeleton::LoggingHelpers
+  extend ServiceSkeleton::Generator
 
-  class Terminate < Exception; end
-
-  def self.config_class(klass)
-    @config_class = klass
-  end
-
-  def self.service_name
-    service_name_from_class(self)
+  def self.included(mod)
+    mod.extend ServiceSkeleton::ServiceName
+    mod.extend ServiceSkeleton::ConfigVariables
+    mod.extend ServiceSkeleton::ConfigClass
+    mod.extend ServiceSkeleton::MetricsMethods
+    mod.extend ServiceSkeleton::SignalsMethods
+    mod.extend ServiceSkeleton::UltravisorChildren
   end
 
   attr_reader :config, :metrics, :logger
 
-  def initialize(env)
-    @env      = env
-    @config   = (self.class.instance_variable_get(:@config_class) || ServiceSkeleton::Config).new(env, self)
-    @logger   = @config.logger
-    @op_mutex = Mutex.new
-
-    initialize_metrics
-    initialize_signals
-  end
-
-  def start
-    @op_mutex.synchronize { @thread = Thread.current }
-
-    begin
-      logger.info(logloc) { "Starting service #{service_name}" }
-      logger.info(logloc) { (["Environment:"] + config.env.map { |k, v| "#{k}=#{v.inspect}" }).join("\n  ") }
-
-      start_metrics_server
-      start_signal_handler
-      run
-    rescue ServiceSkeleton::Terminate
-      # This one is OK
-    rescue ServiceSkeleton::Error::InheritanceContractError
-      # We want this one to be fatal
-      raise
-    rescue StandardError => ex
-      log_exception(ex)
-    end
-
-    @thread = nil
-  end
-
-  def stop(force = false)
-    if force
-      #:nocov:
-      @op_mutex.synchronize do
-        if @thread
-          @thread.raise(ServiceSkeleton::Terminate)
-        end
-      end
-      #:nocov:
-    else
-      shutdown
-    end
-
-    if @metrics_server
-      @metrics_server.shutdown
-      @metrics_server = nil
-    end
-
-    @signal_handler.stop!
-  end
-
-  def service_name
-    self.class.service_name
-  end
-
-  def registered_variables
-    self.class.registered_variables
-  end
-
-  def hook_signal(spec, &blk)
-    @signal_handler.hook_signal(spec, &blk)
-  end
-
-  private
-
-  def self.service_name_from_class(klass)
-    klass.to_s
-      .gsub("::", "_")
-      .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-      .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-      .downcase
-      .gsub(/[^a-zA-Z0-9_]/, "_")
-  end
-
-  def run
-    raise ServiceSkeleton::Error::InheritanceContractError, "ServiceSkeleton#run method not overridden"
-  end
-
-  def shutdown
-    #:nocov:
-    @op_mutex.synchronize do
-      if @thread
-        @thread.raise(ServiceSkeleton::Terminate)
-        @thread.join
-        @thread = nil
-      end
-    end
-    #:nocov:
-  end
-
-  def initialize_metrics
-    @metrics = Prometheus::Client::Registry.new
-
-    Frankenstein::RubyGCMetrics.register(@metrics)
-    Frankenstein::RubyVMMetrics.register(@metrics)
-    Frankenstein::ProcessMetrics.register(@metrics)
-
-    @metrics.singleton_class.prepend(ServiceSkeleton::MetricsMethods)
-    @metrics.service = self
-  end
-
-  def start_metrics_server
-    if config.metrics_port
-      logger.info(logloc) { "Starting metrics server on port #{config.metrics_port}" }
-
-      @metrics_server = Frankenstein::Server.new(
-        port: config.metrics_port,
-        logger: logger,
-        metrics_prefix: :metrics_server,
-        registry: @metrics,
-      )
-      @metrics_server.run
-    end
-  end
-
-  def initialize_signals
-    metrics.counter(:"#{self.service_name}_signals_handled_total", "How many of each type of signal have been handled")
-    @signal_handler = ServiceSkeleton::SignalHandler.new(logger: logger, service: self, signal_counter: metrics.signals_handled_total)
-
-    @signal_handler.hook_signal("USR1") do
-      logger.level -= 1 unless logger.level == Logger::DEBUG
-      logger.info($0) { "Received SIGUSR1; log level is now #{Logger::SEV_LABEL[logger.level]}." }
-    end
-
-    @signal_handler.hook_signal("USR2") do
-      logger.level += 1 unless logger.level == Logger::ERROR
-      logger.info($0) { "Received SIGUSR2; log level is now #{Logger::SEV_LABEL[logger.level]}." }
-    end
-
-    @signal_handler.hook_signal("HUP") do
-      logger.reopen
-      logger.info($0) { "Received SIGHUP; log file handle reopened" }
-    end
-
-    @signal_handler.hook_signal("QUIT") do
-      Sigdump.dump("+")
-    end
-
-    @signal_handler.hook_signal("INT") do
-      self.stop(!!@terminating)
-      @terminating = true
-    end
-
-    @signal_handler.hook_signal("TERM") do
-      self.stop(!!@terminating)
-      @terminating = true
-    end
-  end
-
-  def start_signal_handler
-    @signal_handler.start!
-  end
-
-  @registered_variables = [
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOG_LEVEL) { "INFO" },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOGSTASH_SERVER) { "" },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOG_ENABLE_TIMESTAMPS) { false },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOG_FILE) { nil },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOG_MAX_FILE_SIZE) { 1048576 },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_LOG_MAX_FILES) { 3 },
-    ServiceSkeleton::ConfigVariable.new(:SERVICE_SKELETON_METRICS_PORT) { nil },
-  ]
-
-  def self.inherited(subclass)
-    subclass.string(:"#{subclass.service_name.upcase}_LOG_LEVEL", default: "INFO")
-    subclass.string(:"#{subclass.service_name.upcase}_LOGSTASH_SERVER", default: "")
-    subclass.boolean(:"#{subclass.service_name.upcase}_LOG_ENABLE_TIMESTAMPS", default: false)
-    subclass.string(:"#{subclass.service_name.upcase}_LOG_FILE", default: nil)
-    subclass.integer(:"#{subclass.service_name.upcase}_LOG_MAX_FILE_SIZE", default: 1048576, range: 0..Float::INFINITY)
-    subclass.integer(:"#{subclass.service_name.upcase}_LOG_MAX_FILES", default: 3, range: 1..Float::INFINITY)
-    subclass.integer(:"#{subclass.service_name.upcase}_METRICS_PORT", default: nil, range: 1..65535)
+  def initialize(*_, metrics:, config:)
+    @metrics = metrics
+    @config  = config
+    @logger  = @config.logger
   end
 end
+
+require_relative "service_skeleton/runner"

data/lib/service_skeleton/config.rb

@@ -1,47 +1,57 @@
+# frozen_string_literal: true
+
 require "to_regexp"
 
 require_relative "./filtering_logger"
 
 require "loggerstash"
 
-class ServiceSkeleton
+module ServiceSkeleton
   class Config
-    attr_reader :logger, :env
+    attr_reader :logger, :env, :service_name
 
-    def initialize(env, svc)
-      @svc = svc
+    def initialize(env, service_name, variables)
+      @service_name = service_name
 
-      parse_registered_variables(env)
+      # Parsing variables will redact the environment, so we want to take a
+      # private unredacted copy before that happens for #[] lookup in the
+      # future.
       @env = env.to_hash.dup.freeze
+
+      parse_variables(internal_variables + variables, env)
+
+      # Sadly, we can't setup the logger until we know *how* to setup the
+      # logger, which requires parsing config variables
       setup_logger
     end
 
     def [](k)
-      @env[k]
+      @env[k].dup
     end
 
     private
 
-    def parse_registered_variables(env)
-      @svc.registered_variables.each do |var|
-        val = var.value(env)
+    def parse_variables(variables, env)
+      variables.map do |var|
+        var[:class].new(var[:name], env, **var[:opts])
+      end.each do |var|
+        val = var.value
+        method_name = var.method_name(@service_name).to_sym
 
-        define_singleton_method(var.method_name(@svc.service_name)) do
+        define_singleton_method(method_name) do
           val
         end
 
-        define_singleton_method(var.method_name(@svc.service_name) + "=") do |v|
-          val = v
+        define_singleton_method(:"#{method_name}=") do |new_value|
+          val = new_value
         end
-
-        if var.sensitive?
+      end.each do |var|
+        if var.redact?(env)
           if env.object_id != ENV.object_id
             raise ServiceSkeleton::Error::CannotSanitizeEnvironmentError,
-                  "Attempted to sanitize sensitive variable #{var.name}, but was not passed the ENV object"
-          end
-
-          var.env_keys(env).each do |k|
-            env[k] = "*SENSITIVE*"
+                  "Attempted to sanitize sensitive variable #{var.name}, but we're not operating on the process' environment"
+          else
+            var.redact!(env)
           end
         end
       end
@@ -56,30 +66,35 @@ class ServiceSkeleton
 
       @logger = Logger.new(log_file || $stderr, shift_age, shift_size)
 
-      if self.logstash_server && !self.logstash_server.empty?
-        loggerstash = Loggerstash.new(logstash_server: logstash_server, logger: @logger)
-        loggerstash.metrics_registry = @svc.metrics
-        loggerstash.attach(@logger)
-      end
-
-      thread_id_map = {}
       if Thread.main
-        thread_id_map[Thread.main.object_id] = 0
+        Thread.main[:thread_map_number] = 0
       else
         #:nocov:
-        thread_id_map[Thread.current.object_id] = 0
+        Thread.current[:thread_map_number] = 0
         #:nocov:
       end
 
+      thread_map_mutex = Mutex.new
+
       @logger.formatter = ->(s, t, p, m) do
-        th_n = thread_id_map[Thread.current.object_id] || (thread_id_map[Thread.current.object_id] = thread_id_map.length)
+        th_n = if Thread.current.name
+          #:nocov:
+          Thread.current.name
+          #:nocov:
+        else
+          thread_map_mutex.synchronize do
+            Thread.current[:thread_map_number] ||= begin
+              Thread.list.select { |th| th[:thread_map_number] }.length
+            end
+          end
+        end
 
         ts = log_enable_timestamps ? "#{t.utc.strftime("%FT%T.%NZ")} " : ""
-        "#{ts}##{th_n} #{s[0]} [#{p}] #{m}\n"
+        "#{ts}#{$$}##{th_n} #{s[0]} [#{p}] #{m}\n"
       end
 
       @logger.filters = []
-      @env.fetch("#{@svc.service_name.upcase}_LOG_LEVEL", "INFO").split(/\s*,\s*/).each do |spec|
+      @env.fetch("#{@service_name.upcase}_LOG_LEVEL", "INFO").split(/\s*,\s*/).each do |spec|
         if spec.index("=")
           # "Your developers were so preoccupied with whether or not they
           # could, they didn't stop to think if they should."
@@ -102,5 +117,17 @@ class ServiceSkeleton
         end
       end
     end
+
+    def internal_variables
+      [
+        { name: "#{@service_name.upcase}_LOG_LEVEL",             class: ConfigVariable::String,  opts: { default: "INFO" } },
+        { name: "#{@service_name.upcase}_LOG_ENABLE_TIMESTAMPS", class: ConfigVariable::Boolean, opts: { default: false } },
+        { name: "#{@service_name.upcase}_LOG_FILE",              class: ConfigVariable::String,  opts: { default: nil } },
+        { name: "#{@service_name.upcase}_LOG_MAX_FILE_SIZE",     class: ConfigVariable::Integer, opts: { default: 1048576, range: 0..Float::INFINITY } },
+        { name: "#{@service_name.upcase}_LOG_MAX_FILES",         class: ConfigVariable::Integer, opts: { default: 3,       range: 1..Float::INFINITY } },
+        { name: "#{@service_name.upcase}_LOGSTASH_SERVER",       class: ConfigVariable::String,  opts: { default: "" } },
+        { name: "#{@service_name.upcase}_METRICS_PORT",          class: ConfigVariable::Integer, opts: { default: nil,     range: 1..65535 } },
+      ]
+    end
   end
 end

data/lib/service_skeleton/config_class.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module ServiceSkeleton
+  module ConfigClass
+    Undefined = Module.new
+    private_constant :Undefined
+
+    def config_class(klass = Undefined)
+      unless klass == Undefined
+        @config_class = klass
+      end
+
+      @config_class
+    end
+  end
+end

data/lib/service_skeleton/config_variable.rb

@@ -1,35 +1,43 @@
-class ServiceSkeleton
+# frozen_string_literal: true
+
+module ServiceSkeleton
   class ConfigVariable
-    attr_reader :name, :key_pattern
+    attr_reader :name, :value
 
-    def initialize(name, **opts, &blk)
+    def initialize(name, env, **opts, &blk)
       @name = name
       @opts = opts
       @blk  = blk
+
+      @value = pluck_value(env)
     end
 
     def method_name(svc_name)
-      name.to_s.gsub(/\A#{Regexp.quote(svc_name)}_/i, '').downcase
+      @name.to_s.gsub(/\A#{Regexp.quote(svc_name)}_/i, '').downcase
     end
 
-    def sensitive?
-      !!@opts[:sensitive]
+    def redact?(env)
+      @opts[:sensitive]
     end
 
-    def value(env)
-      if @opts[:key_pattern]
-        matches = env.select { |k, _| @opts[:key_pattern] === k.to_s }
-        @blk.call(matches)
-      else
-        @blk.call(env[@name.to_s])
+    def redact!(env)
+      if @opts[:sensitive]
+        env[@name.to_s] = "*SENSITIVE*" if env.has_key?(@name.to_s)
       end
     end
 
-    def env_keys(env)
-      if @opts[:key_pattern]
-        env.keys.select { |k| @opts[:key_pattern] === k.to_s }
+    private
+
+    def maybe_default(env)
+      if env.has_key?(@name.to_s)
+        yield
       else
-        env.keys.include?(@name.to_s) ? [@name.to_s] : []
+        if @opts.has_key?(:default)
+          @opts[:default]
+        else
+          raise ServiceSkeleton::Error::InvalidEnvironmentError,
+                "Value for required environment variable #{@name} not specified"
+        end
       end
     end
   end

data/lib/service_skeleton/config_variable/boolean.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "service_skeleton/config_variable"
+
+class ServiceSkeleton::ConfigVariable::Boolean < ServiceSkeleton::ConfigVariable
+  private
+
+  def pluck_value(env)
+    maybe_default(env) do
+      case env[@name.to_s]
+      when /\A(no|n|off|0|false)\z/i
+        false
+      when /\A(yes|y|on|1|true)\z/i
+        true
+      else
+        raise ServiceSkeleton::Error::InvalidEnvironmentError,
+              "Value #{env[@name.to_s].inspect} for environment variable #{@name} is not a valid boolean value"
+      end
+    end
+  end
+end