service_pattern 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb37f2c1aa001cef4abdfe0937e15b82c52bb845d44c9527851bc6d770bfd44d
-  data.tar.gz: 52344b2c5450cb137bcb743c4fe24bf543e5c22c8d61a831a063d5a4b5de7829
+  metadata.gz: 278a1fa25b8d796da5bbd34a1b9f25f4de20bc11e4567290284c04706955e67f
+  data.tar.gz: 839b2968eeecfcce9319b4730eb6b9f58a0fca4529c8a56c063a588af9d35812
 SHA512:
-  metadata.gz: 432e00eceea33e9f3335bcc00a5fc44f153ddbf925e11b853d3e6c698607bac1f090a6060eaa88875c5535d86863212409426b28a7ae5a1c66ad42991ceae1ca
-  data.tar.gz: a072a0f461b12c9e09e7a9d2c80ee593015434797cb6da32ef7825f0ab1c834e6d77caf22cc36ad264f52950980931cef6b7a6de3930a4d53280b2ef563673aa
+  metadata.gz: f8b6f769bb27497d09a37956659e793ebfd1a57fdfa175070fd0ae731ac60e2738c213c0d3a979cd8c4448fe533dfe7f3aaaea506fe0918e156e7f8a6e29f957
+  data.tar.gz: c3e7c12b8d3e5bfce1f963e58dd26e0a540b0594deb2bc94fb5b1c46cb196e2424e2f279601f700b30b856bd1022eab818171d20ab9008e64b6cb52d7af51d12

data/README.md

@@ -23,7 +23,7 @@ Create your first service in "app/services/users/activator_service":
 class Users::ActivatorService < ApplicationService
   def execute
     User.all.find_each(&:activate!)
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 end
 ```
@@ -33,17 +33,35 @@ Then call it like this:
 response = Users::ActivatorService.()
 
 if response.success?
-  puts "Wee"
+  puts "Result: #{response.result}"
 else
-  puts "Errors: #{result.errors.join(". ")}"
+  puts "Errors: #{response.errors.join(". ")}"
 end
 ```
 
+Or like this:
+```ruby
+response = Users::ActivatorService.execute()
+
+if response.success?
+  puts "Result: #{response.result}"
+else
+  puts "Errors: #{response.errors.join(". ")}"
+end
+```
+
+Or raise an error if it fails and return the result directly:
+```ruby
+result = Users::ActivatorService.execute!
+
+puts "Result: #{result}"
+```
+
 ### Returning results
 
 You can also return a result, which will automatically make the response successfull:
 ```ruby
-ServicePattern::Response.new(result: {message: "Hello world"})
+succeed!(message: "Hello world")
 ```
 
 You can then retrieve it like this:
@@ -52,5 +70,15 @@ response = Users::ActivatorService.()
 puts "Result: #{response.result}"
 ```
 
+You can fail a service like this
+```ruby
+fail! "Hello world"
+```
+
+Or with multiple errors:
+```ruby
+fail! ["Hello world", "Hello again"]
+```
+
 ## License
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/lib/service_pattern/failed_error.rb

@@ -1 +1,3 @@
-class ServicePattern::FailedError < RuntimeError; end
+class ServicePattern::FailedError < RuntimeError
+  attr_accessor :errors
+end

data/lib/service_pattern/response.rb

@@ -1,19 +1,10 @@
 class ServicePattern::Response
   attr_reader :errors, :result
 
-  def initialize(args)
-    @errors = args[:errors] || []
-    @result = args[:result]
-
-    if args.key?(:success)
-      @success = args.fetch(:success)
-    elsif args.key?(:errors) && @errors.any?
-      @success = false
-    elsif @result
-      @success = true
-    else
-      raise "Couldn't figure out if it was a success"
-    end
+  def initialize(errors: [], result: nil)
+    @errors = errors
+    @result = result
+    @success = !errors || errors.empty?
   end
 
   def success?

data/lib/service_pattern/service.rb

@@ -4,7 +4,7 @@ class ServicePattern::Service
     service = new(*args, &blk)
 
     can_execute_response = service.can_execute?
-    raise ServicePattern::FailedError, can_execute_response.errors.join(". ") unless can_execute_response.success?
+    ServicePattern::Service.fail!(can_execute_response.errors) unless can_execute_response.success?
 
     service.execute
   end
@@ -21,21 +21,35 @@ class ServicePattern::Service
 
     service.execute
   rescue ServicePattern::FailedError => e
-    ServicePattern::Response.new(errors: [e.message])
+    ServicePattern::Response.new(errors: e.errors)
   end
 
   def self.execute!(*args, &blk)
     response = execute(*args, &blk)
-    raise ServicePattern::FailedError, response.errors.join(". ") unless response.success?
-
+    ServicePattern::Service.fail!(response.errors) unless response.success?
     response.result
   end
 
+  def self.fail!(errors)
+    errors = [errors] unless errors.is_a?(Array)
+    error =  ServicePattern::FailedError.new(errors.join(". "))
+    error.errors = errors
+    raise error
+  end
+
   def can_execute?
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 
   def execute(*_args)
-    raise NoMethodError, "You should implement the `execute!` method on your service"
+    raise NoMethodError, "You should implement the `execute` method on your service"
+  end
+
+  def fail!(errors)
+    ServicePattern::Service.fail!(errors)
+  end
+
+  def succeed!(result = nil)
+    ServicePattern::Response.new(result: result)
   end
 end

data/lib/service_pattern/version.rb

@@ -1,3 +1,3 @@
 module ServicePattern
-  VERSION = "0.0.4".freeze
+  VERSION = "0.0.5".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: service_pattern
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-19 00:00:00.000000000 Z
+date: 2019-12-31 00:00:00.000000000 Z
 dependencies: []
 description: ServicePattern for Ruby on Rails.
 email: