service_core 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f67c3782ff8c7f937074ff46819d3be8e1a292c34626d78679b3c76678b7691b
-  data.tar.gz: c7d291d06cfa2c133ced540e3a7d93c587af49237ec9623a4faaeb2aa04aff11
+  metadata.gz: d9e82b7404a555e1d2b60d559e82b3f37a2cfe829ad947687f5e290252b87712
+  data.tar.gz: a170ee5ab04fe57be88786b027b07ca1db31732fa316eafb0a36b10c827c078c
 SHA512:
-  metadata.gz: c0b1d2784eeeb0c9c1bb640127a4a492f702b7fc092b584f5f6f019afb13999e3cfda5a101ef1561971c543f3eb56f5e1fd677fbd832c2f0739daa2898474d3f
-  data.tar.gz: 5f069a26c2734b989cd870671d1f66e99c9a1fe3559be78ab5f1ad4a133a7677cd00c614278f138f1a656ab5f7737850f7df286d5f787f8ab5e15258acad2a3d
+  metadata.gz: 2a109447da13844396e83db86186849598c0ad4b55b845d07fb6c8c1592aa7a10dc69b135cd84785b407588580871470bf94132158e60c2b237b7a05fdd099ff
+  data.tar.gz: b2a495f969e193f7f6a9403c32fd88cf7586f49150268d61bbb600ea565ed039107aa1edc119cf8c5ebc37614f303a10471230292294c420930d3f19241c6539

data/.rubocop.yml

@@ -1,14 +1,25 @@
+plugins:
+  - rubocop-rake
+
 require:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.1
   NewCops: enable
+  SuggestExtensions: false
+  Exclude:
+    - "gemfiles/**/*"
+    - "vendor/**/*"
 
 Style/StringLiterals:
   Enabled: true
   EnforcedStyle: double_quotes
 
+# Per project style, frozen_string_literal magic comments are not used.
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/StringLiteralsInInterpolation:
   Enabled: true
   EnforcedStyle: double_quotes
@@ -32,4 +43,10 @@ RSpec/MessageSpies:
   Enabled: false
 
 RSpec/VerifiedDoubleReference:
-  Enabled: false
+  Enabled: false
+
+# add_error_and_validate is part of the public API and intentionally returns
+# the boolean result of valid?, but its name describes the action it performs.
+Naming/PredicateMethod:
+  AllowedMethods:
+    - add_error_and_validate

data/.tool-versions

@@ -0,0 +1 @@
+ruby 3.4.9

data/Appraisals

@@ -0,0 +1,19 @@
+# Each appraisal pins ActiveModel/ActiveSupport to a maintained Rails release.
+# Older Rails versions (6.1, 7.0, 7.1) are still permitted by the gemspec
+# floor but are not exercised here because their upstream support window
+# has ended.
+
+appraise "rails-7.2" do
+  gem("activemodel", "~> 7.2.0")
+  gem("activesupport", "~> 7.2.0")
+end
+
+appraise "rails-8.0" do
+  gem("activemodel", "~> 8.0.0")
+  gem("activesupport", "~> 8.0.0")
+end
+
+appraise "rails-8.1" do
+  gem("activemodel", "~> 8.1.0")
+  gem("activesupport", "~> 8.1.0")
+end

data/CHANGELOG.md

@@ -1,5 +1,83 @@
+# Changelog
+
+All notable changes to this project are documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
 ## [Unreleased]
 
+## [1.0.0] - 2026-05-14
+
+### Added
+
+- `ServiceCore::Response`: a Hash-compatible value object backing
+  `service.response` / `service.output` and the return of `#call`. Adds
+  named accessors (`response.status`, `response.data`, `response.message`,
+  `response.errors`), Hash-style `[]` / `[]=` / `==`, `dig`, `fetch`,
+  `each_pair`, and `as_json` / `to_json`. Callers that previously
+  reached for `service.output[:key]` on the 0.1.0 Hash output continue
+  to work unchanged.
+- `service.response` as an alias for `service.output`.
+- `ServiceCore::FieldSet`: an immutable snapshot for `service.fields`.
+  Each declared symbol field is exposed as a real method (e.g.
+  `service.fields.first_name`); call `to_h` for a plain Hash.
+- `field` raises `ServiceCore::ReservedFieldName` when the declared name
+  would shadow a ServiceCore method. The reserved names are `:call`,
+  `:errors`, `:fields`, `:output`, `:perform` and `:response`. Previously
+  these names silently overrode gem internals (most dangerously
+  `:errors`, which broke `ActiveModel::Validations`).
+- `ServiceCore::Error` hierarchy with concrete subclasses
+  `ServiceCore::InvalidKey` (raised by `Response#[]` / `[]=` on a
+  non-allowed key) and `ServiceCore::ReservedFieldName`. `Error` itself
+  existed since 0.1.0 but was never raised; `rescue ServiceCore::Error`
+  now actually catches things.
+- Cross-Rails test matrix via `appraisal`: Rails 7.2, 8.0 and 8.1.
+- CI matrix across Ruby 3.3, 3.4 and 4.0 (excluding Ruby 4.0 + Rails 7.2).
+
+### Changed
+
+- The mixin that provides `success_response`, `error_response` and
+  `formatted_response` is renamed from `ServiceCore::Response` to
+  `ServiceCore::Responder`. The `Response` name now refers to the value
+  object; the `Responder` mixin is the builder. Both modules are internal
+  implementation details consumed via `include ServiceCore`, so users
+  who only ever `include ServiceCore` are unaffected. Anyone including
+  `ServiceCore::Response` directly must switch to
+  `include ServiceCore::Responder`.
+- Gemspec: `required_ruby_version` raised to `>= 3.1.0` (Ruby 2.7 and 3.0 are EOL).
+- Gemspec: ActiveModel / ActiveSupport range widened to `>= 6.1, < 9.0`.
+- RuboCop bumped to `~> 1.86` with `rubocop-rake` added as a plugin.
+- Replaced `byebug` (unmaintained on Ruby 3+) with the stdlib `debug` gem.
+- Removed `# frozen_string_literal: true` magic comments project-wide in
+  favour of the project style; `VERSION` is now explicitly `.freeze`d.
+- `add_error_and_validate` now forwards its `options` argument to
+  `add_error` (and through to `ActiveModel::Errors#add`), matching its
+  declared signature.
+- Internal cleanups: `Output#initialize` now calls `super()`, the
+  `StepValidation` validator helpers are private, and `auto_assign_status`
+  no longer has the redundant elsif clauses.
+- The class-level `fields_defined` registry is renamed to `field_names`
+  and is now a `Set` of declared names rather than a Hash mapping names
+  to defaults. Typed defaults are still applied through
+  `ActiveModel::Attributes`; the old Hash was a Set with a confusing
+  name and shape.
+- `service.fields` no longer behaves like a Hash. The new `FieldSet`
+  exposes named accessors plus `to_h`. Callers that did
+  `service.fields[:name]` should use `service.fields.name`; iteration
+  goes through `service.fields.to_h.each`.
+
+### Fixed
+
+- `Output#set_output` no longer drops legitimate falsy values. Previously
+  `false`, `0`, and `""` were silently discarded; only `nil` is now skipped.
+- `Responder#formatted_response` no longer gates its writes on
+  ActiveSupport `present?`. `success_response(data: false)` now records
+  `data: false`.
+- `Base.field` no longer swallows positional defaults of `false` or `nil`.
+  The arity of the positional arguments is used instead of `||`, so
+  `field :enabled, :boolean, false` actually defaults to `false`.
+
 ## [0.1.0] - 2024-07-17
 
-- Initial release
+- Initial release.