service_contract 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9da1cdc017268f0fc828d1e33277639fccbecf8
-  data.tar.gz: 29be99f6911a39ec5f4d0deeaae962a46e3e29d4
+  metadata.gz: 3ece676fe679b6486a503e341a6b566b67e19cbd
+  data.tar.gz: 54a78577a17d36b8b3541185aeede59dcb2b32f0
 SHA512:
-  metadata.gz: 7ef421e78853b1643c38562efbcb79701f5eb287ec3dd0a77a310275ea3f24305bbeb3f75373f6440d3f563d13be222f96981f2988c13ab2498280d1cba65e55
-  data.tar.gz: 3088c10ee0e92b76a31de3fe12d973839e3aa04807125bf302791bc5347beb65730c6f91e292c4823207a9e2c84b6863e93d41de4839fb73ee5a2cf06e0c2f56
+  metadata.gz: 29275de62be450eab48f0d59a2e620e922db90d71747a63bb4129d361ed416b6a6136f2854ddb72198a3c246b922f25491325de2fc942b449196c1fffd0b9a07
+  data.tar.gz: fc9814bb7a0615a27c8cc4210c87eca4bc371381efd93af0c4d6379b35d8258eb8177004acfdbbca004a39610506fa37e439e95c72c5bd7481a49fb6f733b1a9

data/lib/service_contract/assertions.rb

@@ -16,6 +16,10 @@ module ServiceContract
         # type should have fields
         type.fields.each do |field|
 
+          #Does data contain attributes that the contract doesn't specify?
+          data_extra_attrs = (data.keys.map(&:to_sym) - type.fields.map{|n| n.name.to_sym})
+          assert_equal 0, data_extra_attrs.size, "#{type.name} contains attributes not described in contract: #{data_extra_attrs.join(',')}"
+
           # ensure the field is present
           value = data.fetch(field.name) do
             data.fetch(field.name.to_sym) do

data/lib/service_contract/avro/endpoint.rb

@@ -25,6 +25,11 @@ module ServiceContract
       protected
 
       def request_method
+        #Check for [<METHOD>] at the front of the doc string. this signals an action override
+        if doc =~ /^\[([A-Z]+)\].+$/
+          return $1
+        end
+
         case name
         when "create"
           "POST"

data/lib/service_contract/version.rb

@@ -1,3 +1,3 @@
 module ServiceContract
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/test/assertions_test.rb

@@ -58,4 +58,24 @@ class AssertionsTest < Minitest::Test
     assert_endpoint_response([{customer_id: [1,2,3]}], endpoint)
   end
 
+  def test_uncontracted_data_not_matching
+    service = SampleService.find(2)
+    assert service, "expect to find a service by version"
+
+    protocol = service.protocol("search_param")
+    endpoint = protocol.endpoint("index")
+
+    # test can be nil
+    failure_data = nil
+    begin
+      assert_endpoint_response([{customer_id: nil, bogus_param: 1}], endpoint)
+    rescue Minitest::Assertion => failure
+      failure_data = failure
+    end
+
+    assert !failure_data.nil?
+    assert failure_data.to_s.include?("not described in contract: bogus_param")
+
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: service_contract
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Jeff Ching
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro