service_actor 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ce3e96190aef06e630c4e930ad942876f27b8f0dc6a00b33c0ff2104d9be9be
-  data.tar.gz: 7badaaa07f340dfd66924417d214f070fc50346ec3d9805c4d115757b2845e22
+  metadata.gz: a514ff7ba650102221cb5062bdcba419620229af17070f8393b7dfbdbcf20eae
+  data.tar.gz: ce94d81e2a1e8cd31cf2b6087b86e71cadd7efa84b0823a420131a80477e7518
 SHA512:
-  metadata.gz: f186543f09b78804ea899b57bc8c78e174de83fa205d0a36d74b3089a17b1e6e71f2ddc6c285ae673b5e796b69ab76f327879b57ff6d97a95c4473aa62d1f763
-  data.tar.gz: 7ecedf103e0b66a462a3cfb9f97a7bdb9ec1ea349b3fe7e2824ac716d9a68f68d29f7dd3828099d7ab6569ae90eac573112317c97a3619a7f1072856727fd1c3
+  metadata.gz: a0ef5dc251c17236382350ffbed06936b344dfa7276f69cc67466cb69a4bcfd408d2017d831913f12db7d72cc7b3b9743223ebd75669c23b9b04c1619480651c
+  data.tar.gz: a038729c6b37a9f6a1f29ef02fc1bc451faa4bb1eb1da62f7feef29f585c778be7cce93d62bedb81195fa6ee4fde814284778693954b8af706453730c2edc442

data/README.md

@@ -337,6 +337,20 @@ end
 
 You can use this to trigger an early success.
 
+### Fail on argument error
+
+By default, errors on inputs will raise an error, even when using `.result`
+instead of `.call`. If instead you want to mark the actor as failed, you can
+catch the exception to treat it as an actor failure:
+
+```rb
+class PlaceOrder < Actor
+  fail_on ServiceActor::ArgumentError
+
+  # …
+end
+```
+
 ## Use with Rails
 
 The [service_actor-rails](https://github.com/sunny/actor-rails/) gem includes a

data/lib/service_actor/base.rb

@@ -19,6 +19,7 @@ require 'service_actor/nil_checkable'
 require 'service_actor/conditionable'
 require 'service_actor/defaultable'
 require 'service_actor/collectionable'
+require 'service_actor/failable'
 
 module ServiceActor
   module Base
@@ -34,6 +35,7 @@ module ServiceActor
       base.include(Conditionable)
       base.include(Defaultable)
       base.include(Collectionable)
+      base.include(Failable)
     end
   end
 end

data/lib/service_actor/conditionable.rb

@@ -29,7 +29,7 @@ module ServiceActor
             next if check.call(value)
 
             raise ArgumentError,
-                  "Input #{key} must #{name} but was #{value.inspect}."
+                  "Input #{key} must #{name} but was #{value.inspect}"
           end
         end
 

data/lib/service_actor/defaultable.rb

@@ -27,7 +27,7 @@ module ServiceActor
             next
           end
 
-          raise(ArgumentError, "Input #{name} on #{self.class} is missing.")
+          raise(ArgumentError, "Input #{name} on #{self.class} is missing")
         end
 
         super

data/lib/service_actor/failable.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module ServiceActor
+  # Adds the `fail_on` DSL to actors. This allows you to call `.result` and get
+  # back a failed actor instead of raising an exception.
+  #
+  #   class ApplicationActor < Actor
+  #     fail_on ServiceActor::ArgumentError
+  #   end
+  module Failable
+    def self.included(base)
+      base.extend(ClassMethods)
+      base.prepend(PrependedMethods)
+    end
+
+    module ClassMethods
+      def inherited(child)
+        super
+
+        child.fail_ons.append(*fail_ons)
+      end
+
+      def fail_on(*exceptions)
+        fail_ons.append(*exceptions)
+      end
+
+      def fail_ons
+        @fail_ons ||= []
+      end
+    end
+
+    module PrependedMethods
+      def _call
+        super
+      rescue *self.class.fail_ons => e
+        fail!(error: e.message)
+      end
+    end
+  end
+end

data/lib/service_actor/nil_checkable.rb

@@ -31,7 +31,7 @@ module ServiceActor
 
           raise ArgumentError,
                 "The #{origin} \"#{name}\" on #{self.class} does not allow " \
-                'nil values.'
+                'nil values'
         end
       end
 

data/lib/service_actor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ServiceActor
-  VERSION = '3.0.0'
+  VERSION = '3.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: service_actor
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-20 00:00:00.000000000 Z
+date: 2020-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: code-scanning-rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -128,6 +142,7 @@ files:
 - lib/service_actor/core.rb
 - lib/service_actor/defaultable.rb
 - lib/service_actor/error.rb
+- lib/service_actor/failable.rb
 - lib/service_actor/failure.rb
 - lib/service_actor/nil_checkable.rb
 - lib/service_actor/playable.rb