serverspec 0.2.27 → 0.2.28

data/.gitignore

@@ -4,6 +4,7 @@
 .config
 .yardoc
 .rspec
+.idea/
 Gemfile.lock
 InstalledFiles
 _yardoc

data/lib/serverspec/commands/linux.rb

@@ -6,10 +6,7 @@ module Serverspec
       class NotImplementedError < Exception; end
 
       def check_access_by_user file, user, access
-        # - Maybe it could also use the darwin one...
-        # but using runuser bcs in linux it's common to change the default sudo configuration.
-        # - Using specific shell to avoid system users not logging in
-        "runuser -s /bin/sh -c \"test -#{access} #{file}\" #{user}"
+        "su -s /bin/sh -c \"/usr/bin/test -#{access} #{file}\" #{user}"
       end
 
       def check_iptables_rule rule, table=nil, chain=nil

data/lib/serverspec/commands/redhat.rb

@@ -1,6 +1,11 @@
 module Serverspec
   module Commands
     class RedHat < Linux
+      def check_access_by_user file, user, access
+        # Redhat-specific
+        "runuser -s /bin/sh -c \"test -#{access} #{file}\" #{user}"
+      end
+
       def check_enabled service
         "chkconfig --list #{escape(service)} | grep 3:on"
       end

data/lib/serverspec/commands/solaris.rb

@@ -87,7 +87,7 @@ module Serverspec
         # http://docs.oracle.com/cd/E23823_01/html/816-5166/su-1m.html
         ## No need for login shell as it seems that behavior as superuser is favorable for us, but needs
         ## to be better tested under real solaris env
-        "su #{user} test -#{access} #{file}"
+        "su #{user} -c \"/usr/bin/test -#{access} #{file}\""
       end
     end
   end

data/lib/serverspec/version.rb

@@ -1,3 +1,3 @@
 module Serverspec
-  VERSION = "0.2.27"
+  VERSION = "0.2.28"
 end

data/spec/debian/commands_spec.rb

@@ -229,16 +229,16 @@ end
 describe 'check_access_by_user', :os => :debian do
   context 'read access' do
     subject {commands.check_access_by_user '/tmp/something', 'dummyuser1', 'r'}
-    it { should eq  'runuser -s /bin/sh -c "test -r /tmp/something" dummyuser1' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -r /tmp/something" dummyuser1' }
   end
 
   context 'write access' do
     subject {commands.check_access_by_user '/tmp/somethingw', 'dummyuser2', 'w'}
-    it { should eq  'runuser -s /bin/sh -c "test -w /tmp/somethingw" dummyuser2' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -w /tmp/somethingw" dummyuser2' }
   end
 
   context 'execute access' do
     subject {commands.check_access_by_user '/tmp/somethingx', 'dummyuser3', 'x'}
-    it { should eq  'runuser -s /bin/sh -c "test -x /tmp/somethingx" dummyuser3' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -x /tmp/somethingx" dummyuser3' }
   end
 end

data/spec/gentoo/commands_spec.rb

@@ -227,16 +227,17 @@ end
 describe 'check_access_by_user', :os => :gentoo do
   context 'read access' do
     subject {commands.check_access_by_user '/tmp/something', 'dummyuser1', 'r'}
-    it { should eq  'runuser -s /bin/sh -c "test -r /tmp/something" dummyuser1' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -r /tmp/something" dummyuser1' }
   end
 
   context 'write access' do
     subject {commands.check_access_by_user '/tmp/somethingw', 'dummyuser2', 'w'}
-    it { should eq  'runuser -s /bin/sh -c "test -w /tmp/somethingw" dummyuser2' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -w /tmp/somethingw" dummyuser2' }
   end
 
   context 'execute access' do
     subject {commands.check_access_by_user '/tmp/somethingx', 'dummyuser3', 'x'}
-    it { should eq  'runuser -s /bin/sh -c "test -x /tmp/somethingx" dummyuser3' }
+    it { should eq  'su -s /bin/sh -c "/usr/bin/test -x /tmp/somethingx" dummyuser3' }
   end
 end
+

data/spec/solaris/commands_spec.rb

@@ -240,17 +240,17 @@ end
 describe 'check_access_by_user', :os => :solaris do
   context 'read access' do
     subject {commands.check_access_by_user '/tmp/something', 'dummyuser1', 'r'}
-    it { should eq 'su dummyuser1 test -r /tmp/something' }
+    it { should eq 'su dummyuser1 -c "/usr/bin/test -r /tmp/something"' }
   end
 
   context 'write access' do
     subject {commands.check_access_by_user '/tmp/somethingw', 'dummyuser2', 'w'}
-    it { should eq 'su dummyuser2 test -w /tmp/somethingw' }
+    it { should eq 'su dummyuser2 -c "/usr/bin/test -w /tmp/somethingw"' }
   end
 
   context 'execute access' do
     subject {commands.check_access_by_user '/tmp/somethingx', 'dummyuser3', 'x'}
-    it { should eq 'su dummyuser3 test -x /tmp/somethingx' }
+    it { should eq 'su dummyuser3 -c "/usr/bin/test -x /tmp/somethingx"' }
   end
 end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: serverspec
 version: !ruby/object:Gem::Version 
-  hash: 33
+  hash: 47
   prerelease: false
   segments: 
   - 0
   - 2
-  - 27
-  version: 0.2.27
+  - 28
+  version: 0.2.28
 platform: ruby
 authors: 
 - Gosuke Miyashita