serverengine 2.0.3-x86-mingw32 → 2.2.4-x86-mingw32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 30e143c93f13de994374897c12c6d5d8341121f6
-  data.tar.gz: 97e2987789826974472c8b7d2dfc26bb2a637d75
+SHA256:
+  metadata.gz: 14225458f5959eab0eefdff088da3f289816a4f0e9e871e291edbeb7aa1796df
+  data.tar.gz: 3932f03c87996232a7a58645a8c77ffb2f57302f49b62c1cd6bfc944ab3e9faa
 SHA512:
-  metadata.gz: d338855b1925642c20a58ed8d73f4c05a7f160a0f18068b40f6370d595626d67914674988251a344fc2a3d6a86b4e4f57bfd2fff12be96cc6c6d26762f8fa0e7
-  data.tar.gz: e9808147809ce5f84e274f759bcef7c5d5105ea3e7d37484b8b64fe32a402c5c7bab500d254189157f307865f4a2596df0bc84037e0b95e11cb188241d97eed3
+  metadata.gz: 6db094c6723490b9f4fba7d62bc70a52239aa22f4b9ac3f598d2b734d70052b27460be326283be3f84107127749cf2ed957e1a6f6ad8b0a7cfe731103cc2531c
+  data.tar.gz: 2982698d8a5762b8305f20d92f4e0d8766db9ee735a33a6a3b01c192414fd9a5f9492176e26afab848d9a986d35827cf4a84c14850f7094a69323b860d32bf60

data/.github/workflows/linux.yml

@@ -0,0 +1,26 @@
+name: Testing on Ubuntu
+on:
+  - push
+  - pull_request
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '3.0', '2.7', '2.6', '2.5' ]
+        os:
+          - ubuntu-latest
+    name: Ruby ${{ matrix.ruby }} unit testing on ${{ matrix.os }}
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: unit testing
+      env:
+        CI: true
+      run: |
+        gem install bundler rake
+        bundle install --jobs 4 --retry 3
+        bundle exec rake spec

data/Changelog

@@ -1,3 +1,49 @@
+2021-05-24 version 2.2.4:
+
+* Ensure to get correct Win32 socket error on Ruby 3.0
+
+2021-02-17 version 2.2.3:
+
+* Change SocketManager's port assignment strategy on Windows
+
+2020-11-02 version 2.2.2:
+
+* Fix incomplete Windows support in spawn based multi worker
+
+2020-01-24 version 2.2.1:
+
+* Fix IPv6 dual-stack mode issue for UDP
+* experimental: Add SERVERENGINE_USE_SOCKET_REUSEPORT envvar to enable SO_REUSEPORT
+
+2019-11-16 version 2.2.0:
+
+* Fix IPv6 dual-stack mode issue for TCP
+
+2019-04-22 version 2.1.1:
+
+* Fix bug to ignore SIGDUMP_SIGNAL
+
+2018-11-14 version 2.1.0:
+
+* Improve socket manager security
+
+2018-07-09 version 2.0.7:
+
+* Add disable_sigdump option
+
+2018-02-09 version 2.0.6:
+
+* Avoid thread error log in ruby 2.5
+
+2017-03-01 version 2.0.5:
+
+* Support SERVERENGINE_SOCKETMANAGER_SOCK_DIR environment variable to change
+  base directory of SocketManager's socket path
+
+2016-11-24 version 2.0.4:
+
+* Fix bug to crash Ruby VM when SocketManager fails to bind IPv6 addresses on Windows
+
 2016-11-22 version 2.0.3:
 
 * Fix bug about IPv6 handling on Windows

data/NOTICE

@@ -1,3 +1,3 @@
 ServerEngine
-https://github.com/frsyuki/serverengine
+https://github.com/treasure-data/serverengine
 Copyright (C) 2012-2013 Sadayuki Furuhashi

data/README.md

@@ -319,7 +319,8 @@ Send `USR2` signal to reload configuration file.
 - **HUP:** immediate restart (available only when `worker_type` is "process")
 - **USR2:** reload config file and reopen log file
 - **INT:** detach process for live restarting (available only when `supervisor` and `enable_detach` parameters are true. otherwise graceful shutdown)
-- **CONT:** dump stacktrace and memory information to /tmp/sigdump-<pid>.log file
+- **CONT:** dump stacktrace and memory information to /tmp/sigdump-<pid>.log file. This can be
+    disabled by including `disable_sigdump: true` in the configuration.
 
 Immediate shutdown and restart send SIGQUIT signal to worker processes which kills the processes.
 Graceful shutdown and restart call `Worker#stop` method and wait for completion of `Worker#run` method.
@@ -463,6 +464,7 @@ Available methods are different depending on `worker_type`. ServerEngine support
   - **daemonize** enables daemonize (default: false)
   - **pid_path** sets the path to pid file (default: don't create pid file)
   - **supervisor** enables supervisor if it's true (default: false)
+  - **disable_sigdump** disables the handling of the `SIGCONT` signal and dumping of the thread (default: false)
   - **daemon_process_name** changes process name ($0) of server or supervisor process
   - **chuser** changes execution user
   - **chgroup** changes execution group

data/appveyor.yml

@@ -1,4 +1,6 @@
 ---
+image: Visual Studio 2019
+
 install:
   - SET PATH=C:\Ruby%ruby_version%\bin;%PATH%
   - ruby --version
@@ -6,19 +8,28 @@ install:
   - bundle install
 build: off
 test_script:
-  - bundle exec rake -rdevkit
+  - bundle exec rake spec
 
 environment:
   matrix:
-    - ruby_version: "23-x64"
-      devkit: C:\Ruby23-x64\DevKit
-    - ruby_version: "23"
-      devkit: C:\Ruby23\DevKit
-    - ruby_version: "22-x64"
-      devkit: C:\Ruby23-x64\DevKit
-    - ruby_version: "22"
-      devkit: C:\Ruby23\DevKit
-    - ruby_version: "21-x64"
-      devkit: C:\Ruby23-x64\DevKit
-    - ruby_version: "21"
-      devkit: C:\Ruby23\DevKit
+    - ruby_version: "30-x64"
+    - ruby_version: "27-x64"
+    - ruby_version: "26-x64"
+    - ruby_version: "25-x64"
+
+# On Ruby 3.0, we need to use fiddle 1.0.8 or later to retrieve correct
+# error code. In addition, we have to specify the path of fiddle by RUBYLIB
+# because RubyInstaller loads Ruby's bundled fiddle before initializing gem.
+# See also:
+# * https://github.com/ruby/fiddle/issues/72
+# * https://bugs.ruby-lang.org/issues/17813
+# * https://github.com/oneclick/rubyinstaller2/blob/8225034c22152d8195bc0aabc42a956c79d6c712/lib/ruby_installer/build/dll_directory.rb
+for:
+-
+  matrix:
+    only:
+      - ruby_version: "30-x64"
+  test_script:
+    - gem install fiddle --version 1.0.8
+    - set RUBYLIB=C:/Ruby%ruby_version%/lib/ruby/gems/3.0.0/gems/fiddle-1.0.8/lib
+    - bundle exec rake spec

data/lib/serverengine/multi_process_server.rb

@@ -120,10 +120,19 @@ module ServerEngine
       end
 
       def send_reload
-        @pmon.send_signal(@reload_signal) if @pmon
+        return nil unless @pmon
+        if @pmon.command_sender_pipe
+          send_command("RELOAD\n")
+        else
+          @pmon.send_signal(@reload_signal)
+        end
         nil
       end
 
+      def send_command(command)
+        @pmon.send_command(command) if @pmon
+      end
+
       def join
         @pmon.join if @pmon
         nil

data/lib/serverengine/multi_spawn_server.rb

@@ -46,13 +46,6 @@ module ServerEngine
       @pm.command_sender = @command_sender
     end
 
-    def stop(stop_graceful)
-      if @command_sender == "pipe"
-        @pm.command_sender_pipe.write(stop_graceful ? "GRACEFUL_STOP\n" : "IMMEDIATE_STOP\n")
-      end
-      super
-    end
-
     def run
       super
     ensure

data/lib/serverengine/process_manager.rb

@@ -16,6 +16,7 @@
 #    limitations under the License.
 #
 require 'fcntl'
+require 'serverengine/socket_manager'
 
 module ServerEngine
 
@@ -70,7 +71,6 @@ module ServerEngine
     attr_reader :enable_heartbeat, :auto_heartbeat
 
     attr_accessor :command_sender
-    attr_reader :command_sender_pipe
 
     CONFIG_PARAMS = {
       heartbeat_interval: 1,
@@ -179,18 +179,21 @@ module ServerEngine
           end
         end
 
+        command_sender_pipe = nil
         if @command_sender == "pipe"
-          inpipe, @command_sender_pipe = IO.pipe
-          @command_sender_pipe.sync = true
-          @command_sender_pipe.binmode
+          inpipe, command_sender_pipe = IO.pipe
+          command_sender_pipe.sync = true
+          command_sender_pipe.binmode
           options[:in] = inpipe
         end
+        env['SERVERENGINE_SOCKETMANAGER_INTERNAL_TOKEN'] = SocketManager::INTERNAL_TOKEN
         pid = Process.spawn(env, *args, options)
         if @command_sender == "pipe"
           inpipe.close
         end
 
         m = Monitor.new(pid, monitor_options)
+        m.command_sender_pipe = command_sender_pipe
 
         @monitors << m
 
@@ -305,9 +308,11 @@ module ServerEngine
         @graceful_kill_start_time = nil
         @immediate_kill_start_time = nil
         @kill_count = 0
+
+        @command_sender_pipe = nil
       end
 
-      attr_accessor :last_heartbeat_time
+      attr_accessor :last_heartbeat_time, :command_sender_pipe
       attr_reader :pid
 
       def heartbeat_delay
@@ -327,6 +332,10 @@ module ServerEngine
         end
       end
 
+      def send_command(command)
+        @command_sender_pipe.write(command) if @command_sender_pipe
+      end
+
       def try_join
         pid = @pid
         return true unless pid
@@ -364,15 +373,25 @@ module ServerEngine
       end
 
       def start_graceful_stop!
-        now = Time.now
-        @next_kill_time ||= now
-        @graceful_kill_start_time ||= now
+        if ServerEngine.windows?
+          # heartbeat isn't supported on Windows
+          send_command("GRACEFUL_STOP\n")
+        else
+          now = Time.now
+          @next_kill_time ||= now
+          @graceful_kill_start_time ||= now
+        end
       end
 
       def start_immediate_stop!
-        now = Time.now
-        @next_kill_time ||= now
-        @immediate_kill_start_time ||= now
+        if ServerEngine.windows?
+          # heartbeat isn't supported on Windows
+          system("taskkill /f /pid #{@pid}")
+        else
+          now = Time.now
+          @next_kill_time ||= now
+          @immediate_kill_start_time ||= now
+        end
       end
 
       def tick(now=Time.now)

data/lib/serverengine/server.rb

@@ -70,6 +70,11 @@ module ServerEngine
       nil
     end
 
+    def dump
+      Sigdump.dump unless config[:disable_sigdump]
+      nil
+    end
+
     def install_signal_handlers
       s = self
       if @command_pipe
@@ -89,7 +94,7 @@ module ServerEngine
             when "DETACH"
               s.detach(true)
             when "DUMP"
-              Sigdump.dump
+              s.dump
             end
           end
         end
@@ -104,7 +109,7 @@ module ServerEngine
             st.trap(@config[:signal_graceful_restart] || Signals::GRACEFUL_RESTART) { s.restart(true) }
             st.trap(@config[:signal_immediate_restart] || Signals::IMMEDIATE_RESTART) { s.restart(false) }
             st.trap(@config[:signal_reload] || Signals::RELOAD) { s.reload }
-            st.trap(@config[:signal_dump] || Signals::DUMP) { Sigdump.dump }
+            st.trap(@config[:signal_dump] || Signals::DUMP) { s.dump }
           end
         end
       end

data/lib/serverengine/signal_thread.rb

@@ -67,7 +67,7 @@ module ServerEngine
 
     def signal_handler_main(sig)
       # here always creates new thread to avoid
-      # complicated race conditin in signal handlers
+      # complicated race condition in signal handlers
       Thread.new do
         begin
           enqueue(sig)

data/lib/serverengine/signals.rb

@@ -26,6 +26,6 @@ module ServerEngine
     IMMEDIATE_RESTART = :HUP
     RELOAD = :USR2
     DETACH = :INT
-    DUMP = :CONT
+    DUMP = ENV.has_key?('SIGDUMP_SIGNAL') ? ENV['SIGDUMP_SIGNAL'].to_sym : :CONT
   end
 end

data/lib/serverengine/socket_manager.rb

@@ -17,9 +17,19 @@
 #
 require 'socket'
 require 'ipaddr'
+require 'time'
+require 'securerandom'
+require 'json'
+require 'base64'
 
 module ServerEngine
   module SocketManager
+    # This token is used for communication between peers. If token is mismatched, messages will be discarded
+    INTERNAL_TOKEN = if ENV.has_key?('SERVERENGINE_SOCKETMANAGER_INTERNAL_TOKEN')
+                       ENV['SERVERENGINE_SOCKETMANAGER_INTERNAL_TOKEN']
+                     else
+                       SecureRandom.hex
+                     end
 
     class Client
       def initialize(path)
@@ -62,13 +72,17 @@ module ServerEngine
     class Server
       def self.generate_path
         if ServerEngine.windows?
-          for port in 10000..65535
+          port = ENV['SERVERENGINE_SOCKETMANAGER_PORT']
+          return port.to_i if port
+
+          for port in get_dynamic_port_range
             if `netstat -na | findstr "#{port}"`.length == 0
               return port
             end
           end
         else
-          '/tmp/SERVERENGINE_SOCKETMANAGER_' + Time.now.to_s.gsub(' ', '') + '_' + Process.pid.to_s
+          base_dir = (ENV['SERVERENGINE_SOCKETMANAGER_SOCK_DIR'] || '/tmp')
+          File.join(base_dir, 'SERVERENGINE_SOCKETMANAGER_' + Time.now.utc.iso8601 + '_' + Process.pid.to_s)
         end
       end
 
@@ -136,7 +150,10 @@ module ServerEngine
 
       def process_peer(peer)
         while true
-          pid, method, bind, port = *SocketManager.recv_peer(peer)
+          res = SocketManager.recv_peer(peer)
+          return if res.nil?
+
+          pid, method, bind, port = *res
           begin
             send_socket(peer, pid, method, bind, port)
           rescue => e
@@ -146,18 +163,59 @@ module ServerEngine
       ensure
         peer.close
       end
+
+      if ServerEngine.windows?
+        def self.valid_dynamic_port_range(start_port, end_port)
+          return false if start_port < 1025 or start_port > 65535
+          return false if end_port < 1025 or end_port > 65535
+          return false if start_port > end_port
+          true
+        end
+
+        def self.get_dynamic_port_range
+          numbers = []
+          # Example output of netsh (actual output is localized):
+          #
+          # Protocol tcp Dynamic Port Range
+          # ---------------------------------
+          # Start Port      : 49152
+          # Number of Ports : 16384
+          #
+          str = `netsh int ipv4 show dynamicport tcp`.force_encoding("ASCII-8BIT")
+          str.each_line { |line| numbers << $1.to_i if line.match(/.*: (\d+)/) }
+
+          start_port, n_ports = numbers[0], numbers[1]
+          end_port = start_port + n_ports - 1
+
+          if valid_dynamic_port_range(start_port, end_port)
+            return start_port..end_port
+          else
+            # The default dynamic port range is 49152 - 65535 as of Windows Vista
+            # and Windows Server 2008.
+            # https://docs.microsoft.com/en-us/troubleshoot/windows-server/networking/default-dynamic-port-range-tcpip-chang
+            return 49152..65535
+          end
+        end
+      end
     end
 
     def self.send_peer(peer, obj)
-      data = Marshal.dump(obj)
+      data = [SocketManager::INTERNAL_TOKEN, Base64.strict_encode64(Marshal.dump(obj))]
+      data = JSON.generate(data)
       peer.write [data.bytesize].pack('N')
       peer.write data
     end
 
     def self.recv_peer(peer)
-      len = peer.read(4).unpack('N').first
+      res = peer.read(4)
+      return nil if res.nil?
+
+      len = res.unpack('N').first
       data = peer.read(len)
-      Marshal.load(data)
+      data = JSON.parse(data)
+      return nil if SocketManager::INTERNAL_TOKEN != data.first
+
+      Marshal.load(Base64.strict_decode64(data.last))
     end
 
     if ServerEngine.windows?

data/lib/serverengine/socket_manager_unix.rb

@@ -50,19 +50,30 @@ module ServerEngine
       private
 
       def listen_tcp_new(bind_ip, port)
-        sock = TCPServer.new(bind_ip.to_s, port)
-        sock.listen(Socket::SOMAXCONN)  # TODO make backlog configurable if necessary
-        return sock
+        if ENV['SERVERENGINE_USE_SOCKET_REUSEPORT'] == '1'
+          # Based on Addrinfo#listen
+          tsock = Socket.new(bind_ip.ipv6? ? ::Socket::AF_INET6 : ::Socket::AF_INET, ::Socket::SOCK_STREAM, 0)
+          tsock.ipv6only! if bind_ip.ipv6?
+          tsock.setsockopt(:SOCKET, :REUSEPORT, true)
+          tsock.setsockopt(:SOCKET, :REUSEADDR, true)
+          tsock.bind(Addrinfo.tcp(bind_ip.to_s, port))
+          tsock.listen(::Socket::SOMAXCONN)
+          tsock.autoclose = false
+          TCPServer.for_fd(tsock.fileno)
+        else
+          # TCPServer.new doesn't set IPV6_V6ONLY flag, so use Addrinfo class instead.
+          # TODO: make backlog configurable if necessary
+          tsock = Addrinfo.tcp(bind_ip.to_s, port).listen(::Socket::SOMAXCONN)
+          tsock.autoclose = false
+          TCPServer.for_fd(tsock.fileno)
+        end
       end
 
       def listen_udp_new(bind_ip, port)
-        if bind_ip.ipv6?
-          sock = UDPSocket.new(Socket::AF_INET6)
-        else
-          sock = UDPSocket.new(Socket::AF_INET)
-        end
-        sock.bind(bind_ip.to_s, port)
-        return sock
+        # UDPSocket.new doesn't set IPV6_V6ONLY flag, so use Addrinfo class instead.
+        usock = Addrinfo.udp(bind_ip.to_s, port).bind
+        usock.autoclose = false
+        UDPSocket.for_fd(usock.fileno)
       end
 
       def start_server(path)
@@ -70,7 +81,12 @@ module ServerEngine
         # when client changed working directory
         path = File.expand_path(path)
 
-        @server = UNIXServer.new(path)
+        begin
+          old_umask = File.umask(0077) # Protect unix socket from other users
+          @server = UNIXServer.new(path)
+        ensure
+          File.umask(old_umask)
+        end
 
         @thread = Thread.new do
           begin
@@ -96,7 +112,14 @@ module ServerEngine
       end
 
       def send_socket(peer, pid, method, bind, port)
-        sock = send(method, bind, port)  # calls listen_tcp or listen_udp
+        sock = case method
+               when :listen_tcp
+                 listen_tcp(bind, port)
+               when :listen_udp
+                 listen_udp(bind, port)
+               else
+                 raise ArgumentError, "Unknown method: #{method.inspect}"
+               end
 
         SocketManager.send_peer(peer, nil)
 

data/lib/serverengine/supervisor.rb

@@ -148,6 +148,10 @@ module ServerEngine
       end
     end
 
+    def dump
+      _dump
+    end
+
     def install_signal_handlers
       s = self
       if @command_pipe
@@ -167,7 +171,7 @@ module ServerEngine
             when "DETACH"
               s.detach(true)
             when "DUMP"
-              Sigdump.dump
+              s.dump
             end
           end
         end
@@ -179,7 +183,7 @@ module ServerEngine
           st.trap(Signals::IMMEDIATE_RESTART) { s.restart(false) }
           st.trap(Signals::RELOAD) { s.reload }
           st.trap(Signals::DETACH) { s.detach(true) }
-          st.trap(Signals::DUMP) { Sigdump.dump }
+          st.trap(Signals::DUMP) { s.dump }
         end
       end
     end

data/lib/serverengine/version.rb

@@ -1,3 +1,3 @@
 module ServerEngine
-  VERSION = "2.0.3"
+  VERSION = "2.2.4"
 end

data/lib/serverengine/winsock.rb

@@ -78,6 +78,19 @@ module ServerEngine
       end
     end
 
+    def self.last_error
+      # On Ruby 3.0 calling WSAGetLastError here can't retrieve correct error
+      # code because Ruby's internal code resets it.
+      # See also:
+      # * https://github.com/ruby/fiddle/issues/72
+      # * https://bugs.ruby-lang.org/issues/17813
+      if Fiddle.respond_to?(:win32_last_socket_error)
+        Fiddle.win32_last_socket_error || 0
+      else
+        self.WSAGetLastError
+      end
+    end
+
     INVALID_SOCKET = -1
   end
 
@@ -97,11 +110,10 @@ module ServerEngine
     dlload ruby_dll_path
 
     extern "int rb_w32_map_errno(int)"
-    extern "void rb_syserr_fail(int, char *)"
 
     def self.raise_last_error(name)
-      errno = rb_w32_map_errno(WinSock.WSAGetLastError)
-      rb_syserr_fail(errno, name)
+      errno = rb_w32_map_errno(WinSock.last_error)
+      raise SystemCallError.new(name, errno)
     end
 
     extern "int rb_w32_wrap_io_handle(int, int)"

data/lib/serverengine/worker.rb

@@ -54,6 +54,10 @@ module ServerEngine
     def after_start
     end
 
+    def dump
+      Sigdump.dump unless config[:disable_sigdump]
+    end
+
     def install_signal_handlers
       w = self
       SignalThread.new do |st|
@@ -69,7 +73,7 @@ module ServerEngine
         }
         st.trap(Signals::DETACH) { w.stop }
 
-        st.trap(Signals::DUMP) { Sigdump.dump }
+        st.trap(Signals::DUMP) { w.dump }
       end
     end
 
@@ -77,5 +81,4 @@ module ServerEngine
       run
     end
   end
-
 end

data/serverengine.gemspec

@@ -15,13 +15,13 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
-  gem.has_rdoc = false
 
   gem.required_ruby_version = ">= 2.1.0"
 
   gem.add_dependency "sigdump", ["~> 0.2.2"]
 
-  gem.add_development_dependency "rake", [">= 0.9.2"]
+  # rake v12.x doesn't work with rspec 2. rspec should be updated to 3
+  gem.add_development_dependency "rake", ["~> 11.0"]
   gem.add_development_dependency "rspec", ["~> 2.13.0"]
 
   gem.add_development_dependency 'rake-compiler-dock', ['~> 0.5.0']

data/spec/blocking_flag_spec.rb

@@ -20,10 +20,16 @@ describe ServerEngine::BlockingFlag do
   it 'wait_for_set timeout' do
     start = Time.now
 
-    subject.wait_for_set(0.01)
+    subject.wait_for_set(0.1)
     elapsed = Time.now - start
 
-    elapsed.should >= 0.01
+    if ServerEngine.windows? && ENV['CI'] == 'True'
+      # timer seems low accuracy on Windows CI container, often a bit shorter
+      # than expected
+      elapsed.should >= 0.1 * 0.95
+    else
+      elapsed.should >= 0.1
+    end
   end
 
   it 'wait_for_reset timeout' do
@@ -31,10 +37,16 @@ describe ServerEngine::BlockingFlag do
 
     start = Time.now
 
-    subject.wait_for_reset(0.01)
+    subject.wait_for_reset(0.1)
     elapsed = Time.now - start
 
-    elapsed.should >= 0.01
+    if ServerEngine.windows? && ENV['CI'] == 'True'
+      # timer seems low accuracy on Windows CI container, often a bit shorter
+      # than expected
+      elapsed.should >= 0.1 * 0.95
+    else
+      elapsed.should >= 0.1
+    end
   end
 
   it 'wait' do

data/spec/daemon_spec.rb

@@ -44,6 +44,10 @@ describe ServerEngine::Daemon do
       wait_for_stop
       test_state(:server_restart_immediate).should == 1
 
+      dm.dump
+      wait_for_stop
+      test_state(:server_dump).should == 1
+
       dm.stop(false)
       wait_for_stop
       test_state(:server_stop_immediate).should == 1

data/spec/server_worker_context.rb

@@ -146,6 +146,11 @@ module TestServer
     incr_test_state :server_detach
     super
   end
+
+  def dump
+    incr_test_state :server_dump
+    super
+  end
 end
 
 module TestWorker
@@ -249,7 +254,7 @@ shared_context 'test server and worker' do
   before { reset_test_state }
 
   def wait_for_fork
-    sleep 0.8
+    sleep 1.5
   end
 
   def wait_for_stop

data/spec/socket_manager_spec.rb

@@ -19,6 +19,36 @@ describe ServerEngine::SocketManager do
     File.unlink(server_path) if server_path.is_a?(String) && File.exist?(server_path)
   end
 
+  if ServerEngine.windows?
+    context 'Server.generate_path' do
+      it 'returns socket path as port number' do
+        path = SocketManager::Server.generate_path
+        expect(path).to be_between(49152, 65535)
+      end
+
+      it 'can be changed via environment variable' do
+        ENV['SERVERENGINE_SOCKETMANAGER_PORT'] = '54321'
+        path = SocketManager::Server.generate_path
+        expect(path).to be 54321
+        ENV.delete('SERVERENGINE_SOCKETMANAGER_PORT')
+      end
+    end
+  else
+    context 'Server.generate_path' do
+      it 'returns socket path under /tmp' do
+        path = SocketManager::Server.generate_path
+        expect(path).to include('/tmp/SERVERENGINE_SOCKETMANAGER_')
+      end
+
+      it 'can be changed via environment variable' do
+        ENV['SERVERENGINE_SOCKETMANAGER_SOCK_DIR'] = '/tmp/foo'
+        path = SocketManager::Server.generate_path
+        expect(path).to include('/tmp/foo/SERVERENGINE_SOCKETMANAGER_')
+        ENV.delete('SERVERENGINE_SOCKETMANAGER_SOCK_DIR')
+      end
+    end
+  end
+
   context 'with thread' do
     context 'using ipv4' do
       it 'works' do
@@ -139,7 +169,27 @@ describe ServerEngine::SocketManager do
         test_state(:is_udp_socket).should == 1
         test_state(:udp_data_sent).should == 1
       end
-    end if (TCPServer.open("::1",0) rescue nil)
+    end if (TCPServer.open("::1", 0) rescue nil)
+
+    unless ServerEngine.windows?
+      context 'using ipv4/ipv6' do
+        it 'can bind ipv4/ipv6 together' do
+          server = SocketManager::Server.open(server_path)
+          client = ServerEngine::SocketManager::Client.new(server_path)
+
+          tcp_v4 = client.listen_tcp('0.0.0.0', test_port)
+          udp_v4 = client.listen_udp('0.0.0.0', test_port)
+          tcp_v6 = client.listen_tcp('::', test_port)
+          udp_v6 = client.listen_udp('::', test_port)
+
+          tcp_v4.close
+          udp_v4.close
+          tcp_v6.close
+          udp_v6.close
+          server.close
+        end
+      end if (TCPServer.open("::", 0) rescue nil)
+    end
   end
 
   if ServerEngine.windows?

data/spec/supervisor_spec.rb

@@ -191,7 +191,7 @@ describe ServerEngine::Supervisor do
         sv, t = start_supervisor(RunErrorWorker, server_restart_wait: 1, command_sender: sender)
 
         begin
-          sleep 2.2
+          sleep 2.5
         ensure
           sv.stop(true)
           t.join

data/spec/winsock_spec.rb

@@ -0,0 +1,18 @@
+require 'windows/error' if ServerEngine.windows?
+
+describe ServerEngine::WinSock do
+  # On Ruby 3.0, you need to use fiddle 1.0.8 or later to retrieve a correct
+  # error code. In addition, you need to specify the path of fiddle by RUBYLIB
+  # or `ruby -I` when you use RubyInstaller because it loads Ruby's bundled
+  # fiddle before initializing gem.
+  # See also:
+  # * https://github.com/ruby/fiddle/issues/72
+  # * https://bugs.ruby-lang.org/issues/17813
+  # * https://github.com/oneclick/rubyinstaller2/blob/8225034c22152d8195bc0aabc42a956c79d6c712/lib/ruby_installer/build/dll_directory.rb
+  context 'last_error' do
+    it 'bind error' do
+      expect(WinSock.bind(0, nil, 0)).to be -1
+      expect(WinSock.last_error).to be Windows::Error::WSAENOTSOCK
+    end
+  end
+end if ServerEngine.windows?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: serverengine
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.2.4
 platform: x86-mingw32
 authors:
 - Sadayuki Furuhashi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-22 00:00:00.000000000 Z
+date: 2021-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sigdump
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,9 +101,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/linux.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Changelog
 - Gemfile
 - LICENSE
@@ -148,6 +148,7 @@ files:
 - spec/socket_manager_spec.rb
 - spec/spec_helper.rb
 - spec/supervisor_spec.rb
+- spec/winsock_spec.rb
 homepage: https://github.com/fluent/serverengine
 licenses:
 - Apache 2.0
@@ -167,8 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.2.5
 signing_key: 
 specification_version: 4
 summary: ServerEngine - multiprocess server framework
@@ -183,4 +183,4 @@ test_files:
 - spec/socket_manager_spec.rb
 - spec/spec_helper.rb
 - spec/supervisor_spec.rb
-has_rdoc: false
+- spec/winsock_spec.rb

data/.travis.yml

@@ -1,20 +0,0 @@
-language: ruby
-
-rvm:
-  - 2.1.10
-  - 2.2.4
-  - 2.3.0
-  - ruby-head
-
-branches:
-  only:
-    - master
-
-script: bundle exec rake spec
-
-before_install:
- - gem update bundler
-
-matrix:
-  allow_failures:
-    - rvm: ruby-head