server_metrics 1.0.2 → 1.0.3

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.3
+
+* Assuming 100 jiffies/second vs. reading from /proc/timer_list
+
 ## 1.0.2
 
 * Also grouping under kthread (one d vs. 2 ds)

data/lib/server_metrics/collectors/processes.rb

@@ -26,11 +26,7 @@ class ServerMetrics::Processes
 
 
   # This is the main method to call. It returns a hash of processes, keyed by the executable name.
-  # Processes are returned either because they are a top 10 CPU consumer, or a top 10 memory consumer.
   #
-  # The exact number or processes returned depends on the overlap between the two lists (cpu and memory consumers).
-  # The list will always be between 10 and 20 items long.
-
   # {'mysqld' =>
   #     {
   #      :cmd => "mysqld",    # the command (without the path of arguments being run)
@@ -111,17 +107,13 @@ class ServerMetrics::Processes
     grouped
   end
 
-  # Relies on the /proc directory (/proc/timer_list). We need this because the process CPU utilization is measured in jiffies.
+  # We need this because the process CPU utilization is measured in jiffies.
   # In order to calculate the process' % usage of total CPU resources, we need to know how many jiffies have passed.
-  # Unfortunately, jiffies isn't a fixed value (it can vary between 100 and 250 per second), so we need to calculate it ourselves.
   #
-  # if /proc/timer_list isn't available, fall back to the assumption of 100 jiffies/second (10 milliseconds/jiffy)
+  # While jiffies isn't a fixed value (it can vary between 100 and 250 per second),
+  # we assume it is 100 jiffies/second (10 milliseconds/jiffy) because that is most common.
   def get_jiffies
-    if File.exist?('/proc/timer_list')
-      `cat /proc/timer_list`.match(/^jiffies: (\d+)$/)[1].to_i
-    else
-      (Time.now.to_f*100).to_i
-    end
+    (Time.now.to_f*100).to_i
   end
   
   # Sys::ProcTable.ps returns +rss+ in pages, not in bytes. 

data/lib/server_metrics/version.rb

@@ -1,3 +1,3 @@
 module ServerMetrics
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: server_metrics
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
   prerelease: 
 platform: ruby
 authors: