server-generated-popups 1.1.5 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f44889fade94aaf392127e00315078e2c7cf9475
-  data.tar.gz: 1a356a0aba7c5995cded8dc644b47b0c5007cbec
+  metadata.gz: 7c2036800e7ea8636eb0c470c6ff5920a08488bd
+  data.tar.gz: 926185300b09af0d11835029cfe281073cc24b64
 SHA512:
-  metadata.gz: cdca7359f6e16bc0be9de36696a77fbe743195d08c5205e19b94eec62ca40988d3c0f4c48028bf47de6e1f26be0eb2fbdbadb32b988e55e537c2474c4f3515a6
-  data.tar.gz: 8dd1af1f7e0a366dabba8a81a56f27e5ae38a4c0cbd6ad13399f74e2dfdbac292c0d2b96261e2edd1bc3fca2ebd5918c61f1eec009f50d259ad217da961e832a
+  metadata.gz: 59d3840643ef016cad8b468eae2d98c6ee5e4441bf55ea0656ddcec9b7ed41fd2783a4121497a6e026f250d9a3f6e38d9d07599b7edf5c4c70ef35e383bb407c
+  data.tar.gz: bc19ce0c8419bb67508fddd2457d5cd8b0e3155fe88c12fb09ae8f959af93b409e1610c08c321c21d66e963e65bc06f11d4e40ddc1df88b9417433b1b9133810

data/README.md

@@ -61,14 +61,13 @@ Sink the popup down through the bottom of the screen:
 popup.hide('down')
 ```
 
-### Events
-
-Say, you have buttons in your popup and want to handle clicks on them. Well, my usual advice is to go for `<%= link_to 'Button', remote: true %>` and a [JavaScript response](https://signalvnoise.com/posts/3697-server-generated-javascript-responses), but sometimes you want to do something right there on the front-end. In such case, hook up to `popup:show` event:
+If you need to do something after the popup slides onto the screen — play an animation and attach a handler to the "Close" button — pass a second argument to the `show` method:
 
 ```javascript
-$(document).on('popup:show', function (popup) {
-  $('.popup #close.button').on('click', function () {
-    popup.hide('down')
+editInvoiceDetails = Popup("<%=j render @invoice %>").show('up', function () {
+  blink($('.heading'))
+  $(this).on('click', '#close.button', function () {
+  	editInvoiceDetails.hide('down')
   })
 })
 ```

data/app/assets/javascripts/popup.js

@@ -16,12 +16,10 @@ function Popup(html, options) {
     this.popupWindow.animate({top: to}, callback)
   }
 
-  this.show = function (direction) {
+  this.show = function (direction, callback) {
     $('body').append(this.popupWindow)
-    $(document).trigger('popup:show', this)
-    
     startFrom = (direction == 'up') ? '150%' : '-50%'
-    move(startFrom, distanceFromTop)
+    move(startFrom, distanceFromTop, callback)
     return this;
   }
   this.hide = function (direction) {

data/server-generated-popups.gemspec

@@ -4,7 +4,7 @@ Gem::Specification.new do |gem|
   gem.authors       = ["Anton Khamets"]
   gem.email         = ["colorfulfool@gmail.com"]
   gem.summary       = %q{Show a popup with one line of code}
-  gem.summary       = %q{Show a popup with one line of code. Perfect for format: :js responses, and just in JS too.}
+  gem.summary       = %q{Show a popup with one line of code. Perfect for format.js responses, and just in JS too.}
   gem.homepage      = "https://github.com/colorfulfool/rails-popup"
 
   gem.files         = `git ls-files`.split($\)
@@ -12,5 +12,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "server-generated-popups"
   gem.require_paths = ["lib"]
-  gem.version       = "1.1.5"
+  gem.version       = "1.1.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: server-generated-popups
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.6
 platform: ruby
 authors:
 - Anton Khamets
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -45,6 +45,6 @@ rubyforge_project:
 rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: 'Show a popup with one line of code. Perfect for format: :js responses, and
-  just in JS too.'
+summary: Show a popup with one line of code. Perfect for format.js responses, and
+  just in JS too.
 test_files: []