servactory 3.0.0.rc2 → 3.0.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eee9fc6bec95dd20ef1a266e76789505c2047fdcefb762537cda444bfcf0aa41
-  data.tar.gz: ff045dc86733a26574bb47b37476b9efcf57736b2f269e24a5799d4abdeec0f3
+  metadata.gz: 5972f03405d88ae923f1e000479449e281af67b9d22b52010d2131dc1023cc15
+  data.tar.gz: 6c7c495d158deee0453114fb637897a2431d7ce4efc4e522a0716ec28a7dd89b
 SHA512:
-  metadata.gz: 9f32384fffa078eb57863ca1b7f4fee8d79ee8018bb9ccb5e928577df062e94cfe9781ee6dbb45efc06887e8d845c3c2e634295a2f331c9e10443d56ba523e2e
-  data.tar.gz: d177b88839a2ea979eaca67c4cb97fbcbfe554aa9add0be2308301715539c528a5fb024427f7cda6d15622016f0a184d88a7ce8862e40b942e18eed2502e27a3
+  metadata.gz: 82e84edd70b3ee47a91944bd60e5d9bec1cf33b18ca5d008d40973685c796cfa31b48de2f0599764c864db535959cd86a073ed30725c1fe1af49a98ce4bd72ab
+  data.tar.gz: 585a53ba4491246e5e4aaec23568e074a2d142d467b9d44bc551d629bce2047fcfd99d89c0bdcb897e9a28e9f7037b9128396107fe6c01083ff0b4298ee11f71

data/lib/servactory/maintenance/attributes/option.rb

@@ -136,11 +136,7 @@ module Servactory
           return if @define_methods.blank?
 
           @define_methods.map do |define_method|
-            <<-RUBY.squish
-              def #{define_method.name};
-                #{define_method.content.call(option: @body)};
-              end
-            RUBY
+            "def #{define_method.name}; #{define_method.content.call(option: @body)}; end"
           end.join("; ")
         end
       end

data/lib/servactory/maintenance/attributes/options_collection.rb

@@ -3,19 +3,64 @@
 module Servactory
   module Maintenance
     module Attributes
+      # Collection wrapper for managing Option objects.
+      #
+      # ## Purpose
+      #
+      # OptionsCollection provides a unified interface for storing and querying
+      # Option instances associated with service attributes (inputs, internals, outputs).
+      # It wraps a Set to ensure uniqueness and delegates common enumeration methods.
+      #
+      # ## Usage
+      #
+      # The collection is used internally by Input, Internal, and Output classes
+      # to manage their registered options:
+      #
+      # ```ruby
+      # collection = OptionsCollection.new
+      # collection << Option.new(name: :required, ...)
+      # collection << Option.new(name: :types, ...)
+      #
+      # collection.names              # => [:required, :types]
+      # collection.find_by(name: :required)  # => Option instance
+      # ```
+      #
+      # ## Performance
+      #
+      # The collection uses memoization for frequently accessed data:
+      # - `validation_classes` - cached list of unique validation classes
+      # - `options_for_checks` - cached hash for validation pipeline
+      # - `options_index` - cached hash for O(1) lookups by name
+      #
       class OptionsCollection
         extend Forwardable
 
-        def_delegators :@collection, :<<, :filter, :each, :map, :flat_map, :find, :empty?, :size
+        def_delegators :@collection,
+                       :<<,
+                       :filter,
+                       :each, :each_with_object,
+                       :map, :flat_map,
+                       :find,
+                       :size,
+                       :empty?
 
+        # Initializes an empty collection.
+        #
+        # @return [OptionsCollection]
         def initialize
           @collection = Set.new
         end
 
+        # Returns all option names in the collection.
+        #
+        # @return [Array<Symbol>] list of option names
         def names
           map(&:name)
         end
 
+        # Returns unique validation classes from all options.
+        #
+        # @return [Array<Class>] deduplicated list of validation classes
         def validation_classes
           @validation_classes ||=
             filter { |option| option.validation_class.present? }
@@ -23,24 +68,47 @@ module Servactory
             .uniq
         end
 
+        # Returns options that need validation checks as a hash.
+        #
+        # @return [Hash{Symbol => Object}] option names mapped to normalized bodies
         def options_for_checks
-          filter(&:need_for_checks?).to_h do |option|
+          @options_for_checks ||= filter(&:need_for_checks?).to_h do |option|
             [option.name, extract_normalized_body_from(option:)]
           end
         end
 
+        # Returns the first conflict code found among options.
+        #
+        # @return [Object, nil] conflict code or nil if no conflicts
         def defined_conflict_code
           flat_map { |option| resolve_conflicts_from(option:) }
             .reject(&:blank?)
             .first
         end
 
+        # Finds an option by its name using indexed lookup.
+        #
+        # @param name [Symbol] the option name to find
+        # @return [Option, nil] the found option or nil
         def find_by(name:)
-          find { |option| option.name == name }
+          options_index[name]
         end
 
         private
 
+        # Builds and caches a hash index for O(1) option lookups.
+        #
+        # @return [Hash{Symbol => Option}] option names mapped to Option instances
+        def options_index
+          @options_index ||= each_with_object({}) do |option, index|
+            index[option.name] = option
+          end
+        end
+
+        # Extracts the normalized body value from an option.
+        #
+        # @param option [Option] the option to extract from
+        # @return [Object] the :is value if body is a Hash with :is key, otherwise the full body
         def extract_normalized_body_from(option:)
           body = option.body
           return body unless body.is_a?(Hash)
@@ -48,6 +116,10 @@ module Servactory
           body.key?(:is) ? body.fetch(:is) : body
         end
 
+        # Resolves conflict codes from an option's define_conflicts.
+        #
+        # @param option [Option] the option to check for conflicts
+        # @return [Array<Object>] array of conflict codes (may contain nils/blanks)
         def resolve_conflicts_from(option:)
           return [] unless option.define_conflicts
 

data/lib/servactory/version.rb

@@ -5,7 +5,7 @@ module Servactory
     MAJOR = 3
     MINOR = 0
     PATCH = 0
-    PRE = "rc2"
+    PRE = "rc3"
 
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: servactory
 version: !ruby/object:Gem::Version
-  version: 3.0.0.rc2
+  version: 3.0.0.rc3
 platform: ruby
 authors:
 - Anton Sokolov