servactory 1.8.7 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1be37829a79065ae8dcecc340fbecb58a1fcd15739221b38cf57474e371f3e5
-  data.tar.gz: beed9c07d4ed8772da258084c320f0f278e5170169971abe4497a3863eb59399
+  metadata.gz: 8d3dde0507ee0b98c8ab6f6950d76928e1dd378020ac82ed17a05b73c8ad7bc2
+  data.tar.gz: edadf08439ecfbdae91640959ba142b055b5c74551c0e48519d0a50fe97a83b0
 SHA512:
-  metadata.gz: 03a6c5da26c496b0d96a7ae51cbd85e1cc70e318222db1561add7d91fa27f0278c160129735b3e65ac9165eb440a5ec3fe33c4f2390e7e33c95997521c185203
-  data.tar.gz: 73772169c25d6d2eeb45a4032bb47ce0a6f47dad6e05102a2f2512fa33eaf9c13bdcdcc665e84f7e2660c169ba683919921f497708967b2bbd3b5b221a28a7b9
+  metadata.gz: 42008a44ef24107e0c4bc9077a6b60efb0d7398d01cb437a553cce74a41ec74f11cc9109e815f5d010c693f9f75f6adc4ecb783fcb67e9b0417a687d4ea5d294
+  data.tar.gz: bc500cfae97cc2876f38882ef78bff775d4da7a18bb720a3bb5f3738db3f58d647b72010fd78ba6947a43b5ebee7275c61655683befac7765213069a3e0620a4

data/README.md

@@ -41,7 +41,7 @@ class UserService::Authenticate < Servactory::Base
   private
 
   def call
-    if (user = User.find_by(email: inputs.email)&.authenticate(inputs.password))
+    if (user = User.authenticate_by(email: inputs.email, password: inputs.password)).present?
       outputs.user = user
     else
       fail!(message: "Authentication failed")

data/config/locales/en.yml

@@ -28,9 +28,6 @@ en:
       checks:
         type:
           default_error: "[%{service_class_name}] Wrong type of output attribute `%{output_name}`, expected `%{expected_type}`, got `%{given_type}`"
-      tools:
-        conflicts:
-          error: "[%{service_class_name}] Conflict between internal and output attributes `%{overlapping_attributes}`"
     methods:
       call:
-        not_used: Nothing to perform. Use `make` or create a `call` method
+        not_used: Nothing to perform. Use `make` or create a `call` method.

data/config/locales/ru.yml

@@ -0,0 +1,33 @@
+ru:
+  servactory:
+    inputs:
+      checks:
+        inclusion:
+          default_error: "[%{service_class_name}] Неверное значение в `%{input_name}`, должно быть одним из `%{input_inclusion}`"
+        must:
+          default_error: "[%{service_class_name}] Инпут `%{input_name}` должен \"%{code}\""
+          syntax_error: "[%{service_class_name}] Синтаксическая ошибка внутри `%{code}` инпута `%{input_name}`"
+        required:
+          default_error:
+            default: "[%{service_class_name}] Обязательный инпут `%{input_name}` отсутствует"
+            for_array: "[%{service_class_name}] Обязательный элемент в инпуте-массиве `%{input_name}` отсутствует"
+        type:
+          default_error:
+            default: "[%{service_class_name}] Неверный тип инпута `%{input_name}`, ожидалось `%{expected_type}`, получено `%{given_type}`"
+            for_array: "[%{service_class_name}] Неверный тип инпута-массива `%{input_name}`, ожидалось `%{expected_type}`"
+      tools:
+        find_unnecessary:
+          error: "[%{service_class_name}] Неожиданные атрибуты: `%{unnecessary_attributes}`"
+        rules:
+          error: "[%{service_class_name}] Конфликт в опциях инпута `%{input_name}`: `%{conflict_code}`"
+    internals:
+      checks:
+        type:
+          default_error: "[%{service_class_name}] Неверный тип внутреннего атрибута `%{internal_name}`, ожидалось `%{expected_type}`, получено `%{given_type}`"
+    outputs:
+      checks:
+        type:
+          default_error: "[%{service_class_name}] Неверный тип выходящего атрибута `%{output_name}`, ожидалось `%{expected_type}`, получено `%{given_type}`"
+    methods:
+      call:
+        not_used: Нечего исполнять. Используйте `make` или создайте метод `call`.

data/lib/servactory/configuration/dsl.rb

@@ -8,10 +8,29 @@ module Servactory
       end
 
       module ClassMethods
+        def inherited(child) # rubocop:disable Metrics/AbcSize
+          super
+
+          child.config.input_error_class = config.input_error_class
+          child.config.internal_error_class = config.internal_error_class
+          child.config.output_error_class = config.output_error_class
+
+          child.config.failure_class = config.failure_class
+
+          child.config.input_option_helpers = config.input_option_helpers
+
+          child.config.aliases_for_make = config.aliases_for_make
+          child.config.shortcuts_for_make = config.shortcuts_for_make
+        end
+
+        def config
+          @config ||= Servactory::Configuration::Setup.new
+        end
+
         private
 
         def configuration(&block)
-          @configuration_factory ||= Factory.new
+          @configuration_factory ||= Factory.new(config)
 
           @configuration_factory.instance_eval(&block)
         end

data/lib/servactory/configuration/factory.rb

@@ -3,32 +3,36 @@
 module Servactory
   module Configuration
     class Factory
+      def initialize(config)
+        @config = config
+      end
+
       def input_error_class(input_error_class)
-        Servactory.configuration.input_error_class = input_error_class
+        @config.input_error_class = input_error_class
       end
 
       def output_error_class(output_error_class)
-        Servactory.configuration.output_error_class = output_error_class
+        @config.output_error_class = output_error_class
       end
 
       def internal_error_class(internal_error_class)
-        Servactory.configuration.internal_error_class = internal_error_class
+        @config.internal_error_class = internal_error_class
       end
 
       def failure_class(failure_class)
-        Servactory.configuration.failure_class = failure_class
+        @config.failure_class = failure_class
       end
 
       def input_option_helpers(input_option_helpers)
-        Servactory.configuration.input_option_helpers.merge(input_option_helpers)
+        @config.input_option_helpers.merge(input_option_helpers)
       end
 
       def aliases_for_make(aliases_for_make)
-        Servactory.configuration.aliases_for_make.merge(aliases_for_make)
+        @config.aliases_for_make.merge(aliases_for_make)
       end
 
       def shortcuts_for_make(shortcuts_for_make)
-        Servactory.configuration.shortcuts_for_make.merge(shortcuts_for_make)
+        @config.shortcuts_for_make.merge(shortcuts_for_make)
       end
     end
   end

data/lib/servactory/context/callable.rb

@@ -20,7 +20,7 @@ module Servactory
 
       def call(arguments = {})
         call!(arguments)
-      rescue Servactory.configuration.failure_class => e
+      rescue config.failure_class => e
         Servactory::Result.failure_for(exception: e)
       end
     end

data/lib/servactory/context/workspace.rb

@@ -29,14 +29,14 @@ module Servactory
       alias out outputs
 
       def fail_input!(input_name, message:)
-        raise Servactory.configuration.input_error_class.new(
+        raise self.class.config.input_error_class.new(
           input_name: input_name,
           message: message
         )
       end
 
       def fail!(message:, meta: nil)
-        raise Servactory.configuration.failure_class.new(message: message, meta: meta)
+        raise self.class.config.failure_class.new(message: message, meta: meta)
       end
 
       private
@@ -76,7 +76,7 @@ module Servactory
       end
 
       def call
-        raise Servactory.configuration.failure_class.new(
+        raise self.class.config.failure_class.new(
           message: I18n.t(
             "servactory.methods.call.not_used",
             service_class_name: self.class.name

data/lib/servactory/dsl.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Servactory
+  module DSL
+    def self.included(base)
+      base.include(Configuration::DSL)
+      base.include(Info::DSL)
+      base.include(Context::DSL)
+      base.include(Inputs::DSL)
+      base.include(Internals::DSL)
+      base.include(Outputs::DSL)
+      base.include(Methods::DSL)
+    end
+  end
+end

data/lib/servactory/inputs/dsl.rb

@@ -21,6 +21,7 @@ module Servactory
           collection_of_inputs << Input.new(
             name,
             *helpers,
+            config: config,
             **options
           )
         end

data/lib/servactory/inputs/input.rb

@@ -8,7 +8,8 @@ module Servactory
       private_constant :ARRAY_DEFAULT_VALUE
 
       attr_reader :name,
-                  :internal_name
+                  :internal_name,
+                  :config
 
       # rubocop:disable Style/KeywordParametersOrder
       def initialize(
@@ -16,10 +17,12 @@ module Servactory
         *helpers,
         as: nil,
         type:,
+        config:,
         **options
       )
         @name = name
         @internal_name = as.present? ? as : name
+        @config = config
 
         options = apply_helpers_for_options(helpers: helpers, options: options) if helpers.present?
 
@@ -43,7 +46,7 @@ module Servactory
         prepared_options = {}
 
         helpers.each do |helper|
-          found_helper = Servactory.configuration.input_option_helpers.find_by(name: helper)
+          found_helper = config.input_option_helpers.find_by(name: helper)
 
           next if found_helper.blank?
 

data/lib/servactory/inputs/tools/find_unnecessary.rb

@@ -23,7 +23,7 @@ module Servactory
             unnecessary_attributes: unnecessary_attributes.join(", ")
           )
 
-          raise Servactory.configuration.input_error_class.new(message: message_text)
+          raise @context.class.config.input_error_class.new(message: message_text)
         end
 
         private

data/lib/servactory/inputs/tools/rules.rb

@@ -35,7 +35,7 @@ module Servactory
             conflict_code: input.conflict_code
           )
 
-          raise Servactory.configuration.input_error_class.new(
+          raise @context.class.config.input_error_class.new(
             message: message_text,
             input_name: input.name
           )

data/lib/servactory/inputs/tools/validation.rb

@@ -43,7 +43,12 @@ module Servactory
           end
         end
 
-        def process_validation_classes(validation_class, input:, check_key:, check_options:)
+        def process_validation_classes(
+          validation_class,
+          input:,
+          check_key:,
+          check_options:
+        )
           validation_class.check(
             context: @context,
             input: input,
@@ -68,7 +73,7 @@ module Servactory
         def raise_errors
           return if (tmp_errors = errors.not_blank).empty?
 
-          raise Servactory.configuration.input_error_class.new(message: tmp_errors.first)
+          raise @context.class.config.input_error_class.new(message: tmp_errors.first)
         end
       end
     end

data/lib/servactory/internals/validations/base.rb

@@ -9,7 +9,7 @@ module Servactory
         def raise_error_with(message, **attributes)
           message = message.call(**attributes) if message.is_a?(Proc)
 
-          raise Servactory.configuration.internal_error_class.new(message: message)
+          raise @context.class.config.internal_error_class.new(message: message)
         end
       end
     end

data/lib/servactory/methods/dsl.rb

@@ -68,13 +68,9 @@ module Servactory
         end
 
         def method_missing(name, *args, &block)
-          if Servactory.configuration.aliases_for_make.include?(name)
-            return method_missing_for_aliases_for_make(name, *args, &block)
-          end
+          return method_missing_for_aliases_for_make(name, *args, &block) if config.aliases_for_make.include?(name)
 
-          if Servactory.configuration.shortcuts_for_make.include?(name)
-            return method_missing_for_shortcuts_for_make(name, *args, &block)
-          end
+          return method_missing_for_shortcuts_for_make(name, *args, &block) if config.shortcuts_for_make.include?(name)
 
           super
         end
@@ -97,9 +93,7 @@ module Servactory
         end
 
         def respond_to_missing?(name, *)
-          Servactory.configuration.aliases_for_make.include?(name) ||
-            Servactory.configuration.shortcuts_for_make.include?(name) ||
-            super
+          config.aliases_for_make.include?(name) || config.shortcuts_for_make.include?(name) || super
         end
 
         def next_position

data/lib/servactory/outputs/validations/base.rb

@@ -9,7 +9,7 @@ module Servactory
         def raise_error_with(message, **attributes)
           message = message.call(**attributes) if message.is_a?(Proc)
 
-          raise Servactory.configuration.output_error_class.new(message: message)
+          raise @context.class.config.output_error_class.new(message: message)
         end
       end
     end

data/lib/servactory/test_kit/result.rb

@@ -3,11 +3,27 @@
 module Servactory
   module TestKit
     class Result
-      def initialize(**attributes)
-        attributes.each_pair do |method_name, method_return|
-          define_singleton_method(method_name) { method_return }
+      def self.as_success(attributes = {})
+        Servactory::Result.success_for(context: new(attributes))
+      end
+
+      def self.as_failure(exception: nil)
+        Servactory::Result.failure_for(exception: exception)
+      end
+
+      def initialize(attributes = {})
+        attributes.each_pair do |name, value|
+          service_storage[:outputs].merge!({ name => value })
         end
       end
+
+      private_class_method :new
+
+      private
+
+      def service_storage
+        @service_storage ||= { outputs: {} }
+      end
     end
   end
 end

data/lib/servactory/version.rb

@@ -3,8 +3,8 @@
 module Servactory
   module VERSION
     MAJOR = 1
-    MINOR = 8
-    PATCH = 7
+    MINOR = 9
+    PATCH = 0
 
     STRING = [MAJOR, MINOR, PATCH].join(".")
   end

data/lib/servactory.rb

@@ -4,32 +4,12 @@ require "zeitwerk"
 
 require "active_support/core_ext/string"
 
-# require "servactory/support/loader"
-
 loader = Zeitwerk::Loader.for_gem
 loader.inflector.inflect(
   "dsl" => "DSL"
 )
 loader.setup
 
-module Servactory
-  module_function
-
-  def configuration
-    @configuration ||= Servactory::Configuration::Setup.new
-  end
-
-  def reset
-    @configuration = Servactory::Configuration::Setup.new
-  end
-
-  def configure
-    yield(configuration)
-  end
-end
+module Servactory; end
 
 require "servactory/engine" if defined?(Rails::Engine)
-
-# require_relative "servactory/exceptions"
-
-# require_relative "servactory/base"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: servactory
 version: !ruby/object:Gem::Version
-  version: 1.8.7
+  version: 1.9.0
 platform: ruby
 authors:
 - Anton Sokolov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-13 00:00:00.000000000 Z
+date: 2023-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -188,6 +188,7 @@ files:
 - README.md
 - Rakefile
 - config/locales/en.yml
+- config/locales/ru.yml
 - lib/servactory.rb
 - lib/servactory/base.rb
 - lib/servactory/configuration/dsl.rb
@@ -199,6 +200,7 @@ files:
 - lib/servactory/context/workspace/inputs.rb
 - lib/servactory/context/workspace/internals.rb
 - lib/servactory/context/workspace/outputs.rb
+- lib/servactory/dsl.rb
 - lib/servactory/engine.rb
 - lib/servactory/errors/base.rb
 - lib/servactory/errors/failure.rb
@@ -276,7 +278,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.17
 signing_key:
 specification_version: 4
 summary: A set of tools for building reliable services of any complexity