servactory 1.8.0 → 1.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddbffa6de1db943a943b369efceef704bb98c5160b13fcada0515069705af423
-  data.tar.gz: 4b6c33e2d95002a784468ee064ff83d90ce63e01f1ca323dc1afccad103c5063
+  metadata.gz: 2a87d01c5389b8d6d538b2cd1befe0cd8fa51b0ea578eefb8c0c0b457957fa75
+  data.tar.gz: 4ff7989cf58492790ad7cfef807cd2a2f6befacefa9407a4fb04e3b4567e2d6f
 SHA512:
-  metadata.gz: f57071853afa1e92822161608af16e9d303b03bdbe769110cb27d9e59be3d77b4517da5b55d8fdc93a86bcfd470617d5094d8ea03eeb5dd5abad342ead7ae1e9
-  data.tar.gz: ff862da58716ac985651f59d74aa49f44d06b10c6d8e000bc45877575f83062567f97e0acbaaa9559091ba888ec3a0dde38d9db571f400726a2c9a06a13d042e
+  metadata.gz: 2b880c2475447311de03023601adc91597b38ecd083d5e108e4df8869dd65137d2a4001066142234c609c69aecf279d211be2258f806d662fc43893e97fea978
+  data.tar.gz: 8efc74ceb569789340dad5b3e1d54cc996528fda101f6bbf9719b9c8f55fc70baf5674659116d27312cc271ec9a7e0764f4de4c9e8a26d674377c157cc1a3330

data/README.md

@@ -9,12 +9,18 @@ A set of tools for building reliable services of any complexity.
 
 See [servactory.com](https://servactory.com) for documentation.
 
-## Examples
+## Example
+
+### Installation
+
+```ruby
+gem "servactory"
+```
 
 ### Service
 
 ```ruby
-class UserService::Authenticate < ApplicationService::Base
+class UserService::Authenticate < Servactory::Base
   input :email, type: String
   input :password, type: String
 
@@ -32,7 +38,7 @@ class UserService::Authenticate < ApplicationService::Base
 end
 ```
 
-### Using in controller
+### Usage
 
 ```ruby
 class SessionsController < ApplicationController
@@ -58,8 +64,10 @@ end
 
 ## Contributing
 
-This project is intended to be a safe, welcoming space for collaboration. Contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. We recommend reading the [contributing guide](./website/docs/CONTRIBUTING.md) as well.
+This project is intended to be a safe, welcoming space for collaboration. 
+Contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. 
+We recommend reading the [contributing guide](./website/docs/CONTRIBUTING.md) as well.
 
 ## License
 
-ViewComponent is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+Servactory is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/lib/servactory/context/workspace/internals.rb

@@ -28,7 +28,9 @@ module Servactory
 
           return yield unless @collection_of_internals.names.include?(prepared_name)
 
-          internal = @collection_of_internals.find_by(name: prepared_name)
+          internal = @collection_of_internals.find_by(name: prepared_name) # ::Servactory::Internals::Internal
+
+          return yield if internal.nil?
 
           Servactory::Internals::Validations::Type.validate!(
             context: @context,

data/lib/servactory/context/workspace/outputs.rb

@@ -28,7 +28,9 @@ module Servactory
 
           return yield unless @collection_of_outputs.names.include?(prepared_name)
 
-          output = @collection_of_outputs.find_by(name: prepared_name)
+          output = @collection_of_outputs.find_by(name: prepared_name) # ::Servactory::Outputs::Output
+
+          return yield if output.nil?
 
           Servactory::Outputs::Validations::Type.validate!(
             context: @context,

data/lib/servactory/inputs/input.rb

@@ -24,14 +24,20 @@ module Servactory
         options = apply_helpers_for_options(helpers: helpers, options: options) if helpers.present?
 
         add_basic_options_with(type: type, options: options)
+      end
+      # rubocop:enable Style/KeywordParametersOrder
 
-        collection_of_options.each do |option|
-          self.class.attr_reader(:"#{option.name}")
+      def method_missing(name, *args, &block)
+        option = collection_of_options.find_by(name: name)
 
-          instance_variable_set(:"@#{option.name}", option.value)
-        end
+        return super if option.nil?
+
+        option.value
+      end
+
+      def respond_to_missing?(name, *)
+        collection_of_options.names.include?(name) || super
       end
-      # rubocop:enable Style/KeywordParametersOrder
 
       def apply_helpers_for_options(helpers:, options:)
         prepared_options = {}

data/lib/servactory/inputs/options_collection.rb

@@ -5,12 +5,16 @@ module Servactory
     class OptionsCollection
       # NOTE: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes
       extend Forwardable
-      def_delegators :@collection, :<<, :filter, :each, :map, :flat_map
+      def_delegators :@collection, :<<, :filter, :each, :map, :flat_map, :find
 
       def initialize(*)
         @collection = Set.new
       end
 
+      def names
+        map(&:name)
+      end
+
       def validation_classes
         filter { |option| option.validation_class.present? }.map(&:validation_class).uniq
       end
@@ -34,6 +38,10 @@ module Servactory
           end
         end.reject(&:blank?).first
       end
+
+      def find_by(name:)
+        find { |option| option.name == name }
+      end
     end
   end
 end

data/lib/servactory/methods/dsl.rb

@@ -87,8 +87,8 @@ module Servactory
           end
         end
 
-        def respond_to_missing?(shortcut_name, *)
-          Servactory.configuration.aliases_for_make.include?(shortcut_name) ||
+        def respond_to_missing?(name, *)
+          Servactory.configuration.aliases_for_make.include?(name) ||
             Servactory.configuration.shortcuts_for_make.include?(name) ||
             super
         end

data/lib/servactory/result.rb

@@ -3,26 +3,46 @@
 module Servactory
   class Result
     def self.success_for(...)
-      new.send(:success_for, ...)
+      new(...).send(:as_success)
     end
 
     def self.failure_for(...)
-      new.send(:failure_for, ...)
+      new(...).send(:as_failure)
     end
 
-    private
+    def initialize(context: nil, collection_of_outputs: nil, exception: nil)
+      @context = context
+      @collection_of_outputs = collection_of_outputs
+      @exception = exception
+    end
+
+    def method_missing(name, *args, &block)
+      output = @collection_of_outputs&.find_by(name: name)
+
+      return super if output.nil?
+
+      output_value_for(output)
+    end
 
-    def success_for(context:, collection_of_outputs:)
-      prepare_outputs_with(context: context, collection_of_outputs: collection_of_outputs)
+    def respond_to_missing?(name, *)
+      @collection_of_outputs&.names&.include?(name) || super
+    end
+
+    def inspect
+      "#<#{self.class.name} #{draw_result}>"
+    end
 
+    private
+
+    def as_success
       define_singleton_method(:success?) { true }
       define_singleton_method(:failure?) { false }
 
       self
     end
 
-    def failure_for(exception:)
-      define_singleton_method(:error) { exception }
+    def as_failure
+      define_singleton_method(:error) { @exception }
 
       define_singleton_method(:success?) { false }
       define_singleton_method(:failure?) { true }
@@ -30,12 +50,14 @@ module Servactory
       self
     end
 
-    def prepare_outputs_with(context:, collection_of_outputs:)
-      collection_of_outputs.each do |output|
-        self.class.attr_reader(:"#{output.name}")
+    def draw_result
+      @collection_of_outputs&.map do |output|
+        "@#{output.name}=#{output_value_for(output).inspect}"
+      end&.join(", ")
+    end
 
-        instance_variable_set(:"@#{output.name}", context.instance_variable_get(:"@#{output.name}"))
-      end
+    def output_value_for(output)
+      @context.instance_variable_get(:"@#{output.name}")
     end
   end
 end

data/lib/servactory/version.rb

@@ -4,7 +4,7 @@ module Servactory
   module VERSION
     MAJOR = 1
     MINOR = 8
-    PATCH = 0
+    PATCH = 2
 
     STRING = [MAJOR, MINOR, PATCH].join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: servactory
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.2
 platform: ruby
 authors:
 - Anton Sokolov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-20 00:00:00.000000000 Z
+date: 2023-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rbs
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -164,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.19'
+- !ruby/object:Gem::Dependency
+  name: steep
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement