servactory 1.6.5 → 1.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e0ef0253d0030321767ea6a532f52fada7923dcf9f0cc87e7651d7df5a1ec57
-  data.tar.gz: 5e080cef06176ffdd734802503cf987fa6608f3acccf7d1497da6ad0968142c9
+  metadata.gz: 36958cd40c5a7f821265cbbaa4509262da61fb1dcb799d9ba57433012d2e35c1
+  data.tar.gz: 3a7a5736e738bc71be30ddef3bee4c536c108a29f24493da9359aa3cfd3eef3c
 SHA512:
-  metadata.gz: 1195d6f2dcebe355307197eaf11cf0591ba5d9486020572afc8e4991741920664d0f8525052c1d1742e9af14eee627634e7be439529e9827ecfdaa437e87c8a0
-  data.tar.gz: 48ed814dff14b30ac71d3484649ac7412e54ec8edcdc2bc8bcaa925d2babac1573efd473547717d83ea821064926ca8a9810c34fa91995d018d7b5e6c23bc221
+  metadata.gz: e9b3da95a52a025298169b2f6eea8e6b75bf538dc1ea98c4e903c3c43e50dccada335f37b6883f1cf7c1cb49ed4370a2b182ee2c05cb1c48e35b888575bdd26e
+  data.tar.gz: d52fe6ad625529e3f5efb114cbea5331505df217802f3acfc3a68acaa61e761de770c394210d28dd16be134c2eb1003e42d6ed1dc994e8ed8ec8ddad6538e1ad

data/README.md

@@ -9,6 +9,53 @@ A set of tools for building reliable services of any complexity.
 
 See [servactory.com](https://servactory.com) for documentation.
 
+## Examples
+
+### Service
+
+```ruby
+class UserService::Authenticate < ApplicationService::Base
+  input :email, type: String
+  input :password, type: String
+
+  output :user, type: User
+
+  private
+
+  def call
+    if (user = User.find_by(email: inputs.email)&.authenticate(inputs.password))
+      self.user = user
+    else
+      fail!(message: "Authentication failed")
+    end
+  end
+end
+```
+
+### Using in controller
+
+```ruby
+class SessionsController < ApplicationController
+  def create
+    service_result = UserService::Authenticate.call(**session_params)
+
+    if service_result.success?
+      session[:current_user_id] = service_result.user.id
+      redirect_to service_result.user
+    else
+      flash.now[:message] = service_result.errors.first.message
+      render :new
+    end
+  end
+
+  private
+
+  def session_params
+    params.require(:session).permit(:email, :password)
+  end
+end
+```
+
 ## Contributing
 
 This project is intended to be a safe, welcoming space for collaboration. Contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. We recommend reading the [contributing guide](./website/docs/CONTRIBUTING.md) as well.

data/lib/servactory/context/callable.rb

@@ -6,6 +6,8 @@ module Servactory
       def call!(arguments = {}) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
         @context_store = Store.new(self)
 
+        context_store.context.send(:assign_service_strict_mode, true)
+
         assign_data_with(arguments)
 
         inputs_workbench.find_unnecessary!
@@ -31,6 +33,8 @@ module Servactory
       def call(arguments = {}) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
         @context_store = Store.new(self)
 
+        context_store.context.send(:assign_service_strict_mode, false)
+
         assign_data_with(arguments)
 
         inputs_workbench.find_unnecessary!

data/lib/servactory/context/workspace.rb

@@ -29,7 +29,17 @@ module Servactory
       end
 
       def fail!(message:, meta: nil)
-        errors << Servactory.configuration.failure_class.new(message: message, meta: meta)
+        failure = Servactory.configuration.failure_class.new(message: message, meta: meta)
+
+        raise failure if @service_strict_mode
+
+        errors << failure
+      end
+
+      private
+
+      def assign_service_strict_mode(flag)
+        @service_strict_mode = flag
       end
     end
   end

data/lib/servactory/inputs/dsl.rb

@@ -16,9 +16,10 @@ module Servactory
 
         private
 
-        def input(name, **options)
+        def input(name, *helpers, **options)
           collection_of_inputs << Input.new(
             name,
+            *helpers,
             **options
           )
         end

data/lib/servactory/inputs/input.rb

@@ -5,12 +5,21 @@ module Servactory
     class Input # rubocop:disable Metrics/ClassLength
       ARRAY_DEFAULT_VALUE = ->(is: false, message: nil) { { is: is, message: message } }
 
+      HELPER_LIBRARY = {
+        optional: { required: false },
+        internal: { internal: true },
+        as_array: { array: true }
+      }.freeze
+
+      private_constant :ARRAY_DEFAULT_VALUE, :HELPER_LIBRARY
+
       attr_reader :name,
                   :internal_name
 
       # rubocop:disable Style/KeywordParametersOrder
       def initialize(
         name,
+        *helpers,
         as: nil,
         type:,
         **options
@@ -18,6 +27,8 @@ module Servactory
         @name = name
         @internal_name = as.present? ? as : name
 
+        options = apply_helpers_for_options(helpers: helpers, options: options) if helpers.present?
+
         add_basic_options_with(type: type, options: options)
 
         collection_of_options.each do |option|
@@ -28,6 +39,20 @@ module Servactory
       end
       # rubocop:enable Style/KeywordParametersOrder
 
+      def apply_helpers_for_options(helpers:, options:)
+        prepared_options = {}
+
+        helpers.each do |helper|
+          next unless HELPER_LIBRARY.key?(helper)
+
+          found_helper = HELPER_LIBRARY[helper]
+
+          prepared_options.merge!(found_helper)
+        end
+
+        options.merge(prepared_options)
+      end
+
       def add_basic_options_with(type:, options:)
         # Check Class: Servactory::Inputs::Validations::Required
         add_required_option_with(options)
@@ -63,7 +88,7 @@ module Servactory
             )
           ],
           define_input_conflicts: [
-            DefineInputConflict.new(content: -> { return :required_vs_default if required? && default_value_present? })
+            DefineInputConflict.new(content: -> { :required_vs_default if required? && default_value_present? })
           ],
           need_for_checks: true,
           value_key: :is,
@@ -114,8 +139,8 @@ module Servactory
             )
           ],
           define_input_conflicts: [
-            DefineInputConflict.new(content: -> { return :array_vs_array if array? && types.include?(Array) }),
-            DefineInputConflict.new(content: -> { return :array_vs_inclusion if array? && inclusion_present? })
+            DefineInputConflict.new(content: -> { :array_vs_array if array? && types.include?(Array) }),
+            DefineInputConflict.new(content: -> { :array_vs_inclusion if array? && inclusion_present? })
           ],
           need_for_checks: false,
           value_key: :is,

data/lib/servactory/inputs/validations/type.rb

@@ -94,7 +94,7 @@ module Servactory
         end
 
         def prepared_value
-          @prepared_value ||= @input.optional? && !@input.default.nil? ? @input.default : @value
+          @prepared_value ||= @input.optional? && !@input.default.nil? && @value.blank? ? @input.default : @value
         end
       end
     end

data/lib/servactory/internals/validations/type.rb

@@ -31,6 +31,8 @@ module Servactory
         end
 
         def validate!
+          return unless should_be_checked?
+
           return if prepared_types.any? { |type| @value.is_a?(type) }
 
           raise_error_with(
@@ -44,6 +46,12 @@ module Servactory
 
         private
 
+        def should_be_checked?
+          @internal.required? || (
+            @internal.optional? && !@value.nil?
+          )
+        end
+
         def prepared_types
           @prepared_types ||=
             Array(@internal.types).map do |type|

data/lib/servactory/outputs/validations/type.rb

@@ -31,6 +31,8 @@ module Servactory
         end
 
         def validate!
+          return unless should_be_checked?
+
           return if prepared_types.any? { |type| @value.is_a?(type) }
 
           raise_error_with(
@@ -44,6 +46,14 @@ module Servactory
 
         private
 
+        def should_be_checked?
+          @output.required? || (
+            @output.optional? && !@output.default.nil?
+          ) || (
+            @output.optional? && !@value.nil?
+          )
+        end
+
         def prepared_types
           @prepared_types ||=
             Array(@output.types).map do |type|

data/lib/servactory/test/fake_type.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Servactory
+  module Test
+    class FakeType; end
+  end
+end

data/lib/servactory/test/result.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Servactory
+  module Test
+    class Result
+      def initialize(**attributes)
+        attributes.each_pair do |method_name, method_return|
+          define_singleton_method(method_name) { method_return }
+        end
+      end
+    end
+  end
+end

data/lib/servactory/version.rb

@@ -4,7 +4,7 @@ module Servactory
   module VERSION
     MAJOR = 1
     MINOR = 6
-    PATCH = 5
+    PATCH = 7
 
     STRING = [MAJOR, MINOR, PATCH].join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: servactory
 version: !ruby/object:Gem::Version
-  version: 1.6.5
+  version: 1.6.7
 platform: ruby
 authors:
 - Anton Sokolov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-06 00:00:00.000000000 Z
+date: 2023-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -247,6 +247,8 @@ files:
 - lib/servactory/outputs/validations/type.rb
 - lib/servactory/outputs/workbench.rb
 - lib/servactory/result.rb
+- lib/servactory/test/fake_type.rb
+- lib/servactory/test/result.rb
 - lib/servactory/utils.rb
 - lib/servactory/version.rb
 homepage: https://github.com/afuno/servactory