servactory 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3877871b09a517026f3b66849d43348aae44feca18f2f97e101d1948cbc4f9d0
-  data.tar.gz: c6f0feca2515ebfd9e6123351c78ac29aee0ded0da66c4f689b259460ee7e403
+  metadata.gz: 54a713971d52bebd38a97f473eb942be19f5c4029604aa26f0729cb1dc40f24a
+  data.tar.gz: 1b368e874cdf3c502328fe3dbf71758a3c0821140c1b0e9a595f6622b41ec1bc
 SHA512:
-  metadata.gz: 3d9d7237afe83f2b813d3c3555a322c5357dcc56aff1f45c0289c8efc47a139f5dc0f1bfec5f81005be1083aa0372b40a99b345df212aeded2edb425a03337c8
-  data.tar.gz: e1c7a318ce6a853269c6c3240e4028921fbad2f2d50c0e0c8d1ef52820bff91fe96638e363bbf63f278419cf477c8c2211a929d0c8f19a7198dd4e76c2c122df
+  metadata.gz: c2e412f4e06a1a21aa70a43a0f898f6d5fc0adcca1eaf7922edb80aa719313b9c2325d83ef41e34eda9c8cacc988e60b076938e23b1ff1e709d50aee9ce0f0b1
+  data.tar.gz: d871cef64e8249b89572f6b97e9fdd9410632d20a393ea77d59f36481acc7f0207bfa26e6c79749a2031962927b965955986f257ce298d554d8289f2f85bfaf4

data/README.md

@@ -26,6 +26,9 @@ A set of tools for building reliable services of any complexity.
   - [Stage](#stage)
   - [Failures](#failures)
   - [Result](#result)
+- [Testing](#testing)
+- [Thanks](#thanks)
+- [Contributing](#contributing)
 
 ## Requirements
 
@@ -160,6 +163,26 @@ class UsersService::Create < ApplicationService::Base
 end
 ```
 
+#### As
+
+This option changes the name of the input within the service.
+
+```ruby
+class NotificationService::Create < ApplicationService::Base
+  input :customer, as: :user, type: User
+
+  output :notification, type: Notification
+
+  stage { make :create_notification! }
+
+  private
+
+  def create_notification!
+    self.notification = Notification.create!(user: inputs.user)
+  end
+end
+```
+
 #### An array of specific values
 
 ```ruby
@@ -342,3 +365,19 @@ And then you can work with this result, for example, in this way:
 ```ruby
 Notification::SendJob.perform_later(service_result.notification.id)
 ```
+
+## Testing
+
+Testing Servactory services is the same as testing regular Ruby classes.
+
+## Thanks
+
+Thanks to [@sunny](https://github.com/sunny) for [Service Actor](https://github.com/sunny/actor).
+
+## Contributing
+
+1. Fork it (https://github.com/afuno/servactory/fork);
+2. Create your feature branch (`git checkout -b my-new-feature`);
+3. Commit your changes (`git commit -am "Add some feature"`);
+4. Push to the branch (`git push origin my-new-feature`);
+5. Create a new Pull Request.

data/lib/servactory/base.rb

@@ -8,5 +8,7 @@ module Servactory
     include InternalArguments::DSL
     include OutputArguments::DSL
     include Stage::DSL
+
+    private_class_method :new
   end
 end

data/lib/servactory/context/store.rb

@@ -6,7 +6,7 @@ module Servactory
       attr_reader :context
 
       def initialize(service_class)
-        @context = service_class.new
+        @context = service_class.send(:new)
       end
     end
   end

data/lib/servactory/context/workspace/errors.rb

@@ -8,12 +8,12 @@ module Servactory
         extend Forwardable
         def_delegators :@collection, :<<, :filter, :reject, :empty?, :first
 
-        def initialize(collection = [])
+        def initialize(collection = Set.new)
           @collection = collection
         end
 
-        def not_blank_and_uniq
-          Errors.new(reject(&:blank?).uniq)
+        def not_blank
+          Errors.new(reject(&:blank?))
         end
 
         def for_fails

data/lib/servactory/context/workspace.rb

@@ -23,7 +23,7 @@ module Servactory
       end
 
       def raise_first_fail
-        return if (tmp_errors = errors.for_fails.not_blank_and_uniq).empty?
+        return if (tmp_errors = errors.for_fails.not_blank).empty?
 
         raise Servactory.configuration.failure_class, tmp_errors.first.message
       end

data/lib/servactory/input_arguments/checks/base.rb

@@ -4,18 +4,18 @@ module Servactory
   module InputArguments
     module Checks
       class Base
-        def initialize
-          @errors = []
-        end
-
-        attr_reader :errors
-
         protected
 
         def add_error(message, **arguments)
           message = message.call(**arguments) if message.is_a?(Proc)
 
-          errors.push(message)
+          errors.add(message)
+        end
+
+        private
+
+        def errors
+          @errors ||= Errors.new
         end
       end
     end

data/lib/servactory/input_arguments/checks/errors.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Servactory
+  module InputArguments
+    module Checks
+      class Errors
+        # NOTE: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes
+        extend Forwardable
+        def_delegators :@collection, :add, :to_a
+
+        def initialize(*)
+          @collection = Set.new
+        end
+      end
+    end
+  end
+end

data/lib/servactory/input_arguments/collection.rb

@@ -8,7 +8,7 @@ module Servactory
       def_delegators :@collection, :<<, :each, :map
 
       def initialize(*)
-        @collection = []
+        @collection = Set.new
       end
 
       def names

data/lib/servactory/input_arguments/input_argument.rb

@@ -6,10 +6,19 @@ module Servactory
       ARRAY_DEFAULT_VALUE = ->(is: false, message: nil) { { is: is, message: message } }
 
       attr_reader :name,
+                  :internal_name,
                   :collection_of_options
 
-      def initialize(name, collection_of_options:, type:, **options)
+      # rubocop:disable Style/KeywordParametersOrder
+      def initialize(
+        name,
+        as: nil,
+        collection_of_options:,
+        type:,
+        **options
+      )
         @name = name
+        @internal_name = as.present? ? as : name
         @collection_of_options = collection_of_options
 
         add_basic_options_with(type: type, options: options)
@@ -20,6 +29,7 @@ module Servactory
           instance_variable_set(:"@#{option.name}", option.value)
         end
       end
+      # rubocop:enable Style/KeywordParametersOrder
 
       def add_basic_options_with(type:, options:)
         # Check Class: Servactory::InputArguments::Checks::Required
@@ -72,8 +82,8 @@ module Servactory
         collection_of_options << Option.new(
           name: :types,
           input: self,
-          original_value: Array(type),
           check_class: Servactory::InputArguments::Checks::Type,
+          original_value: Array(type),
           need_for_checks: true,
           value_fallback: nil,
           with_advanced_mode: false
@@ -167,6 +177,7 @@ module Servactory
         collection_of_options << Option.new(
           name: :internal,
           input: self,
+          check_class: nil,
           define_input_methods: lambda do
             <<-RUBY
               def internal?
@@ -175,7 +186,6 @@ module Servactory
             RUBY
           end,
           need_for_checks: false,
-          check_class: nil,
           value_key: :is,
           value_fallback: false,
           **options

data/lib/servactory/input_arguments/options_collection.rb

@@ -8,7 +8,7 @@ module Servactory
       def_delegators :@collection, :<<, :filter, :each, :map
 
       def initialize(*)
-        @collection = []
+        @collection = Set.new
       end
 
       def check_classes

data/lib/servactory/input_arguments/tools/check.rb

@@ -13,8 +13,6 @@ module Servactory
           @incoming_arguments = incoming_arguments
           @collection_of_input_arguments = collection_of_input_arguments
           @collection_of_input_options = collection_of_input_options
-
-          @errors = []
         end
 
         def check!
@@ -42,7 +40,7 @@ module Servactory
               check_options: check_options
             )
 
-            @errors.push(*errors_from_checks)
+            errors.merge(errors_from_checks.to_a)
           end
         end
 
@@ -64,8 +62,12 @@ module Servactory
 
         ########################################################################
 
+        def errors
+          @errors ||= CheckErrors.new
+        end
+
         def raise_errors
-          return if (tmp_errors = @errors.reject(&:blank?).uniq).empty?
+          return if (tmp_errors = errors.not_blank).empty?
 
           raise Servactory.configuration.input_argument_error_class, tmp_errors.first
         end

data/lib/servactory/input_arguments/tools/check_errors.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Servactory
+  module InputArguments
+    module Tools
+      class CheckErrors
+        # NOTE: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes
+        extend Forwardable
+        def_delegators :@collection, :merge, :reject, :first, :empty?
+
+        def initialize(collection = Set.new)
+          @collection = collection
+        end
+
+        def not_blank
+          CheckErrors.new(reject(&:blank?))
+        end
+      end
+    end
+  end
+end

data/lib/servactory/input_arguments/tools/prepare.rb

@@ -31,7 +31,7 @@ module Servactory
           input_value = @incoming_arguments.fetch(input.name, nil)
           input_value = input.default if input.optional? && input_value.blank?
 
-          @inputs_variables[input.name] = input_value
+          @inputs_variables[input.internal_name] = input_value
 
           return unless input.internal?
 

data/lib/servactory/internal_arguments/collection.rb

@@ -8,7 +8,7 @@ module Servactory
       def_delegators :@collection, :<<, :each, :map
 
       def initialize(*)
-        @collection = []
+        @collection = Set.new
       end
 
       def names

data/lib/servactory/output_arguments/collection.rb

@@ -8,7 +8,7 @@ module Servactory
       def_delegators :@collection, :<<, :each, :map
 
       def initialize(*)
-        @collection = []
+        @collection = Set.new
       end
 
       def names

data/lib/servactory/stage/methods.rb

@@ -8,7 +8,7 @@ module Servactory
       def_delegators :@methods, :<<, :each
 
       def initialize(*)
-        @methods = []
+        @methods = Set.new
       end
     end
   end

data/lib/servactory/version.rb

@@ -4,7 +4,7 @@ module Servactory
   module VERSION
     MAJOR = 1
     MINOR = 4
-    PATCH = 3
+    PATCH = 4
 
     STRING = [MAJOR, MINOR, PATCH].join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: servactory
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Anton Sokolov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-12 00:00:00.000000000 Z
+date: 2023-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk
@@ -177,6 +177,7 @@ files:
 - lib/servactory/errors/internal_argument_error.rb
 - lib/servactory/errors/output_argument_error.rb
 - lib/servactory/input_arguments/checks/base.rb
+- lib/servactory/input_arguments/checks/errors.rb
 - lib/servactory/input_arguments/checks/inclusion.rb
 - lib/servactory/input_arguments/checks/must.rb
 - lib/servactory/input_arguments/checks/required.rb
@@ -187,6 +188,7 @@ files:
 - lib/servactory/input_arguments/option.rb
 - lib/servactory/input_arguments/options_collection.rb
 - lib/servactory/input_arguments/tools/check.rb
+- lib/servactory/input_arguments/tools/check_errors.rb
 - lib/servactory/input_arguments/tools/find_unnecessary.rb
 - lib/servactory/input_arguments/tools/prepare.rb
 - lib/servactory/input_arguments/tools/rules.rb