serial_translator 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9195a07bb5714e15a778ba0de2dc2e23d0be4f9
-  data.tar.gz: ad43b00cdf697c73e7bde108428ff91740f4b52b
+  metadata.gz: 46318b38f444ed6a25379dd0aeafe616232b1f22
+  data.tar.gz: 4aa381357c2b9ae40d97330ca7b466114d69225f
 SHA512:
-  metadata.gz: 831d4682cdde18ff4e9ddaef77adac67447b78093e9f8a732ada466b0b4176366662e5c668954d515e9d6d3250f05bec53f30ac4b0b73ccf90007552eb00cc56
-  data.tar.gz: d88f89b1769a907ecf3df74640b8fad8913509eeb1de4f890b3885c092b6aba11a06388348082d52217156ef7b1e66ebbcf4168e331aadcdefee76e61572100f
+  metadata.gz: 179f207c79c20b56732b8a760ac18e0c02cb7e97de9d781a9de6761fc9a6480b7908f0cb701c40dfda4f51b3058f89cf9914511042d004fea80593c66baa7585
+  data.tar.gz: 2c46ea1ceaf2f97f76c67d954ca935167bb3f793b6fafedf3acf3a346635328feb396487be6035cd77e3ce687d0bcfe3daa1806e86fcf38b6804e9074989ac22

data/.rspec

@@ -0,0 +1 @@
+--color

data/lib/serial_translator.rb

@@ -37,6 +37,7 @@ module SerialTranslator
           else
             translations.delete(current_translation_locale)
           end
+          __send__(:"#{attribute}_translations_will_change!")
           __send__(:"#{attribute}_translations=", translations)
         end
 

data/lib/serial_translator/version.rb

@@ -1,3 +1,3 @@
 module SerialTranslator
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/lib/serial_translator/serial_translator_validator_spec.rb

@@ -6,80 +6,94 @@ describe SerialTranslator::SerialTranslatorValidator do
   describe 'presence validation' do
     it 'validates presence correctly if attribute is nil' do
       example.valid?
-      example.should have(1).error_on(:description)
+      expect(example.errors[:description].size).to eq 1
     end
 
     it 'validates presence correctly if attribute is empty' do
       example.description = ''
-      example.should have(1).error_on(:description)
+      example.valid?
+      expect(example.errors[:description].size).to eq 1
     end
 
     it 'has no error if everything is fine' do
       example.description = 'This is a nice foo thing'
-      example.should have(0).errors_on(:description)
+      example.valid?
+      expect(example.errors[:description].size).to eq 0
     end
 
     it 'is valid if any language has a value' do
       example.description_translations = { en: '', de: '' }
-      example.should have(1).errors_on(:description)
+      example.valid?
+      expect(example.errors[:description].size).to eq 1
+
       example.description_translations = { en: '', de: 'foobar' }
-      example.should have(0).errors_on(:description)
+      example.valid?
+      expect(example.errors[:description].size).to eq 0
+
       example.description_translations = { en: 'foobar', de: nil }
-      example.should have(0).errors_on(:description)
+      example.valid?
+      expect(example.errors[:description].size).to eq 0
     end
   end
 
   describe 'length validation' do
     it 'validates min length correctly' do
       example.title = '123'
-      example.should have(1).error_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 1
     end
 
     it 'validates max length correctly' do
       example.title = 'f' * 26
-      example.should have(1).error_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 1
     end
 
     it 'ignores blank fields' do
       example.title = ''
-      example.should have(0).errors_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 0
     end
 
     it 'validates all translation values' do
       example.title_translations = { en: '123', de: '123' }
-      example.should have(2).errors_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 2
 
       example.title_translations = { en: '123456', de: '123' }
-      example.should have(1).errors_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 1
 
       example.title_translations = { en: '123', de: '123456' }
-      example.should have(1).errors_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 1
 
       example.title_translations = { en: '123456', de: '123456' }
-      example.should have(0).errors_on(:title)
+      example.valid?
+      expect(example.errors[:title].size).to eq 0
     end
 
     it 'validates correctly on language change as well' do
       I18n.locale = :de
       example.description = :something_to_make_it_pass_valid
       example.title = 'Valid foo'
-      example.should be_valid
+      expect(example).to be_valid
 
       I18n.locale = :en
       example.title = ''
-      example.should be_valid
+      expect(example).to be_valid
     end
   end
 
   describe '#kind' do
     it 'returns length if length validation is set' do
       validator = SerialTranslator::SerialTranslatorValidator.new(attributes: :foo, length: 1..2)
-      validator.kind.should eq :length
+      expect(validator.kind).to eq :length
     end
 
     it 'returns presence if it is no length validation' do
       validator = SerialTranslator::SerialTranslatorValidator.new(attributes: :foo)
-      validator.kind.should eq :presence
+      expect(validator.kind).to eq :presence
     end
   end
 end

data/spec/lib/serial_translator_spec.rb

@@ -7,32 +7,32 @@ describe SerialTranslator do
   describe 'getting a translated value' do
     it 'returns the translated value in the requested locale' do
       object.title_translations = { de: 'German translation', en: 'English translation' }
-      object.title(:de).should eq 'German translation'
+      expect(object.title(:de)).to eq 'German translation'
     end
 
     it 'returns the origin locale value if no translation is present' do
       object.title_translations = { en: 'English translation' }
-      object.title(:de).should eq 'English translation'
+      expect(object.title(:de)).to eq 'English translation'
     end
 
     it 'returns the origin locale value if the translation is empty' do
       object.title_translations = { de: '', en: 'English translation' }
-      object.title(:de).should eq 'English translation'
+      expect(object.title(:de)).to eq 'English translation'
     end
 
     it 'returns nil if no translations are there at all' do
       object.title_translations = {}
-      object.title(:de).should be_nil
+      expect(object.title(:de)).to be_nil
     end
 
     it 'uses the given text locale' do
       object.title_translations = { de: 'Deutsch', en: 'English' }
       object.current_translation_locale = :en
-      object.title.should eq 'English'
+      expect(object.title).to eq 'English'
     end
 
     it 'does not fail even if translations were not initialized before' do
-      object.title.should be_blank
+      expect(object.title).to be_blank
     end
   end
 
@@ -40,74 +40,79 @@ describe SerialTranslator do
     it 'sets the value for the current text locale' do
       object.current_translation_locale = :de
       object.title = 'Deutsch'
-      object.title_translations.should eq({ de: 'Deutsch' })
+      expect(object.title_translations).to eq({ de: 'Deutsch' })
     end
 
     it 'nil removes the value for the current text locale' do
       object.title_translations = { de: 'Deutsch' }
       object.current_translation_locale = :de
       object.title = nil
-      object.title_translations.should eq({})
+      expect(object.title_translations).to eq({})
     end
 
     it 'blank string removes the value for the current text locale' do
       object.title_translations = { de: 'Deutsch' }
       object.current_translation_locale = :de
       object.title = "    "
-      object.title_translations.should eq({})
+      expect(object.title_translations).to eq({})
+    end
+
+    it 'marks the changes on the object for active record' do
+      object.title = 'Changed'
+      expect(object.changes).to include :title_translations
     end
   end
 
   describe 'getting an attribute for a specific locale' do
     it 'gets the correct translation' do
       object.title_translations = { de: 'Deutsch' }
-      object.title_de.should eq 'Deutsch'
+      expect(object.title_de).to eq 'Deutsch'
     end
 
     it 'uses fallback mechanisms as well' do
       object.title_translations = { en: 'English' }
-      object.title_de.should eq 'English'
+      expect(object.title_de).to eq 'English'
     end
   end
 
   describe 'writing an attribute with for a specific locale' do
     it 'sets the value for the correct locale' do
       object.title_de = 'Deutsch'
-      object.title_translations.should eq({ de: 'Deutsch' })
+      expect(object.title_translations).to eq({ de: 'Deutsch' })
     end
 
     it 'works for complex locales as well' do
       object.title_en_gb = 'Arrr'
-      object.title_translations.should eq({ :'en-GB' => 'Arrr' })
+      expect(object.title_translations).to eq({ :'en-GB' => 'Arrr' })
     end
   end
 
   describe '#current_translation_locale' do
     it 'returns the value that was given' do
       object.current_translation_locale = 'de'
-      object.current_translation_locale.should eq :de
+      expect(object.current_translation_locale).to eq :de
     end
 
     it 'must not return nil' do
       object.current_translation_locale = nil
-      object.current_translation_locale.should eq I18n.locale.to_sym
+      expect(object.current_translation_locale).to eq I18n.locale.to_sym
     end
   end
 
   describe '#translated_locales' do
     it 'returns an empty array if nothing was translated' do
-      object.translated_locales.should eq []
+      expect(object.translated_locales).to eq []
     end
 
     it 'includes all locales where something is present' do
       object.title_translations = { en: 'Foo', de: 'Foo' }
       object.summary_translations = { nb: 'Foo' }
-      object.translated_locales.should eq [:en, :de, :nb]
+      expect(object.translated_locales).to eq [:en, :de, :nb]
     end
 
     it 'does not include locales where all translations are blank' do
       object.title_translations = { en: 'Foo', de: '' }
-      object.translated_locales.should eq [:en]
+      expect(object.translated_locales).to eq [:en]
     end
   end
 
@@ -115,15 +120,15 @@ describe SerialTranslator do
     before { object.title_translations = { en: 'Foo', de: '' } }
 
     it 'returns true if there is a translation available for this locale' do
-      object.should be_translated_into :en
+      expect(object).to be_translated_into :en
     end
 
     it 'returns false if there is no translation present for this locale' do
-      object.should_not be_translated_into :de
+      expect(object).to_not be_translated_into :de
     end
 
     it 'returns false if this locale is unknown yet' do
-      object.should_not be_translated_into :yml
+      expect(object).to_not be_translated_into :yml
     end
   end
 end

data/spec/spec_helper.rb

@@ -11,7 +11,3 @@ require 'active_model'
 require 'active_resource'
 require 'support/validations_matcher'
 require 'support/fake_object'
-
-RSpec.configure do |config|
-  config.color_enabled = true
-end

data/spec/support/fake_object.rb

@@ -1,13 +1,35 @@
 # This class is only used for testing purposes.
 class FakeObject
   include ActiveModel::Validations
+
   def self.serialize(*) ; end
   def self.before_save(*) ; end
+
   attr_accessor :title_translations, :description_translations, :summary_translations
 
   # Has to be set in this context to test it correctly
   I18n.available_locales = [:en, :de, :'en-GB']
 
+  def changes
+    @changes ||= []
+  end
+
+  def mark_change(attribute)
+    changes << attribute
+  end
+
+  def description_translations_will_change!
+    mark_change :description_translations
+  end
+
+  def title_translations_will_change!
+    mark_change :title_translations
+  end
+
+  def summary_translations_will_change!
+    mark_change :summary_translations
+  end
+
   include SerialTranslator
   serial_translator_for :title, :description, :summary
   validates :title,       serial_translator: { length: 5..25 }

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: serial_translator
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - betterplace development team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-17 00:00:00.000000000 Z
+date: 2014-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Translate attribute values without additional models
@@ -101,10 +101,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".ruby-gemset"
-- ".ruby-version"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .ruby-gemset
+- .ruby-version
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -128,12 +129,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []